March 2009 - Dillo-dev - lists.mailman3.com

[patch]: remove the BW_* flags

by jcid＠dillo.org

Hi, On Fri, Mar 13, 2009 at 05:52:07PM +0000, Jeremy Henty wrote: > On Fri, Mar 13, 2009 at 08:40:45AM -0300, Jorge Arellano Cid wrote: > > > Anyway I reviewed the patch back then, and remembered that the > > current interface was meant for flexibility to experiment. > > Yes, there is a case for keeping the flags for future development. I > just wanted to point that they are currently redundant and we could > remove them if we wanted. I'd prefer to keep the flags. > > I have to give it a second review. Anyway, if there're more cleanups > > pending on this patch, it may be worth accepting them > > Just so you know, the cleanups I have pending refactor a lot of code > that calls the dList_* API in convoluted and inefficient ways. (Most > stuff that call dList_remove() are like this.) You get cleaner and > more efficient code by defining new dList_remove_* and dList_free_* > functions, because that lets you replace lots of convoluted code paths > that call dList_remove(), dList_nth_data() etc. with single API calls. dList API was designed with a minimal working function set in mind. This keeps the API easy to remmeber and use. Now, if there's a measurable performance gain with the added functions it may be worth adding them. > One function that gets refactored is a_Bw_stop_clients(), which is why > submitting the cleanup patches is waiting on the decision about the > BM_Flags patch. It won't be hard to fix the cleanup patches if the > BM_Flags patch does not go in, but until the decision is made I don't > know whether or not to do that. Please try to get some performance numbers, and in the meanwhile send me a summary of the API changes. -- Cheers Jorge.-

March 18, 2009

[patch]: fix comment for DLWin::del()

by jcid＠dillo.org

On Wed, Mar 18, 2009 at 06:27:17AM +0000, Jeremy Henty wrote: > > > The comment for DLWin::del() was copied and pasted from > > DLWin::new(), but never corrected! > > And here's the patch. D'oh! Committed. -- Cheers Jorge.-

March 18, 2009

Re: Ohloh does not accept http://hg.dillo.org/dillo as Enlistment for the Dillo browser.

by akemnade＠tzi.de

Hi, On Tue, 17 Mar 2009 20:41:19 +0100 Detlef Riekenberg <wine.dev(a)web.de> wrote: > On Di, 2009-02-24 at 20:21 +0100, Detlef Riekenberg wrote: > > Hi. > > Thanks for working on Dillo. > > > > I tried to update the Dillo Project Page on Ohloh, > > but the the repository failed on the id command. > > > > ...$ hg id http://hg.dillo.org/dillo > > abort: cannot look up remote revision; remote repository does not > > support the 'lookup' capability! > > > > Which Mercurial version is used to serve dillo? > > Ohloh still can't accept the current dillo repository, because "hg id" > failed: > hg id http://hg.dillo.org/dillo > > Any Ideas, who can fix the repository configuration? > I have not updated the server yet (I'll to it at the weekend). I qoute myself: It is Mercurial Distributed SCM (version 0.9.1) Thats the version coming with debian etch. The id command works differently in the newer versions. I plan to upgrade at the end of march at the latest to the just-released stable. Greetings Andreas Kemnade

March 18, 2009

[patch]: fix comment for DLWin::del()

by onepoint＠starurchin.org

> The comment for DLWin::del() was copied and pasted from > DLWin::new(), but never corrected! And here's the patch. D'oh! Jeremy Henty

March 18, 2009

[patch]: fix comment for DLWin::del()

by onepoint＠starurchin.org

The comment for DLWin::del() was copied and pasted from DLWin::new(), but never corrected! Regards, Jeremy Henty

March 18, 2009

Re: Ohloh does not accept http://hg.dillo.org/dillo as Enlistment for the Dillo browser.

by wine.dev＠web.de

On Di, 2009-02-24 at 20:21 +0100, Detlef Riekenberg wrote: > Hi. > Thanks for working on Dillo. > > I tried to update the Dillo Project Page on Ohloh, > but the the repository failed on the id command. > > ...$ hg id http://hg.dillo.org/dillo > abort: cannot look up remote revision; remote repository does not > support the 'lookup' capability! > > Which Mercurial version is used to serve dillo? Ohloh still can't accept the current dillo repository, because "hg id" failed: hg id http://hg.dillo.org/dillo Any Ideas, who can fix the repository configuration? -- By by ... Detlef

March 17, 2009

My valgrind logs, for all to see.

by onepoint＠starurchin.org

On Mon, Mar 16, 2009 at 10:49:41PM +0100, Hofmann Johannes wrote: > How long does it take you to get e.g. the image related leak > messages? Very hard to say. It never seems to happen after just a few minutes, but after a few hours it's pretty common. > Are you doing anything special? Not that I can tell, just surfing lots. Regards, Jeremy Henty

March 17, 2009

My valgrind logs, for all to see.

by Johannes.Hofmann＠gmx.de

On Mon, Mar 16, 2009 at 09:36:20PM +0000, Jeremy Henty wrote: > On Mon, Mar 16, 2009 at 07:18:14PM +0100, Hofmann Johannes wrote: > > > in your valgrind logs I see references to "dList_truncate_free_data" > > which I can't find anywhere in the sources. Do you have some > > uncommitted patches in your tree? > > Yes, this is part of the dList_* API cleanup I talked about elsewhere. > Unfortunately those patches are stuck in my (Mercurial) queue ahead of > the BW_* flags cleanup patch, which has been submitted and not > reviewed yet. > > I realise that it is unhelpful to anyone using my valgrind logs that > my Dillo is so heavily patched at the moment. Would it help if I push > the BW_* flags cleanup patch back up my queue and submit the dList_* > API patches instead? They might be easier to review (as they are just > refactorings) and once they were out of the way (whether accepted or > rejected) the divergence between my Dillo and the mainstream would be > small again. (BTW, there has always been some small divergence, but > this is the first time there has been a persistent large divergence > that has affected the valgrind logs.) I'd like to fix as many valgrind errors as possible before the release. But it's pretty hard as I can't reproduce them myself. How long does it take you to get e.g. the image related leak messages? Are you doing anything special? Regards, Johannes

March 16, 2009

My valgrind logs, for all to see.

by onepoint＠starurchin.org

On Mon, Mar 16, 2009 at 07:18:14PM +0100, Hofmann Johannes wrote: > in your valgrind logs I see references to "dList_truncate_free_data" > which I can't find anywhere in the sources. Do you have some > uncommitted patches in your tree? Yes, this is part of the dList_* API cleanup I talked about elsewhere. Unfortunately those patches are stuck in my (Mercurial) queue ahead of the BW_* flags cleanup patch, which has been submitted and not reviewed yet. I realise that it is unhelpful to anyone using my valgrind logs that my Dillo is so heavily patched at the moment. Would it help if I push the BW_* flags cleanup patch back up my queue and submit the dList_* API patches instead? They might be easier to review (as they are just refactorings) and once they were out of the way (whether accepted or rejected) the divergence between my Dillo and the mainstream would be small again. (BTW, there has always been some small divergence, but this is the first time there has been a persistent large divergence that has affected the valgrind logs.) Regards, Jeremy Henty

March 16, 2009

My valgrind logs, for all to see.

by Johannes.Hofmann＠gmx.de

Hi Jeremy, in your valgrind logs I see references to "dList_truncate_free_data" which I can't find anywhere in the sources. Do you have some uncommitted patches in your tree? Cheers, Johannes

March 16, 2009