Dillo-dev

By thread

dillo-dev@mailman3.com

March 2009

16 participants
141 messages

Re: css parsing numbers

by Johannes.Hofmann＠gmx.de

On Sat, Feb 28, 2009 at 12:22:32AM +0100, Hofmann Johannes wrote: > On Fri, Feb 27, 2009 at 07:06:27PM +0100, Hofmann Johannes wrote: > > On Fri, Feb 27, 2009 at 03:29:55PM +0000, corvid wrote: > > > > On Fri, Feb 27, 2009 at 02:26:03PM +0000, corvid wrote: > > > > > > Committed. I hoped to be able to make that code a bit shorter, but > > > > > > could not find a reasonable solution... > > > > > > > > > > Yeah. In any case, it's just going to get worse/rearranged again > > > > > for negative numbers... > > > > > > > > Exactly. I started my simplification attempts, added negative number > > > > support - and blew it all up :) > > > > I'm really considering a flex based scanner now. What do you think? > > > > > > I only touched flex very briefly for a class at school long ago, > > > and I don't remember anything from the experience, but the > > > idea interests me since it has to be less trouble than trying > > > to do it by hand... > > > > > > > This turned out to be easier than expected. Attached patch adds a flex > based scanner for CSS data. > It's not optimized or polished but seems to work here. To make reviewing easier I created a repo for the flex experiment: http://freehg.org/u/dillo/flex/ I think the use of flex makes the code simpler and more maintainable. For some reason rendering is a bit different, e.g. on wikipedia.org maybe because negative numbers are supported. It would be nice if people could test it regarding the performance impact. What do you think. Is it worth to add the flex dependency? Cheers, Johannes

March 1, 2009

Jump to page: