February 2009 - Dillo-dev - lists.mailman3.com

Bad character coding for www.blisty.cz

by Johannes.Hofmann＠gmx.de

On Sun, Feb 01, 2009 at 07:45:39PM +0100, Hofmann Johannes wrote: > On Sun, Feb 01, 2009 at 03:53:32PM +0000, corvid wrote: > > Jorge wrote: > > > On Sun, Feb 01, 2009 at 02:24:30AM +0000, corvid wrote: > > > > Michal wrote: > > > > > Hi, > > > > > > > > > > I am affraid there ocurred regression in post-dillo-2.0 when compared to > > > > > dillo-2.0. Look on the www.blisty.cz web page, on the top there's > > > > > following sence (it's in Czech) > > > > > > > > > > "??t??te Britsk? listy speci?ln?? upraven? pro va??e mobiln? telefony a PDA" > > > > > > > > > > but in current hg tip it's displayed as > > > > > > > > > > "???t???te Britsk??? listy speci???ln??? upraven??? pro va???e mobiln??? telefony a PDA" > > > > > > > > > > and of course, the whole page is displayed like in ISO-8859-1 coding. > > > > > > > > > > I noticed this first when the character coding code in post-dillo-2.0 > > > > > was changed. > > > > > > > > > > When the page is saved to disk and opened it works as expected. > > > > > > > > > > It appeared that it is somehow related to default dillorc. > > > > > > > > > > 1) remove the ~/.dillo directory > > > > > 2) dillo www.blisty.cz > > > > > 3) --> PASS > > > > > 4) quit dillo > > > > > 5) dillo www.blisty.cz > > > > > 6) --> FAIL > > > > > > > > > > Can anyone, please, have a look at this and say whether is it > > > > > reproducible and, perhaps, fix it? :) > > > > > > > > Breaks for me, too. > > > > > > > > Plus having to wait through 116K of download before anything > > > > appears is no fun. > > > > > > It works for me! :-) > > > > > > Seriously, I still have a pending item to review here, and it's > > > when charset appears after the stylesheet in HEAD. This page also > > > has timing issues: http://www.daemonnews.org > > > > > > It looks like queueing the stylesheets and asking for them > > > after charset or at head close may fix it. > > > > Does anyone else experience pages not rendering until > > download is complete? I see this with the dillo.org > > pages, for instance, since the meta charset is iso-8859-1. > > Yes, I'm also seeing it. Not sure when this started. According to hg bisect it starts with d29cdb5b842e, but I don't see any obvious issues there. Jorge, can you have a look please? Cheers, Johannes

Feb. 1, 2009

a policy for dillorc vs. style.css conflicts?

by Johannes.Hofmann＠gmx.de

On Sun, Feb 01, 2009 at 07:20:33PM +0000, corvid wrote: > I was just looking at some of the prefs that I > don't think are doing anything right now, e.g., > link_color, force_my_colors... > I could stuff them into buildUserStyle(), but > I don't know which should prevail in case of > conflicts. > > I can't remember whether I've already mentioned that > I've been wondering whether it might be reasonable to > rip a bunch of color stuff out of dillorc and expect > a dillo user to be able to deal with a well-commented > sample style.css instead. Good point. I always favor simplicity so I think we should have just one way to modify the style. Having two (style.css and preferences) just adds confusion. We need to document this properly as you said. Johannes

Feb. 1, 2009

a policy for dillorc vs. style.css conflicts?

by corvid＠lavabit.com

I was just looking at some of the prefs that I don't think are doing anything right now, e.g., link_color, force_my_colors... I could stuff them into buildUserStyle(), but I don't know which should prevail in case of conflicts. I can't remember whether I've already mentioned that I've been wondering whether it might be reasonable to rip a bunch of color stuff out of dillorc and expect a dillo user to be able to deal with a well-commented sample style.css instead.

Feb. 1, 2009

What's left to do for dillo-2.1?

by jcid＠dillo.org

On Sun, Feb 01, 2009 at 07:20:58PM +0100, Hofmann Johannes wrote: > On Sun, Feb 01, 2009 at 05:57:59PM +0000, corvid wrote: > > Johannes wrote: > > > On Sat, Jan 31, 2009 at 01:15:07PM +0000, Jeremy Henty wrote: > > > > > > > > I get the feeling we are close to releasing dillo-2.1. Do others > > > > agree? What's left to be done? > > > > > > I agree. Of course there is a lot todo regarding CSS conformance, > > > but we won't pass any ACID test soon anyway. > > > I'd like to get the font-size issue on wikipedia.org fixed however - > > > help on that is very welcome :-). > > > > That reminds me, it would be good to add some checking for > > malicious values before release. > > Yes, I think stylengine.cc would be the right place. > Maybe we can add some generic checks and remove the ones in html.cc > - this needs to be checked. > We also need to give cssparser.cc a thorough look regarding potential > buffer overflows... At some point in time the whole browser will need a check against malicious/random data. The dillo-2.x process has been focused on features. I agree that the CSS part needs a review before release. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Feb. 1, 2009

[Patch]: [v2]: fix URL leak in Html_tag_open_link()

by jcid＠dillo.org

On Sun, Feb 01, 2009 at 07:15:43PM +0100, Hofmann Johannes wrote: > On Sun, Feb 01, 2009 at 02:18:10PM -0300, Jorge Arellano Cid wrote: > > On Sun, Feb 01, 2009 at 08:32:14AM +0000, Jeremy Henty wrote: > > > > > > OK, I'm fairly sure this version is not as utterly broken as the > > > previous one. :-) > > > > Committed > > (with just a small change) > > > > > > > > BTW, does a_Html_tag_open_link() really need to check the stylesheets > > > preference twice? > > > > The repush scheme include parsing the HTML header twice. > > (not a big deal). > > I think Jeremy is referring to > > if (!prefs.load_stylesheets) > return; > > in Html_tag_open_link() which seems redundant, as there is > > /* Remote stylesheets enabled? */ > dReturn_if_fail (prefs.load_stylesheets); > > some lines above. Oh, Yes! Committed. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Feb. 1, 2009

Bad character coding for www.blisty.cz

by Johannes.Hofmann＠gmx.de

On Sun, Feb 01, 2009 at 03:53:32PM +0000, corvid wrote: > Jorge wrote: > > On Sun, Feb 01, 2009 at 02:24:30AM +0000, corvid wrote: > > > Michal wrote: > > > > Hi, > > > > > > > > I am affraid there ocurred regression in post-dillo-2.0 when compared to > > > > dillo-2.0. Look on the www.blisty.cz web page, on the top there's > > > > following sence (it's in Czech) > > > > > > > > "??t??te Britsk? listy speci?ln?? upraven? pro va??e mobiln? telefony a PDA" > > > > > > > > but in current hg tip it's displayed as > > > > > > > > "???t???te Britsk??? listy speci???ln??? upraven??? pro va???e mobiln??? telefony a PDA" > > > > > > > > and of course, the whole page is displayed like in ISO-8859-1 coding. > > > > > > > > I noticed this first when the character coding code in post-dillo-2.0 > > > > was changed. > > > > > > > > When the page is saved to disk and opened it works as expected. > > > > > > > > It appeared that it is somehow related to default dillorc. > > > > > > > > 1) remove the ~/.dillo directory > > > > 2) dillo www.blisty.cz > > > > 3) --> PASS > > > > 4) quit dillo > > > > 5) dillo www.blisty.cz > > > > 6) --> FAIL > > > > > > > > Can anyone, please, have a look at this and say whether is it > > > > reproducible and, perhaps, fix it? :) > > > > > > Breaks for me, too. > > > > > > Plus having to wait through 116K of download before anything > > > appears is no fun. > > > > It works for me! :-) > > > > Seriously, I still have a pending item to review here, and it's > > when charset appears after the stylesheet in HEAD. This page also > > has timing issues: http://www.daemonnews.org > > > > It looks like queueing the stylesheets and asking for them > > after charset or at head close may fix it. > > Does anyone else experience pages not rendering until > download is complete? I see this with the dillo.org > pages, for instance, since the meta charset is iso-8859-1. Yes, I'm also seeing it. Not sure when this started.

Feb. 1, 2009

What's left to do for dillo-2.1?

by Johannes.Hofmann＠gmx.de

On Sun, Feb 01, 2009 at 05:57:59PM +0000, corvid wrote: > Johannes wrote: > > On Sat, Jan 31, 2009 at 01:15:07PM +0000, Jeremy Henty wrote: > > > > > > I get the feeling we are close to releasing dillo-2.1. Do others > > > agree? What's left to be done? > > > > I agree. Of course there is a lot todo regarding CSS conformance, > > but we won't pass any ACID test soon anyway. > > I'd like to get the font-size issue on wikipedia.org fixed however - > > help on that is very welcome :-). > > That reminds me, it would be good to add some checking for > malicious values before release. Yes, I think stylengine.cc would be the right place. Maybe we can add some generic checks and remove the ones in html.cc - this needs to be checked. We also need to give cssparser.cc a thorough look regarding potential buffer overflows... Cheers, Johannes

Feb. 1, 2009

Refactored prefs.c to a much smaller size!

by Johannes.Hofmann＠gmx.de

Excellent!

Feb. 1, 2009

[Patch]: [v2]: fix URL leak in Html_tag_open_link()

by Johannes.Hofmann＠gmx.de

On Sun, Feb 01, 2009 at 02:18:10PM -0300, Jorge Arellano Cid wrote: > On Sun, Feb 01, 2009 at 08:32:14AM +0000, Jeremy Henty wrote: > > > > OK, I'm fairly sure this version is not as utterly broken as the > > previous one. :-) > > Committed > (with just a small change) > > > > > BTW, does a_Html_tag_open_link() really need to check the stylesheets > > preference twice? > > The repush scheme include parsing the HTML header twice. > (not a big deal). I think Jeremy is referring to if (!prefs.load_stylesheets) return; in Html_tag_open_link() which seems redundant, as there is /* Remote stylesheets enabled? */ dReturn_if_fail (prefs.load_stylesheets); some lines above. Cheers, Johannes

Feb. 1, 2009

What's left to do for dillo-2.1?

by corvid＠lavabit.com

Johannes wrote: > On Sat, Jan 31, 2009 at 01:15:07PM +0000, Jeremy Henty wrote: > > > > I get the feeling we are close to releasing dillo-2.1. Do others > > agree? What's left to be done? > > I agree. Of course there is a lot todo regarding CSS conformance, > but we won't pass any ACID test soon anyway. > I'd like to get the font-size issue on wikipedia.org fixed however - > help on that is very welcome :-). That reminds me, it would be good to add some checking for malicious values before release.

Feb. 1, 2009