November 2009 - Dillo-dev - lists.mailman3.com

take_focus on a new tab

by jcid＠dillo.org

On Thu, Nov 26, 2009 at 11:01:02PM +0900, furaisanjin wrote: > 2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > >> > >> > I would propose something as in attached patch to ensure that > >> > Location is focused when opening a new (empty) tab. > >> > >> +1 > > > > +1 > > I hope the patch will be part of dillo soon. The patch works very well. @Johannes, please comment what the change is for before committing. -- Cheers Jorge.-

Nov. 26, 2009

take_focus on a new tab

by furaisanjin＠gmail.com

2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: >> >> > I would propose something as in attached patch to ensure that >> > Location is focused when opening a new (empty) tab. >> >> +1 > > +1 I hope the patch will be part of dillo soon. The patch works very well. Regards, furaisanjin

Nov. 26, 2009

take_focus on a new tab

by jcid＠dillo.org

On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > > > I would propose something as in attached patch to ensure that > > Location is focused when opening a new (empty) tab. > > +1 +1 -- Cheers Jorge.-

Nov. 26, 2009

take_focus on a new tab

by onepoint＠starurchin.org

On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > I would propose something as in attached patch to ensure that > Location is focused when opening a new (empty) tab. +1 Jeremy Henty

Nov. 26, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Sat, Nov 21, 2009 at 05:33:24PM +0900, furaisanjin wrote: > Hi all. > > I'm wondering if > "BW2UI(new_bw)->tabs()->selected_child()->take_focus()" is really > needed in a_UIcmd_open_url_nt. I usually hit space bar to scroll down > but I can't do this when I open a new tab by clicking middle mouse > button. The reason is that cursor stays on address bar so that I just > add space at the end of url if I hit space bar. Good point. I would propose something as in attached patch to ensure that Location is focused when opening a new (empty) tab. Cheers, Johannes

Nov. 24, 2009

take_focus on a new tab

by furaisanjin＠gmail.com

Hi all. I'm wondering if "BW2UI(new_bw)->tabs()->selected_child()->take_focus()" is really needed in a_UIcmd_open_url_nt. I usually hit space bar to scroll down but I can't do this when I open a new tab by clicking middle mouse button. The reason is that cursor stays on address bar so that I just add space at the end of url if I hit space bar. Regards, furaisanjin

Nov. 21, 2009

[patch]: trim the labels of the stylesheet menu

by corvid＠lavabit.com

Jeremy wrote: > On Fri, Nov 20, 2009 at 09:28:25PM +0000, corvid wrote: > > Jeremy wrote: > > > > > It's interesting that FLTK decides to clip a little bit from the end > > there. I wonder what it was thinking... > > Me too, but I didn't feel like wading through FLTK code tonight! :-) Turns out that it doesn't do it to me when I run it. So let's blame the font... > > > We just copy the pointer to the DilloUrl structure, so we are > > > assuming it will never be free()-ed while the menu is up. If I'm > > > wrong about this the patch will need to be revised. > > > > I don't know the details of when Jorge's code decides to free cache > > entries, but I think it would be best not to assume that the url > > remains valid. > > OK, I agree: robust code should ensure its own safety, not depend on > other code to look after it. Here's a patch to do that. It applies > on top of the previous patch. Committed.

Nov. 21, 2009

modify bookmarks (Re: [Dillo-dev] EAGAIN loop in IO_read)

by furaisanjin＠gmail.com

2009/11/20 Jorge Arellano Cid <jcid(a)dillo.org>: > ?@all: please test the patch in the repo and report. Bookmark problem is fixed on FreeBSD. > ?The ?problem with HTTP proxy *may* be a different thing, but it > also may be fixed now. Please check and report. Still I need to modify for HTTP proxy, so the root cause is different. Regards, furaisanjin

Nov. 21, 2009

[patch]: trim the labels of the stylesheet menu

by onepoint＠starurchin.org

On Fri, Nov 20, 2009 at 09:28:25PM +0000, corvid wrote: > Jeremy wrote: > > > It's interesting that FLTK decides to clip a little bit from the end > there. I wonder what it was thinking... Me too, but I didn't feel like wading through FLTK code tonight! :-) > > We just copy the pointer to the DilloUrl structure, so we are > > assuming it will never be free()-ed while the menu is up. If I'm > > wrong about this the patch will need to be revised. > > I don't know the details of when Jorge's code decides to free cache > entries, but I think it would be best not to assume that the url > remains valid. OK, I agree: robust code should ensure its own safety, not depend on other code to look after it. Here's a patch to do that. It applies on top of the previous patch. Jeremy

Nov. 20, 2009

[patch]: trim the labels of the stylesheet menu

by corvid＠lavabit.com

Jeremy wrote: > > While thinking about stylesheet issues I noticed a UI problem: the > stylesheet menu uses URLs as the labels of the menu items. This is > unfortunate because some sites have stylesheets with insanely long > URLs. (Try Wikipedia if you don't believe me!) So I'm attaching a > patch that trims long URLs in the menu. This is just a UI change - no > functionality is affected. > > Here's a demonstration of the patch on the front page of Wikipedia: > > http://starurchin.org/dillo/stylesheet_menu/ Good. It would be nice to improve the labels. It's interesting that FLTK decides to clip a little bit from the end there. I wonder what it was thinking... > Notes: > > Since the label is no longer always the same as the label the callback > must find the URL elsewhere. We put it in the user_data() of the menu > item. > > We just copy the pointer to the DilloUrl structure, so we are assuming > it will never be free()-ed while the menu is up. If I'm wrong about > this the patch will need to be revised. I don't know the details of when Jorge's code decides to free cache entries, but I think it would be best not to assume that the url remains valid.

Nov. 20, 2009