November 2009 - Dillo-dev - lists.mailman3.com

patch: anchors no longer words

by corvid＠lavabit.com

Johannes wrote: > Looks fine to me too. Maybe you could also garbage collect > core::Content::ANCHOR to avoid confusion, or is it still used? Yes, I plan to remove it.

Nov. 30, 2009

patch: anchors no longer words

by Johannes.Hofmann＠gmx.de

On Mon, Nov 30, 2009 at 10:38:08AM -0300, Jorge Arellano Cid wrote: > On Mon, Nov 30, 2009 at 07:29:13AM +0000, corvid wrote: > > A few days ago, I tried to make addParbreak() work properly when listitems > > have anchors in the beginning (that's why they often show breaks before > > their contents), but it was quite icky -- and required more extensive > > changes than I expected. > > > > So instead, here's what we get if we pull the anchors out of the Word > > list and store them separately. Less icky. > > It looks OK to me, especially if it helps to fix the list item's > extra-line-break bug, by means of code clarity. Looks fine to me too. Maybe you could also garbage collect core::Content::ANCHOR to avoid confusion, or is it still used? Cheers, Johannes

Nov. 30, 2009

patch: anchors no longer words

by jcid＠dillo.org

On Mon, Nov 30, 2009 at 07:29:13AM +0000, corvid wrote: > A few days ago, I tried to make addParbreak() work properly when listitems > have anchors in the beginning (that's why they often show breaks before > their contents), but it was quite icky -- and required more extensive > changes than I expected. > > So instead, here's what we get if we pull the anchors out of the Word > list and store them separately. Less icky. It looks OK to me, especially if it helps to fix the list item's extra-line-break bug, by means of code clarity. -- Cheers Jorge.-

Nov. 30, 2009

patch: anchors no longer words

by corvid＠lavabit.com

A few days ago, I tried to make addParbreak() work properly when listitems have anchors in the beginning (that's why they often show breaks before their contents), but it was quite icky -- and required more extensive changes than I expected. So instead, here's what we get if we pull the anchors out of the Word list and store them separately. Less icky.

Nov. 30, 2009

take_focus on a new tab

by furaisanjin＠gmail.com

2009/11/28 Johannes Hofmann <Johannes.Hofmann(a)gmx.de>: > I committed a slightly different patch to also cover the case when > middle_click_opens_new_tab=NO > > Please test, I tested but I found still there were cases where cursor stayed on address bar. Could you consider this patch? diff -r 292c1755001c src/web.cc --- a/src/web.cc Sat Nov 28 09:56:57 2009 +0900 +++ b/src/web.cc Sat Nov 28 12:59:41 2009 +0900 @@ -87,6 +87,7 @@ /* Let the Nav module know... */ a_Nav_expect_done(Web->bw); + a_UIcmd_focus_main_area (Web->bw); } else { /* A non-RootUrl. At this moment we only handle image-children */ After page rendering finishes, focus is changed to main area so that cursor doesn't stay on address bar. Regards, furaisanjin

Nov. 28, 2009

take_focus on a new tab

by corvid＠lavabit.com

Johannes wrote: > On Thu, Nov 26, 2009 at 11:53:12AM -0300, Jorge Arellano Cid wrote: > > On Thu, Nov 26, 2009 at 11:01:02PM +0900, furaisanjin wrote: > > > 2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > > > > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > > > >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > > > >> > > > >> > I would propose something as in attached patch to ensure that > > > >> > Location is focused when opening a new (empty) tab. > > > >> > > > >> +1 > > > > > > > > +1 > > > > > > I hope the patch will be part of dillo soon. The patch works very well. > > > > @Johannes, please comment what the change is for before committing. > > I committed a slightly different patch to also cover the case when > middle_click_opens_new_tab=NO This is a good improvement. Having the Location focused in a new window == :) I notice that, after shift-button2 on a link, shift-right_arrow doesn't work until I click on things a bit.

Nov. 27, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Thu, Nov 26, 2009 at 11:53:12AM -0300, Jorge Arellano Cid wrote: > On Thu, Nov 26, 2009 at 11:01:02PM +0900, furaisanjin wrote: > > 2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > > > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > > >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > > >> > > >> > I would propose something as in attached patch to ensure that > > >> > Location is focused when opening a new (empty) tab. > > >> > > >> +1 > > > > > > +1 > > > > I hope the patch will be part of dillo soon. The patch works very well. > > @Johannes, please comment what the change is for before committing. I committed a slightly different patch to also cover the case when middle_click_opens_new_tab=NO Please test, Johannes

Nov. 27, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Thu, Nov 26, 2009 at 08:56:52PM +0000, corvid wrote: > Johannes wrote: > > On Thu, Nov 26, 2009 at 11:53:12AM -0300, Jorge Arellano Cid wrote: > > > On Thu, Nov 26, 2009 at 11:01:02PM +0900, furaisanjin wrote: > > > > 2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > > > > > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > > > > >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > > > > >> > > > > >> > I would propose something as in attached patch to ensure that > > > > >> > Location is focused when opening a new (empty) tab. > > > > >> > > > > >> +1 > > > > > > > > > > +1 > > > > > > > > I hope the patch will be part of dillo soon. The patch works very well. > > > > > > @Johannes, please comment what the change is for before committing. > > > > does anybody know, why > > BW2UI(new_bw)->tabs()->selected_child()->take_focus(); > > focusses the location text input? > > I wouldn't be surprised if fltk chooses it because it's the > UI's first child. Indeed! With below patch, the dummy CustInput get's the focus. diff -r 90fabbb4077b src/ui.cc --- a/src/ui.ccSun Nov 22 18:35:48 2009 +0100 +++ b/src/ui.ccThu Nov 26 22:06:51 2009 +0100 @@ -444,6 +444,7 @@ b->callback(clear_cb, this); b->clear_tab_to_focus(); + new CustInput(0,0,100,0,0); Input *i = Location = new CustInput(0,0,0,0,0); i->color(CuteColor); i->when(WHEN_ENTER_KEY);

Nov. 26, 2009

take_focus on a new tab

by corvid＠lavabit.com

Johannes wrote: > On Thu, Nov 26, 2009 at 11:53:12AM -0300, Jorge Arellano Cid wrote: > > On Thu, Nov 26, 2009 at 11:01:02PM +0900, furaisanjin wrote: > > > 2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > > > > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > > > >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > > > >> > > > >> > I would propose something as in attached patch to ensure that > > > >> > Location is focused when opening a new (empty) tab. > > > >> > > > >> +1 > > > > > > > > +1 > > > > > > I hope the patch will be part of dillo soon. The patch works very well. > > > > @Johannes, please comment what the change is for before committing. > > does anybody know, why > BW2UI(new_bw)->tabs()->selected_child()->take_focus(); > focusses the location text input? I wouldn't be surprised if fltk chooses it because it's the UI's first child.

Nov. 26, 2009

take_focus on a new tab

by Johannes.Hofmann＠gmx.de

On Thu, Nov 26, 2009 at 11:53:12AM -0300, Jorge Arellano Cid wrote: > On Thu, Nov 26, 2009 at 11:01:02PM +0900, furaisanjin wrote: > > 2009/11/26, Jorge Arellano Cid <jcid(a)dillo.org>: > > > On Thu, Nov 26, 2009 at 08:22:25AM +0000, Jeremy Henty wrote: > > >> On Tue, Nov 24, 2009 at 11:03:23PM +0100, Johannes Hofmann wrote: > > >> > > >> > I would propose something as in attached patch to ensure that > > >> > Location is focused when opening a new (empty) tab. > > >> > > >> +1 > > > > > > +1 > > > > I hope the patch will be part of dillo soon. The patch works very well. > > @Johannes, please comment what the change is for before committing. does anybody know, why BW2UI(new_bw)->tabs()->selected_child()->take_focus(); focusses the location text input? Cheers, Johannes

Nov. 26, 2009