January 2009 - Dillo-dev - lists.mailman3.com

Valgrind errors

by corvid＠lavabit.com

Jeremy wrote: > On Thu, Jan 22, 2009 at 10:37:41PM +0000, corvid wrote: > > Jeremy wrote: > > > ==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) > > > ==20949== > > > ==20949== Invalid read of size 4 > > > ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145) > > > > Does this part of it stop complaining if the > > a_UIcmd_set_page_prog(Client_bw, data->len, 1); > > in Cache_process_queue() uses Cache_data(entry)->len instead? > > Yes. Patch attached. I realized we should really be using entry->Data regardless of character encoding when showing progress in receiving the page. Attached.

Jan. 23, 2009

Valgrind error: possible link to Imgbuf crash?

by onepoint＠starurchin.org

Here's another valgrind error that I think might be related to the crashes I have been seeing. The gdb stack trace showed that a_Imgbuf_new() was calling a layout method with an invalid address for the layout object. The valgrind error shows a_Imgbuf_new() reading invalid memory when it calls Widget::getLayout(). It looks to me as though a_Imgbuf_new() is being passed an Image that has already been freed. Regards, Jeremy Henty

Jan. 23, 2009

Valgrind errors

by onepoint＠starurchin.org

On Thu, Jan 22, 2009 at 10:37:41PM +0000, corvid wrote: > Jeremy wrote: > > ==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) > > ==20949== > > ==20949== Invalid read of size 4 > > ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145) > > Does this part of it stop complaining if the > a_UIcmd_set_page_prog(Client_bw, data->len, 1); > in Cache_process_queue() uses Cache_data(entry)->len instead? Yes. Patch attached. Regards, Jeremy Henty

Jan. 23, 2009

dillo CSS and charset

by jcid＠dillo.org

On Fri, Jan 23, 2009 at 07:31:56AM +0900, furaisanjin wrote: > Hi. > > 2009/1/23 Jorge Arellano Cid <jcid(a)dillo.org>: > >> Have you added charset to the content-type given by the bookmarks dpi? > >> or have you added a META or both? > > I did hg revert cache.c to cancel my local modification and then built > dillo again. However I can't reproduce the problem anymore. I don't > add content-type on dpi nor meta on bookmark because if encoding type > is UTF-8, no conversion is required. I assume dillo native encoding is > UTF-8 now. > > Sorry for confusion. Please ignore bookmark problem. OK, but I still want to commit the proposed patch. Please test it and comment. -- Cheers Jorge.-

Jan. 23, 2009

[patch]: control lout's MSG from the preferences

by jcid＠dillo.org

Hi Jeremy, On Sat, Jan 17, 2009 at 06:57:55PM +0000, Jeremy Henty wrote: > > This patch makes the dillorc show_msg preference control lout's MSG > macros as well as dillo's. Please comment. As is, it looks like an overkill to me, but it may be interesting to be able to handle other preferences as well. This is, to have something like: lout::prefs::message({true|false}); henceforth items could be added when neeeded. e.g. lout::prefs::tableDebugRendering({true|false}); Please resubmit like above, but with just message. -- Cheers Jorge.-

Jan. 23, 2009

Valgrind errors

by corvid＠lavabit.com

Jeremy wrote: > ==20949== by 0x806065B: a_Cache_process_dbuf (cache.c:865) > ==20949== > ==20949== Invalid read of size 4 > ==20949== at 0x8060E9B: Cache_process_queue (cache.c:1145) Does this part of it stop complaining if the a_UIcmd_set_page_prog(Client_bw, data->len, 1); in Cache_process_queue() uses Cache_data(entry)->len instead?

Jan. 22, 2009

dillo CSS and charset

by furaisanjin＠gmail.com

Hi. 2009/1/23 Jorge Arellano Cid <jcid(a)dillo.org>: >> Have you added charset to the content-type given by the bookmarks dpi? >> or have you added a META or both? I did hg revert cache.c to cancel my local modification and then built dillo again. However I can't reproduce the problem anymore. I don't add content-type on dpi nor meta on bookmark because if encoding type is UTF-8, no conversion is required. I assume dillo native encoding is UTF-8 now. Sorry for confusion. Please ignore bookmark problem. Regards, furaisanjin

Jan. 22, 2009

Valgrind errors

by onepoint＠starurchin.org

I've been valgrinding Dillo to see what I find and this one keeps turning up. Some memory is accessed that was freed by a_Cache_set_content_type(). Regards, Jeremy Henty

Jan. 22, 2009

dillo CSS and charset

by Johannes.Hofmann＠gmx.de

On Thu, Jan 22, 2009 at 06:53:46PM +0000, corvid wrote: > Johannes wrote: > > On Thu, Jan 22, 2009 at 05:57:42PM +0000, corvid wrote: > > > Johannes wrote: > > > > BTW. now you can set vw_fontname in dillorc again. This font will > > > > then be used when CSS specifies "sans" as font, e.g: > > > > vw_fontname="VL Gothic" > > > > > > If I put a serif font in vw_fontname and then use > > > sans in style.css for some things, it'll use > > > the serif font. > > > > True. We need to make new config options > > > > sans-serif_fontname > > serif_fontname > > cursive_fontname > > fantasy_fontname > > monospace_fontname > > > > maybe even dropping the "_fontname" suffix. > > > > But of course that would no longer be compatible with older > > versions of dillorc. > > I would add the new options and remove the old options. > CSS is big and certainly worth some incompatibility. Ok, attached is a patch for discussion. Cheers, Johannes > > Related to this, I've been wondering whether we should have > a policy about the dillorc on the website -- whether it should > follow tip, or follow the most recent release, or always add > new options but never delete old options... > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 22, 2009

[patch]: fix DBG build of table.cc

by jcid＠dillo.org

On Sat, Jan 17, 2009 at 06:53:13PM +0000, Jeremy Henty wrote: > > If you uncomment the #define of DBG in table.cc it won't compile. It > looks as though most of the DBG code was fixed not to use the > non-existent "result" variable, but one instance was left unchanged. > Patch attached. Committed. -- Cheers Jorge.-

Jan. 22, 2009