September 2008 - Dillo-dev - lists.mailman3.com

segfault -- callback + closed window?

by jcid＠dillo.org

On Tue, Sep 30, 2008 at 06:39:44PM +0200, Johannes Hofmann wrote: > On Tue, Sep 30, 2008 at 12:41:21PM -0400, Jorge Arellano Cid wrote: > > On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote: > > > On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote: > > > > Hi, > > > > > > > > On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote: > > > > > I hit ',' a few times, going back past a page with a > > > > > big progressive jpeg webcomic, and hit ^Q to close the window > > > > > while dillo was thinking its way past that image. > > > > > > > > > > Got: > > > > > > > > > > Program received signal SIGSEGV, Segmentation fault. > > > > > [Switching to Thread 16384 (LWP 2782)] > > > > > 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > > > > at Widget.cxx:575 > > > > > 575 widget->damage_ |= DAMAGE_CHILD; > > > > > (gdb) bt > > > > > #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > > > > at Widget.cxx:575 > > > > > #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) > > > > > at ui.cc:1109 > > > > > #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 > > > > > #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 > > > > > #4 0x080e489d in fltk::run () at TabGroup.cxx:116 > > > > > #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 > > > > > > > > > > > > > > > Maybe that's just a part of life with callbacks... > > > > > > > > > > > > > I no longer see this crash when removing the buttons_sens workaround > > > > in uicmd.cc as in attached patch. > > > > Does someone remember why it was introduced? > > > > > > It comes from dillo1. > > > > > > Committed. > > > > > > BTW, this is exactly what I meant with a UI getting the wrong bw. > > > I think this should be fixed before the release. > > > > Update: I have a patch that works in my tree. It gets rid of > > bw as the window's user_data(). > > Just allow me some time to test/polish. > > > > Cool. Just wanted to start it myself. Please try the attached patch, not tested, I'm on my way to the airport. -- Cheers Jorge.-

Sept. 30, 2008

segfault -- callback + closed window?

by corvid＠lavabit.com

Johannes wrote: > On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote: > > I hit ',' a few times, going back past a page with a > > big progressive jpeg webcomic, and hit ^Q to close the window > > while dillo was thinking its way past that image. > > > > Got: > > > > Program received signal SIGSEGV, Segmentation fault. > > [Switching to Thread 16384 (LWP 2782)] > > 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > at Widget.cxx:575 > > 575 widget->damage_ |= DAMAGE_CHILD; > > (gdb) bt > > #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > at Widget.cxx:575 > > #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) > > at ui.cc:1109 > > #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 > > #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 > > #4 0x080e489d in fltk::run () at TabGroup.cxx:116 > > #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 > > > > > > Maybe that's just a part of life with callbacks... > > > > I no longer see this crash when removing the buttons_sens workaround > in uicmd.cc as in attached patch. No more crash for me either. Thanks!

Sept. 30, 2008

an experiment regarding cross site request forgery

by joerg.sonnenberger＠web.de

On Tue, Sep 30, 2008 at 02:51:58PM +0000, corvid wrote: > Joerg wrote: > > On Tue, Sep 30, 2008 at 12:56:05PM +0000, corvid wrote: > > > So my latest little experiment: out of the image urls your browser > > > sees that have queries (the '?a=b&c=d&e=f'), how many are > > > > There's nothing wrong with that. Such an image URL is a simple GET > > request. Any web application doing a modification is broken by design > > and there are good reasons for allowing such URLs. The problem is > > allowing POST actions to a different site than the one issuing it. > > Isn't that part of the problem -- that broken sites are using GET for > things they shouldn't? CSRF is about both. Broken sites are broken sites -- not much to do about them. What I do worry about are properly written web applications, e.g. those that correctly use GET/POST, but don't have explicit protection about CSRF. The latter is kind of intrusive if the framework used doesn't allow that. > PS How about not sending cookies with queries for images? Breaks if you are using session controll to decide what images can be accessed. Joerg

Sept. 30, 2008

segfault -- callback + closed window?

by Johannes.Hofmann＠gmx.de

On Tue, Sep 30, 2008 at 12:41:21PM -0400, Jorge Arellano Cid wrote: > On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote: > > On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote: > > > > I hit ',' a few times, going back past a page with a > > > > big progressive jpeg webcomic, and hit ^Q to close the window > > > > while dillo was thinking its way past that image. > > > > > > > > Got: > > > > > > > > Program received signal SIGSEGV, Segmentation fault. > > > > [Switching to Thread 16384 (LWP 2782)] > > > > 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > > > at Widget.cxx:575 > > > > 575 widget->damage_ |= DAMAGE_CHILD; > > > > (gdb) bt > > > > #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > > > at Widget.cxx:575 > > > > #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) > > > > at ui.cc:1109 > > > > #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 > > > > #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 > > > > #4 0x080e489d in fltk::run () at TabGroup.cxx:116 > > > > #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 > > > > > > > > > > > > Maybe that's just a part of life with callbacks... > > > > > > > > > > I no longer see this crash when removing the buttons_sens workaround > > > in uicmd.cc as in attached patch. > > > Does someone remember why it was introduced? > > > > It comes from dillo1. > > > > Committed. > > > > BTW, this is exactly what I meant with a UI getting the wrong bw. > > I think this should be fixed before the release. > > Update: I have a patch that works in my tree. It gets rid of > bw as the window's user_data(). > Just allow me some time to test/polish. > Cool. Just wanted to start it myself. Cheers, Johannes

Sept. 30, 2008

segfault -- callback + closed window?

by jcid＠dillo.org

On Tue, Sep 30, 2008 at 12:03:57PM -0400, Jorge Arellano Cid wrote: > On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote: > > Hi, > > > > On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote: > > > I hit ',' a few times, going back past a page with a > > > big progressive jpeg webcomic, and hit ^Q to close the window > > > while dillo was thinking its way past that image. > > > > > > Got: > > > > > > Program received signal SIGSEGV, Segmentation fault. > > > [Switching to Thread 16384 (LWP 2782)] > > > 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > > at Widget.cxx:575 > > > 575 widget->damage_ |= DAMAGE_CHILD; > > > (gdb) bt > > > #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > > at Widget.cxx:575 > > > #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) > > > at ui.cc:1109 > > > #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 > > > #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 > > > #4 0x080e489d in fltk::run () at TabGroup.cxx:116 > > > #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 > > > > > > > > > Maybe that's just a part of life with callbacks... > > > > > > > I no longer see this crash when removing the buttons_sens workaround > > in uicmd.cc as in attached patch. > > Does someone remember why it was introduced? > > It comes from dillo1. > > Committed. > > BTW, this is exactly what I meant with a UI getting the wrong bw. > I think this should be fixed before the release. Update: I have a patch that works in my tree. It gets rid of bw as the window's user_data(). Just allow me some time to test/polish. -- Cheers Jorge.-

Sept. 30, 2008

segfault -- callback + closed window?

by jcid＠dillo.org

On Tue, Sep 30, 2008 at 05:22:08PM +0200, Johannes Hofmann wrote: > Hi, > > On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote: > > I hit ',' a few times, going back past a page with a > > big progressive jpeg webcomic, and hit ^Q to close the window > > while dillo was thinking its way past that image. > > > > Got: > > > > Program received signal SIGSEGV, Segmentation fault. > > [Switching to Thread 16384 (LWP 2782)] > > 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > at Widget.cxx:575 > > 575 widget->damage_ |= DAMAGE_CHILD; > > (gdb) bt > > #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > > at Widget.cxx:575 > > #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) > > at ui.cc:1109 > > #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 > > #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 > > #4 0x080e489d in fltk::run () at TabGroup.cxx:116 > > #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 > > > > > > Maybe that's just a part of life with callbacks... > > > > I no longer see this crash when removing the buttons_sens workaround > in uicmd.cc as in attached patch. > Does someone remember why it was introduced? It comes from dillo1. Committed. BTW, this is exactly what I meant with a UI getting the wrong bw. I think this should be fixed before the release. -- Cheers Jorge.-

Sept. 30, 2008

segfault -- callback + closed window?

by Johannes.Hofmann＠gmx.de

Hi, On Mon, Sep 29, 2008 at 07:38:20PM +0000, corvid wrote: > I hit ',' a few times, going back past a page with a > big progressive jpeg webcomic, and hit ^Q to close the window > while dillo was thinking its way past that image. > > Got: > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 16384 (LWP 2782)] > 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > at Widget.cxx:575 > 575 widget->damage_ |= DAMAGE_CHILD; > (gdb) bt > #0 0x080fc708 in fltk::Widget::redraw (this=0x81cb680, flags=8 '\b') > at Widget.cxx:575 > #1 0x0804f679 in UI::button_set_sens (this=0x82ce9d8, btn=UI_STOP, sens=0) > at ui.cc:1109 > #2 0x08054c59 in a_UIcmd_set_buttons_sens_cb (vbw=0x81ad858) at uicmd.cc:835 > #3 0x080e47f9 in fltk::wait () at TabGroup.cxx:116 > #4 0x080e489d in fltk::run () at TabGroup.cxx:116 > #5 0x0804efab in main (argc=1, argv=0xbffffb44) at dillo.cc:127 > > > Maybe that's just a part of life with callbacks... > I no longer see this crash when removing the buttons_sens workaround in uicmd.cc as in attached patch. Does someone remember why it was introduced? Cheers, Johannes

Sept. 30, 2008

what crashes remain?

by corvid＠lavabit.com

Jorge wrote: > On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > > It's still possible to crash dillo if you click on a remote link and > > quickly click on some images to load them. Doesn't crash every time, > > but typically within four tries or so. I had assumed it was the same > > thing as whatever was wrong with the menu crash, so I'd ignored it. > > > > If I stick > > a_Bw_stop_clients(bw, BW_Img); > > in the DilloHtml destructor, I can no longer get it to crash, but > > I randomly got a "Cache_process_queue Caught busy!!!" while browsing > > earlier today, so there's something wrong with just doing that. > > (Assuming it's related; I'm not in the habit of getting that MSG.) > > That message means big trouble: the event loop stepped over itself... > > I've tried several different ways but can't get to crash it. > > Does the attached patch help? Now I've started to see a few times -- seemingly at random -- where I can't load an image unless I page back and forward again. I'll have to stick some MSGs in my tree and see why it's unhappy.

Sept. 30, 2008

source window's reluctance to show end of file

by jcid＠dillo.org

On Mon, Sep 22, 2008 at 09:06:03PM +0000, corvid wrote: > Jorge wrote: > > On Mon, Sep 22, 2008 at 04:00:59PM +0000, corvid wrote: > > > I've been assuming all along that everyone sees this problem, > > > but then I don't think anyone has ever mentioned it, so I > > > wonder whether it only shows up on my slow machine. > > > > > > Thus far it's always been easier for me to resize the > > > window -- thereby causing whatever refiguring is > > > necessary -- than to dig through TextDisplay to find > > > out what goes wrong when line numbers are turned on. > > > > Yes, I've noticed this and use the same trick to get to the page > > bottom! ;) > > > > Most probably a bug in fltk::TextDisplay. > > > > It also makes me think of making "View source" display from within > > dillo as modified plain text (line numbers + text lines) to get > > "find text" for free as we discussed some time ago. > > > > Unfortunately now the priority is with Tabs and the near release. > > Playing around without too much of an idea of what > I'm doing, I find that sticking a td->relayout(LAYOUT_WH); > after the line number calculations seems to make the > problem go away, so if (as seems overwhelmingly likely) > we don't have a nice solution by release, we could do > something like that as a workaround. It didn't work here. Committed another workaround. Please test. -- Cheers Jorge.-

Sept. 30, 2008

an experiment regarding cross site request forgery

by corvid＠lavabit.com

Joerg wrote: > On Tue, Sep 30, 2008 at 12:56:05PM +0000, corvid wrote: > > So my latest little experiment: out of the image urls your browser > > sees that have queries (the '?a=b&c=d&e=f'), how many are > > There's nothing wrong with that. Such an image URL is a simple GET > request. Any web application doing a modification is broken by design > and there are good reasons for allowing such URLs. The problem is > allowing POST actions to a different site than the one issuing it. Isn't that part of the problem -- that broken sites are using GET for things they shouldn't? PS How about not sending cookies with queries for images? > > If you want to prevent CSRF, consider adding a warning for that (e.g. > form action and current URL are not under the same second level domain). > > Joerg

Sept. 30, 2008