September 2008 - Dillo-dev - lists.mailman3.com

SEGFAULT with mouse click

by corvid＠lavabit.com

Jorge wrote: > This hinted me towards a timing issue and found this way to > crash dillo (most probably akin to the "middle-click" bug): > > 1.- Left click over a remote URL link > (to have some time while DNS is resolving) > 2.- Move the mouse pointer out of the link and right-click > to get the popup menu, before the new page starts downloading. > 3.- Once the new page starts to show, click again to get rid of > the popup, and it'll crash. What a coincidence! I finally got around to making a patch for that last night. (I'd known about that one for a while...)

Sept. 26, 2008

[patch] raw labels, was Re: [Dillo-dev] Tabs!!!

by jcid＠dillo.org

On Fri, Sep 26, 2008 at 07:36:30PM +0200, Johannes Hofmann wrote: > On Mon, Sep 22, 2008 at 03:31:58PM +0000, corvid wrote: > > Johannes wrote: > > > On Mon, Sep 22, 2008 at 05:06:35AM +0000, corvid wrote: > > > > I wrote: > > > > > Johannes wrote: > > > > > > On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > > > > > > > I wrote: > > > > > > > > Sometimes the window closes when I click on a page. > > > > > > > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > > > > > > > and then HIDE. > > > > > > > > (I only had one tab, in case that matters.) > > > > > > > > > > > > > > Okay, that was not accurate. > > > > > > > It looks like PUSH and FOCUS_CHANGE is from clicking > > > > > > > and HIDE is from pressing Space to page down. > > > > > > > > > > > > I'm also seeing that. No idea yet... > > > > > > > > > > I finally sat down and worked out what the problem is. > > > > > It's not only click-space, but that's the most common case. > > > > > > > > > > <title>...&[character]...</title> > > > > > > > > > > causes click-[character] to close it. > > > > > > > > > > So fltk must think that's a shortcut in > > > > > the tab text, and it tries to do whatever > > > > > it does with shortcuts -- but there's a > > > > > shortcut-handling piece missing, so it > > > > > just closes the window. > > > > > > > > It doesn't care about the tab text. > > > > It's the UI->window() label stuff that's causing the problem. > > > > It appears that you can escape &-as-shortcut in general > > > > by doubling them, but I end up with doubled && in the > > > > title bar. > > > > Why wasn't this a problem in the past? I don't know; maybe it > > > > _was_ regarded as a shortcut but handle() took care of it. > > > > > > > > > > Thanks for tracking this down! > > > I could also reproduce it with pre-tabs versions. > > > > I have a dillo from Sept. 5 around, and space doesn't > > close the window for me. > > > > > Please try attached patch. > > > > It works! RAW_LABEL is so much better than trying to escape &. > > > > Here comes a complete patch to disable label parsing for labels set > from html. I hope I didn't miss one. Committed. -- Cheers Jorge.-

Sept. 26, 2008

[patch] raw labels, was Re: [Dillo-dev] Tabs!!!

by Johannes.Hofmann＠gmx.de

On Fri, Sep 26, 2008 at 06:47:55PM +0000, corvid wrote: > Johannes wrote: > > Here comes a complete patch to disable label parsing for labels set > > from html. I hope I didn't miss one. > > Does the UI's label need it in principle? > (It didn't seem to require escaping the other day, but...) > I tried it with <html> <body> <form> <select> <option>&a</option> <option>&b</option> <option>&c</option> </select> </form> </body> </html> Without the patch there is no & and Alt a/b/c seem to be working as shortcut on the open select. Cheers, Johannes

Sept. 26, 2008

[patch] raw labels, was Re: [Dillo-dev] Tabs!!!

by corvid＠lavabit.com

Johannes wrote: > Here comes a complete patch to disable label parsing for labels set > from html. I hope I didn't miss one. Does the UI's label need it in principle? (It didn't seem to require escaping the other day, but...)

Sept. 26, 2008

SEGFAULT with mouse click

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 11:14:28PM -0700, Donald Chai wrote: > On Thu, Sep 25, 2008 at 3:58 PM, Jorge Arellano Cid <jcid(a)dillo.org> wrote: > > I just came accross an easy to reproduce segfault, that's > > present since long ago. > > > > Middle-clicking works OK right? > > > > Well, try middle-clicking a link with a two mouse button (i.e. > > pressing both at the same time). The link menu stays open and > > after a second click (e.g. left click to make it dissapear) > > it segfaults. > > [...] > > I see this problem as well. If I very quickly press the left then > right mouse button (NOT at the same time), then I get a segfault. > Dillo seems to try to select some text on the old page, after the new > page is loaded. This hinted me towards a timing issue and found this way to crash dillo (most probably akin to the "middle-click" bug): 1.- Left click over a remote URL link (to have some time while DNS is resolving) 2.- Move the mouse pointer out of the link and right-click to get the popup menu, before the new page starts downloading. 3.- Once the new page starts to show, click again to get rid of the popup, and it'll crash. -- Cheers Jorge.-

Sept. 26, 2008

PATCH: select new tabs

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Thu, Sep 25, 2008 at 06:51:14PM -0400, Jorge Arellano Cid wrote: > Hi there, > > On Mon, Sep 22, 2008 at 10:03:32AM -0700, bf wrote: > > > > > > > > --- On Mon, 9/22/08, corvid <corvid(a)lavabit.com> wrote: > > > > > From: corvid <corvid(a)lavabit.com> > > > Subject: Re: [Dillo-dev] PATCH: select new tabs > > > To: dillo-dev(a)dillo.org > > > Date: Monday, September 22, 2008, 11:41 AM > > > Jeremy wrote: > > > > On Mon, Sep 22, 2008 at 12:06:27AM +0000, corvid > > > wrote: > > > > > Jeremy wrote: > > > > > > > > > > > This patch is more of a call for > > > discussion than a fix as it > > > > > > fiddles with the UI. It makes Dillo > > > select the new tab after > > > > > > creating it. As a special case, > > > middle-clicking a link does not > > > > > > select the new tab unless the Shift key > > > is down. (This is the > > > > > > same behaviour as Firefox which saves > > > learning a new set of > > > > > > reflexes.) What do people think? > > > > > > > > > > It does seem that "I want to see this in a > > > new tab/window now" has > > > > > been more common for me than "I want to > > > look at this in a different > > > > > tab/window later". > > > > > > > > So do you think that a middle button click on a > > > link should always > > > > select the new tab? I often go down a list opening > > > up new tabs to > > > > look at later so I get frustrated when I have to > > > switch back each > > > > time. On the other hand when I create a new blank > > > tab I always want > > > > to switch to it immediately so I prefer Dillo to do > > > that for me. > > > > > > Well, I've never been in the habit of using tabs, so I > > > don't have too much > > > of an opinion about the particulars yet. I will agree that > > > allowing > > > both "see this now" and "see this > > > later" in some way is good. > > > > > > > Yes, please make it possible for users to choose both via keyboard or mouse -- I find it very useful to alternate between both behaviors -- sometimes I want to switch immediately to new content in a new tab, and other times I want to open a new tab, but > > remain in the current tab, and look at the new tab "in a minute". You don't want to have to either backtrack in a webpage or navigate back to a tab unnecessarily. Some other glitches(?) I've noticed: > > [...] > > Considering the feedback, there's a new patch in CVS. > > It adds: > "New Tab Ctrl+T" in the File menu > "Open Link in new Tab" in the Link menu > "Open Image in new Tab" in the Image menu > > It also adds two dillo2rc options: > (don't forget to add them to your local dillo2rc) > > # A mouse's middle click over a link opens a new Tab. > # If you prefer to open a new Window instead, set it to NO. > #middle_click_opens_new_tab=YES > > # Focus follows new Tabs. > # You can hold SHIFT to temporarily revert this behaviour. > #focus_new_tab=YES > > Note that Ctrl+T always focus the new Tab, but you can use SHIFT > while clicking to revert the focus_new_tab setting! > > It also adds Johannes fixup for the resizable in case we just removed it. > > > Please give it some test and enjoy! :-) > Excellent! I like how you avoided to make DilloTabs a member of BrowserWindow. Cheers, Johannes

Sept. 26, 2008

[patch] raw labels, was Re: [Dillo-dev] Tabs!!!

by Johannes.Hofmann＠gmx.de

On Mon, Sep 22, 2008 at 03:31:58PM +0000, corvid wrote: > Johannes wrote: > > On Mon, Sep 22, 2008 at 05:06:35AM +0000, corvid wrote: > > > I wrote: > > > > Johannes wrote: > > > > > On Fri, Sep 19, 2008 at 03:21:58PM +0000, corvid wrote: > > > > > > I wrote: > > > > > > > Sometimes the window closes when I click on a page. > > > > > > > A quick fprintf() says PUSH causing a recursive FOCUS_CHANGE, > > > > > > > and then HIDE. > > > > > > > (I only had one tab, in case that matters.) > > > > > > > > > > > > Okay, that was not accurate. > > > > > > It looks like PUSH and FOCUS_CHANGE is from clicking > > > > > > and HIDE is from pressing Space to page down. > > > > > > > > > > I'm also seeing that. No idea yet... > > > > > > > > I finally sat down and worked out what the problem is. > > > > It's not only click-space, but that's the most common case. > > > > > > > > <title>...&[character]...</title> > > > > > > > > causes click-[character] to close it. > > > > > > > > So fltk must think that's a shortcut in > > > > the tab text, and it tries to do whatever > > > > it does with shortcuts -- but there's a > > > > shortcut-handling piece missing, so it > > > > just closes the window. > > > > > > It doesn't care about the tab text. > > > It's the UI->window() label stuff that's causing the problem. > > > It appears that you can escape &-as-shortcut in general > > > by doubling them, but I end up with doubled && in the > > > title bar. > > > Why wasn't this a problem in the past? I don't know; maybe it > > > _was_ regarded as a shortcut but handle() took care of it. > > > > > > > Thanks for tracking this down! > > I could also reproduce it with pre-tabs versions. > > I have a dillo from Sept. 5 around, and space doesn't > close the window for me. > > > Please try attached patch. > > It works! RAW_LABEL is so much better than trying to escape &. > Here comes a complete patch to disable label parsing for labels set from html. I hope I didn't miss one. Cheers, Johannes

Sept. 26, 2008

patch: Re: [Dillo-dev] cut off word ends with italic fonts

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 08:25:12PM +0000, corvid wrote: > Johannes wrote: > > somtimes the end of italic words get cut off e.g. in > > > > <html> > > <body> > > <i><a href="foo">FUU</a>BAR</i> > > </body> > > </html> > > > > when seen with vw_fontname="helvetica". > > > > This is due to a change in html.cc (I think it was introduced with > > rev 1.36). This change sets the backgroundColor for all words which > > means that for each word, the bounding box get's drawn before the > > actual text. This obviously has a performance impact too. > > > > I'm not sure how to get back to the original behaviour > > (backgroundColor == NULL for normal words) without breaking anything. > > Can someone please have a look? > > This > - reverts all of the style->backgroundColor to current_bg_color > - sets backgroundColor for fltk widgets because NULL is already > taken to mean standard_widget_colors > - sets backgroundColor for image inputs and <button>s since they use a > new Layout. > - changes table_cell_style's backgroundColor at the bottom of > Html_tag_open_tr() if the TR specifies one. I don't know why the original > code didn't need that. Maybe it was broken. > > I wasn't feeling too sure about doing this before release, but Johannes > says "currently an unnecessary XFillRectangle() command is sent to the X > Server for every word" and I haven't had problems running on it so far, > so it seems worthy of putting on the list for consideration. Committed. -- Cheers Jorge.-

Sept. 26, 2008

SEGFAULT with mouse click

by corvid＠lavabit.com

Jorge wrote: > On Thu, Sep 25, 2008 at 11:33:09PM +0000, corvid wrote: > > Jorge wrote: > > > I just came accross an easy to reproduce segfault, that's > > > present since long ago. > > > > > > Middle-clicking works OK right? > > > > > > Well, try middle-clicking a link with a two mouse button (i.e. > > > pressing both at the same time). The link menu stays open and > > > after a second click (e.g. left click to make it dissapear) > > > it segfaults. > > > > If I "middle-click" a link by pressing both buttons, it just opens a new tab. > > If I middle-click with an external three button mouse, it works > perfectly. Here in my laptop I have three "mice": a usb external, > a trackpoint with a couple of buttons (like the thinkpads) and a > touch pad with another pair of buttons. Pressing both touchpad > buttons works OK, but pressing the buttons belonging to the > trackpoint produces a segfault. Trackpoint is what I have. I tried commenting out the 3-button emulation in xorg.conf and restarting X, but it still worked the same (which surprised me, btw).

Sept. 26, 2008

SEGFAULT with mouse click

by jcid＠dillo.org

On Thu, Sep 25, 2008 at 11:33:09PM +0000, corvid wrote: > Jorge wrote: > > I just came accross an easy to reproduce segfault, that's > > present since long ago. > > > > Middle-clicking works OK right? > > > > Well, try middle-clicking a link with a two mouse button (i.e. > > pressing both at the same time). The link menu stays open and > > after a second click (e.g. left click to make it dissapear) > > it segfaults. > > If I "middle-click" a link by pressing both buttons, it just opens a new tab. If I middle-click with an external three button mouse, it works perfectly. Here in my laptop I have three "mice": a usb external, a trackpoint with a couple of buttons (like the thinkpads) and a touch pad with another pair of buttons. Pressing both touchpad buttons works OK, but pressing the buttons belonging to the trackpoint produces a segfault. -- Cheers Jorge.-

Sept. 26, 2008