September 2008 - Dillo-dev - lists.mailman3.com

patch: changeLinkColor

by corvid＠lavabit.com

I wrote: > The registerName is because html.cc needs to have that working in > order to call changeLinkColor. By the way, in addition to html.cc, instanceOf is used in Textblock::addParbreak(). Perhaps we will see some effect from this.

Sept. 28, 2008

patch: changeLinkColor

by corvid＠lavabit.com

Johannes wrote: > On Sun, Sep 28, 2008 at 06:00:20AM +0000, corvid wrote: > > I just took the 0.8.6 version and replaced everything in it with > > dillo2 versions. (well, then had to add in the widget part) > > The fact that it seems to be working is kind of shocking. > > > > As for whether this is still the right way to do it, I leave this > > matter for the experts. > > Not that I'm an expert, but it looks right to me. It looks like it still needs to change spaceStyle. I wonder why spaceStyle is necessary... something to do with CSS?

Sept. 28, 2008

panel_size=small hides the menubar

by onepoint＠starurchin.org

On Sun, Sep 28, 2008 at 08:27:28AM -0400, Jorge Arellano Cid wrote: > On Sun, Sep 28, 2008 at 12:58:17PM +0100, Jeremy Henty wrote: > > > > If I add "panel_size=small" to ~/.dillo/dillo2rc then the menubar > > disappears! Huh? (~/.dillo/dillo2rc is otherwise identical to > > the default /etc/dill2rc) > > Well, more or less that's the idea with tiny, small and medium. Oh, I see! I was thinking of "the panel" as referring to just the button bar rather than the whole set of controls at the top. It makes more sense now but it's still a little surprising: I would expect a change of size specification to do nothing more than change the size of things, not make some of them disappear. > Whereas it has an inconsistency with the "show_menubar" preference, > that's happily ignored by the code. > > This should be corrected into a consistent and easy to use model. I would say that it would be simpler and more consistent to make "show_menubar" the only thing that determines whether the menubar is shown, and make "panel_size" affect nothing except the sizes of things. *If* there's an opportunity for a more radical change before release, why not move the File menubutton into the button bar (perhaps with a vertical divider to set them apart)? IMHO it's very ugly to have the File button sitting all alone at the top, wasting all that precious vertical whitespace for just one button! (That's why I only just noticed the menubar had gone, I normally turn it off anyway.) Regards, Jeremy Henty

Sept. 28, 2008

panel_size=small hides the menubar

by jcid＠dillo.org

On Sun, Sep 28, 2008 at 12:58:17PM +0100, Jeremy Henty wrote: > > If I add "panel_size=small" to ~/.dillo/dillo2rc then the menubar > disappears! Huh? (~/.dillo/dillo2rc is otherwise identical to the > default /etc/dill2rc) Well, more or less that's the idea with tiny, small and medium. Whereas it has an inconsistency with the "show_menubar" preference, that's happily ignored by the code. This should be corrected into a consistent and easy to use model. -- Cheers Jorge.-

Sept. 28, 2008

panel_size=small hides the menubar

by onepoint＠starurchin.org

If I add "panel_size=small" to ~/.dillo/dillo2rc then the menubar disappears! Huh? (~/.dillo/dillo2rc is otherwise identical to the default /etc/dill2rc) Regards, Jeremy Henty

Sept. 28, 2008

patch: changeLinkColor

by Johannes.Hofmann＠gmx.de

On Sun, Sep 28, 2008 at 06:00:20AM +0000, corvid wrote: > I just took the 0.8.6 version and replaced everything in it with > dillo2 versions. (well, then had to add in the widget part) > The fact that it seems to be working is kind of shocking. > > As for whether this is still the right way to do it, I leave this > matter for the experts. Not that I'm an expert, but it looks right to me. Cheers, Johannes

Sept. 28, 2008

patch: changeLinkColor

by corvid＠lavabit.com

I just took the 0.8.6 version and replaced everything in it with dillo2 versions. (well, then had to add in the widget part) The fact that it seems to be working is kind of shocking. As for whether this is still the right way to do it, I leave this matter for the experts. The registerName is because html.cc needs to have that working in order to call changeLinkColor.

Sept. 28, 2008

what crashes remain?

by corvid＠lavabit.com

Johannes wrote: > On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > > I can't think of any other crashes, but I don't remember whether > > Johannes still gets bus errors. > > No, they got fixed with > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-July/004649.html > > The only issues I'm seeing are the 128 tabs limit from fltk and the > redraw storms related to the MenuTabPager. Playing with the file menu, I see that Alt-W, Alt-E, Alt-X, Alt-C all segfault. I thought somebody said something (that I didn't pay attention to) about the file menu since tabs were added, but if so, I can't find that mail.

Sept. 28, 2008

what crashes remain?

by corvid＠lavabit.com

Jorge wrote: > On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > > It's still possible to crash dillo if you click on a remote link and > > quickly click on some images to load them. Doesn't crash every time, > > but typically within four tries or so. I had assumed it was the same > > thing as whatever was wrong with the menu crash, so I'd ignored it. > > > > If I stick > > a_Bw_stop_clients(bw, BW_Img); > > in the DilloHtml destructor, I can no longer get it to crash, but > > I randomly got a "Cache_process_queue Caught busy!!!" while browsing > > earlier today, so there's something wrong with just doing that. > > (Assuming it's related; I'm not in the habit of getting that MSG.) > > That message means big trouble: the event loop stepped over itself... > > I've tried several different ways but can't get to crash it. > > Does the attached patch help? Seems to be working well so far. Is there any danger in adding something like a_Nav_cancel_expect to a_UIcmd_stop()? PS Stop should have a keyboard shortcut, I think. I long had a reflex of hitting ESC from the netscape/mozilla days, but of course ESC would be inconsistent for dillo.

Sept. 28, 2008

what crashes remain?

by jcid＠dillo.org

On Sat, Sep 27, 2008 at 05:29:28PM +0000, corvid wrote: > It's still possible to crash dillo if you click on a remote link and > quickly click on some images to load them. Doesn't crash every time, > but typically within four tries or so. I had assumed it was the same > thing as whatever was wrong with the menu crash, so I'd ignored it. > > If I stick > a_Bw_stop_clients(bw, BW_Img); > in the DilloHtml destructor, I can no longer get it to crash, but > I randomly got a "Cache_process_queue Caught busy!!!" while browsing > earlier today, so there's something wrong with just doing that. > (Assuming it's related; I'm not in the habit of getting that MSG.) That message means big trouble: the event loop stepped over itself... I've tried several different ways but can't get to crash it. Does the attached patch help? -- Cheers Jorge.-

Sept. 27, 2008