June 2008 - Dillo-dev - lists.mailman3.com

Textblock::addText()

by Johannes.Hofmann＠gmx.de

Hi, On Fri, Jun 20, 2008 at 01:03:26PM -0400, Jorge Arellano Cid wrote: > Hi there, > > - Changed Textblock::addText() to internally allocate its text string, > making the memory handling opaque to the caller. > > Does anybody remmeber the topic of addText() deleting a malloc'ed > block of memory? > > I decided to make the change for API cleanliness/correctness and set > the Textblock do the whole memory handling (i.e. now the Textblock is > the one that allocates/deallocates the text string). > > The HTML parser was adjusted a bit to keep its old performance. Very nice! I thought this is the right moment to drag out my old text allocation optimization. And now it really makes a difference. I see about 10M less memory usage on the mysql page and most important, leaving that huge page is quite a bit faster - as there is less free() calls. The result may be completely different on Linux however. So please give it a try on Linux. Cheers, Johannes

June 20, 2008

[patch] move highlighting data into Textblock

by jcid＠dillo.org

On Fri, Jun 20, 2008 at 04:26:39PM +0200, Johannes Hofmann wrote: > Hi, > > attached patch fixes the issue here. I had just recently switched > the code from using hlStart[layer].index < 0 to > hlStart[layer].index > hlEnd[layer].index to indicate that nothing > is highlighted. > It turned out that I had forgotten to adapt some parts. > In addition this patch cleans up some rough edges. Committed. -- Cheers Jorge.-

June 20, 2008

form.cc: more refactoring

by jcid＠dillo.org

On Thu, Jun 19, 2008 at 08:48:48PM +0100, Jeremy Henty wrote: > On Wed, Jun 18, 2008 at 08:35:57AM -0400, Jorge Arellano Cid wrote: > > > Committed, except 00 and 05. > > > > 00: The stash buffer may hold a script, in that case parse_stash is not > > as clear as parse_entities. > > Would a better name make the change acceptable? For instance, > Html_parse_stash_entries() ? Html_parse_stash_entities() ? Why is it better than the traditional a_Html_parse_entities()? > > > 05: gives compilation errors: > > [...] > > form.cc: In function 'void Html_option_finish(DilloHtml*)': > > form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* > > DilloHtmlSelect::options' is private > > form.cc:1918: error: within this context > > form.cc:184: error: 'lout::misc::SimpleVector<DilloHtmlOption*>* > > DilloHtmlSelect::options' is private > > form.cc:1918: error: within this context > > That's because not committing 00 breaks one of the chunks in 04 so you > still have an explicit ->inputs which should have been replaced by a > call to getCurrentOption() . I'm appending the missing chunk of 04 > and resubmitting 05 . Committed. -- Cheers Jorge.-

June 20, 2008

Textblock::addText()

by jcid＠dillo.org

Hi there, - Changed Textblock::addText() to internally allocate its text string, making the memory handling opaque to the caller. Does anybody remmeber the topic of addText() deleting a malloc'ed block of memory? I decided to make the change for API cleanliness/correctness and set the Textblock do the whole memory handling (i.e. now the Textblock is the one that allocates/deallocates the text string). The HTML parser was adjusted a bit to keep its old performance. -- Cheers Jorge.-

June 20, 2008

occasional bus errors

by corvid＠lavabit.com

Johannes wrote: > is anyone else seeing these rare bus errors? This is not new and > happens every now and then. I'm trying to track it down, but it > would be helpful to have a method to reliably reproduce it. No, I haven't been seeing them here on linux.

June 20, 2008

occasional bus errors

by Johannes.Hofmann＠gmx.de

Hi is anyone else seeing these rare bus errors? This is not new and happens every now and then. I'm trying to track it down, but it would be helpful to have a method to reliably reproduce it. Cheers, Johannes BTW: It's currently the only type of crash I noticed. Program terminated with signal 10, Bus error. #0 0x28595b1a in ?? () (gdb) bt #0 0x28595b1a in ?? () #1 0x0808ec51 in ~DeepIterator (this=0x28565720) at iterator.cc:515 #2 0x08091dc8 in dw::core::SelectionState::resetSelection (this=0x2850a47c) at selection.cc:85 #3 0x08091e20 in dw::core::SelectionState::reset (this=0x2850a47c) at selection.cc:75 #4 0x08091809 in dw::core::Layout::removeWidget (this=0x2850a400) at layout.cc:167 #5 0x080970ff in ~Widget (this=0x285aaf00) at widget.cc:269 #6 0x0807d554 in ~Textblock (this=0x285aaf00) at textblock.cc:117 #7 0x080916c7 in dw::core::Layout::setWidget (this=0x2850a400, widget=0x285b0300) at layout.cc:175 #8 0x08056ddc in a_Web_dispatch_by_type (Type=0x285a4560 "text/html; charset=us-ascii", Web=0x285659c0, Call=0x285958d0, Data=0x285958d4) at web.cc:94 #9 0x08058583 in Cache_process_queue (entry=0x28582400) at cache.c:1042 #10 0x08058d3c in a_Cache_process_dbuf (Op=0, buf=0x2873c000 "HTTP/1.1 200 OK\r\nDate: Fri, 20 Jun 2008 15:51:22 GMT\r\nServer: Apache/1.3.34 (Debian) PHP/4.4.4-8+etch6 mod_ssl/2.8.25 OpenSSL/0.9.8c\r\nCache-control: no-cache\r\nConnection: close\r\nTransfer-Encoding: chu"..., buf_size=1440, Url=0x285a1d00) at cache.c:871 #11 0x080564b8 in a_Chain_fcb (Op=134802368, Info=0x285a2e80, Data1=0x285c9ac0, Data2=0x80eb3e3) at chain.c:111 #12 0x080743dc in a_Dpi_ccc (Op=2, Branch=2, Dir=1, Info=0x28595b40, Data1=0x285c9200, Data2=0x0) at dpi.c:223 #13 0x080564b8 in a_Chain_fcb (Op=134802368, Info=0x285a2e80, Data1=0x285c9200, Data2=0x0) at chain.c:111 #14 0x08074cfd in a_IO_ccc (Op=2, Branch=2, Dir=1, Info=0x28595ba0, Data1=0x28595e00, Data2=0x0) at IO.c:418 #15 0x08074e8a in IO_callback (fd=<value optimized out>, io=0x28595e00) at IO.c:205 #16 0x08074f63 in IO_fd_read_cb (fd=4, data=0x20e) at IO.c:291 #17 0x080c28cd in fltk::wait () #18 0x080c2a7d in fltk::run () #19 0x0804e63d in main (argc=-1958539068, argv=0x58390446) at dillo.cc:125

June 20, 2008

easy way to get many root certificates?

by corvid＠lavabit.com

Johannes wrote: > On Fri, Jun 20, 2008 at 02:16:33PM +0000, corvid wrote: > > Joerg wrote: > > > On Fri, Jun 20, 2008 at 05:06:49AM +0000, corvid wrote: > > > > But I don't want to do that over and over for all > > > > of the common root certificates. > > > > > > http://lxr.mozilla.org/mozilla/source/security/nss/lib/ckfw/builtins/certda… > > > > Is there a quick way to generate certificates from that? > > You may try > > http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/security/mozilla-root… It's working! Thanks guys!

June 20, 2008

easy way to get many root certificates?

by joerg.sonnenberger＠web.de

On Fri, Jun 20, 2008 at 02:16:33PM +0000, corvid wrote: > Joerg wrote: > > On Fri, Jun 20, 2008 at 05:06:49AM +0000, corvid wrote: > > > But I don't want to do that over and over for all > > > of the common root certificates. > > > > http://lxr.mozilla.org/mozilla/source/security/nss/lib/ckfw/builtins/certda… > > Is there a quick way to generate certificates from that? Yes, but it seems to be broken right now. I'll ask the author of the pkgsrc script to take a look. Joerg

June 20, 2008

[patch] move highlighting data into Textblock

by Johannes.Hofmann＠gmx.de

Hi, attached patch fixes the issue here. I had just recently switched the code from using hlStart[layer].index < 0 to hlStart[layer].index > hlEnd[layer].index to indicate that nothing is highlighted. It turned out that I had forgotten to adapt some parts. In addition this patch cleans up some rough edges. Cheers, Johannes On Thu, Jun 19, 2008 at 06:28:26PM -0400, Jorge Arellano Cid wrote: > On Fri, Jun 20, 2008 at 12:18:12AM +0200, Johannes Hofmann wrote: > > On Thu, Jun 19, 2008 at 03:16:38PM -0400, Jorge Arellano Cid wrote: > > > On Thu, Jun 19, 2008 at 04:32:31PM +0200, Johannes Hofmann wrote: > > > > Hi, > > > > > > > > as promised here comes a patch to move highlighting information from > > > > struct Word into Textblock to save memory. > > > > I had to change the semantics of the highlighting API slightly (see > > > > comments) to ensure that the highlighted part is always contiguous. > > > > > > > > Here are some measurements (with load_images=NO): > > > > > > > > Page dillo-fltk patched_dillo-fltk dillo1 firefox > > > > ============================================================== > > > > splash 7240K 7236K > > > > xslt [1] 15016K 14220K > > > > freebsd [2] 70264K 58084K > > > > mysql [3] 186M 148M 232M 200M > > > > > > > > Obviously the difference is mostly visible on large pages. And > > > > firefox is pretty close regarding memory usage. However it needed more > > > > than 3 minutes to load the local mysql page compared to 6 seconds > > > > for dillo-fltk! > > > > > > > > Please look out for possible highlight related regressions. > > > > > > With the same msql page: > > > > > > http://downloads.mysql.com/docs/refman-6.0-en.html.tar.gz > > > > > > and HUGE_FILESIZE set to 15MB, search for "yen sign". After > > > the fourth match, strange highlights become to happen. > > > > I only have the Euro sign on my keyboard :-) Searching for it works > > fine. Do you know how I can enter the Yen sign? > > No, but I'm talking of the string "yen sign" fed to find text! :-) > > > Can you try whether this issue is new with my patch? > > I did. > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

June 20, 2008

easy way to get many root certificates?

by Johannes.Hofmann＠gmx.de

On Fri, Jun 20, 2008 at 02:16:33PM +0000, corvid wrote: > Joerg wrote: > > On Fri, Jun 20, 2008 at 05:06:49AM +0000, corvid wrote: > > > But I don't want to do that over and over for all > > > of the common root certificates. > > > > http://lxr.mozilla.org/mozilla/source/security/nss/lib/ckfw/builtins/certda… > > Is there a quick way to generate certificates from that? You may try http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/security/mozilla-root… Cheers, Johannes

June 20, 2008