May 2008 - Dillo-dev - lists.mailman3.com

Previous patches a la camelCase

by onepoint＠starurchin.org

In case Jorge prefers them, here are revised versions of today's patches with camelCased method names. Regards, Jeremy Henty

May 28, 2008

[patch]: html.cc: change Html_make_multipart_boundary() to DilloHtmlForm::make_multipart_boundary()

by onepoint＠starurchin.org

More of the same. I'll hold off sending any more patches until these three have been reviewed. (Especially since I just remembered Jorge will probably want to camelCase the method names. D'oh!) Regards, Jeremy Henty

May 28, 2008

[patch]: html.cc: rename Html_build_query_data() to DilloHtmlForm::build_query_data()

by onepoint＠starurchin.org

Does what it says on the tin! There's no "move diff" for this one due to declaration order dependencies. I expect the move will happen after the functions that access DilloHtmlInput internals are converted to DilloHtmlInput methods. Regards, Jeremy Henty

May 28, 2008

[patch]: html.cc: change Html_add_input() to HtmlForm::add_input()

by onepoint＠starurchin.org

This changes the Html_add_input() function to an HtmlForm::add_input() method. As before I'm submitting this as a "change diff" + "move diff" to make it easier to review. Reviewers please tell me if it makes things harder instead! Regards, Jeremy Henty

May 28, 2008

html.cc: convert Html_*_reset functions to methods

by onepoint＠starurchin.org

On Tue, May 27, 2008 at 02:18:29PM -0400, Jorge Arellano Cid wrote: > On Tue, May 27, 2008 at 05:03:13PM +0100, Jeremy Henty wrote: > > > > The patch is in two parts: the first makes the changes and the > > second moves the new methods to the right place in the file. If I > > roll the changes and the move into one then "diff" gets confused > > and creates an unreadable monster of a patch. > > [...] BTW, here diff made a nice single patch. I might have messed up the cut and paste on the first attempt and moved more code than I intended, which is why I got the monster diff. However I think that splitting up the patch into a change diff and a move diff might be better for reviewers as it gives them a diff that shows exactly what has changed rather than forcing them to manually compare a delete chunk in one place with an add chunk elsewhere. So I might continue splitting up diffs this way, unless you and the other reviewers think it just makes more work. > BUG: Please notice that forms "reset" doesn't reset selection > lists. (it also wasn't working before the patch). to_do_list++; Regards, Jeremy Henty

May 28, 2008

html.cc: convert Html_*_reset functions to methods

by jcid＠dillo.org

On Tue, May 27, 2008 at 05:03:13PM +0100, Jeremy Henty wrote: > > This changes Html_reset_form() to DilloHtmlForm::reset() and > Html_reset_input() to DilloHtmlInput::reset() . It's part of the plan > to move code that accesses DilloHtmlForm and DilloHtmlInput internals > into methods and make the internals private. > > The patch is in two parts: the first makes the changes and the second > moves the new methods to the right place in the file. If I roll the > changes and the move into one then "diff" gets confused and creates an > unreadable monster of a patch. I'd recommend feeding the two > attachments to patch separately; it might do the right thing given the > whole message in one go, but then again it might not. > > Comments are welcome. Patch committed. BTW, here diff made a nice single patch. BUG: Please notice that forms "reset" doesn't reset selection lists. (it also wasn't working before the patch). > There are several other functions in html.cc > that are really just methods in disguise and are future targets for > the same treatment as Html_reset_form() and Html_reset_input() get > here. OK. -- Cheers Jorge.-

May 27, 2008

html.cc: convert Html_*_reset functions to methods

by onepoint＠starurchin.org

This changes Html_reset_form() to DilloHtmlForm::reset() and Html_reset_input() to DilloHtmlInput::reset() . It's part of the plan to move code that accesses DilloHtmlForm and DilloHtmlInput internals into methods and make the internals private. The patch is in two parts: the first makes the changes and the second moves the new methods to the right place in the file. If I roll the changes and the move into one then "diff" gets confused and creates an unreadable monster of a patch. I'd recommend feeding the two attachments to patch separately; it might do the right thing given the whole message in one go, but then again it might not. Comments are welcome. There are several other functions in html.cc that are really just methods in disguise and are future targets for the same treatment as Html_reset_form() and Html_reset_input() get here. Regards, Jeremy Henty

May 27, 2008

html.cc: small tweak for consistency and debugging

by onepoint＠starurchin.org

This renames a local variable from "size" to "nf". This is consistent with the names of similar local variables elsewhere in the file and also ensures that the _MSG statement will compile if debugging is enabled. Jeremy Henty

May 27, 2008

Re: (working) prototype of charset decoding in cache.c

by jcid＠dillo.org

On Mon, May 26, 2008 at 08:50:19PM +0000, corvid wrote: > Jorge wrote: > > > But I mean it finishes seeing the first head, enables view source, > > > user views the source, and then the charset in the second head causes > > > a repush. Is the parser avoiding that? > > > > Yes, once you are IN_BODY, HEAD can't be re-opened, > > and META doesn't work outside HEAD. > > But if I give it a page containing > > <html> > <head> <title>first head</title> </head> > <body> body </body> > <head> > <meta http-equiv="content-type" content="text/html; charset=iso-8859-1"> > </head> > </html> > > I get > > .. > META Content-Type changes charset to: iso-8859-1 > .. > META Content-Type gave charset as: iso-8859-1 > a_Nav_expect_done: repush! That's a corner case bug. It passed because you closed BODY explicitly (i.e. if you remove the </body> tag, the fault is caught. Patch committed. > > I'd prefer to try the dpi before optimizing. > > I don't know dpis, so to me that's the difficult way... Then let's focus in the decoder. -- Cheers Jorge.-

May 27, 2008

[patch]: html.cc: DilloHtmlInput class: WAS: DilloHtmlForm::getCurrentInput()

by jcid＠dillo.org

On Tue, May 27, 2008 at 10:43:51AM +0100, Jeremy Henty wrote: > > This turns DilloHtmlInput into a class and adds a constructor and > destructor to manage its data members. Note that > DilloHtmlForm::inputs is now a vector of pointers instead of structs. > This is consistent with the earlier change to DilloHtml::forms . OK. Committed. -- Cheers Jorge.-

May 27, 2008