May 2008 - Dillo-dev - lists.mailman3.com

Hooked a decoder for text/plain with charset.

by corvid＠lavabit.com

Jorge wrote: > Just committed this patch. It makes things like: > > http://separat-lib.narod.ru/master.txt > > work. Why now? I don't understand the motivation for this. My next patch is just going to rip it out again because it will become unnecessary.

May 29, 2008

[patch]: simplify a_Html_form_event_handler(): part II

by jcid＠dillo.org

On Thu, May 29, 2008 at 07:38:26PM +0100, Jeremy Henty wrote: > > More simplification of form handling. Several functions that used an > index to an input in the form's input list have been changed to use a > pointer to the input, which removed some useless indirection. This > enabled refactoring the code in a_Html_form_event_handler() that found > the input from the resource into a new method "DilloHtmlInput > *DilloHtmlForm::getInput (void *v_resource)". Committed. -- Cheers Jorge.-

May 29, 2008

[patch]: simplify a_Html_form_event_handler()

by jcid＠dillo.org

On Thu, May 29, 2008 at 05:54:57PM +0100, Jeremy Henty wrote: > > The a_Html_form_event_handler() function displays an amusing > anti-pattern (which I wish I knew the name of) where it's not given > enough data and has to go searching for the missing information. > Specifically, it gets a pointer to the DilloHtml of the page, but not > not the DilloHtmlForm that submitted it, so it has to search the form > list of the DilloHtml to find the form. > > This patch passes the DilloHtmlForm to the handler and adds a pointer > from the DilloHtmlForm to the DilloHtml , so the handler can now > directly access the form and the html without messing around. Committed. -- Cheers Jorge.-

May 29, 2008

Hooked a decoder for text/plain with charset.

by jcid＠dillo.org

Hi, Just committed this patch. It makes things like: http://separat-lib.narod.ru/master.txt work. -- Cheers Jorge.-

May 29, 2008

[patch]: convert Html_submit_form2() to DilloHtmlForm::buildQueryUrl()

by jcid＠dillo.org

On Thu, May 29, 2008 at 03:40:02PM +0100, Jeremy Henty wrote: > > The function Html_submit_form2() does two jobs rolled into one: most > of its code creates a url from a DilloHtmlForm and a few lines push > the url to a DilloHtml . This patch takes advantage of the fact that > Html_submit_form2() is only called from a_Html_form_event_handler() ; > it moves the url push out into the caller and the rest of the code > into a new method "DilloUrl *DilloHtmlForm::buildQueryUrl()". This > separates concerns nicely: the DilloHtmlForm creates the url and > a_Html_form_event_handler() pushes it to the DilloHtml . Committed. > We're getting close to having a proper API for DilloHtmlForm , > unfortunately some of the remaining code is very messy. I'll do the > rest of the easy stuff and then summarise what's left. OK. -- Cheers Jorge.-

May 29, 2008

Previous patches a la camelCase

by jcid＠dillo.org

On Wed, May 28, 2008 at 05:29:35PM +0100, Jeremy Henty wrote: > > In case Jorge prefers them, here are revised versions of today's > patches with camelCased method names. Patch set Committed! -- Cheers Jorge.-

May 29, 2008

[patch]: html.cc: change Html_add_input() to HtmlForm::add_input()

by jcid＠dillo.org

On Wed, May 28, 2008 at 02:31:54PM +0100, Jeremy Henty wrote: > [...] > As before I'm submitting this as a "change diff" + "move > diff" to make it easier to review. Reviewers please tell me if it > makes things harder instead! So far it's been a pleasure to review in this format, but this is not a definitive answer because this is not a complex changeset. For the later case I'd like to have it munched like this anyway. ;) -- Cheers Jorge.-

May 29, 2008

[patch]: simplify a_Html_form_event_handler(): part II

by onepoint＠starurchin.org

More simplification of form handling. Several functions that used an index to an input in the form's input list have been changed to use a pointer to the input, which removed some useless indirection. This enabled refactoring the code in a_Html_form_event_handler() that found the input from the resource into a new method "DilloHtmlInput *DilloHtmlForm::getInput (void *v_resource)". Regards, Jeremy Henty

May 29, 2008

[patch]: simplify a_Html_form_event_handler()

by onepoint＠starurchin.org

The a_Html_form_event_handler() function displays an amusing anti-pattern (which I wish I knew the name of) where it's not given enough data and has to go searching for the missing information. Specifically, it gets a pointer to the DilloHtml of the page, but not not the DilloHtmlForm that submitted it, so it has to search the form list of the DilloHtml to find the form. This patch passes the DilloHtmlForm to the handler and adds a pointer from the DilloHtmlForm to the DilloHtml , so the handler can now directly access the form and the html without messing around. Regards, Jeremy Henty

May 29, 2008

[patch]: convert Html_submit_form2() to DilloHtmlForm::buildQueryUrl()

by onepoint＠starurchin.org

The function Html_submit_form2() does two jobs rolled into one: most of its code creates a url from a DilloHtmlForm and a few lines push the url to a DilloHtml . This patch takes advantage of the fact that Html_submit_form2() is only called from a_Html_form_event_handler() ; it moves the url push out into the caller and the rest of the code into a new method "DilloUrl *DilloHtmlForm::buildQueryUrl()". This separates concerns nicely: the DilloHtmlForm creates the url and a_Html_form_event_handler() pushes it to the DilloHtml . We're getting close to having a proper API for DilloHtmlForm , unfortunately some of the remaining code is very messy. I'll do the rest of the easy stuff and then summarise what's left. Regards, Jeremy Henty

May 29, 2008