May 2008 - Dillo-dev - lists.mailman3.com

[patch]: Refactor {FltkListResource,FltkOptionMenuResource}::sizeRequest()

by onepoint＠starurchin.org

> A simple refactoring: FltkListResource and FltkOptionMenuResource > use the same code to determine the maximum string width. And here's the patch! D'oh!

May 6, 2008

[patch]: Refactor {FltkListResource,FltkOptionMenuResource}::sizeRequest()

by onepoint＠starurchin.org

A simple refactoring: FltkListResource and FltkOptionMenuResource use the same code to determine the maximum string width. Jeremy Henty

May 6, 2008

[bugfix]: FltkSelectionResource leaks memory

by onepoint＠starurchin.org

corvid pointed this out to me. Patch attached. Jeremy Henty

May 6, 2008

Q: should we select option groups

by onepoint＠starurchin.org

FLTK allows both Choice and MultiBrowsers to select group items as well as normal leaf items. The Dillo Selection widget currently ignores selected group items, which could be confusing if a user selects a group and expects the application to do something about it. On the other hand the HTML 4 spec[1] reads as though only options and not option groups can be selected, though it does not say so explicitly. What should Dillo do about this? [1] http://www.htmlhelp.com/reference/html40/forms/select.html

May 6, 2008

ListResources: version 3

by jcid＠dillo.org

On Mon, May 05, 2008 at 11:40:52PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jorge Arellano Cid wrote: > > [..] > > * Used (long) cast for 64bit compatibility (please somebody test). > > That would be me ;) Gotcha! > I haven't looked into whether the added functionality works (didn't know > where to look), but it compiles cleanly and runs just fine. Please check the attached page. You should be able to select any set from the list, and to confirm it works by pressing the test button and looking at the generated URL. > It's nice that you kept an eye on the platform issue ;) Sure. -- Cheers Jorge.-

May 6, 2008

Dillo freeze

by corvid＠lavabit.com

Jorge wrote: > Dillo freezes on this page: > > http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign > > Dillo bug or FLTK2? I ran into this a few months ago with http://p3p.yahoo.com/w3c/p3p.xml (and then eventually forgot about it). They are both tiny and fit in a packet, which might be significant...

May 6, 2008

Dillo freeze

by jcid＠dillo.org

Hi there, Dillo freezes on this page: http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign Dillo bug or FLTK2? -- Cheers Jorge.-

May 5, 2008

ListResources: version 3

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > [..] > * Used (long) cast for 64bit compatibility (please somebody test). That would be me ;) I haven't looked into whether the added functionality works (didn't know where to look), but it compiles cleanly and runs just fine. It's nice that you kept an eye on the platform issue ;) Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIH37koPmwNWhsaZYRAk+fAJ48XIMCFjaD/TbxOSYjciW1brFG+ACeJGvV qgdJPm591wlzYHgXEJxfG9Y= =xmAr -----END PGP SIGNATURE-----

May 5, 2008

patch: dialog.cc window deletion

by jcid＠dillo.org

On Sat, May 03, 2008 at 04:39:34AM +0000, corvid wrote: > Using the crude tool of top(1), I learned that viewing the source of a > 500K file meant losing 500K down the drain. > > - If I give the text to the TextDisplay's initial buffer, it knows that > it owns it. > > - Window::destroy() doesn't delete. The header comment in > fltk/src/Window.cxx says it's some sort of 'hide' function: > > "Hides the window and also deletes all window system information > about the window, and thus returns it back to the state it was in > before the first show(). It is harmless to call this if the window > is already destroyed." > > > - And while I was in there, I threw in some callback(window_close_cb, ...)s > for closing windows using the window mgr instead of a button. > Committed! Funny how the Escape key started working again as close shortcut. -- Cheers Jorge.-

May 5, 2008

ListResources: version 3

by jcid＠dillo.org

Hi Jeremy, In a nutshell: 00__html_dlist_fix.dillo2 10__html_select_multiple.dillo2 10__listresource.dw2 15__listresource_selection.dw2 16__listresource_sizerequest.dw2 committed with minor changes! Some minor changes: * Used (long) cast for 64bit compatibility (please somebody test). * single return point in FltkListResource::widgetCallback. * added some comments. * Removed: //blindly copied from FltkOptionMenuResource, is it necessary? R: yes, it's necessary. Each new added item may change the Width. On Fri, May 02, 2008 at 11:42:18PM +0100, Jeremy Henty wrote: > > I am attaching two patches that get ListResource selection working > properly, ie. you can click items as you wish and > FltkListResource::isSelected() will now return the correct value. > > The first patch is my previous selection patch, unchanged. The second > is a small fix that I proposed in the lout::misc::StringBuffer fix > thread: it makes FltkListResource::addItem call Widget::set_selected() > on fltk::Item widgets, and the call to Menu::set_item() becomes > conditional on a virtual boolean hook that defaults to false, but is > redefined to true in FltkOptionMenuResource() . Yes, it looks simple enough. Added a reminding comment anyway. > [...] > Currently FltkListResource::sizeRequest() is a stub with some > hardwired values that are not very useful. This patch replaces it > with something more appropriate (closely following the existing > implementation of FltkOptionMenuResource::sizeRequest() ). Added some minor adjustments to fit the new size. Good work! -- Cheers Jorge.-

May 5, 2008