May 2008 - Dillo-dev - lists.mailman3.com

Bug that aborts Dillo

by jcid＠dillo.org

On Sat, May 17, 2008 at 02:17:55AM +0000, corvid wrote: > Jorge wrote: > > Hi there, > > > > I reviewed my personal notes on dillo segfaults and all of them > > but one are fixed now. This is: > > > > BUG: > > http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 > > /m/151006647731/r/264004847731 > > Aborts dillo. > > I tried it and it crashed. > Then I dug up the > > - requisition->width += getStyle()->boxDiffHeight (); > + requisition->width += getStyle()->boxDiffWidth (); > > in sizeRequestImpl from > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-January/003690.html > and it no longer wanted to crash for me. Committed, also with the rest of the patch. BTW, when I skip one of these patches, please send me a reminder. I commented the patch to let Sebastian delete/fix the commented-out lines when working there. -- Cheers Jorge.-

May 18, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by Johannes.Hofmann＠gmx.de

On Sat, May 17, 2008 at 05:46:26PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I thought about dillos fullscreen mode, which is not a fullscreen mode > at all but a "get rid of those panels"-mode. So I decided to rename > those functions and variables accordingly (00-*) to make it possible to > implement a real fullscreen mode (01-*). shouldn't window resizing be done by the window manager? Do we really need to implement this inside dillo? I agree on the name change however. Cheers, Johannes

May 18, 2008

Horizontal scrolling

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Huhu there :) attached is a tiny patch that enables the horizontal scrolling of the content of the main dillo widget. Unfortunately fltk supports this up to now (r6129) only on OSX. I do have a patch for fltk that enables this on x11, let's see if I can slip it in ;) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIL0tNoPmwNWhsaZYRAmE+AJ9LN79iT4/nyt1JWJYt7BP1PYcFlQCeLV/g BRZ6xTrW7ER5rbDm7V5E1Hk= =SWKS -----END PGP SIGNATURE-----

May 17, 2008

Keyboard shortcuts & fullscreen button

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 The UI constructor creates a button for the fullscreen mode, but it is not added to anything: // Make the full screen button (to be attached to the viewport later) // TODO: attach to the viewport FullScreen = new HighlightButton(0,0,15,15); [...] Any idea why this was postponed? Should it be enabled now? Also I noticed, that the way events are handled is somewhat lax with respect to modifier keys. The code just checks if ctrl is pressed, not if ctrl but none of the other modifiers are pressed. This makes ctrl-l equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is this a bug or a feature? Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILwMvoPmwNWhsaZYRAmHYAJ49XUO6F6mBTG+CbWAzfN5yknkrKgCfQOjB QzlODEtqUdlztUo6tHuluUE= =hCHy -----END PGP SIGNATURE-----

May 17, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I thought about dillos fullscreen mode, which is not a fullscreen mode at all but a "get rid of those panels"-mode. So I decided to rename those functions and variables accordingly (00-*) to make it possible to implement a real fullscreen mode (01-*). Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILv3RoPmwNWhsaZYRAtAeAKCpvjp7U4n+NW7U25gfd1DJDpnGkACeJw2c PhKxtMxtFGQ1zPs+Qi/Wv8o= =jxiR -----END PGP SIGNATURE-----

May 17, 2008

Bug that aborts Dillo

by corvid＠lavabit.com

Jorge wrote: > Hi there, > > I reviewed my personal notes on dillo segfaults and all of them > but one are fixed now. This is: > > BUG: > http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 > /m/151006647731/r/264004847731 > Aborts dillo. I tried it and it crashed. Then I dug up the - requisition->width += getStyle()->boxDiffHeight (); + requisition->width += getStyle()->boxDiffWidth (); in sizeRequestImpl from http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-January/003690.html and it no longer wanted to crash for me.

May 17, 2008

Bug that aborts Dillo

by jcid＠dillo.org

Hi there, I reviewed my personal notes on dillo segfaults and all of them but one are fixed now. This is: BUG: http://episteme.arstechnica.com/groupee/forums/a/tpc/f/96509133 /m/151006647731/r/264004847731 Aborts dillo. If you wget that URL to a local file, it's easier to debug because the problem is with a requested image. A negative number is propagated down from image.cc:199 #13 0x0807d083 in dw::Image::sizeAllocateImpl (this=0x81eca98,allocation=0xbfc69fb8) at image.cc:201 (gdb) p *allocation $4 = {x = 366, y = 941, width = 3, ascent = 2, descent = 1} (gdb) p dx $5 = 8 (gdb) p dy $6 = 26607 (gdb) allocation->width - dx = -5. from there width=-5 wreaks havoc. Please someone more seasoned in the (dx,dy) offsets give it a look. -- Cheers Jorge.-

May 17, 2008

Dillo freeze

by jcid＠dillo.org

On Fri, May 16, 2008 at 04:28:12PM -0400, Jorge Arellano Cid wrote: > On Mon, May 12, 2008 at 09:29:11PM +0200, Johannes Hofmann wrote: > > On Mon, May 05, 2008 at 05:41:32PM -0400, Jorge Arellano Cid wrote: > > > Hi there, > > > > > > Dillo freezes on this page: > > > > > > http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.24.6.tar.bz2.sign > > > > > > Dillo bug or FLTK2? > > > > Other than I initially thought it is a Dillo bug. The IOwatch for > > reading is not removed properly. As a result the select call in the > > fltk event loop keeps failing with EBADF. > > Attached is a fix for the problem, but I'm not sure whether it is > > correct. Jorge, can you please have a look at it? > > Committed. > > After a really long review. :-P > > Related CCC patches pending here... Ok, the pending patches are now committed. The Changelog reads: - CCC: added reentrancy control to the OpEnd and OpAbort operations. - CCC: enhanced the debug function and implemented OpAbort for dpi. This fixes: - A ftp problem with short files not being sent back. - Downloading short ftp files freezing the downloader. - Cancel on download dialog for ftp file aborting dillo (SEGFAULT). Maybe more... :) Please test. -- Cheers Jorge.-

May 17, 2008

website FAQ update

by corvid＠lavabit.com

Justus wrote: > Jorge Arellano Cid wrote: > > On Fri, May 16, 2008 at 08:21:25PM +0000, corvid wrote: > >> Are "dillo1" and "dillo2" official names? If so, I'll add in some text to > >> make it clear what's what. > > > > They're not official, but good mnemonics! > > > > When there was GTK1 dillo only, there was no confusion. > > Currently the CVS is using dillo-fltk, but I'd much prefer > > to have a binary named "dillo2". > > > > Probably this is a good choice. Let's hear what dillo-dev > > people say. Here's the proposal: > > > > * call the new binary "dillo2", and refer to the old 0.8.x series > > as dillo1. > > I think it's problematic to have a digit in the official name (or in the > name of the binary) since people will think it's the version. I'd > suggest something along these lines: > > * Dillo is the name of the brand > * dillo2 is the codename for the fltk branch > * for marketing reasons sell any snapshots / upcoming releases of that > branch as the all new dillo version 2.x.y with tons of new features > * the binary is called dillo (it's what people expect to type in to > start the lightweight web browser thingie [at least I tried to run > $PREFIX/bin/dillo a couple of times now...]) I also prefer to have a binary named dillo. (and dillorc2 -> dillorc)

May 17, 2008

website FAQ update

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > On Fri, May 16, 2008 at 08:21:25PM +0000, corvid wrote: >> Are "dillo1" and "dillo2" official names? If so, I'll add in some text to >> make it clear what's what. > > They're not official, but good mnemonics! > > When there was GTK1 dillo only, there was no confusion. > Currently the CVS is using dillo-fltk, but I'd much prefer > to have a binary named "dillo2". > > Probably this is a good choice. Let's hear what dillo-dev > people say. Here's the proposal: > > * call the new binary "dillo2", and refer to the old 0.8.x series > as dillo1. I think it's problematic to have a digit in the official name (or in the name of the binary) since people will think it's the version. I'd suggest something along these lines: * Dillo is the name of the brand * dillo2 is the codename for the fltk branch * for marketing reasons sell any snapshots / upcoming releases of that branch as the all new dillo version 2.x.y with tons of new features * the binary is called dillo (it's what people expect to type in to start the lightweight web browser thingie [at least I tried to run $PREFIX/bin/dillo a couple of times now...]) Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFILf4BoPmwNWhsaZYRAor2AJ0U728787tvENHwVuxFW000e/DC/gCgpqZD JVaxk8o+/yROgKeKOapZlA4= =ym7X -----END PGP SIGNATURE-----

May 16, 2008