May 2008 - Dillo-dev - lists.mailman3.com

RFC: human interface guidelines

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) I was thinking about improving the dillo experience by adding some functionality / shortcuts people have come to expect. But what people expect is influenced by their background, their choice of desktop environment and platform. We could pick one / some user interface guideline(s) ([1] lists some) and try to adhere to it / them. Or we could pick one popular browser and copy its 'feel'. Attached are two patches mapping 'reload' to F5 and 'help' to F1. Let me know what you think of them and the whole interface thing. Justus 1: http://en.wikipedia.org/wiki/Human_Interface_Guidelines - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0jvoPmwNWhsaZYRAveJAJ9ROk+E0VWLzK6G99qcTlpNjeB5igCeJ7r9 Grz4wtWQ+BIEbWrIY8PDCFg= =JnX2 -----END PGP SIGNATURE-----

May 21, 2008

Uncluttering dillo, part II: the findbar

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey everyone :) attached is a patch that transforms dillos find in page dialog box into a firefox style toolbar. There are some issues that I cannot put my finger on... see the comments in the event handler. Maybe there's some magic about fltks event model that I did not fully understand... then again it might be fltks fault. Anyway, I'd be happy for some hints. Jorge, could you update your coding conventions with respect to c++ specific language features? Cheers, Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0pmoPmwNWhsaZYRAi1VAJwO/e+JWmCoMsjOF/hYuF4X1DUOWwCePB96 +X++Veu0Gyv854m0TxSwI7Q= =rc5Z -----END PGP SIGNATURE-----

May 21, 2008

[patch] minor memory reduction

by jcid＠dillo.org

On Tue, May 20, 2008 at 07:16:45PM +0200, Johannes Hofmann wrote: > Hi, > > attached is a small patch to improve memory usage. It creates a > single word for a sequence of spaces in PRE mode instead of one word > per character. Good idea, but it's not the same rendering. Check the offsets with the attached file. BTW, there's a memory leak when len=0 (bacause Dstr allocates for the string). While reviewing I thought why not just count the spaces and use dStrnfill(num_spc, ' '). -- Cheers Jorge.-

May 21, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > On Sat, May 17, 2008 at 05:46:26PM +0200, Justus Winter wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> I thought about dillos fullscreen mode, which is not a fullscreen mode >> at all but a "get rid of those panels"-mode. So I decided to rename >> those functions and variables accordingly (00-*) > > Committed. > > With the addition that when the Location is already focused, > the text is also selected. This helps as a visual clue and also > to quickly get rid of the old URL. > > Note: I used a trick in ::handle() to do it. If you know a > better way, please send a patch. Yes, that's a nice feature indeed. Reading the fltk documentation I came up with the attached patch. I am pretty sure that strlen is the wrong function when dealing with utf-8 character data, but you get the idea. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0OmoPmwNWhsaZYRAi0KAJ9B9akYL9AN1c51U0HJoXe9imPcjwCfe7I2 oGA/oCVvuUyZ3+CYPBPsH5U= =SCqk -----END PGP SIGNATURE-----

May 20, 2008

Keyboard shortcuts & fullscreen button

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote: >> Also I noticed, that the way events are handled is somewhat lax with >> respect to modifier keys. The code just checks if ctrl is pressed, not >> if ctrl but none of the other modifiers are pressed. This makes ctrl-l >> equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is >> this a bug or a feature? > > Bug I think. > > The UI was coded in a hurry to get it running. Lax parts need > polish. The attached patch addresses modifier issue. Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIM0KVoPmwNWhsaZYRAr9lAJ429TW3JBochKDUiHAZTK1n5gapZwCeOVGg Na+M4LYF8QqFGJfOaIBFkhI= =Xkri -----END PGP SIGNATURE-----

May 20, 2008

[patch] minor memory reduction

by Johannes.Hofmann＠gmx.de

Hi, attached is a small patch to improve memory usage. It creates a single word for a sequence of spaces in PRE mode instead of one word per character. The second part is just a minor simplification. Cheers, Johannes

May 20, 2008

Horizontal scrolling

by jcid＠dillo.org

On Sat, May 17, 2008 at 11:17:01PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Huhu there :) > > attached is a tiny patch that enables the horizontal scrolling of the > content of the main dillo widget. Unfortunately fltk supports this up to > now (r6129) only on OSX. I do have a patch for fltk that enables this on > x11, let's see if I can slip it in ;) Committed. BTW, please send patched with "diff -pru". -- Cheers Jorge.-

May 19, 2008

Keyboard shortcuts & fullscreen button

by jcid＠dillo.org

On Sat, May 17, 2008 at 06:09:19PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > The UI constructor creates a button for the fullscreen mode, but it is > not added to anything: > > // Make the full screen button (to be attached to the viewport later) > // TODO: attach to the viewport > FullScreen = new HighlightButton(0,0,15,15); > [...] > > Any idea why this was postponed? Should it be enabled now? The idea is that there's a gadget in the viewport (i.e. a small button in the lower right corner that shows even when in fullwindow mode). This was to be used to enable/disable full window mode. Now, thinking twice, maybe is not a bad idea to hook a right-click fullscreen to this button. Leaving left-click for fullwindow mode. ...but for that, the gadget code needs to be enabled. > Also I noticed, that the way events are handled is somewhat lax with > respect to modifier keys. The code just checks if ctrl is pressed, not > if ctrl but none of the other modifiers are pressed. This makes ctrl-l > equivalent with ctrl-shift-alt-l. I'd like to hear your opinions, is > this a bug or a feature? Bug I think. The UI was coded in a hurry to get it running. Lax parts need polish. -- Cheers Jorge.-

May 19, 2008

Uncluttering dillos UI - getting rid of the dialog boxes

by jcid＠dillo.org

On Sat, May 17, 2008 at 05:46:26PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I thought about dillos fullscreen mode, which is not a fullscreen mode > at all but a "get rid of those panels"-mode. So I decided to rename > those functions and variables accordingly (00-*) Committed. With the addition that when the Location is already focused, the text is also selected. This helps as a visual clue and also to quickly get rid of the old URL. Note: I used a trick in ::handle() to do it. If you know a better way, please send a patch. BTW, it'd be great if we can get rid of the findtext window, and place it as an horizontal widget near the bottom (i.e as FF). > to make it possible to implement a real fullscreen mode (01-*). Not committed yet. More on this in my next post... -- Cheers Jorge.-

May 19, 2008

website FAQ update

by corvid＠lavabit.com

Jorge wrote: > > [...] (and dillorc2 -> dillorc) > > We need a way to distinguish among the rc for dillo1 and dillo2. > > Currently you can have both dillo1 and dillo2 installed, sharing > cookies and bookmarks (because we have a single ~/.dillo directory). > > Ideas are welcomed, including dillorc2 -> dillo2rc :-) I was thinking that one was just a superset of the other, but that's because I forgot that the fonts would be different.

May 19, 2008