May 2008 - Dillo-dev - lists.mailman3.com

[BUG]: Redirect to previous page + Reload crashes

by corvid＠lavabit.com

Jeremy wrote: > Dillo crashes as follows: > * Point Dillo at http://starurchin.org:8080/dillo/here > * Click the "There" link. Dillo is redirected back to the "Here" > page. > * Click the "Reload" button. > * Dillo crashes inside a_Nav_reload() (nav.c) at the line "if > (URL_FLAGS(url) & URL_Post) {" because url is NULL. > > I noticed this a few weeks ago but only just found a simple way to > trigger it. Any ideas why this is happening? The problem went away when I tried the attached change, but I may be treating the symptom rather than the disease. It must not be the result of a very recent change, because I have a dillo from April 8 that crashes doing this.

May 24, 2008

RFC: removing the search dialog

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey :) I hacked up opera (at least I _think_ they do it this way) style search engine handling. I am not too happy with what I did to the config file parser, but it works for now :). The parser is beautiful in its simplicity, but it has its limitations (like not being able to handle dictionaries). I am not sure what I would like to see, but for the moment I'd go with dictionaries and the ability to include other files. This way we could ship some config files (think browser personalities) and the user could include the one he likes best and fine tune the settings in his personal dillorc. I was also unsure about the proper way to inform the user of errors and I believe the reason for this is simply that there is no mechanism to do this properly. I am thinking about using the browser widget to render error pages like most of the mainstream browsers. Any thoughts on this one? Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIN4EQoPmwNWhsaZYRAn93AJ9cVSrlojFB7rcRfDuuysS+iF9MrwCfY5rB Be/P/5ORephsPhmdBcyk+MM= =1rOv -----END PGP SIGNATURE-----

May 24, 2008

Uncluttering dillo, part II: the findbar

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: >> attached is a patch that transforms dillos find in page dialog box into >> a firefox style toolbar. > > Nice! > > Committed with some changes. See below. Corvid spotted two spelling errors. Patch is attached. >> There are some issues that I cannot put my >> finger on... see the comments in the event handler. Maybe there's some >> magic about fltks event model that I did not fully understand... then >> again it might be fltks fault. Anyway, I'd be happy for some hints. > > Ok, the comment says: > >> /* BUG: this is acting funny >> * >> * 1. figure out why the first EscapeKey is only >> * sent to the input widget if it is focused at the time >> * 2. ctrl-f ; type foo ; select foo and type bar ; press esc >> * => foo is inserted into the input box >> */ > > Fixed both in the committed version. > > FLTK2 sends the event to handle() and its return value tells > whether the event was handled or not. Here, the input widget was > handling the event (and making the selection empty) so there was > no need to propagate the event upwards, but when the selected > text was already empty (second time) there was nothing to do and > the event was propagated upwards. > > The patch was the same as for the location bar. A custom input > widget that handles keys in a slightly different way that the > native Input widget. In this case (MyInput) we don't handle the > escape key and let FLTK pass it upwards, and thus get the desired > effect. Thanks for the explanation... It really makes sense, but for some strange reason I assumed that the events bubble the other way around... Justus - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIN3q9oPmwNWhsaZYRAoBQAKCw/pncNv/vWyN3cVGuGYoH/ZHxdQCcCrJ3 J/S96py9oODzwP24jdg496U= =SCyw -----END PGP SIGNATURE-----

May 24, 2008

[BUG]: Redirect to previous page + Reload crashes

by onepoint＠starurchin.org

Dillo crashes as follows: * Point Dillo at http://starurchin.org:8080/dillo/here * Click the "There" link. Dillo is redirected back to the "Here" page. * Click the "Reload" button. * Dillo crashes inside a_Nav_reload() (nav.c) at the line "if (URL_FLAGS(url) & URL_Post) {" because url is NULL. I noticed this a few weeks ago but only just found a simple way to trigger it. Any ideas why this is happening? Regards, Jeremy Henty

May 24, 2008

memory statistics

by jcid＠dillo.org

On Fri, May 23, 2008 at 06:42:14PM +0200, Johannes Hofmann wrote: > On Fri, May 23, 2008 at 12:25:46PM -0400, Jorge Arellano Cid wrote: > > On Fri, May 23, 2008 at 03:22:15PM +0000, corvid wrote: > > > Johannes wrote: > > > > Another thing is the way new incoming html is handled in > > > > DilloHtml::write(). It' get's decoded in a new string and is then > > > > copied to the end of Local_Buf. Maybe we could avoid the copy by > > > > letting the decoder write it to the right place? > > > > > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > > I have working prototype code, but it's not good enough to put into > > > dillo. If anyone would like to receive a 35K patch and provide > > > suggestions on how to improve it... :) > > > > Ouch! > > > > I know I have this pending. Well, if I dissappear some time > > from dillo-dev you'll know what I am at. > > > > On to another topic, I'd really like to see gprof working again. > > What exactly is not working for you? When using "./configure --enable-gprof" both in dw2 and dillo2, the resulting dillo-fltk binary doesn't produce gmon.out. The dw2 test programs inside test/ work out of the box. i.e. There's no need to disable XFT nor to link manually. Just "./configure --enable-gprof". > Do you want to automate the static linking? I'd like dillo-fltk to work out of the box with "./configure --enable-gprof" just as the test programs in dw. -- Cheers Jorge.-

May 23, 2008

memory statistics

by jcid＠dillo.org

On Fri, May 23, 2008 at 05:15:53PM +0000, corvid wrote: > Jorge wrote: > > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > > I have working prototype code, but it's not good enough to put into > > > dillo. If anyone would like to receive a 35K patch and provide > > > suggestions on how to improve it... :) > > > > Ouch! > > > > I know I have this pending. Well, if I dissappear some time > > from dillo-dev you'll know what I am at. > > Don't read that the wrong way. > I know perfectly well that it isn't good enough to go into dillo as it is, > and I spoke of it in case anybody on the list might wish to take a look. > > I know it's ultimately my code and my responsibility, but I haven't had > any insights occur to me. No problem. I just meant it has high priority now, and that other thing will have to wait. -- Cheers Jorge.-

May 23, 2008

memory statistics

by corvid＠lavabit.com

Jorge wrote: > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > I have working prototype code, but it's not good enough to put into > > dillo. If anyone would like to receive a 35K patch and provide > > suggestions on how to improve it... :) > > Ouch! > > I know I have this pending. Well, if I dissappear some time > from dillo-dev you'll know what I am at. Don't read that the wrong way. I know perfectly well that it isn't good enough to go into dillo as it is, and I spoke of it in case anybody on the list might wish to take a look. I know it's ultimately my code and my responsibility, but I haven't had any insights occur to me.

May 23, 2008

Uncluttering dillo, part II: the findbar

by Johannes.Hofmann＠gmx.de

On Thu, May 22, 2008 at 12:32:07PM -0400, Jorge Arellano Cid wrote: > On Wed, May 21, 2008 at 05:43:05PM +0200, Johannes Hofmann wrote: > > Hi Justus, > > > > On Wed, May 21, 2008 at 12:02:14AM +0200, Justus Winter wrote: > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > > > > > > Hey everyone :) > > > > > > attached is a patch that transforms dillos find in page dialog box into > > > a firefox style toolbar. There are some issues that I cannot put my > > > finger on... see the comments in the event handler. Maybe there's some > > > magic about fltks event model that I did not fully understand... then > > > again it might be fltks fault. Anyway, I'd be happy for some hints. > > > > This is really nice! For text search the popup menus are even more > > annoying than for entering an url. > > > > One minor thing. You can make the CheckButton and Input members of > > Findbar private if you use static methods for the callbacks instead > > of functions. > > Yes, I agree. Patch attached. Cheers, Johannes

May 23, 2008

memory statistics

by Johannes.Hofmann＠gmx.de

On Fri, May 23, 2008 at 12:25:46PM -0400, Jorge Arellano Cid wrote: > On Fri, May 23, 2008 at 03:22:15PM +0000, corvid wrote: > > Johannes wrote: > > > Another thing is the way new incoming html is handled in > > > DilloHtml::write(). It' get's decoded in a new string and is then > > > copied to the end of Local_Buf. Maybe we could avoid the copy by > > > letting the decoder write it to the right place? > > > > If possible, I'd prefer to move decoding from html.cc to cache.c. > > I have working prototype code, but it's not good enough to put into > > dillo. If anyone would like to receive a 35K patch and provide > > suggestions on how to improve it... :) > > Ouch! > > I know I have this pending. Well, if I dissappear some time > from dillo-dev you'll know what I am at. > > On to another topic, I'd really like to see gprof working again. What exactly is not working for you? Do you want to automate the static linking? Cheers, Johannes

May 23, 2008

memory statistics

by jcid＠dillo.org

On Fri, May 23, 2008 at 03:22:15PM +0000, corvid wrote: > Johannes wrote: > > Another thing is the way new incoming html is handled in > > DilloHtml::write(). It' get's decoded in a new string and is then > > copied to the end of Local_Buf. Maybe we could avoid the copy by > > letting the decoder write it to the right place? > > If possible, I'd prefer to move decoding from html.cc to cache.c. > I have working prototype code, but it's not good enough to put into > dillo. If anyone would like to receive a 35K patch and provide > suggestions on how to improve it... :) Ouch! I know I have this pending. Well, if I dissappear some time from dillo-dev you'll know what I am at. On to another topic, I'd really like to see gprof working again. -- Cheers Jorge.-

May 23, 2008