May 2008 - Dillo-dev - lists.mailman3.com

why is SELECT a block container in Tags[]?

by corvid＠lavabit.com

Jorge wrote: > On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote: > > Why is SELECT a block container rather than an inline container in Tags[]? > > Most probably by mistake! > > Given that the DTD says: > > <!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> > [...] > <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> > [...] > <!ELEMENT OPTION - O (#PCDATA) -- selectable choice --> > > it looks like inline container would fit better. > (and stop some segfaults Justus detected). Well, it would still provide him with new segfaults for inline stuff like <form> <select> <font color=red>segfault</font> </select> </form>

May 31, 2008

why is SELECT a block container in Tags[]?

by jcid＠dillo.org

On Sat, May 31, 2008 at 03:26:50PM +0000, corvid wrote: > Why is SELECT a block container rather than an inline container in Tags[]? Most probably by mistake! Given that the DTD says: <!ELEMENT SELECT - - (OPTGROUP|OPTION)+ -- option selector --> [...] <!ELEMENT OPTGROUP - - (OPTION)+ -- option group --> [...] <!ELEMENT OPTION - O (#PCDATA) -- selectable choice --> it looks like inline container would fit better. (and stop some segfaults Justus detected). -- Cheers Jorge.-

May 31, 2008

[patch]: replace form::Form and remove form.{cc,hh}

by onepoint＠starurchin.org

The source files dillo2/src/form.{hh,cc} (which define the form::Form class) are modified copies of dw2/test/form.{hh,cc} . Dillo uses almost none of the code in these files. All dillo needs is a Receiver class that wraps a DilloHtmlForm and delegates calls to the event handlers to DilloHtmlForm methods. This patch removes all references to form::Form and form.{hh,cc} . It replaces form::Form with DilloHtmlReceiver. It also moves the event handler code into a DilloHtmlForm method and removes some unnecessary (void *) casting. This simplifies the code that bridges form events to DilloHtmlForm methods. WARNING: developers must run " make maintainer-clean ; ./autogen.sh " after this patch appears in their CVS working directory. This is because automake has to recreate Makefile.in , otherwise the build will try to compile form.cc which no longer works. After this patch is applied you can delete dillo2/src/form.{hh,cc} . Don't delete dw2/test/form.{hh,cc} though! Please comment! Regards, Jeremy Henty

May 31, 2008

why is SELECT a block container in Tags[]?

by corvid＠lavabit.com

Why is SELECT a block container rather than an inline container in Tags[]?

May 31, 2008

Hooked a decoder for text/plain with charset.

by corvid＠lavabit.com

Jorge wrote: > On Thu, May 29, 2008 at 09:15:24PM +0000, corvid wrote: > > Jorge wrote: > > > On Thu, May 29, 2008 at 08:49:22PM +0000, corvid wrote: > > > > Jorge wrote: > > > > > Just committed this patch. It makes things like: > > > > > > > > > > http://separat-lib.narod.ru/master.txt > > > > > > > > > > work. > > > > > > > > Why now? I don't understand the motivation for this. > > > > > > > > My next patch is just going to rip it out again because it > > > > will become unnecessary. > > > > > > Yeah, I noticed it could happen after making the patch, > > > but a segfault on that page made me fix and commit it. > > > > Why did it make plain segfault? > > The patch is attached for you to review in detail. > > The relevant part is an: > > Start_Ofs += i - len; > > substituted by a: > > Buf_Consumed = BufSize - len; > > (if the length of a long line got bigger than 'i', 'i - len' > was negative. A strange case triggered by that page, that has > really long lines). How did len get bigger than i? I tried the page yesterday without being able to get a crash. And now I've saved it locally and changed file.dpi to send it 200 bytes at a time, which gives me a long series of normal values when lines get bigger than packets: .. i-len 76 i-len 0 i-len 273 i-len 112 i-len 183 i-len 91 i-len 0 i-len 0 i-len 389 i-len 101 i-len 0 i-len 182 i-len 0 i-len 0 ..

May 31, 2008

[patch]: html.cc: DilloHtmlInput::connectTo()

by jcid＠dillo.org

On Fri, May 30, 2008 at 05:33:17AM +0100, Jeremy Henty wrote: > > This implements DilloHtmlInput::connectTo() which is called by > DilloHtmlForm::addInput and connects the input to the form. > > This is another API milestone: now only DilloHtmlForm methods access > DilloHtmlForm::form_receiver . We are nearly done with the > DilloHtmlForm API, there only a few locations left that directly > access DilloHtmlForm data members. Committed. -- Cheers Jorge.-

May 30, 2008

[patch]: html.cc: remove DilloHtmlInput::widget

by jcid＠dillo.org

On Fri, May 30, 2008 at 03:22:50AM +0100, Jeremy Henty wrote: > > It turns out that the embed and widget members of the DilloHtmlInput > class are always the same, so we can remove widget. Patch attached. Committed. -- Cheers Jorge.-

May 30, 2008

[patch]: html.cc: DilloHtmlForm::getRadioInput()

by jcid＠dillo.org

On Thu, May 29, 2008 at 11:15:51PM +0100, Jeremy Henty wrote: > > This refactors code that looks for a radio input with a given name > into a new method DilloHtmlForm::getRadioInput() . > > This marks a DilloHtmlForm API milestone: now only DilloHtmlForm > member functions access the inputs data member. Everything else that > needs to get an input from a form goes through the API. Committed. -- Cheers Jorge.-

May 30, 2008

[patch]: html.cc: remove MSG_HTML and rename Html_msg() to DilloHtml::message()

by jcid＠dillo.org

On Fri, May 30, 2008 at 07:30:49PM +0100, Jeremy Henty wrote: > > Self-explanatory, I hope. This is a useful bit of yak-shaving to > prepare for more refactoring of form handling code. The reasons for > removing MSG_HTML are: > > * It doesn't belong in msg.h since it can only work when used in > http.cc . OK. > * It's a UI function not a debugging function like the other MSG_* > so it's misleading for it to look similar to the MSG_* macros. OK. > > * Using it has no advantage over simply calling the function that it > wraps. Yes it has. The macro is shorter and mnemonic. > * It's fragile because it requires html to be in scope and have the > right value. Easily detected at compile time. A mixed patch was committed. Left the method in DilloHtml and made a macro in html.cc. You should be able to continue from here. -- Cheers Jorge.-

May 30, 2008

Hooked a decoder for text/plain with charset.

by jcid＠dillo.org

Here goes the attachment... -- Cheers Jorge.-

May 30, 2008