April 2008 - Dillo-dev - lists.mailman3.com

Docs question: dw::core::ui::ListResource::SelectionMode::SELECTION_AT_MOST_ONE

by jcid＠dillo.org

On Sat, Apr 26, 2008 at 10:46:26AM +0100, Jeremy Henty wrote: > On Sat, Apr 26, 2008 at 10:31:51AM +0200, Johannes Hofmann wrote: > > On Sat, Apr 26, 2008 at 09:27:01AM +0100, Jeremy Henty wrote: > > > > > > The description of > > > dw::core::ui::ListResource::SelectionMode::SELECTION_AT_MOST_ONE > > > does not make sense. Should "The user may not the only selected > > > item." read "The user may unselect the only selected item."? > > > > I guess so. Maybe the comment was copied from > > SELECTION_EXACTLY_ONE_BY_USER and "unselect" was deleted instead of > > "not"? > > That's my guess too. If someone comfirms this I'll make a patch. Committed! -- Cheers Jorge.-

April 26, 2008

Re: patch: Accept-Charset: utf-8,*;q=0.8

by jcid＠dillo.org

On Sat, Apr 26, 2008 at 04:56:45PM +0000, corvid wrote: > Jorge wrote: > > Committed, assuming: > > > > "Accept-Charset: utf-8,*;q=0.8\r\n" > > > > means dillo2 leaves the door open to also receive iso-8859-1. > > Yes. Here's what the RFC says: > > The special value "*", if present in the Accept-Charset field, > matches every character set (including ISO-8859-1) which is not > mentioned elsewhere in the Accept-Charset field. If no "*" is present > in an Accept-Charset field, then all character sets not explicitly > mentioned get a quality value of 0, except for ISO-8859-1, which gets > a quality value of 1 if not explicitly mentioned. OK. -- Cheers Jorge.-

April 26, 2008

patch: /* todo: don't create things if button type is unknown */

by jcid＠dillo.org

Hi, Committed. -- Cheers Jorge.-

April 26, 2008

patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Sat, Apr 26, 2008 at 05:26:58PM +0000, corvid wrote: > Jorge wrote: > > On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote: > > > dw: I added motionNotifyImpl() and currLink > > > > > > dillo: > > > - I imagine the setUseMap() in open_img() is probably supposed to be > > > routed through DilloImage. > > > - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. > > > For one thing, the old code couldn't handle whitespace preceding a comma. > > > - I didn't really like that dReturn_if_fail so far down in open_area() > > > since coords is dynamically allocated now, but I left it there. > > > > Committed this patch and also scroll_motionNotify.dw2. > > > > Shape image-mapped links work so far. Coordinates are not > > yet being sent. If I missed something, please repost the patch. > > (I assume this is a work in progress). > > What's not working exactly? We didn't do ISMAP yet, if that's what > you're saying... Yes, ISMAP. -- Cheers Jorge.-

April 26, 2008

Re: the last patch that I sent you BREAKS isindex.

by corvid＠lavabit.com

Jorge wrote: > On Thu, Apr 17, 2008 at 06:17:04AM +0000, corvid wrote: > > I shouldn't have moved isindex's connectActivate to close_form. > > If you wish, I can make a new version. > > Yes, please. I just wanted to let people on the list know that that patch wasn't sent to the list, so this isn't about anything that you might have applied to your tree. > > By the way, I found that the top of open_input needs > > if (html->InFlags & IN_SELECT) { > > MSG_HTML("INPUT inside SELECT\n"); > > return; > > } > > Otherwise, if another input sneaks in there, close_select will crash. > > Please include it in the patch. I'm planning to make a patch that contains a few IN_* tests that are needed here and there...

April 26, 2008

Re: the last patch that I sent you BREAKS isindex.

by jcid＠dillo.org

On Thu, Apr 17, 2008 at 06:17:04AM +0000, corvid wrote: > I shouldn't have moved isindex's connectActivate to close_form. > If you wish, I can make a new version. Yes, please. > > By the way, I found that the top of open_input needs > if (html->InFlags & IN_SELECT) { > MSG_HTML("INPUT inside SELECT\n"); > return; > } > Otherwise, if another input sneaks in there, close_select will crash. Please include it in the patch. -- Cheers Jorge.-

April 26, 2008

[patch] introduce lout namespace (was: namespace problem)

by jcid＠dillo.org

On Thu, Apr 24, 2008 at 09:18:30PM +0200, Johannes Hofmann wrote: > Hi, > > while trying to implement a fix to the namespace problem I came to > the conclusion that the easiest and least intrusive way is to keep > the existing namespaces in the lout directory and just wrap them in > another namespace "lout". > This fixes the name collision with signal. Committed. BTW, now the documentation should mention this "lout" namespace. ;-) -- Cheers Jorge.-

April 26, 2008

patch: /* todo: don't create things if button type is unknown */

by corvid＠lavabit.com

April 26, 2008

patch: Re: [Dillo-dev] start on image maps (dw-part)

by corvid＠lavabit.com

Jorge wrote: > On Tue, Apr 22, 2008 at 04:50:32AM +0000, corvid wrote: > > dw: I added motionNotifyImpl() and currLink > > > > dillo: > > - I imagine the setUseMap() in open_img() is probably supposed to be > > routed through DilloImage. > > - Html_read_coords() was borrowed from 0.8.6 and modified a fair amount. > > For one thing, the old code couldn't handle whitespace preceding a comma. > > - I didn't really like that dReturn_if_fail so far down in open_area() > > since coords is dynamically allocated now, but I left it there. > > Committed this patch and also scroll_motionNotify.dw2. > > Shape image-mapped links work so far. Coordinates are not > yet being sent. If I missed something, please repost the patch. > (I assume this is a work in progress). What's not working exactly? We didn't do ISMAP yet, if that's what you're saying...

April 26, 2008

I figured out why charset handling has been all broken lately.

by jcid＠dillo.org

On Thu, Apr 24, 2008 at 01:57:41AM +0000, corvid wrote: > The top of Nav_open_url has > > bool_t ForceReload = (URL_FLAGS(url) & > (URL_E2EReload + URL_ReloadFromCache)); > > When repushing URLs, URL_FLAGS contains URL_ReloadFromCache, > which is 0x100. And remember how Jorge changed bool_t from > int to unsigned char? I'd forgotten about it, too, which meant > I wasted some time looking in the wrong places for this bug. Ooops, sorry. I thought the parenthesis wrapping was returning a boolean value. Patch committed. diff -pru dillo2/src/nav.c dillo2-cur/src/nav.c --- dillo2/src/nav.c 2008-04-08 17:50:25.000000000 -0400 +++ dillo2-cur/src/nav.c 2008-04-26 13:19:27.000000000 -0400 @@ -204,14 +204,14 @@ static void Nav_stack_clean(BrowserWindo static void Nav_open_url(BrowserWindow *bw, const DilloUrl *url, int offset) { DilloUrl *old_url; - bool_t MustLoad; + bool_t MustLoad, ForceReload; int x, y, idx, ClientKey; DilloWeb *Web; - bool_t ForceReload = (URL_FLAGS(url) & - (URL_E2EReload + URL_ReloadFromCache)); MSG("Nav_open_url: new url='%s'\n", URL_STR_(url)); + ForceReload = (URL_FLAGS(url) & (URL_E2EReload + URL_ReloadFromCache)) != 0; + /* Get the url of the current page */ idx = a_Nav_stack_ptr(bw); old_url = a_History_get_url(NAV_UIDX(bw, idx)); -- Cheers Jorge.-

April 26, 2008