April 2008 - Dillo-dev - lists.mailman3.com

patch: motionNotify and LEAVE

by jcid＠dillo.org

On Mon, Apr 28, 2008 at 09:21:16PM +0000, corvid wrote: > Since findtext has been in the news lately, I might as well > at least provide this bit so that my code behaves better with dialogs. > What is this patch for? > diff -pur dw2/dw/fltkviewport.cc dw2-cur/dw/fltkviewport.cc > --- dw2/dw/fltkviewport.cc 2008-04-26 18:21:55.000000000 +0000 > +++ dw2-cur/dw/fltkviewport.cc 2008-04-28 20:40:43.000000000 +0000 > @@ -273,6 +273,10 @@ int FltkViewport::handle (int event) > positionChanged(); > break; > > + case ::fltk::LEAVE: > + mouse_x = mouse_y = -1; > + break; > + > case ::fltk::SHORTCUT: > switch (::fltk::event_key()) { > case PageUpKey: > @@ -324,14 +328,15 @@ void FltkViewport::setCanvasSize (int wi > } > > /* > - * This is needed when a position change is not the result of mouse motion. > + * This is used to simulate mouse motion (e.g., when scrolling). > */ > void FltkViewport::positionChanged () > { > - (void)theLayout->motionNotify (this, > - translateViewXToCanvasX (mouse_x), > - translateViewYToCanvasY (mouse_y), > - (core::ButtonState)0); > + if (mouse_x != -1) > + (void)theLayout->motionNotify (this, > + translateViewXToCanvasX (mouse_x), > + translateViewYToCanvasY (mouse_y), > + (core::ButtonState)0); > } > > /* > diff -pur dw2/dw/textblock.cc dw2-cur/dw/textblock.cc > --- dw2/dw/textblock.cc 2008-04-17 13:30:05.000000000 +0000 > +++ dw2-cur/dw/textblock.cc 2008-04-28 20:52:39.000000000 +0000 > @@ -549,12 +549,12 @@ bool Textblock::motionNotifyImpl (core:: > > void Textblock::enterNotifyImpl (core::EventCrossing *event) > { > - hoverLink = -1; > } > > void Textblock::leaveNotifyImpl (core::EventCrossing *event) > { > - (void) emitLinkEnter (-1, -1, -1, -1); > + hoverLink = -1; > + (void) emitLinkEnter (hoverLink, -1, -1, -1); > } > > /** > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev -- Cheers Jorge.-

April 29, 2008

Cheering some recent improvements in table layout

by jcid＠dillo.org

Hi Jeremy, On Sun, Apr 27, 2008 at 07:22:05AM +0100, Jeremy Henty wrote: > > Just to say that I'm seeing much better table rendering now. I have a > page with a large two-column table. For a while recently this > rendered very strangely in Dillo: it appeared with the two columns at > opposite sides of the page, then the second column would move over to > the left, one item at a time, to sit next to the first. But now the > table immediately appears with both columns in the right place. I > don't know what caused the strange realignment behaviour but I'm glad > it's gone. Great! There were several minor typo-bug fixes and who knows which one of them made it for you. Please send me a compressed version of the test page you use. -- Cheers Jorge.-

April 29, 2008

[patch] phrase search - take 2

by jcid＠dillo.org

On Mon, Apr 28, 2008 at 10:10:21PM +0200, Johannes Hofmann wrote: > Hi, > > here comes my second attempt on phrase search. As already described, > I changed CharIterator back to not return \0s. Instead blanks are > inserted when the space flag is set. > This way CharIterator always returns a smooth stream of chars > whether for normal html- or pre-text. > Then there was a bug in DeepIterator::prev() that took me some > time to find. > I also adjusted charsEqual() to treat all space-chars equally. > Finally I had to add a check in CharIterator::highlight() to avoid a > crash when searching for the last word in pre-text with a blank > appended. Great. Committed. With this miscelany of bug fixes within patches, it seems some bugs are starting to vanish as "side effects" of patches (as with what Jeremy reports happened with tables!). -- Cheers Jorge.-

April 29, 2008

patch: Re: patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Sun, Apr 27, 2008 at 06:36:31PM +0000, corvid wrote: > > /* BUG: if several ISMAP images follow each other without > > * being separated with a word, only the first one is ISMAPed > > */ > > PS I left this old comment in, but if I make a file containing a bunch of > ismap images in a row, they certainly _seem_ ismapped. I click on them and > dillo tries to go to http://[wherever]?x,y. Yes, comment was deleted. -- Cheers Jorge.-

April 29, 2008

patch: Re: patch: Re: [Dillo-dev] start on image maps (dw-part)

by jcid＠dillo.org

On Sun, Apr 27, 2008 at 06:22:48PM +0000, corvid wrote: > Jorge wrote: > > Yes, ISMAP. > > All right, here you go. It turned out to be a lot of work :) Committed. It'd be good to hook emitMotionNotify() to have URL feedback for ISMAP in the status box. -- Cheers Jorge.-

April 29, 2008

[patch]: remove redundant #include in fltkflatview.cc

by onepoint＠starurchin.org

A small cleanup: the "#include <fltk/damage.h>" in fltkflatview.cc is unnecessary. Regards, Jeremy Henty

April 29, 2008

dillo seems to close file descriptors twice

by joerg.sonnenberger＠web.de

On Tue, Apr 29, 2008 at 04:54:20PM +0200, Johannes Hofmann wrote: > The signal is delivered as dillo writes to a socket that has been > closed by the remote side. I rather wonder, why this does not happen > on Linux. Just set it to SIG_IGN. Joerg

April 29, 2008

FIXED: [PATCH]: call widget->layout_damage() from FltkWidgetView::allocateFltkWidget

by onepoint＠starurchin.org

D'oh! "||" where I should have used "|"! What a n00b! Here's the fixed patch. (And this time I have tested by running all the executables in dw/test/ .) Regards, Jeremy Henty

April 29, 2008

dillo seems to close file descriptors twice

by Johannes.Hofmann＠gmx.de

Hi, On Tue, Apr 29, 2008 at 10:40:18AM -0400, Jorge Arellano Cid wrote: > On Tue, Apr 22, 2008 at 08:27:39PM +0200, Johannes Hofmann wrote: > > Hi, > > > > I just noticed, that dillo seems to close file descriptors twice via > > IO_close_fd, which causes problems when other threads run in parallel > > for name server queries. > > Here are the two call stacks via which IO_close_fd is called > > for each fd: > > OK, I committed a commented patch for this. Please test it. Yes, the double close problem is gone with this patch. > I'd be also interested to know whether this fixes the SIGPIPE > problems you saw in your OS. > > I remember removing the ignore SIGPIPE code because it didn't > happen anymore in GNU/Linux. It'd be good to know where it comes > from. The SIGPIPE problem is still there: Program received signal SIGPIPE, Broken pipe. 0x283e1050 in write () from /usr/lib/libc.so.6 (gdb) bt #0 0x283e1050 in write () from /usr/lib/libc.so.6 #1 0x28297f2c in write () from /usr/lib/libpthread.so.0 #2 0x080712a2 in IO_callback (fd=<value optimized out>, io=0x282a18c0) at IO.c:226 #3 0x080713f7 in IO_fd_write_cb (fd=7, data=0x1) at IO.c:303 #4 0x080bd4b9 in fltk::wait () #5 0x080bd669 in fltk::run () #6 0x0804eadb in main (argc=Cannot access memory at address 0x0) at dillo.cc:110 The signal is delivered as dillo writes to a socket that has been closed by the remote side. I rather wonder, why this does not happen on Linux. I found this on the topic: http://www.developerweb.net/forum/showthread.php?t=2953 Cheers, Johannes

April 29, 2008

dillo seems to close file descriptors twice

by jcid＠dillo.org

On Tue, Apr 22, 2008 at 08:27:39PM +0200, Johannes Hofmann wrote: > Hi, > > I just noticed, that dillo seems to close file descriptors twice via > IO_close_fd, which causes problems when other threads run in parallel > for name server queries. > Here are the two call stacks via which IO_close_fd is called > for each fd: OK, I committed a commented patch for this. Please test it. I'd be also interested to know whether this fixes the SIGPIPE problems you saw in your OS. I remember removing the ignore SIGPIPE code because it didn't happen anymore in GNU/Linux. It'd be good to know where it comes from. -- Cheers Jorge.-

April 29, 2008