March 2008 - Dillo-dev - lists.mailman3.com

dw::Table valgrind-friendliness

by onepoint＠starurchin.org

On Sun, Mar 02, 2008 at 03:45:57PM +0100, Johannes Hofmann wrote: > can you please send the valgrind log? I replied privately to you with it (since it's big enough to trigger list moderation). Jeremy Henty

March 2, 2008

dw::Table valgrind-friendliness

by Johannes.Hofmann＠gmx.de

On Sun, Mar 02, 2008 at 02:57:14PM +0000, Jeremy Henty wrote: > On Sun, Mar 02, 2008 at 02:43:56PM +0000, Jeremy Henty wrote: > > On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote: > > > On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote: > > > > > > > > Dillo has been neglecting its valgrind cleanliness recently and > > > > it turns out the culprit is dw::Table, which resizes its > > > > internal vectors without initialising any new values that > > > > appear. > > > > > > AFAIU, this patch covers the symptoms of a BUG that current CVS > > > fixes. Please test current CVS against valgrind. > > > > No change. 121 "Conditional jump..." errors, reduced to 2 by my > > patch. > > To explain, these errors appear because the code updates the entries > of the cumHeight and colWidths vectors with wrapper methods > setCumHeight and setColWidth. These wrappers begin by comparing the > new value with old one and branching on the result, so you get the > "Conditional jump..." errors whenever the old value was not > initialized. That means these errors have nothing to do with any of > the Table algorithms, they're entirely due to the way the Table code > manages the cumHeight and colWidths vectors. These wrapper methods were introduced by my redraw patch. I will fix this. Johannes > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

March 2, 2008

dw::Table valgrind-friendliness

by onepoint＠starurchin.org

On Sun, Mar 02, 2008 at 02:43:56PM +0000, Jeremy Henty wrote: > On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote: > > On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote: > > > > > > Dillo has been neglecting its valgrind cleanliness recently and > > > it turns out the culprit is dw::Table, which resizes its > > > internal vectors without initialising any new values that > > > appear. > > > > AFAIU, this patch covers the symptoms of a BUG that current CVS > > fixes. Please test current CVS against valgrind. > > No change. 121 "Conditional jump..." errors, reduced to 2 by my > patch. To explain, these errors appear because the code updates the entries of the cumHeight and colWidths vectors with wrapper methods setCumHeight and setColWidth. These wrappers begin by comparing the new value with old one and branching on the result, so you get the "Conditional jump..." errors whenever the old value was not initialized. That means these errors have nothing to do with any of the Table algorithms, they're entirely due to the way the Table code manages the cumHeight and colWidths vectors. Jeremy Henty

March 2, 2008

dw::Table valgrind-friendliness

by Johannes.Hofmann＠gmx.de

Hi Jeremy, can you please send the valgrind log? Johannes On Sun, Mar 02, 2008 at 02:43:56PM +0000, Jeremy Henty wrote: > On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote: > > On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote: > > > > > > Dillo has been neglecting its valgrind cleanliness recently and it > > > turns out the culprit is dw::Table, which resizes its internal > > > vectors without initialising any new values that appear. > > > > AFAIU, this patch covers the symptoms of a BUG that current CVS > > fixes. Please test current CVS against valgrind. > > No change. 121 "Conditional jump..." errors, reduced to 2 by my > patch. > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

March 2, 2008

dw::Table valgrind-friendliness

by onepoint＠starurchin.org

On Sun, Mar 02, 2008 at 11:31:16AM -0300, Jorge Arellano Cid wrote: > On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote: > > > > Dillo has been neglecting its valgrind cleanliness recently and it > > turns out the culprit is dw::Table, which resizes its internal > > vectors without initialising any new values that appear. > > AFAIU, this patch covers the symptoms of a BUG that current CVS > fixes. Please test current CVS against valgrind. No change. 121 "Conditional jump..." errors, reduced to 2 by my patch. Jeremy Henty

March 2, 2008

Fixed a mistake in the CSS-box-model PNG image (style-box-model.png).

by jcid＠dillo.org

Hi, I just committed this fix. The wrong documentation image mislead me a lot while working on the redraw problems. Now it's accurate (CSS box model in namespacedw_1_1core_1_1style.html). -- Cheers Jorge.-

March 2, 2008

dw::Table valgrind-friendliness

by onepoint＠starurchin.org

On Sun, Mar 02, 2008 at 02:15:39PM +0000, I wrote: > Dillo has been neglecting its valgrind cleanliness recently and it > turns out the culprit is dw::Table, ... Oops, I missed one! Here's a followup patch for consistency. Jeremy Henty

March 2, 2008

dw::Table valgrind-friendliness

by jcid＠dillo.org

On Sun, Mar 02, 2008 at 02:15:39PM +0000, Jeremy Henty wrote: > > Dillo has been neglecting its valgrind cleanliness recently and it > turns out the culprit is dw::Table, which resizes its internal vectors > without initialising any new values that appear. If you valgrind > dillo and immediately close the splash window, valgrind reports 121 > "Conditional jump or move depends on uninitialised value" errors! > This patch reduces that number to 2! AFAIU, this patch covers the symptoms of a BUG that current CVS fixes. Please test current CVS against valgrind. -- Cheers Jorge.-

March 2, 2008

dw::Table valgrind-friendliness

by onepoint＠starurchin.org

Dillo has been neglecting its valgrind cleanliness recently and it turns out the culprit is dw::Table, which resizes its internal vectors without initialising any new values that appear. If you valgrind dillo and immediately close the splash window, valgrind reports 121 "Conditional jump or move depends on uninitialised value" errors! This patch reduces that number to 2! Regards, Jeremy Henty

March 2, 2008

a drawing segfault

by onepoint＠starurchin.org

On Sun, Mar 02, 2008 at 06:30:03AM +0000, place wrote: > I was just opening file:///tmp/, which is not normally a problem... > > *** [unknown] Assertion failed! *** > Array index out of bounds: 28 >= 28 > > Program received signal SIGABRT, Aborted. I see this occasionally too, though it seems to be sporadic. I can't figure what the trigger is. Does it happen every time you open the directory or only occasionally? Jeremy Henty

March 2, 2008