February 2008 - Dillo-dev - lists.mailman3.com

[PATCH]: Table::apportionRowSpan()

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 06:10:39AM +0000, Jeremy Henty wrote: > > OK, please ignore my previous attempt at reworking Dillo's ROWSPAN > handling. I have a simple fix for the bugs I reported at > http://starurchin.singularity/dillo/bugs/table_rowspan.html . This > patch tweaks dw::Table::apportionRowSpan() to handle the special case > where all the rows being spanned have zero height. This fixes the > special cases that were breaking without changing the behaviour in any > other case. Committed. > (BTW, I still think there is a case for reworking Dillo's ROWSPAN > algorithms along the lines I suggested, but it's nice to fix bugs > without such efforts.) If you want to go further, please keep in the O(n) realm. -- Cheers Jorge.-

Feb. 1, 2008

a couple of patches: referer and image_off

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 12:39:41AM +0000, place wrote: > Jorge wrote: > > >From the updated dillorc2: > > > > # Set the HTTP Referer information (WARNING: affects privacy) > > * # We use the same URI, not the refering page (to avoid cross-site tracking). > > # none : No referer at all (full privacy). > > # host : Default value. Send same URI's hostname (no sensible info is sent). > > # path : same URI is sent (NO PRIVACY). > > http_referer=host > > What do you mean by "NO PRIVACY"? I meant that if we send the referring page's path, there would be no privacy. Later I changed the referer approach by using the same URI, which worked surprisingly well on tests, and this new approach obsoleted the comments. Note that "path" is not sending the same URI, it strips the query and fragment parts. In brief, using the same URI, the three options offer good privacy (because no new information is sent), and if we ever enable using the referring page, the old comments apply. i.e. Using Same URI: # none : No referer at all (nothing is sent) # host : Default value. Send same URI's hostname (no new info is sent). # path : same URI is sent (no new info is sent). Using referring page (not implemented): # none : No referer at all (nothing is sent) # host : Default value. Send URI's hostname (referring hostname is known). # path : referring URI is sent (NO PRIVACY, fine grained tracking # of the pages/sites you visit). Using referring page only if hostname matches (not implemented): # none : No referer at all (nothing is sent) # host : Default value. Send URI's hostname (no new info is sent). # path : referring URI is sent (NO PRIVACY, fine-grained per-site # tracking of the pages you visit). I'll fix the comments (of implemented part) upon finishing this thread. Thanks for the question. -- Cheers Jorge.-

Feb. 1, 2008

patch: [Dillo-dev] a couple of patches: referer and image_off

by jcid＠dillo.org

On Fri, Feb 01, 2008 at 01:50:35AM +0000, place wrote: > linebreaks... Ooops!, committed. -- Cheers Jorge.-

Feb. 1, 2008

[PATCH]: Table::apportionRowSpan()

by onepoint＠starurchin.org

OK, please ignore my previous attempt at reworking Dillo's ROWSPAN handling. I have a simple fix for the bugs I reported at http://starurchin.singularity/dillo/bugs/table_rowspan.html . This patch tweaks dw::Table::apportionRowSpan() to handle the special case where all the rows being spanned have zero height. This fixes the special cases that were breaking without changing the behaviour in any other case. (BTW, I still think there is a case for reworking Dillo's ROWSPAN algorithms along the lines I suggested, but it's nice to fix bugs without such efforts.) Regards, Jeremy Henty

Feb. 1, 2008

patch: [Dillo-dev] a couple of patches: referer and image_off

by place＠gobigwest.com

linebreaks... diff -pur dillo2/src/IO/http.c dillo2-cur/src/IO/http.c --- dillo2/src/IO/http.c 2008-01-31 23:55:04.000000000 +0000 +++ dillo2-cur/src/IO/http.c 2008-02-01 01:40:08.000000000 +0000 @@ -158,11 +158,11 @@ static char *Http_get_referer(const Dill if (!strcmp(prefs.http_referer, "host")) { referer = dStrconcat("Referer: ", URL_SCHEME(url), "://", - URL_AUTHORITY(url), "/", NULL); + URL_AUTHORITY(url), "/\r\n", NULL); } else if (!strcmp(prefs.http_referer, "path")) { referer = dStrconcat("Referer: ", URL_SCHEME(url), "://", URL_AUTHORITY(url), - URL_PATH_(url) ? URL_PATH(url) : "/", NULL); + URL_PATH_(url) ? URL_PATH(url) : "/", "\r\n", NULL); } if (!referer) referer = strdup("");

Feb. 1, 2008

a couple of patches: referer and image_off

by place＠gobigwest.com

Jorge wrote: > >From the updated dillorc2: > > # Set the HTTP Referer information (WARNING: affects privacy) > * # We use the same URI, not the refering page (to avoid cross-site tracking). > # none : No referer at all (full privacy). > # host : Default value. Send same URI's hostname (no sensible info is sent). > # path : same URI is sent (NO PRIVACY). > http_referer=host What do you mean by "NO PRIVACY"?

Feb. 1, 2008