December 2008 - Dillo-dev - lists.mailman3.com

how about a form menu?

by corvid＠lavabit.com

I was playing around with making a form menu. So far: 1) Submit. Nicer from the user's perspective than prefs.generate_submit. 2) Reset. Not really needed when you can just press back and forward. 3) Show/Hide Hiddens. Lets you edit them, which I believe the user should have the power to do. ..and thinking of making an Info option to show submission charset and, oh, whatever else. What I have now is icky proof-of-concept code (although it's been working fine), so I want to see how well the idea goes over before trying to clean it up.

Dec. 9, 2008

empty html elements

by jcid＠dillo.org

On Mon, Dec 01, 2008 at 06:56:12PM +0100, Johannes Hofmann wrote: > Hi, > > while working on css I came across the following: > > <a class="d" name="INCR32"/> (found at [1]) > > dillo currently doesn't recognize that the element is empty. > The relevant code is at html.cc:3530: > > /* Test for </x>, ReqTagClose, <x /> and <x/> */ > if (*start == '/' || /* </x> */ > html->ReqTagClose || /* request */ > (tag[tagsize - 2] == '/' && /* XML: */ > (isspace(tag[tagsize - 3]) || /* <x /> */ > (size_t)tagsize == strlen(Tags[ni].name) + 3))) { /* <x/> */ > > > We could simply drop the requirement for the blank before '/' which > would lead to > > /* Test for </x>, ReqTagClose, <x /> and <x/> */ > if (*start == '/' || /* </x> */ > html->ReqTagClose || /* request */ > (tag[tagsize - 2] == '/')) { /* XML */ > > > or allow a '"' instead of the blank or keep things as they are, if > XML requires a blank before the '/'. > >>From http://www.w3.org/TR/2006/REC-xml-20060816/#sec-starttags > I'd say the blank is optional. > > What do you think? > > Cheers, > Johannes > > [1] http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc/port… Oh, I committed a new version allowing [ "'] before />, and also a self closing element: <x/>. This because the former one failed on things like: <a href=/html/k_links/Kayden_Kross/> Kayden Kross </a> Example taken from: http://www.freeones.com/html/d_links/Denise_Milani/ look at the non-working bottom links, or elsewhere if you like. :-) -- Cheers Jorge.-

Dec. 8, 2008

Thoughts on revision control

by onepoint＠starurchin.org

I've been using git to manage the Dillo source locally. I just installed mercurial to experiment with. Things I like about git are the ability to rebase, ie. reorder patches. This is neat because I can develop a patch on top of my local modifications and then push it down the stack so that I submit a patch against the pristine source rather than my customised version. The ability to stash your current changes in a temporary branch is useful too. You could do all this with explicit branches, but it would be more involved and git gives you nice, quick and easy ways to do the same thing. Mercurial seems to be the same sort of beast, though perhaps it is a bit less of a "Swiss Army Chainsaw" than git. I'd be surprised if there were any real issues using either to manage Dillo since I doubt we'd be using anything more than the basic facilities that both offer. I'd prefer git but only out of laziness as it's the one I already know (which means I should probably investigate mercurial just to broaden my mind if nothing else). Regards, Jeremy Henty

Dec. 8, 2008

Html_tag_close_* called twice

by jcid＠dillo.org

On Sun, Dec 07, 2008 at 08:50:50PM +0100, Johannes Hofmann wrote: > Hi, > > corvid pointed out that Html_tag_close_* functions are getting > called twice. This is causing problems when parsing > <style>...</style> contents in Html_tag_close_style() > as done in css-prototype now. > We could work around this somehow, but wouldn't it be cleaner to > make sure Html_tag_close_* is called just once, when an element > is closed? Oh, true... Patch commited to Hg repository. Note: I left nice MSG output on, so you can see the parsed HTML structure on the fly. -- Cheers Jorge.-

Dec. 8, 2008

empty html elements

by corvid＠lavabit.com

Johannes wrote: > On Sun, Dec 07, 2008 at 04:38:06PM -0300, Jorge Arellano Cid wrote: > > BTW, I want to give mercurial a more serious try so will keep > > updating only this repo for some time as a test: > > > > (http://freehg.org/u/dillo/main) > > > > In a nutshell: > > To get the repo into your HD: > > hg clone http://freehg.org/u/dillo/main dillo > > To update: > > cd dillo > > hg pull http://freehg.org/u/dillo/main > > > > Yes, I'm yet to update the web pages in our site... > > I personally like mercurial, but what do the other developers think? Hmm...looks like I'll have to make some room for python...

Dec. 7, 2008

empty html elements

by Johannes.Hofmann＠gmx.de

On Sun, Dec 07, 2008 at 04:38:06PM -0300, Jorge Arellano Cid wrote: > On Mon, Dec 01, 2008 at 06:56:41PM +0000, corvid wrote: > > Johannes wrote: > > > Hi, > > > > > > while working on css I came across the following: > > > > > > <a class="d" name="INCR32"/> (found at [1]) > > > > > > dillo currently doesn't recognize that the element is empty. > > > The relevant code is at html.cc:3530: > > > > > > /* Test for </x>, ReqTagClose, <x /> and <x/> */ > > > if (*start == '/' || /* </x> */ > > > html->ReqTagClose || /* request */ > > > (tag[tagsize - 2] == '/' && /* XML: */ > > > (isspace(tag[tagsize - 3]) || /* <x /> */ > > > (size_t)tagsize == strlen(Tags[ni].name) + 3))) { /* <x/> */ > > > > > > > > > We could simply drop the requirement for the blank before '/' which > > > would lead to > > > > > > /* Test for </x>, ReqTagClose, <x /> and <x/> */ > > > if (*start == '/' || /* </x> */ > > > html->ReqTagClose || /* request */ > > > (tag[tagsize - 2] == '/')) { /* XML */ > > > > > > > > > or allow a '"' instead of the blank or keep things as they are, if > > > XML requires a blank before the '/'. > > > >From http://www.w3.org/TR/2006/REC-xml-20060816/#sec-starttags > > > I'd say the blank is optional. > > > > > > What do you think? > > > > Yes, it looks like whitespace is optional there. > > > > EmptyElemTag ::= '<' Name (S Attribute)* S? '/>' > > S ::= (#x20 | #x9 | #xD | #xA)+ > > > Committed to the mercurial repository. > > BTW, I want to give mercurial a more serious try so will keep > updating only this repo for some time as a test: > > (http://freehg.org/u/dillo/main) > > In a nutshell: > To get the repo into your HD: > hg clone http://freehg.org/u/dillo/main dillo > To update: > cd dillo > hg pull http://freehg.org/u/dillo/main > > Yes, I'm yet to update the web pages in our site... I personally like mercurial, but what do the other developers think? Cheers, Johannes

Dec. 7, 2008

Html_tag_close_* called twice

by Johannes.Hofmann＠gmx.de

Hi, corvid pointed out that Html_tag_close_* functions are getting called twice. This is causing problems when parsing <style>...</style> contents in Html_tag_close_style() as done in css-prototype now. We could work around this somehow, but wouldn't it be cleaner to make sure Html_tag_close_* is called just once, when an element is closed? Cheers, Johannes

Dec. 7, 2008

empty html elements

by jcid＠dillo.org

On Mon, Dec 01, 2008 at 06:56:41PM +0000, corvid wrote: > Johannes wrote: > > Hi, > > > > while working on css I came across the following: > > > > <a class="d" name="INCR32"/> (found at [1]) > > > > dillo currently doesn't recognize that the element is empty. > > The relevant code is at html.cc:3530: > > > > /* Test for </x>, ReqTagClose, <x /> and <x/> */ > > if (*start == '/' || /* </x> */ > > html->ReqTagClose || /* request */ > > (tag[tagsize - 2] == '/' && /* XML: */ > > (isspace(tag[tagsize - 3]) || /* <x /> */ > > (size_t)tagsize == strlen(Tags[ni].name) + 3))) { /* <x/> */ > > > > > > We could simply drop the requirement for the blank before '/' which > > would lead to > > > > /* Test for </x>, ReqTagClose, <x /> and <x/> */ > > if (*start == '/' || /* </x> */ > > html->ReqTagClose || /* request */ > > (tag[tagsize - 2] == '/')) { /* XML */ > > > > > > or allow a '"' instead of the blank or keep things as they are, if > > XML requires a blank before the '/'. > > >From http://www.w3.org/TR/2006/REC-xml-20060816/#sec-starttags > > I'd say the blank is optional. > > > > What do you think? > > Yes, it looks like whitespace is optional there. > > EmptyElemTag ::= '<' Name (S Attribute)* S? '/>' > S ::= (#x20 | #x9 | #xD | #xA)+ Committed to the mercurial repository. BTW, I want to give mercurial a more serious try so will keep updating only this repo for some time as a test: (http://freehg.org/u/dillo/main) In a nutshell: To get the repo into your HD: hg clone http://freehg.org/u/dillo/main dillo To update: cd dillo hg pull http://freehg.org/u/dillo/main Yes, I'm yet to update the web pages in our site... -- Cheers Jorge.- PS: I've been quite busy, trying to catch up. Please be patient...

Dec. 7, 2008

[ladislav@distrowatch.com: Re: Donation for Dillo]

by jcid＠dillo.org

FYI, -- Cheers Jorge.-

Dec. 7, 2008

[patch]: Basic Authentication

by onepoint＠starurchin.org

Next iteration: one bugfix. * In Auth_parse_auth_basic(), fix the test for the "realm" token. Jeremy Henty

Dec. 6, 2008