October 2008 - Dillo-dev - lists.mailman3.com

patch: prefs.vw_fontname as fltk ui's default font

by corvid＠lavabit.com

Johannes wrote: > On Wed, Oct 22, 2008 at 02:27:23PM +0000, corvid wrote: > > I was changing the font in a few more places that > > can take arbitrary user text -- and then having > > to change it for neighbouring things so that > > the difference isn't too jarring -- and I reached > > the point where it seemed like it may be best > > just to change the font for everything. > > > > I like it! > We could also remove the places where the font has been set already. Yeah, I figured I'd rip out the existing ones later in a patch to Jorge if this one goes over well. (except source, which I'm accustomed to seeing in a fixed-width font) For me, there's no change by default because dejavu sans is my default sans-serif font in fontconfig and I use it for dillo unless I want to view Asian characters for some reason. > PS: In case someone needs it we could add a ui font option in dillorc > and default to fw_fontname. Why fw?

Oct. 22, 2008

patch: prefs.vw_fontname as fltk ui's default font

by Johannes.Hofmann＠gmx.de

On Wed, Oct 22, 2008 at 02:27:23PM +0000, corvid wrote: > I was changing the font in a few more places that > can take arbitrary user text -- and then having > to change it for neighbouring things so that > the difference isn't too jarring -- and I reached > the point where it seemed like it may be best > just to change the font for everything. > I like it! We could also remove the places where the font has been set already. Cheers, Johannes PS: In case someone needs it we could add a ui font option in dillorc and default to fw_fontname.

Oct. 22, 2008

dillo-2.0 compilation failure

by Johannes.Hofmann＠gmx.de

On Wed, Oct 22, 2008 at 08:44:48AM -0300, Jorge Arellano Cid wrote: > On Wed, Oct 22, 2008 at 12:09:10AM +0200, Ben de Groot wrote: > > Jorge Arellano Cid wrote: > > > On Tue, Oct 21, 2008 at 07:39:51PM +0200, Ben de Groot wrote: > > > > >> % grep inbuf_t work/dillo-2.0/config.log > > >> #define inbuf_t const char > > > > > > It looks like the test in configure.in detects iconv() in > > > a strange way. > > > > Indeed, something seems to go wrong there. My glibc version is > > 2.8_p20080602. > > > > > What's inconv's signature in your OS? > > > > extern size_t iconv (iconv_t __cd, char **__restrict __inbuf, > > size_t *__restrict __inbytesleft, > > char **__restrict __outbuf, > > size_t *__restrict __outbytesleft); > > OK. > > A "char **" not a "const char **". > > > > Just for testing try setting [char] instead of [const char] in > > > configure.in:348. > > > > In our bugtracker another patch was proposed, which makes dillo compile > > for me. https://bugs.gentoo.org/show_bug.cgi?id=242774 > > > > --- src/form.cc 2008-10-21 21:02:31 +0000 > > +++ src/form.cc 2008-10-21 21:02:53 +0000 > > @@ -1240,8 +1240,9 @@ > > int rc = 0; > > Dstr *output; > > const int bufsize = 128; > > - inbuf_t *inPtr; > > - char *buffer, *outPtr; > > + //inbuf_t *inPtr; > > + //char *buffer, *outPtr; > > + char *buffer, *outPtr, *inPtr; > > size_t inLeft, outRoom; > > bool bad_chars = false; > > > > Does this patch look good to you? > > No. > > It seems to be enough for Gentoo, but I'd prefer to detect the > type of inbuf_t correctly in configure.in, so it compiles out of > the box. One could think that using char* for inPtr would work for both cases (char ** and const char ** in the declaration of iconv), but it doesn't: void test(const char **s) {}; int main(int argc, char **argv) { char *s; test(&s); } fails with const.cc: In function 'int main(int, char**)': const.cc:5: error: invalid conversion from 'char**' to 'const char**' const.cc:5: error: initializing argument 1 of 'void test(const char**)' See e.g. http://www.parashift.com/c++-faq-lite/const-correctness.html#faq-18.17 for the reason why this does not work. Cheers, Johannes

Oct. 22, 2008

[patch]: change the default tab label to "Dillo"

by Johannes.Hofmann＠gmx.de

On Tue, Oct 21, 2008 at 09:12:02PM +0000, corvid wrote: > Jorge wrote: > > On Mon, Oct 20, 2008 at 12:21:49PM +0100, Jeremy Henty wrote: > > > > > > *ahem*, replying to myself. > > > > > > > ... I think it looks a little sad when a new tab pops up with the > > > > pointless label "Label", so I changed it to "Dillo". > > > > > > No comments on this? It seems to have vanished without trace. > > > > It doesn't seem to make much difference (and we have no > > comments so far). > > > > Although I see one point with the "Label" label ;), > > it suggests that there goes a label that's yet unset. > > I didn't say anything because I didn't care too much, > but I suppose I like Dillo better than Label. Same here. Cheers, Johannes

Oct. 22, 2008

patch: prefs.vw_fontname as fltk ui's default font

by corvid＠lavabit.com

I was changing the font in a few more places that can take arbitrary user text -- and then having to change it for neighbouring things so that the difference isn't too jarring -- and I reached the point where it seemed like it may be best just to change the font for everything.

Oct. 22, 2008

dillo-2.0 compilation failure

by jcid＠dillo.org

On Wed, Oct 22, 2008 at 12:09:10AM +0200, Ben de Groot wrote: > Jorge Arellano Cid wrote: > > On Tue, Oct 21, 2008 at 07:39:51PM +0200, Ben de Groot wrote: > > >> % grep inbuf_t work/dillo-2.0/config.log > >> #define inbuf_t const char > > > > It looks like the test in configure.in detects iconv() in > > a strange way. > > Indeed, something seems to go wrong there. My glibc version is > 2.8_p20080602. > > > What's inconv's signature in your OS? > > extern size_t iconv (iconv_t __cd, char **__restrict __inbuf, > size_t *__restrict __inbytesleft, > char **__restrict __outbuf, > size_t *__restrict __outbytesleft); OK. A "char **" not a "const char **". > > Just for testing try setting [char] instead of [const char] in > > configure.in:348. > > In our bugtracker another patch was proposed, which makes dillo compile > for me. https://bugs.gentoo.org/show_bug.cgi?id=242774 > > --- src/form.cc 2008-10-21 21:02:31 +0000 > +++ src/form.cc 2008-10-21 21:02:53 +0000 > @@ -1240,8 +1240,9 @@ > int rc = 0; > Dstr *output; > const int bufsize = 128; > - inbuf_t *inPtr; > - char *buffer, *outPtr; > + //inbuf_t *inPtr; > + //char *buffer, *outPtr; > + char *buffer, *outPtr, *inPtr; > size_t inLeft, outRoom; > bool bad_chars = false; > > Does this patch look good to you? No. It seems to be enough for Gentoo, but I'd prefer to detect the type of inbuf_t correctly in configure.in, so it compiles out of the box. Please try the tweak-test in configure.in. If it works, we'll be sure proper detection will fix the bug. -- Cheers Jorge.-

Oct. 22, 2008

dillo-2.0 compilation failure

by yngwin＠gentoo.org

Jorge Arellano Cid wrote: > On Tue, Oct 21, 2008 at 07:39:51PM +0200, Ben de Groot wrote: >> % grep inbuf_t work/dillo-2.0/config.log >> #define inbuf_t const char > > It looks like the test in configure.in detects iconv() in > a strange way. Indeed, something seems to go wrong there. My glibc version is 2.8_p20080602. > What's inconv's signature in your OS? extern size_t iconv (iconv_t __cd, char **__restrict __inbuf, size_t *__restrict __inbytesleft, char **__restrict __outbuf, size_t *__restrict __outbytesleft); > Just for testing try setting [char] instead of [const char] in > configure.in:348. In our bugtracker another patch was proposed, which makes dillo compile for me. https://bugs.gentoo.org/show_bug.cgi?id=242774 --- src/form.cc 2008-10-21 21:02:31 +0000 +++ src/form.cc 2008-10-21 21:02:53 +0000 @@ -1240,8 +1240,9 @@ int rc = 0; Dstr *output; const int bufsize = 128; - inbuf_t *inPtr; - char *buffer, *outPtr; + //inbuf_t *inPtr; + //char *buffer, *outPtr; + char *buffer, *outPtr, *inPtr; size_t inLeft, outRoom; bool bad_chars = false; Does this patch look good to you? It looks like this issue doesn't pop up with glibc-2.6.1, which is our stable version. But obviously, I'd like it to work on our testing branch as well. Cheers, -- Ben de Groot Gentoo Linux developer (lxde, media, desktop-misc) Gentoo Linux Release Engineering PR liaison __________________________________________________ yngwin(a)gentoo.org http://ben.liveforge.org/ irc://chat.freenode.net/#gentoo-media irc://irc.oftc.net/#lxde __________________________________________________

Oct. 22, 2008

[patch]: change the default tab label to "Dillo"

by corvid＠lavabit.com

Jorge wrote: > On Mon, Oct 20, 2008 at 12:21:49PM +0100, Jeremy Henty wrote: > > > > *ahem*, replying to myself. > > > > > ... I think it looks a little sad when a new tab pops up with the > > > pointless label "Label", so I changed it to "Dillo". > > > > No comments on this? It seems to have vanished without trace. > > It doesn't seem to make much difference (and we have no > comments so far). > > Although I see one point with the "Label" label ;), > it suggests that there goes a label that's yet unset. I didn't say anything because I didn't care too much, but I suppose I like Dillo better than Label. I think what I'd expect as a user is for it to be blank if the page doesn't contain anything yet.

Oct. 21, 2008

dillo-2.0 compilation failure

by jcid＠dillo.org

On Tue, Oct 21, 2008 at 07:39:51PM +0200, Ben de Groot wrote: > corvid wrote: > >> form.cc: In member function ???Dstr* DilloHtmlForm::encodeText(void*, > >> Dstr**)???: > >> form.cc:1261: error: invalid conversion from ???const char**??? to ???char**??? > >> form.cc:1261: error: initializing argument 2 of ???size_t iconv(void*, > >> char**, size_t*, char**, size_t*)??? > > > Did you run configure yourself? What type does inbuf_t have in config.log? > > yes, I ran configure first, with: > ./configure --prefix=/usr --host=i686-pc-linux-gnu > --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share > --sysconfdir=/etc --localstatedir=/var/lib --enable-gif --disable-ipv6 > --enable-jpeg --enable-png --enable-ssl --build=i686-pc-linux-gnu > > > % grep inbuf_t work/dillo-2.0/config.log > #define inbuf_t const char It looks like the test in configure.in detects iconv() in a strange way. What's inconv's signature in your OS? Just for testing try setting [char] instead of [const char] in configure.in:348. -- Cheers Jorge.-

Oct. 21, 2008

[patch]: change the default tab label to "Dillo"

by jcid＠dillo.org

On Mon, Oct 20, 2008 at 12:21:49PM +0100, Jeremy Henty wrote: > > *ahem*, replying to myself. > > > ... I think it looks a little sad when a new tab pops up with the > > pointless label "Label", so I changed it to "Dillo". > > No comments on this? It seems to have vanished without trace. It doesn't seem to make much difference (and we have no comments so far). Although I see one point with the "Label" label ;), it suggests that there goes a label that's yet unset. -- Cheers Jorge.-

Oct. 21, 2008