January 2008 - Dillo-dev - lists.mailman3.com

patch: colspan=0

by place＠gobigwest.com

(Since Jeremy brought up the topic of spanning...) table.cc can handle colspan=0, so this just makes html.cc accept it as valid. from the spec: "The value zero ("0") means that the cell spans all columns from the current column to the last column of the column group (COLGROUP) in which the cell is defined." <table border=2> <tr> <td>A</td><td colspan=h>colspan=h</td></tr> <tr> <td>A</td><td colspan=-2>colspan=-2</td></tr> <tr> <td>A</td><td colspan=0>colspan=0</td></tr> <tr> <td>A</td><td colspan=1>colspan=1</td></tr> <tr> <td>A</td><td colspan=2>colspan=2</td></tr> <tr> <td>B</td><td>C</td><td>D</td><td>E</td><td>F</td></tr> </table>

Jan. 30, 2008

New table layout rocks!

by onepoint＠starurchin.org

On Tue, Jan 29, 2008 at 02:39:17PM +0100, Diego . wrote: > After this effort maybe the "Rewrite of tables code" item on Plans > page ( http://www.dillo.org/Plans.html) can change from > yellow(prototype at least) to green (recently finished) Sadly this may a little too hasty. I am currently investigating bugs in the handling of ROWSPAN. Also, my impression is that performance has badly degraded for tables with many rows. Jeremy Henty

Jan. 29, 2008

New table layout rocks!

by darkspirit5000＠gmail.com

After this effort maybe the "Rewrite of tables code" item on Plans page ( http://www.dillo.org/Plans.html) can change from yellow(prototype at least) to green (recently finished) :) Diego. PD: I can not get scrollbar in that page. 2008/1/26, Jeremy Henty <onepoint(a)starurchin.org>: > > On Fri, Jan 25, 2008 at 08:09:14PM +0100, Johannes Hofmann wrote: > > > > Yes, Jorge did a great job. I've not yet found any regressions and > > on some pages it's better than dillo1 was. > > Another improvement I forgot to mention: I had several links where > huge areas of whitespace appeared inside the page. These now render > sensibly. The new code seems to be much better at allocating space > between the rows and columns. > > Regards, > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >

Jan. 29, 2008

[PATCH]: cleanup: comment out DEBUG_MSG in dw2/dw/widget.cc

by onepoint＠starurchin.org

This patch comments out all uses of DEBUG_MSG in widget.cc . The justification is: * Consistency: all other uses of DEBUG_MSG in the DW source are already commented out. * The arguments to DEBUG_MSG use the GTK API, so they would fail to compile if they were ever used. Regards, Jeremy Henty

Jan. 29, 2008

a highlighting colors proposal (with code)

by place＠gobigwest.com

(Maybe this one deserves to be called a patch. It seems pretty clearly to be an improvement to me, at least...) If a page has, e.g., black text on a black background, it is nice to be able to highlight it to read it. So this changes the behavior from highlighted background is inverted background and highlighted text is inverted text to highlighted background is inverted background and highlighted text is normal background. And that is a good improvement in most cases, but then bg_color=#808080 inverts to 7f7f7f. So I changed SHADING_INVERSE so that it's really more of a SHADING_CONTRAST (I left the name alone because you might have chosen to apply my recent widget coloring code, which had SHADING_INVERSE in it somewhere, and it's nice to have patches compile cleanly.) The one negative point I've seen is in something like: <html><head></head><body bgcolor=#808080 text=#808080 link=blue> words words <s>strike</s> <u>underline</u> <a href=link>link</a> words. </body></html> The highlighted text will show no distinction between the underlined text and the link. It didn't seem important enough to bother with at the moment...

Jan. 29, 2008

[PATCH]: escape illegal characters instead of stripping them

by onepoint＠starurchin.org

Oops, I broke the indentation! Here's the same patch, but with corrected whitespace. Jeremy Henty

Jan. 28, 2008

[PATCH]: escape illegal characters instead of stripping them

by onepoint＠starurchin.org

HREF attributes often contain unescaped spaces, even though this is illegal. This is unfortunate because Dillo deletes illegal URL characters, which breaks the link. See, eg. http://www.labreporter.com/Films.html This patch makes Dillo escape all illegal URL characters instead of stripping them. Regards, Jeremy Henty

Jan. 27, 2008

Q: "Yes, enough memory!", really?

by onepoint＠starurchin.org

On Sun, Jan 27, 2008 at 06:17:21PM +0100, Johannes Hofmann wrote: > Hi, > > On Sun, Jan 27, 2008 at 05:11:30PM +0000, Jeremy Henty wrote: > > > > I'm worried about dillo2/src/url.c, line 361: > > > > p = str1 = dNew(char, strlen(url_str)); /* Yes, enough memory! */ > > > > The code after this line copies url_str to str1 , skipping illegal > > characters. It seems to me it should allocate one more character for > > the terminating null character. Does the comment "enough memory" mean > > that I am missing something, or is it talking about some other issue? > > Yeah, looks scary! But this code path is only reached if there is at > least one illegal character, so at least one char will be skipped > and then there is enough room for the \0. OK, I get it! Thanks. I thought I must be missing something since otherwise Dillo would have segfaulted everytime it created a URL, which obviously does not happen. Regards, Jeremy Henty

Jan. 27, 2008

Q: "Yes, enough memory!", really?

by Johannes.Hofmann＠gmx.de

Hi, On Sun, Jan 27, 2008 at 05:11:30PM +0000, Jeremy Henty wrote: > > I'm worried about dillo2/src/url.c, line 361: > > p = str1 = dNew(char, strlen(url_str)); /* Yes, enough memory! */ > > The code after this line copies url_str to str1 , skipping illegal > characters. It seems to me it should allocate one more character for > the terminating null character. Does the comment "enough memory" mean > that I am missing something, or is it talking about some other issue? Yeah, looks scary! But this code path is only reached if there is at least one illegal character, so at least one char will be skipped and then there is enough room for the \0. Regards, Johannes > > Regards, > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 27, 2008

Q: "Yes, enough memory!", really?

by onepoint＠starurchin.org

I'm worried about dillo2/src/url.c, line 361: p = str1 = dNew(char, strlen(url_str)); /* Yes, enough memory! */ The code after this line copies url_str to str1 , skipping illegal characters. It seems to me it should allocate one more character for the terminating null character. Does the comment "enough memory" mean that I am missing something, or is it talking about some other issue? Regards, Jeremy Henty

Jan. 27, 2008