January 2008 - Dillo-dev - lists.mailman3.com

[patch] make TopGroup a PackedGroup

by jcid＠dillo.org

On Tue, Jan 01, 2008 at 04:41:49PM +0100, Johannes Hofmann wrote: > Hi Jorge, > > On Tue, Jan 01, 2008 at 11:26:59AM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote: > > > Hello, > > > > > > as I didn't get any feedback from Sebastian yet on my proposal > > > to make the scrollbars part of UI instead of FltkViewport, I > > > decided to split my initial patch. > > > Below is a version that still uses a PackedGroup in UI, but leaves > > > the scrollbars in FltkViewport. > > > Here comes the details: > > > > > > * Make scrollbars really children of FltkViewport, as it was > > > probabely intended. > > > * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. > > > * Adjust draw() and handle() so that scrollbars work properly. > > > * As a consequence replace() now works properly, so remove the > > > workaround. > > > * Make TopGroup a PackedGroup and let it do the layout. > > > * Simplify fullscreen mode. > > > > > > This also fixes annoying problems with the statusbar when new windows > > > are created in fullscreen mode. > > > > Reviewing the patch made me remember the struggle I had, to > > develop those workarounds to have the UI working. As you may > > intuit I'm more than willing to commit. ;-) > > > > The question is: Do you agree with commiting now or do you > > prefer to hold them for comment as the former patch? > > I think it can be commited, as this new patch does not include the > reorganization of my initial patch that makes the scrollbars part of > the UI and thereby obsoletes all the ScrollbarThickness stuff in dw. Committed! -- Cheers Jorge.-

Jan. 2, 2008

[PATCH] image load graphics improvements

by onepoint＠starurchin.org

This patch tweaks the image load graphics: the spacing is nicer and the 'G' in "IMG" is more legible. You can preview the changes at http://starurchin.org/dillo/image_load/ . Regards, Jeremy Henty

Jan. 1, 2008

Best wishes for this year 2008

by onepoint＠starurchin.org

On Tue, Jan 01, 2008 at 10:38:17AM -0300, Jorge Arellano Cid wrote: > I want to start the year expressing my gratitude to all of you who > have contributed your time and effort to make the Dillo project > continue forward. Likewise I am grateful to you for opening up Dillo development so that we can contribute! > The working atmosphere is very nice and that's a very important > asset! I agree. I have been very encouraged by the good-natured and constructive responses my suggestions have received. I hope everyone else feels the same. Regards, Jeremy Henty

Jan. 1, 2008

[patch] make TopGroup a PackedGroup

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Tue, Jan 01, 2008 at 11:26:59AM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote: > > Hello, > > > > as I didn't get any feedback from Sebastian yet on my proposal > > to make the scrollbars part of UI instead of FltkViewport, I > > decided to split my initial patch. > > Below is a version that still uses a PackedGroup in UI, but leaves > > the scrollbars in FltkViewport. > > Here comes the details: > > > > * Make scrollbars really children of FltkViewport, as it was > > probabely intended. > > * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. > > * Adjust draw() and handle() so that scrollbars work properly. > > * As a consequence replace() now works properly, so remove the > > workaround. > > * Make TopGroup a PackedGroup and let it do the layout. > > * Simplify fullscreen mode. > > > > This also fixes annoying problems with the statusbar when new windows > > are created in fullscreen mode. > > Reviewing the patch made me remember the struggle I had, to > develop those workarounds to have the UI working. As you may > intuit I'm more than willing to commit. ;-) > > The question is: Do you agree with commiting now or do you > prefer to hold them for comment as the former patch? I think it can be commited, as this new patch does not include the reorganization of my initial patch that makes the scrollbars part of the UI and thereby obsoletes all the ScrollbarThickness stuff in dw. Cheers, Johannes > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Jan. 1, 2008

[patch] make TopGroup a PackedGroup

by jcid＠dillo.org

Hi Johannes, On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote: > Hello, > > as I didn't get any feedback from Sebastian yet on my proposal > to make the scrollbars part of UI instead of FltkViewport, I > decided to split my initial patch. > Below is a version that still uses a PackedGroup in UI, but leaves > the scrollbars in FltkViewport. > Here comes the details: > > * Make scrollbars really children of FltkViewport, as it was > probabely intended. > * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. > * Adjust draw() and handle() so that scrollbars work properly. > * As a consequence replace() now works properly, so remove the > workaround. > * Make TopGroup a PackedGroup and let it do the layout. > * Simplify fullscreen mode. > > This also fixes annoying problems with the statusbar when new windows > are created in fullscreen mode. Reviewing the patch made me remember the struggle I had, to develop those workarounds to have the UI working. As you may intuit I'm more than willing to commit. ;-) The question is: Do you agree with commiting now or do you prefer to hold them for comment as the former patch? -- Cheers Jorge.-

Jan. 1, 2008

[PATCH] initialise Layout::scrollIdleNotInterrupted

by onepoint＠starurchin.org

This is another valgrind pacifier; it squashes an error "Conditional jump or move depends on uninitialised value(s)" at "dw::core::Layout::updateAnchor() (layout.cc:474)" from "valgrind dw2-cur/test/dw-lists". Regards, Jeremy Henty

Jan. 1, 2008

Best wishes for this year 2008

by jcid＠dillo.org

Hi guys, I want to start the year expressing my gratitude to all of you who have contributed your time and effort to make the Dillo project continue forward. The working atmosphere is very nice and that's a very important asset! Our ability to keep working steadily and to attract more developers is probably the cornerstone that can make Dillo --as a project-- thrive and evolve. The manpower behind a project is what pushes it forward. Once again, thanks to you all, and receive my best wishes. -- Cheers Jorge.-

Jan. 1, 2008

[patch] segfault when closing window while it is loading

by Johannes.Hofmann＠gmx.de

Happy new year! Below is a small patch to fix a crash that happens when I open a new window (e.g. with the middle mouse button) and close it immediately while it is still loading the page. Johannes --- a/src/uicmd.cc Mon Dec 31 22:49:02 2007 +0100 +++ b/src/uicmd.cc Tue Jan 01 12:38:14 2008 +0100 @@ -125,6 +125,7 @@ void a_UIcmd_close_bw(void *vbw) Layout *layout = (Layout*)bw->render_layout; MSG("a_UIcmd_close_bw\n"); + a_Bw_stop_clients(bw, BW_Root + BW_Img + Bw_Force); ui->destroy(); delete(layout); a_Bw_free(bw);

Jan. 1, 2008

hook up the limit_text_width pref

by place＠gobigwest.com

I'm not sure under what circumstances this pref. actually changes anything, but here it is anyway. (I didn't notice a difference when I enabled it in my old dillo either...)

Jan. 1, 2008