December 2007 - Dillo-dev - lists.mailman3.com

[patch] partial redraws - updated

by Johannes.Hofmann＠gmx.de

On Mon, Dec 03, 2007 at 02:00:07PM -0300, Jorge Arellano Cid wrote: > On Sun, Dec 02, 2007 at 01:53:14PM +0100, Johannes Hofmann wrote: > > Hello, > > > > this patch fixes the problem pointed out by Sebastian regarding > > partial redraws and scrolling interference. > > It adds a new Region class that is implemented similarily > > as in dillo1 as a set of rectangles not containing each other. > > The conversion from canvas to view coordinates is now done at > > draw-time. > > Committed! Thanks. Attached is another patch that has some improvements to that code: * The case that multiple rectangles can be exactly combined to a larger one is quite likely (other than the comment in dillo1 suggests). It happens all the time, e.g. when an image is loaded piece by piece. The region code is improved to take advantage of this. * A minor bug also present in the dillo1 code is fixed: If a rectangle existing already in the region is contained in a newly added rectangle, we must not stop the loop. The new rectangle may contain other rectangles as well! * The actual drawing of a region now checks, whether a rectangle is actually visible at the moment. * The background is now cleared properly when doing a partial redraw. This fixes some screen corruption occuring when selecting / deselecting text. Cheers, Johannes > > > PS: The code did not get as complex as I initially thought > > it would :-) > > Great. > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 4, 2007

[patch] partial redraws - updated

by jcid＠dillo.org

On Sun, Dec 02, 2007 at 01:53:14PM +0100, Johannes Hofmann wrote: > Hello, > > this patch fixes the problem pointed out by Sebastian regarding > partial redraws and scrolling interference. > It adds a new Region class that is implemented similarily > as in dillo1 as a set of rectangles not containing each other. > The conversion from canvas to view coordinates is now done at > draw-time. Committed! > PS: The code did not get as complex as I initially thought > it would :-) Great. -- Cheers Jorge.-

Dec. 3, 2007

Re: patch: a _minuscule_ amount of cleaning up the header parsing code

by jcid＠dillo.org

On Thu, Nov 29, 2007 at 03:08:12PM +0000, place wrote: > No change in behavior is intended. > Yes, that code is getting hard to understand. After a review, I wondered why Cache_parse_header() is dealing with the message body, when it should only parse the header, and why is it getting the (buf, bufsize) pair when it has the content in entry->Header. It looks that a cleaner way would be something like: (not tested, just pseudo-code) if (!(entry->Flags & CA_GotHeader)) { while ((len = Cache_get_header(entry, buf + start, buf_size - start))) { /* Let's scan, allocate, and set things according to header info */ Cache_parse_header(entry); if (entry->Flags & CA_GotHeader) { start += len; } else // Let the flow continue downward so the remaining // of the buffer is processed } return; } and to get rid of the: dbuf = a_Decode_process(entry->TransferDecoder, dbuf); dbuf = a_Decode_process(entry->ContentDecoder, dbuf); lines inside Cache_parse_header(). Please give it a try. -- Cheers Jorge.-

Dec. 3, 2007

[patch] partial redraws - updated

by Johannes.Hofmann＠gmx.de

Hello, this patch fixes the problem pointed out by Sebastian regarding partial redraws and scrolling interference. It adds a new Region class that is implemented similarily as in dillo1 as a set of rectangles not containing each other. The conversion from canvas to view coordinates is now done at draw-time. Regards, Johannes PS: The code did not get as complex as I initially thought it would :-)

Dec. 2, 2007