December 2007 - Dillo-dev - lists.mailman3.com

[PATCH] TEXTAREA controls submit their contents

by Johannes.Hofmann＠gmx.de

On Wed, Dec 19, 2007 at 09:35:01PM +0000, Jeremy Henty wrote: > On Wed, Dec 19, 2007 at 06:34:19PM +0100, Johannes Hofmann wrote: > > > When you leave a page that has a textarea field you get a double > > free(). The TextBuffer is deleted first, then the TextEditor widgets > > are deleted and these access member methods of of the TextBuffer in > > their destructors. > > Ouch! Yes, since the derived class manages the buffer and the > superclass manages the widgets C++ insists on deleting the buffer > first. > > > I have no idea yet how to fix this. Perhaps we can disassociate the > > TextBuffer from the TextEditor widgets in the > > FltkMultiLineTextResource destructor before deleting it? > > I think we must, since we have no way of postponing the deletion of > the buffer. Here's the patch. > > Jeremy Henty > > > diff -pru -- dw2-ref/dw/fltkui.cc dw2-cur/dw/fltkui.cc > --- dw2-ref/dw/fltkui.cc 2007-12-19 14:13:25.000000000 +0000 > +++ dw2-cur/dw/fltkui.cc 2007-12-19 21:10:16.000000000 +0000 > @@ -541,6 +541,11 @@ FltkMultiLineTextResource::FltkMultiLine > > FltkMultiLineTextResource::~FltkMultiLineTextResource () > { > + for (Iterator <ViewAndWidget> it = viewsAndWidgets->iterator (); > + it.hasNext(); ) { > + ViewAndWidget *viewAndWidget = it.getNext (); > + ((::fltk::TextEditor *) viewAndWidget->widget)->buffer (0); > + } > delete buffer; > } > Yes, fixed! Regards, Johannes > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 20, 2007

Fixed a bug in the textblock's wrapping algorithm.

by jcid＠dillo.org

A small bug fix in the textblock's wrapping algorithm was committed. It fixes some border cases like the attached page. -- Cheers Jorge.-

Dec. 20, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Wed, Dec 19, 2007 at 07:28:44PM +0100, Johannes Hofmann wrote: > attached is a new patch. Please test it carefully instead of my > initial one. Not fixed yet. :-( The bug appears to be sporadic now: sometimes a middle-click brings up a blank page, sometimes not. I *think* that a left-click still always works. NB: the test page includes an input widget and it is affected too, so this is not AFAICT specific to the FLTK TextEditor. Can you reproduce this at all? Maybe it's affected by the window manager? I'm running Linux 2.6.23 + X windows 7.1 + icewm. Jeremy Henty

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Wed, Dec 19, 2007 at 06:34:19PM +0100, Johannes Hofmann wrote: > When you leave a page that has a textarea field you get a double > free(). The TextBuffer is deleted first, then the TextEditor widgets > are deleted and these access member methods of of the TextBuffer in > their destructors. Ouch! Yes, since the derived class manages the buffer and the superclass manages the widgets C++ insists on deleting the buffer first. > I have no idea yet how to fix this. Perhaps we can disassociate the > TextBuffer from the TextEditor widgets in the > FltkMultiLineTextResource destructor before deleting it? I think we must, since we have no way of postponing the deletion of the buffer. Here's the patch. Jeremy Henty diff -pru -- dw2-ref/dw/fltkui.cc dw2-cur/dw/fltkui.cc --- dw2-ref/dw/fltkui.cc 2007-12-19 14:13:25.000000000 +0000 +++ dw2-cur/dw/fltkui.cc 2007-12-19 21:10:16.000000000 +0000 @@ -541,6 +541,11 @@ FltkMultiLineTextResource::FltkMultiLine FltkMultiLineTextResource::~FltkMultiLineTextResource () { + for (Iterator <ViewAndWidget> it = viewsAndWidgets->iterator (); + it.hasNext(); ) { + ViewAndWidget *viewAndWidget = it.getNext (); + ((::fltk::TextEditor *) viewAndWidget->widget)->buffer (0); + } delete buffer; }

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by Johannes.Hofmann＠gmx.de

Hi, attached is a new patch. Please test it carefully instead of my initial one. * It moves the call to layout from FltkViewport to FltkWidgetView. This is just a cleanup - no functional change * FltkViewbase now call Group::draw() always if DAMAGE_CHILD is set even if other flags are set too. That seems to fix the issue you have noticed when opening a window with the middle mouse button. Cheers, Johannes On Wed, Dec 19, 2007 at 03:11:55PM +0000, Jeremy Henty wrote: > On Wed, Dec 19, 2007 at 02:22:26PM +0000, Jeremy Henty wrote: > > > I have a dillo page with a link to a test page with a form. If I > > middle-click on the link then the test page comes up blank. I have > > to hit reload before the form widgets appear. Left-clicking the > > link works OK. I hope this is simple to fix! > > Follow-up: this bug only appears when the window is large enough to > fit the whole form in vertically. If I resize the window vertically > so that it will be too small to hold the whole form, then middle-click > the link, the new window displays the form properly. > > I guess the widgets aren't getting marked as damaged if they all fit > in the new window, so they don't display themselves? > > Regards, > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by Johannes.Hofmann＠gmx.de

On Wed, Dec 19, 2007 at 02:22:26PM +0000, Jeremy Henty wrote: > On Wed, Dec 19, 2007 at 10:53:02AM +0000, Jeremy Henty wrote: > > On Tue, Dec 18, 2007 at 11:01:01PM +0100, Johannes Hofmann wrote: > > > > > > Please try this instead: > > > > Looks good! Both dillo and test/dw-ui-test work fine, with no > > moving widgets. Hopefully we've cracked it. > > Spoke too soon! I have a dillo page with a link to a test page with a > form. If I middle-click on the link then the test page comes up > blank. I have to hit reload before the form widgets appear. > Left-clicking the link works OK. I hope this is simple to fix! I will look at this. But I just noticed another subtle issue when using TextEditor in forms: When you leave a page that has a textarea field you get a double free(). The TextBuffer is deleted first, then the TextEditor widgets are deleted and these access member methods of of the TextBuffer in their destructors. I have no idea yet how to fix this. Perhaps we can disassociate the TextBuffer from the TextEditor widgets in the FltkMultiLineTextResource destructor before deleting it? Cheers, Johannes > > Regards, > > Jeremy Henty > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 19, 2007

[patch] resize progress indicators dynamically

by jcid＠dillo.org

On Wed, Dec 19, 2007 at 05:01:45PM +0100, Johannes Hofmann wrote: > On Tue, Dec 18, 2007 at 10:28:37PM -0300, Jorge Arellano Cid wrote: > > On Mon, Dec 17, 2007 at 07:37:58PM +0100, Johannes Hofmann wrote: > > > Hello, > > > > > > this patch resizes the progress indicators as needed. > > > I don't like the constant "+ 4". Any ideas? > > > > Yes, I committed a modified version that handles padding > > by subclassing InvisibleBox. > > Great! That's much cleaner. BTW why did you call it NewProgressBox > instead of just ProgressBox? Modified widgets in UI are using the "New" prefix. This helps to tell from a native FLTK widget. This is not written in stone though! -- Cheers Jorge.-

Dec. 19, 2007

[patch] resize progress indicators dynamically

by Johannes.Hofmann＠gmx.de

On Tue, Dec 18, 2007 at 10:28:37PM -0300, Jorge Arellano Cid wrote: > On Mon, Dec 17, 2007 at 07:37:58PM +0100, Johannes Hofmann wrote: > > Hello, > > > > this patch resizes the progress indicators as needed. > > I don't like the constant "+ 4". Any ideas? > > Yes, I committed a modified version that handles padding > by subclassing InvisibleBox. Great! That's much cleaner. BTW why did you call it NewProgressBox instead of just ProgressBox? Cheers, Johannes > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Wed, Dec 19, 2007 at 02:22:26PM +0000, Jeremy Henty wrote: > I have a dillo page with a link to a test page with a form. If I > middle-click on the link then the test page comes up blank. I have > to hit reload before the form widgets appear. Left-clicking the > link works OK. I hope this is simple to fix! Follow-up: this bug only appears when the window is large enough to fit the whole form in vertically. If I resize the window vertically so that it will be too small to hold the whole form, then middle-click the link, the new window displays the form properly. I guess the widgets aren't getting marked as damaged if they all fit in the new window, so they don't display themselves? Regards, Jeremy Henty

Dec. 19, 2007

[PATCH] TEXTAREA controls submit their contents

by onepoint＠starurchin.org

On Wed, Dec 19, 2007 at 10:53:02AM +0000, Jeremy Henty wrote: > On Tue, Dec 18, 2007 at 11:01:01PM +0100, Johannes Hofmann wrote: > > > > Please try this instead: > > Looks good! Both dillo and test/dw-ui-test work fine, with no > moving widgets. Hopefully we've cracked it. Spoke too soon! I have a dillo page with a link to a test page with a form. If I middle-click on the link then the test page comes up blank. I have to hit reload before the form widgets appear. Left-clicking the link works OK. I hope this is simple to fix! Regards, Jeremy Henty

Dec. 19, 2007