December 2007 - Dillo-dev - lists.mailman3.com

patch: color shading

by place＠gobigwest.com

This should make shading better...

Dec. 30, 2007

[patch] make TopGroup a PackedGroup

by place＠gobigwest.com

Johannes wrote: > On Sat, Dec 29, 2007 at 07:00:05AM +0000, place wrote: > > Johannes wrote: > > > just noticed that child widgets where not redrawn properly with my > > > patch. Attached is a fixed version against current cvs. > > > > If I switch to another screen and come back, the scrollbars aren't drawn. > > The viewport has damage 0xc0, and ?scrollbar->damage() is 0. > > Ah yes, the widget specific damage is only set in the DAMAGE_CHILD > case. Please try the patch below. This drawing stuff is really > fragile. It's not much code though (FltkViewport::draw () and > FltkViewBase::draw ()). Seems to be working well now. Thanks...

Dec. 29, 2007

[patch] fix hanging stop button

by Johannes.Hofmann＠gmx.de

Hello, when pressing the stop button, it get's deactivated properly, but seems to get stuck in the pressed position. The patch below fixes the problem here. For the back- and forward- buttons it's not really necessary, because the url change seems to cause the necessary redraw anyway. However I added it there too for consistency. Regards, Johannes --- a/src/ui.cc Fri Dec 28 18:33:50 2007 +0100 +++ b/src/ui.cc Sat Dec 29 10:36:50 2007 +0100 @@ -21,6 +21,7 @@ #include <fltk/Input.h> #include <fltk/Output.h> #include <fltk/run.h> +#include <fltk/damage.h> #include <fltk/BarGroup.h> #include <fltk/PackedGroup.h> #include <fltk/xpmImage.h> @@ -996,12 +997,15 @@ void UI::button_set_sens(UIButton btn, i switch (btn) { case UI_BACK: (sens) ? Back->activate() : Back->deactivate(); + Back->redraw(DAMAGE_HIGHLIGHT); break; case UI_FORW: (sens) ? Forw->activate() : Forw->deactivate(); + Forw->redraw(DAMAGE_HIGHLIGHT); break; case UI_STOP: (sens) ? Stop->activate() : Stop->deactivate(); + Stop->redraw(DAMAGE_HIGHLIGHT); break; default: break;

Dec. 29, 2007

patch: just hooking up panel preferences (panel_size, small_icons)

by Johannes.Hofmann＠gmx.de

Very nice! I was missing this a lot. Johannes On Thu, Dec 27, 2007 at 06:09:37PM +0000, place wrote: > Interestingly, > the default was and is Tiny if panel_size is not mentioned in the rc, > the default was and is Small in dillorc2, > the initial value had been Medium in ui.cc, and > the default was and is Large if the panel_size value is not understood. > > diff -pur dillo2/src/prefs.c dillo2-cur/src/prefs.c > --- dillo2/src/prefs.c 2007-12-09 18:59:45.000000000 +0000 > +++ dillo2-cur/src/prefs.c 2007-12-25 22:02:32.000000000 +0000 > @@ -167,13 +167,13 @@ static int Prefs_parse_pair(char *name, > break; > case DRC_TOKEN_PANEL_SIZE: > if (!dStrcasecmp(value, "tiny")) > - prefs.panel_size = 1; > + prefs.panel_size = P_tiny; > else if (!dStrcasecmp(value, "small")) > - prefs.panel_size = 2; > + prefs.panel_size = P_small; > else if (!dStrcasecmp(value, "medium")) > - prefs.panel_size = 3; > + prefs.panel_size = P_medium; > else /* default to "large" */ > - prefs.panel_size = 4; > + prefs.panel_size = P_large; > break; > case DRC_TOKEN_SMALL_ICONS: > prefs.small_icons = (strcmp(value, "YES") == 0); > @@ -345,7 +345,7 @@ void a_Prefs_init(void) > prefs.force_my_colors = FALSE; > prefs.contrast_visited_color = FALSE; > prefs.show_tooltip = FALSE; > - prefs.panel_size = 1; > + prefs.panel_size = P_tiny; > prefs.small_icons = FALSE; > prefs.limit_text_width = FALSE; > prefs.w3c_plus_heuristics = TRUE; > diff -pur dillo2/src/prefs.h dillo2-cur/src/prefs.h > --- dillo2/src/prefs.h 2007-11-11 16:05:05.000000000 +0000 > +++ dillo2-cur/src/prefs.h 2007-12-25 21:59:02.000000000 +0000 > @@ -20,6 +20,8 @@ extern "C" { > #define DW_COLOR_DEFAULT_PURPLE 0x800080 > #define DW_COLOR_DEFAULT_BGND 0xd6d6c0 > > +/* Panel sizes */ > +enum { P_tiny = 0, P_small, P_medium, P_large }; > > /* define enumeration values to be returned for specific symbols */ > typedef enum { > diff -pur dillo2/src/ui.cc dillo2-cur/src/ui.cc > --- dillo2/src/ui.cc 2007-12-20 20:02:31.000000000 +0000 > +++ dillo2-cur/src/ui.cc 2007-12-25 22:24:47.000000000 +0000 > @@ -593,11 +593,13 @@ UI::UI(int win_w, int win_h, const char* > } else { > // Set some default values > //PanelSize = P_tiny, CuteColor = 26, Small_Icons = 0; > - PanelSize = P_medium, CuteColor = 206, Small_Icons = 0; > + PanelSize = prefs.panel_size; > + Small_Icons = prefs.small_icons; > + CuteColor = 206; > } > > resizable(this); > diff -pur dillo2/src/ui.hh dillo2-cur/src/ui.hh > --- dillo2/src/ui.hh 2007-12-20 20:02:31.000000000 +0000 > +++ dillo2-cur/src/ui.hh 2007-12-25 22:07:57.000000000 +0000 > @@ -13,9 +13,6 @@ > > using namespace fltk; > > -// Panel sizes > -enum { P_tiny = 0, P_small, P_medium, P_large }; > - > typedef enum { > UI_BACK = 0, > UI_FORW, > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 29, 2007

[patch] make TopGroup a PackedGroup

by Johannes.Hofmann＠gmx.de

On Sat, Dec 29, 2007 at 07:00:05AM +0000, place wrote: > Johannes wrote: > > just noticed that child widgets where not redrawn properly with my > > patch. Attached is a fixed version against current cvs. > > If I switch to another screen and come back, the scrollbars aren't drawn. > The viewport has damage 0xc0, and ?scrollbar->damage() is 0. Ah yes, the widget specific damage is only set in the DAMAGE_CHILD case. Please try the patch below. This drawing stuff is really fragile. It's not much code though (FltkViewport::draw () and FltkViewBase::draw ()). Johannes --- a/dw/fltkviewport.cc Fri Dec 28 20:17:46 2007 +0100 +++ b/dw/fltkviewport.cc Sat Dec 29 08:45:03 2007 +0100 @@ -193,10 +193,13 @@ void FltkViewport::draw () if (d) { draw_area(this, cr); - if (hscrollbar->damage ()) + if (d == DAMAGE_CHILD) { + if (hscrollbar->damage ()) draw_child (*hscrollbar); + if (vscrollbar->damage ()) draw_child (*vscrollbar); + } else { draw_child (*hscrollbar); - if (vscrollbar->damage ()) draw_child (*vscrollbar); + } } scrollDX = 0; > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Dec. 29, 2007

[patch] make TopGroup a PackedGroup

by place＠gobigwest.com

Johannes wrote: > just noticed that child widgets where not redrawn properly with my > patch. Attached is a fixed version against current cvs. If I switch to another screen and come back, the scrollbars aren't drawn. The viewport has damage 0xc0, and ?scrollbar->damage() is 0.

Dec. 29, 2007

[patch] make TopGroup a PackedGroup

by Johannes.Hofmann＠gmx.de

Hi, just noticed that child widgets where not redrawn properly with my patch. Attached is a fixed version against current cvs. Cheers, Johannes On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote: > Hello, > > as I didn't get any feedback from Sebastian yet on my proposal > to make the scrollbars part of UI instead of FltkViewport, I > decided to split my initial patch. > Below is a version that still uses a PackedGroup in UI, but leaves > the scrollbars in FltkViewport. > Here comes the details: > > * Make scrollbars really children of FltkViewport, as it was > probabely intended. > * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. > * Adjust draw() and handle() so that scrollbars work properly. > * As a consequence replace() now works properly, so remove the > workaround. > * Make TopGroup a PackedGroup and let it do the layout. > * Simplify fullscreen mode. > > This also fixes annoying problems with the statusbar when new windows > are created in fullscreen mode. > > Cheers, > Johannes

Dec. 28, 2007

[patch] make TopGroup a PackedGroup

by Johannes.Hofmann＠gmx.de

Hi, just noticed that child widgets where not redrawn properly with my patch. Attached is a fixed version against current cvs. Cheers, Johannes On Fri, Dec 28, 2007 at 05:26:19PM +0100, Johannes Hofmann wrote: > Hello, > > as I didn't get any feedback from Sebastian yet on my proposal > to make the scrollbars part of UI instead of FltkViewport, I > decided to split my initial patch. > Below is a version that still uses a PackedGroup in UI, but leaves > the scrollbars in FltkViewport. > Here comes the details: > > * Make scrollbars really children of FltkViewport, as it was > probabely intended. > * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. > * Adjust draw() and handle() so that scrollbars work properly. > * As a consequence replace() now works properly, so remove the > workaround. > * Make TopGroup a PackedGroup and let it do the layout. > * Simplify fullscreen mode. > > This also fixes annoying problems with the statusbar when new windows > are created in fullscreen mode. > > Cheers, > Johannes

Dec. 28, 2007

patch: just hooking up panel preferences (panel_size, small_icons)

by jcid＠dillo.org

Hi, Committed. On Thu, Dec 27, 2007 at 06:09:37PM +0000, place wrote: > Interestingly, > the default was and is Tiny if panel_size is not mentioned in the rc, > the default was and is Small in dillorc2, > the initial value had been Medium in ui.cc, and > the default was and is Large if the panel_size value is not understood. Yeah, quite untidy. Large is ok when there's no dillorc2, or panel_size is bad/not-present, dillorc2 in the source tree may vary. -- Cheers Jorge.-

Dec. 28, 2007

[patch] make TopGroup a PackedGroup

by Johannes.Hofmann＠gmx.de

Hello, as I didn't get any feedback from Sebastian yet on my proposal to make the scrollbars part of UI instead of FltkViewport, I decided to split my initial patch. Below is a version that still uses a PackedGroup in UI, but leaves the scrollbars in FltkViewport. Here comes the details: * Make scrollbars really children of FltkViewport, as it was probabely intended. * Use widget local coordinates in FltkViewport::adjustScrollbarsAndGadgets. * Adjust draw() and handle() so that scrollbars work properly. * As a consequence replace() now works properly, so remove the workaround. * Make TopGroup a PackedGroup and let it do the layout. * Simplify fullscreen mode. This also fixes annoying problems with the statusbar when new windows are created in fullscreen mode. Cheers, Johannes

Dec. 28, 2007