April 2006 - Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] rc4 testing

by Jorge Arellano Cid

Hi there, On Mon, Apr 10, 2006 at 08:23:33PM +0200, Diego Sáenz wrote: > Is it too late for a small hack? > dl_gui is not localized, but wget yes. When you have a locale diferent from "C" or one english one dl_gui do not get the download size (it search for "Lenght:" in wget log) and progress bar do not show real progress. > > How i unknown how portables are locale functions y use puntenv to change locale environ and set wget(and its log) to "C" > A better solution can be to localize dl_gui or generalize wget parser The patchset for downloads GUI is in CVS now. This is: - LC_ALL=C - cookies - Last download goes on top (please send feedback on this) NOTE: please use FLTK2 r4898 or less. The latest versions are too unstable or simply crash. From scratch from svn: svn co -r 4898 http://svn.easysw.com/public/fltk/fltk/trunk/ fltk to an existing svn tree: svn update -r 4898 If I don't get more bug reports from rc4 in a couple of days, I'll expect Diego's feedback and pack rc5 with CVS. -- Cheers Jorge.-

April 12, 2006

Re: [Dillo-dev] rc4 testing

by Jorge Arellano Cid

Hi Diego, On Mon, Apr 10, 2006 at 08:23:33PM +0200, Diego Sáenz wrote: > Is it too late for a small hack? Still time to squash bugs. > dl_gui is not localized, but wget yes. When you have a locale diferent from "C" or one english one dl_gui do not get the download size (it search for "Lenght:" in wget log) and progress bar do not show real progress. > > How i unknown how portables are locale functions y use puntenv to change locale environ and set wget(and its log) to "C" > A better solution can be to localize dl_gui or generalize wget parser > > > diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc dillo-0.8.6-rc4/dpi/downloads.cc > --- dillo-0.8.6-rc4-C/dpi/downloads.cc 2006-04-10 19:47:00.000000000 +0200 > +++ dillo-0.8.6-rc4/dpi/downloads.cc 2006-04-10 19:48:26.000000000 +0200 > @@ -458,6 +458,8 @@ void DLItem::child_init() > close(1); // stdout > close(LogPipe[0]); > dup2(LogPipe[1], 2); // stderr > + // put locale to C (small hack) dl_gui search for "Lenght:" in wget log > + putenv("LC_ALL=C"); > // start wget > execvp(dl_argv[0], dl_argv); > } I prefer setenv(), because with putenv() you have to define _XOPEN_SOURCE or _SVID_SOURCE. > > If i get time i will try to support dillo cookies file. It is only add "--load-cookies $HOME/.dillo/cookies.txt" to wget comandline. May be this work (not tested, can anyone test and report?) > > > diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc dillo-0.8.6-rc4/dpi/downloads.cc > --- dillo-0.8.6-rc4-C/dpi/downloads.cc 2006-04-10 20:20:30.000000000 +0200 > +++ dillo-0.8.6-rc4/dpi/downloads.cc 2006-04-10 20:20:11.000000000 +0200 > @@ -325,7 +325,7 @@ DLItem::DLItem(const char *full_filename > /* avoid malicious SMTP relaying with FTP urls */ > if (g_strncasecmp(esc_url, "ftp:/", 5) == 0) > Filter_smtp_hack(esc_url); > - dl_argv = new char*[6]; > + dl_argv = new char*[7]; > int i = 0; > dl_argv[i++] = "wget"; > if (action == DL_CONTINUE) { > @@ -336,6 +336,7 @@ DLItem::DLItem(const char *full_filename > dl_argv[i++] = "-O"; > dl_argv[i++] = fullname; > dl_argv[i++] = esc_url; //g_strdup_printf("'%s'", esc_url); > + dl_argv[i++] = "--load-cookies $HOME/.dillo/cookies.txt"; > dl_argv[i++] = NULL; > //g_free(esc_url); > AFAIU that code will not work (setting two arguments in one place)... > > But i do not understand this lines in DLItem::~DLItem() > > if (dl_argv[4] == NULL) > g_free(dl_argv[3]); > else > g_free(dl_argv[4]); > delete(dl_argv); > > ¿do not change arguments order if "-c" is used or not? Yes, but it's buggy! ;) All of it is fixed in my tree, but FLTK2 last version breaks lots of things so I'm going back for testing. :-P BTW, I have the idea of adding new downloads on top instead of bottom. That way you always see the fresh download you started, no matter what the size of the window. I'll test this with an older FLTK2 version and commit for your testing pleasure. ;) -- Cheers Jorge.-

April 11, 2006

Upcoming filename changes in FLTK2

by Jeremy Henty

A tip-off for Dillo developers: FLTK2 will shortly rename its installed libraries and configuration scripts from *fltk* to *fltk2* . This means that Dillo's configure.in will then have to refer to fltk2-config everywhere instead of fltk-config . Cheers, Jeremy Henty

April 10, 2006

Re: [Dillo-dev] rc4 testing

by Diego Sáenz

Is it too late for a small hack? dl_gui is not localized, but wget yes. When you have a locale diferent from "C" or one english one dl_gui do not get the download size (it search for "Lenght:" in wget log) and progress bar do not show real progress. How i unknown how portables are locale functions y use puntenv to change locale environ and set wget(and its log) to "C" A better solution can be to localize dl_gui or generalize wget parser diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc dillo-0.8.6-rc4/dpi/downloads.cc --- dillo-0.8.6-rc4-C/dpi/downloads.cc 2006-04-10 19:47:00.000000000 +0200 +++ dillo-0.8.6-rc4/dpi/downloads.cc 2006-04-10 19:48:26.000000000 +0200 @@ -458,6 +458,8 @@ void DLItem::child_init() close(1); // stdout close(LogPipe[0]); dup2(LogPipe[1], 2); // stderr + // put locale to C (small hack) dl_gui search for "Lenght:" in wget log + putenv("LC_ALL=C"); // start wget execvp(dl_argv[0], dl_argv); } If i get time i will try to support dillo cookies file. It is only add "--load-cookies $HOME/.dillo/cookies.txt" to wget comandline. May be this work (not tested, can anyone test and report?) diff -pru dillo-0.8.6-rc4-C/dpi/downloads.cc dillo-0.8.6-rc4/dpi/downloads.cc --- dillo-0.8.6-rc4-C/dpi/downloads.cc 2006-04-10 20:20:30.000000000 +0200 +++ dillo-0.8.6-rc4/dpi/downloads.cc 2006-04-10 20:20:11.000000000 +0200 @@ -325,7 +325,7 @@ DLItem::DLItem(const char *full_filename /* avoid malicious SMTP relaying with FTP urls */ if (g_strncasecmp(esc_url, "ftp:/", 5) == 0) Filter_smtp_hack(esc_url); - dl_argv = new char*[6]; + dl_argv = new char*[7]; int i = 0; dl_argv[i++] = "wget"; if (action == DL_CONTINUE) { @@ -336,6 +336,7 @@ DLItem::DLItem(const char *full_filename dl_argv[i++] = "-O"; dl_argv[i++] = fullname; dl_argv[i++] = esc_url; //g_strdup_printf("'%s'", esc_url); + dl_argv[i++] = "--load-cookies $HOME/.dillo/cookies.txt"; dl_argv[i++] = NULL; //g_free(esc_url); But i do not understand this lines in DLItem::~DLItem() if (dl_argv[4] == NULL) g_free(dl_argv[3]); else g_free(dl_argv[4]); delete(dl_argv); ¿do not change arguments order if "-c" is used or not? Diego. El Sun, 9 Apr 2006 19:44:43 -0400 Jorge Arellano Cid <jcid(a)dillo.org> escribio: > Hi, > > Kelson told me the patch in CVS works for the web bug segfault. > > It looks like we're close to a release. > > I'll wait a couple of days more for feedback. > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

April 10, 2006

rc4 testing

by Jorge Arellano Cid

Hi, Kelson told me the patch in CVS works for the web bug segfault. It looks like we're close to a release. I'll wait a couple of days more for feedback. -- Cheers Jorge.-

April 9, 2006

Dillo 0.8.6 RC4 on a ps2 (with fltk2 dpi)

by robert w hall

In article <4436969B.8080202(a)pobox.com>, Kelson Vibber <kelson(a)pobox.com> writes >I'm seeing far fewer problems with this one so far! Better news on the ps2/fltk2 front (but not much better) I've got a version of fltk2 (4922) to compile, using gcc3.03 and an updated autoconf (2.57). Also small fixes to xutf8 and fltk/glut.h. But it looks like that condemns me (and those others who usually 'roll their own') to using the later gcc3.03 gcc and g++ packages throughout, installing the new autoconf and declaring new paths to CC and CXX in configure. (but at least 'mine eyes have seen' fltk2 in action) -- robert w hall

April 9, 2006

Re: [Dillo-dev] dillo-0.8.6-rc4.tar.bz2

by Thomas-Martin Seck

* Thomas-Martin Seck (tmseck-lists(a)netcologne.de) > * Jorge Arellano Cid (jcid(a)dillo.org) > > > The new rc4 tarball is ready: > > > > http://www.dillo.org/download/dillo-0.8.6-rc4.tar.bz2 > > As usual, compiles on FreeBSD 4, 5, and 6 with a tarball fetched a few > hours ago. Normal usage on FreeBSD 4 and 6 shows no issues whatsoever, > luckily not even the segfault conditions Kelson Vibber had already > reported. Did you reroll the tarball to include the fixes for this? A minor issue: when I try to build dillo against a non-threaded fltk2, I get this: c++ -I/usr/local/include/glib12 -O -pipe -L/usr/local/lib -L/usr/X11R6/lib -L/usr/local/lib -o downloads.dpi downloads.o dpiutil.o -L/usr/local/lib -lglib-12 -L/usr/X11R6/lib -lfltk -L/usr/local/lib -lX11 -lXi -lXinerama -lXft -lm -lXext ../dpip/libDpip.a downloads.o: In function `main': downloads.o(.text+0x2fca): undefined reference to `fltk::lock(void)' gmake[2]: *** [downloads.dpi] Error 1 This is probably to be expected? This is not a big issue, I'll just add a note that people who want to use dillo+fltk2 make sure they install fltk2 with threads support. Threads support is turned on by default but can be turned off if the user wants to. (This can be useful on FreeBSD 4 which has no threads support beyond libc_r.)

April 9, 2006

Re: [Dillo-dev] dillo-0.8.6-rc4.tar.bz2

by Jorge Arellano Cid

On Sun, Apr 09, 2006 at 02:34:15PM +0200, Thomas-Martin Seck wrote: > * Jorge Arellano Cid (jcid(a)dillo.org) > > > The new rc4 tarball is ready: > > > > http://www.dillo.org/download/dillo-0.8.6-rc4.tar.bz2 > > As usual, compiles on FreeBSD 4, 5, and 6 with a tarball fetched a few > hours ago. Normal usage on FreeBSD 4 and 6 shows no issues whatsoever, > luckily not even the segfault conditions Kelson Vibber had already > reported. Did you reroll the tarball to include the fixes for this? Thanks for the feedback. I haven't made a rc5 tarball yet; I'm waiting for more feedback. This way I can pack all the detected bugs into rc5, or if there're only a few bugs, pack a "final" one. The fix for the bug reported by Kelson is in the CVS now. -- Cheers Jorge.-

April 9, 2006

Re: [Dillo-dev] dillo-0.8.6-rc4.tar.bz2

by Thomas-Martin Seck

* Jorge Arellano Cid (jcid(a)dillo.org) > The new rc4 tarball is ready: > > http://www.dillo.org/download/dillo-0.8.6-rc4.tar.bz2 As usual, compiles on FreeBSD 4, 5, and 6 with a tarball fetched a few hours ago. Normal usage on FreeBSD 4 and 6 shows no issues whatsoever, luckily not even the segfault conditions Kelson Vibber had already reported. Did you reroll the tarball to include the fixes for this?

April 9, 2006

Re: [Dillo-dev] Segfault in Dillo 0.8.6 RC4

by Jorge Arellano Cid

Hi Kelson, On Fri, Apr 07, 2006 at 09:43:07AM -0700, Kelson Vibber wrote: > I'm seeing far fewer problems with this one so far! > > I did find a page that made RC4 segfault, though. > > I tracked the segfault to an image where the src URL was missing a > Content-Type header. (The URL also had a content-length of 0, but that > alone doesn't cause Dillo any problems.) It occurred whether I pointed > Dillo at a page containing the <img> element, or pointed it straight at > the image URL. > > RC3 does not segfault on this URL. (It just displays an empty page or > image.) > > I'm reluctant to post the actual URL because it's a web bug, but here > are the headers as reported by the libwww HEAD command: > > 200 OK > Cache-Control: private > Date: Fri, 07 Apr 2006 16:17:06 GMT > Server: Microsoft-IIS/6.0 > Content-Length: 0 > MicrosoftOfficeWebServer: 5.0_Pub > P3P: CP="PUB OTRo" > Set-Cookie: SIClientID=108; path=/ > X-AspNet-Version: 1.1.4322 > X-Powered-By: ASP.NET > > > Here's the debug output from Dillo: > > HTTP warning: Server didn't send Content-Type in header. > Type check: [Srv: (null) Det: text/plain] > Segmentation fault > > > I've been trying to put together a test case, but Apache won't let me > send a response without a content-type, even through CGI. If I don't > create a Content-Type header, it adds one using the default type and > encoding. Thanks a lot for the report! Bug fixed in CVS, please check it. FWIW, I used boa web server. :-) -- Cheers Jorge.-

April 8, 2006