February 2006 - Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] bugs: #707, #708 and #709

by Jorge Arellano Cid

On Tue, Feb 14, 2006 at 12:25:39AM +0100, Michal Nowak wrote: > Hi all, Hi Michal. > I asked last two bug committers of bugs in database (no. 707, 709) about > their version of Dillo and they were both used that > (http://teki.jpn.ph/pc/software/index-e.shtml) patchset version. So I > wrote to DB that this bug is not related to default branch. > > Is correct to write it to DB or you are going to solve or inverstigate > that bugs? The bugtrack is for the official Dillo branch only. I even ask people distributing patched Dillos to state it clearly (hopefully in the splash screen). The i18n-misc tree provides some features but also breaks several things. Bugs should be reported to them, not us. BTW, our plan is to have utf8 (FLTK2) and add i18n over it. I see you have patches for these bugs. Please send them to the i18n-misc maintainer, and let me know to delete these bugtrack entries afterwards. -- Cheers Jorge.-

Feb. 15, 2006

Re: [Dillo-dev] cookies code clean-ups

by Jorge Arellano Cid

On Tue, Feb 14, 2006 at 08:12:02PM +0100, Diego Sáenz wrote: > The second patch do not seems to be in the cvs. Sorry, my mistake. Done! (2) :) -- Cheers Jorge.-

Feb. 15, 2006

Re: [Dillo-dev] cookies code clean-ups

by Diego Sáenz

The second patch do not seems to be in the cvs. Diego. El Mon, 13 Feb 2006 10:20:02 -0300 Jorge Arellano Cid <jcid(a)dillo.org> escribio: > On Mon, Feb 13, 2006 at 04:36:27AM +0100, Diego Sáenz wrote: > > First patch removes some unused code relates to cookies. > > Second one removes commented code in dpi/cookies.c > > > > I am sorry, them were my fault. Patchs works with current cvs. > > Done! :-) > > -- > Cheers > Jorge.- > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Feb. 14, 2006

bugs: #707, #708 and #709

by Michal Nowak

Hi all, I asked last two bug committers of bugs in database (no. 707, 709) about their version of Dillo and they were both used that (http://teki.jpn.ph/pc/software/index-e.shtml) patchset version. So I wrote to DB that this bug is not related to default branch. Is correct to write it to DB or you are going to solve or inverstigate that bugs? Best regards, Michal Nowak -- # Michal Nowak # jabber: nowak(a)jabber.cz # irc: #wmii @ irc.oftc.net ---> newman # icq: 170814295

Feb. 13, 2006

Re: [Dillo-dev] cookies code clean-ups

by Jorge Arellano Cid

On Mon, Feb 13, 2006 at 04:36:27AM +0100, Diego Sáenz wrote: > First patch removes some unused code relates to cookies. > Second one removes commented code in dpi/cookies.c > > I am sorry, them were my fault. Patchs works with current cvs. Done! :-) -- Cheers Jorge.-

Feb. 13, 2006

cookies code clean-ups

by Diego Sáenz

First patch removes some unused code relates to cookies. Second one removes commented code in dpi/cookies.c I am sorry, them were my fault. Patchs works with current cvs. Diego. 8<------------------------------------------------------------------- diff -pru dillo-0.8.6-pre-cvs20060129/src/IO/dpi.c dillo-work/src/IO/dpi.c --- dillo-0.8.6-pre-cvs20060129/src/IO/dpi.c 2006-01-06 00:38:05.000000000 +0100 +++ dillo-work/src/IO/dpi.c 2006-02-13 03:59:11.000000000 +0100 @@ -256,11 +256,6 @@ static void Dpi_parse_token(conn_data_t a_Chain_fcb(OpSend, conn->InfoRecv, msg, cmd); g_free(msg); - } else if (strcmp(cmd, "get_cookie_answer") == 0) { - msg = a_Dpip_get_attr(conn->Buf + conn->TokIdx, conn->TokSize, "cookie"); - a_Chain_fcb(OpSend, conn->InfoRecv, msg, cmd); - g_free(msg); - } else if (strcmp(cmd, "dialog") == 0) { /* For now will send the dpip tag... */ a_Chain_fcb(OpSend, conn->InfoRecv, tag, cmd); 8<------------------------------------------------------------------- diff -pru dillo-0.8.6-pre-cvs20060129/dpi/cookies.c dillo-work/dpi/cookies.c --- dillo-0.8.6-pre-cvs20060129/dpi/cookies.c 2006-01-21 04:00:27.000000000 +0100 +++ dillo-work/dpi/cookies.c 2006-02-13 04:12:45.000000000 +0100 @@ -1375,10 +1375,7 @@ static int srv_parse_buf(SockHandler *sh g_free(host); cmd = a_Dpip_build_cmd("cmd=%s cookie=%s", "get_cookie_answer", cookie); -/* - cmd = g_strdup_printf("<dpi cmd='get_cookie_answer' cookie='%s'>", - cookie); -*/ + if (sock_handler_write_str(sh, cmd, 1)) { g_free(cookie); g_free(cmd);

Feb. 13, 2006

cookies code clean-ups

by Diego Sáenz

First patch removes some unused code relates to cookies. Second one removes commented code in dpi/cookies.c I am sorry, them were my fault. Patchs works with current cvs. Diego. 8<------------------------------------------------------------------- diff -pru dillo-0.8.6-pre-cvs20060129/src/IO/dpi.c dillo-work/src/IO/dpi.c --- dillo-0.8.6-pre-cvs20060129/src/IO/dpi.c 2006-01-06 00:38:05.000000000 +0100 +++ dillo-work/src/IO/dpi.c 2006-02-13 03:59:11.000000000 +0100 @@ -256,11 +256,6 @@ static void Dpi_parse_token(conn_data_t a_Chain_fcb(OpSend, conn->InfoRecv, msg, cmd); g_free(msg); - } else if (strcmp(cmd, "get_cookie_answer") == 0) { - msg = a_Dpip_get_attr(conn->Buf + conn->TokIdx, conn->TokSize, "cookie"); - a_Chain_fcb(OpSend, conn->InfoRecv, msg, cmd); - g_free(msg); - } else if (strcmp(cmd, "dialog") == 0) { /* For now will send the dpip tag... */ a_Chain_fcb(OpSend, conn->InfoRecv, tag, cmd); 8<------------------------------------------------------------------- diff -pru dillo-0.8.6-pre-cvs20060129/dpi/cookies.c dillo-work/dpi/cookies.c --- dillo-0.8.6-pre-cvs20060129/dpi/cookies.c 2006-01-21 04:00:27.000000000 +0100 +++ dillo-work/dpi/cookies.c 2006-02-13 04:12:45.000000000 +0100 @@ -1375,10 +1375,7 @@ static int srv_parse_buf(SockHandler *sh g_free(host); cmd = a_Dpip_build_cmd("cmd=%s cookie=%s", "get_cookie_answer", cookie); -/* - cmd = g_strdup_printf("<dpi cmd='get_cookie_answer' cookie='%s'>", - cookie); -*/ + if (sock_handler_write_str(sh, cmd, 1)) { g_free(cookie); g_free(cmd);

Feb. 13, 2006