May 2005 - Dillo-dev - lists.mailman3.com

Re: [Dillo-dev]dillo on sparc64

by Damien COUDERC

Hi Jorge ! >>The following line is reallocating a buffer: >>conn->Buf = g_realloc(conn->Buf, (gulong)io->Status); >> >>But when debugging the values of io->Status don't seem to be adequate. >>I haven't been able to completely fix it as the code is seriously >>lacking of comment. > > All the dpi stuff is under a big revision. The current diff I'm > working on is 40 pages. BTW, in the new version, that line is: > > conn->Buf = g_realloc(conn->Buf, conn->BufSize + (gulong)io->Status); That is what i had first done to fix the problem. But dillo still segfault a bit later and i've not been able to found where yet. I can just say that there is a problem with the start of a string that is lost somewhere. IMHO the fix of Roberto looks better but as i'm not used to this code i'm maybe wrong. >>To be honest i don't even completely understand what >>this chunk is doing and the code is so unreadable that it doesn't help >>(not to be harsh but just to give my humble opinion). > > :-O This is meant to be a constructive critic. I'm addicted to maintainable code and by experience i know that if there are not enough comments the code is not easily readable. For the record, this bug has been found month ago but i've been unmotivated each time i had to read again the dpi.c file. If it had been well commented i should have been able to fix the problem by myself and to send you the resulting patch. Think that you have maybe lost potential developers just for this reason. Now and again this is just my humble opinion and i'm not pretensious enough to try to learn you how to manage your own project. Cheers, Damien

May 19, 2005

Re: [Dillo-dev]dillo on sparc64

by Jorge Arellano Cid

On Thu, May 19, 2005 at 04:40:55PM +0200, Damien COUDERC wrote: > Hi, > i have problems with dillo on sparc64. When using a mechanism of OpenBSD > 's malloc i'm able to detect a bug in the dpi stuff. > At the moment i've found that the function Dpi_append_io_buf() in the > file src/IO/dpi.c is wrong. > > The following line is reallocating a buffer: > conn->Buf = g_realloc(conn->Buf, (gulong)io->Status); > > But when debugging the values of io->Status don't seem to be adequate. > I haven't been able to completely fix it as the code is seriously > lacking of comment. All the dpi stuff is under a big revision. The current diff I'm working on is 40 pages. BTW, in the new version, that line is: conn->Buf = g_realloc(conn->Buf, conn->BufSize + (gulong)io->Status); > To be honest i don't even completely understand what > this chunk is doing and the code is so unreadable that it doesn't help > (not to be harsh but just to give my humble opinion). :-O -- Jorge.-

May 19, 2005

Re: [Dillo-dev]dillo on sparc64

by Roberto A. Foglietta

Damien COUDERC wrote: > Hi, > i have problems with dillo on sparc64. When using a mechanism of OpenBSD > 's malloc i'm able to detect a bug in the dpi stuff. > At the moment i've found that the function Dpi_append_io_buf() in the > file src/IO/dpi.c is wrong. > > The following line is reallocating a buffer: > conn->Buf = g_realloc(conn->Buf, (gulong)io->Status); > > But when debugging the values of io->Status don't seem to be adequate. > I haven't been able to completely fix it as the code is seriously > lacking of comment. To be honest i don't even completely understand what > this chunk is doing and the code is so unreadable that it doesn't help > (not to be harsh but just to give my humble opinion). in the file src/IO/IO.h, in the function static gboolean IO_read(IOData_t *io) there is at line 464 (in last stable release 0.8.4) io->Status = St; but that is true only if not have been read some more data with DataPending = TRUE; which repeate while and it is in the last else that was wrongly commented as /* BytesRead == io->BufSize */ while that conditions is /* BytesRead == io->BufSize */ So in few words the patch I propose is: io->Status = 0; //HERE do { ret = FALSE; DataPending = FALSE; St = read(io->FD, io->Buf, io->BufSize); io->Status += St; //AND HERE obviuosly who read have to free the previous buffer and set io->Status to zero... but in IMHO because the io struct has a flag wich tell us if there is something allocated is a good idea to use it and also free the buffers whose are sent to be read but not freed before. Cheers, -- Roberto A. Foglietta Analista Programmatore GNU/Linux SAD Trasporto Locale S.p.a. Corso Italia 13/N 39100 BOLZANO (I) Tel. +39/0471-450.261 Fax +39/0471-450.253

May 19, 2005

[Dillo-dev]dillo on sparc64

by Damien COUDERC

Hi, i have problems with dillo on sparc64. When using a mechanism of OpenBSD 's malloc i'm able to detect a bug in the dpi stuff. At the moment i've found that the function Dpi_append_io_buf() in the file src/IO/dpi.c is wrong. The following line is reallocating a buffer: conn->Buf = g_realloc(conn->Buf, (gulong)io->Status); But when debugging the values of io->Status don't seem to be adequate. I haven't been able to completely fix it as the code is seriously lacking of comment. To be honest i don't even completely understand what this chunk is doing and the code is so unreadable that it doesn't help (not to be harsh but just to give my humble opinion). Damien

May 19, 2005

[Dillo-dev]Re: Re: Cookie control?

by beartooth

On Fri, 13 May 2005 14:58:24 +0200, Bjoern Brill wrote: > Anyway, if you're using one of the RPMs built by Kelson Vibber, the > same information can be found in > /usr/share/doc/dillo-0.8.4/developers/Cookies.txt . That's .../doc/... here; but OK otherwise >> file, and the whole content of cookiesrc was "DEFAULT DENY"; so I edited >> it, and now I have : >> ===== >> [root@localhost .dillo]# ls >> cookiesrc dpi_socket_dir >> [root@localhost .dillo]# cat cookiesrc >> DEFAULT ACCEPT_SESSION >> [root@localhost .dillo]# >> ===== >> I hope that's right! > Yes, it is. Oh good. Many thanks! > But you don't surf the Internet as root, do you? No, certainly not. But I do updates, installations, etc. as root -- in case my other user might want access to an app. -- Beartooth Neo-Redneck, Linux Evangelist FC 1, YDL 4; Pine 4.63, Pan 0.14.2; Privoxy 3.0.3; Dillo 0.8.4, Opera 8.0, Firefox 1.0.3, Epiphany 1.0.4 Remember that I have little idea what I am talking about.

May 13, 2005

Re: [Dillo-dev]Re: Cookie control?

by Bjoern Brill

On Thu, 12 May 2005, beartooth wrote: > On Wed, 11 May 2005 20:07:48 +0200, Bjoern Brill wrote: > > > > > On Wed, 11 May 2005, beartooth wrote: > > > >> Where does Dillo store cookies? Is there hope of a setting for "treat all > > In ~/.dillo/cookies . > > > >> cookies as session cookies"? > > Put a "DEFAULT ACCEPT_SESSION" line in ~/.dillo/cookiesrc . Consult > > doc/Cookies.txt in the source tarball for details. > > Hmmmm ... tarballs are mostly over my head. But it seems I had no cookies Why? OK they're black, sticky, and stink like hell, but apart from that tarballs are quite nice and conceptually similar to .zip files: a collection of files bundeled together in one big file, with optional compression. Anyway, if you're using one of the RPMs built by Kelson Vibber, the same information can be found in /usr/share/doc/dillo-0.8.4/developers/Cookies.txt . > file, and the whole content of cookiesrc was "DEFAULT DENY"; so I edited > it, and now I have : > ===== > [root@localhost .dillo]# ls > cookiesrc dpi_socket_dir > [root@localhost .dillo]# cat cookiesrc > DEFAULT ACCEPT_SESSION > [root@localhost .dillo]# > ===== > I hope that's right! Yes, it is. But you don't surf the Internet as root, do you? Regards, Bjoern -- Bj"orn Brill <brill(a)fs.math.uni-frankfurt.de> Frankfurt am Main, Germany

May 13, 2005

[Dillo-dev]Re: Cookie control?

by beartooth

On Wed, 11 May 2005 20:07:48 +0200, Bjoern Brill wrote: > > On Wed, 11 May 2005, beartooth wrote: > >> Where does Dillo store cookies? Is there hope of a setting for "treat all > In ~/.dillo/cookies . > >> cookies as session cookies"? > Put a "DEFAULT ACCEPT_SESSION" line in ~/.dillo/cookiesrc . Consult > doc/Cookies.txt in the source tarball for details. Hmmmm ... tarballs are mostly over my head. But it seems I had no cookies file, and the whole content of cookiesrc was "DEFAULT DENY"; so I edited it, and now I have : ===== [root@localhost .dillo]# ls cookiesrc dpi_socket_dir [root@localhost .dillo]# cat cookiesrc DEFAULT ACCEPT_SESSION [root@localhost .dillo]# ===== I hope that's right! -- Beartooth Neo-Redneck, Linux Evangelist FC 1, YDL 4; Pine 4.63, Pan 0.14.2; Privoxy 3.0.3; Dillo 0.8.4, Opera 8.0, Firefox 1.0.3, Epiphany 1.0.4 Remember that I have little idea what I am talking about.

May 12, 2005

Re: [Dillo-dev]Cookie control?

by Bjoern Brill

On Wed, 11 May 2005, beartooth wrote: > Where does Dillo store cookies? Is there hope of a setting for "treat all In ~/.dillo/cookies . > cookies as session cookies"? Put a "DEFAULT ACCEPT_SESSION" line in ~/.dillo/cookiesrc . Consult doc/Cookies.txt in the source tarball for details. HTH, Bjoern Brill -- Bj"orn Brill <brill(a)fs.math.uni-frankfurt.de> Frankfurt am Main, Germany

May 11, 2005

[Dillo-dev]Cookie control?

by beartooth

Where does Dillo store cookies? Is there hope of a setting for "treat all cookies as session cookies"? -- Beartooth Neo-Redneck, Linux Evangelist FC 1&3, YDL 4; Pine 4.63, Pan 0.14.2; Privoxy 3.0.3; Dillo 0.8.4, Opera 8.0, Firefox 1.0.3, Epiphany 1.0.4 Remember that I have little idea what I am talking about.

May 11, 2005

[Dillo-dev]Some patch files for Korean, Russian and Japanese

by JHB

Hi, I've prepared some patch files for other languages except European (LATIN-1). These patch files work fine with some other languages including Korean, Russian, and Japanese than European languages(LATIN-1). These patches work well with dillo 0.80.4 to 0.80.5-pre (CVS). If it is looked good as you see, please change the link on your web site as follow: http://myhome.naver.com/~ziolo/dillo_patch.html I hope these small patch files help someone to enjoy dillo. Sincerely, Ziolo PS. I’m not professional computer programmer, so I’ll be pleasured if next dillo would supports other languages including my own language (Korean) in main source stream ------------------------------------------------------------------------ 네이버 :: 똑! 소리나게 바뀐 네이버 메일을 만나보세요. http://mail.naver.com/

May 1, 2005