September 2003 - Dillo-dev - lists.mailman3.com

[PATCHES] hand_cursor and image_popup, some remarks

by Frank de Lange

[ Jorge, your mailserver is not healthy... I tried to send this 3 times without success, so it goes to the list instead... ] On Mon, 8 Sep 2003 11:13:32 -0400 (CLT) Jorge Arellano Cid <jcid(a)softhome.org> wrote: > You're right. In that case it causes more troubles than help. > Please send me the patch to commit it to CVS. It is part of the tab/frame patch... It uses the document abstraction. In non-patched Dillo, it would be something like: if(bw->nav_stack_ptr != -1) gtk_widget_grab_focus(GTK_BIN(bw->docwin)->child); else gtk_widget_grab_focus(bw->location); Question is, how much sense does this make in a single-document window? When the window is created, the navigation stack is empty, so focus will always be on the location bar... By the way, there are some problems with 'hidden focus' in Dw. These problems only become directly noticeable in the tab/frame patched version, but they are present in CVS Dillo as well. To see the problem: 1. start dillo on a longish directory listing or a long document (so that the vertical scroll bar appears) 2. use up and down arrow keys to scroll the document. This works in unpatched Dillo. In the (current) patched version, it only works AFTER pressing the UP key once... 3. press SHIFT-TAB twice. Focus is now set on... something. Something invisible. There is no visible focus cue 4. press DOWN key. Nothing happens, no matter how often you press it... Same for TAB, ENTER, RIGHT, ... 5. press UP or SHIFT-TAB or LEFT key. Focus is now on the document, and scrolling keys work as they should. The problem does not show (in patched or unpatched Dillo) when in fullscreen mode. I've searched for the cause of this problem, but have not yet found it. > Clashing with other apps. is almost unavoidable (unless we > clone), but we have chosen to rely over an underlying cognitive > model for our UI. It has been very succesful, and praised! > > Now, as a matter of serendipity :), the bouncing keyboard may > have shown us both a better way. If we make Ctrl-L focus the > location bar (as Ctrl-U does now) and a second Ctrl-L to clear > it, that may be a good choice. Well, Ctrl-U is generally used for 'clear entry' in GTK1 (not in GTK2 though), so I think it is best to use it for that purpose in Dillo as well. For GTK2, following the toolkit default bindings is the logical thing to do. Even better is to allow users to decide for themselves which bindings they want. GTK2 does not allow this by default, but it can be re-enabled. No matter how well thought out a model is, the user should *always* be able to override the designer's defaults. Even if that user messes up a perfectly thought out cognitive model. That is also why I make just about everything user-selectable using preferences with sane default values. So, one of my next goals will probably be to implement user-selectable accelerators in Dillo... Based on GTK's default mechanisms for doing such a thing. > Of course, a more orthogonal way to do it, is the same > functionality, but inside the location popup. But please > experiment with the above suggested idea, and tell me your > findings. Generally I find that popup menu's are more a hinder than a help. This is more of a problem with window managers which do not correctly manage them than with the basic concept of popups, but as the state of the art currently stands I try to avoid them as much as possible. I will therefore try to implement the functionality of Dillo's transient popups (find and open url) in the main window, the former probably in the status bar and the latter in the location bar. And, of course, make a preference to allow the user to choose which version to use - popup or main window. As for using CTRL-L for clearing the location bar, I do not think this is a good idea. But, it is not for me to say it is a bad idea either. > PS: If you send me the requested patches, chances of fast commit > are very high Attached two patches, one for hand_cursor, one for right_click on image. Some remarks: The 'image save as' function in the image popup works, but is dependent on the dpi for the actual save function. That dpi (or, rather, wget) does not know how to handle some link types (eg. file: links), so it will fail on those. The hand_cursor patch works fine, but input_images do NOT work as stated in my previous message. Reverse the patch to dw_button.c to get them back to live... Maybe the image popup should be a submenu on other popups? See the frame/frameset popups (in the tab/frame patch) for an example of what I mean. That way, the image can also be accessed in links (and, maybe, in input images, even those currently do not react to RMB-clicks for obvious reason...) Please be aware of the fact that I will have to keep on adding these patches to the tab/frame patch while the document abstraction has not been committed to CVS... So I will have to patch my own patches, not something I want to keep on doing too long... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Sept. 9, 2003

Re: [Dillo-dev] Two small things that need implementation...

by Thorben Thuermer

On Tue, 2 Sep 2003 10:08:33 -0400 (CLT) Jorge Arellano Cid <jcid(a)softhome.net> wrote: > > Hi, > > These things have waited for a long time unimplemented. Both > don't require much code, but some knowledge: > > 1.- A right-click popup for images > (we have all the code and functions of it, what we need is > to hook an empty popup to right-click over images). That's imho a VERY essential feature... and i have it in my dillo, for months now... i'm using this patch: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-January/000038.html it has some rough edges, but it works and it's been around for quite some time now (long enough so somebody might have fixed the bugs?)... > Cheers > Jorge.- Greetings, Thorben

Sept. 9, 2003

Re: [Dillo-dev] Feature request - Open tab in background

by Frédéric Bothamy

* Colin Michael Yates <colin.yates(a)orange.net> [2003-09-08 11:49] : > Hi, > > Is it possible to open a tab in the background, instead of it always > getting focus? > > I generally go to a forum (for example), and open the messages that I > want to read in a seperate tab, when I have selected all the messages I > want to read, I then go through them one by one. > > Is this feature already implemented, or does anybody with more C coding > skill then me want to implement it :) It is already implemented if you use Franke de Lange's "tab+frame" patch (I don't know about the current CVS status). Just set the option tab_load_in_background to YES in the dillorc file (either /etc/dillorc or ~/.dillo/dillorc) (default value is NO). Fred

Sept. 8, 2003

Feature request - Open tab in background

by Colin Michael Yates

Hi, Is it possible to open a tab in the background, instead of it always getting focus? I generally go to a forum (for example), and open the messages that I want to read in a seperate tab, when I have selected all the messages I want to read, I then go through them one by one. Is this feature already implemented, or does anybody with more C coding skill then me want to implement it :) Cheers, Colin

Sept. 8, 2003

FW: [Dillo-dev] How do your clear the dillo cache

by Ronald W. Henderson

Folks: Let me be more accurate with my problem: The graphic images (which are *.png files) are the ones which are cached. If I hit the reload botton the html code updates ok but the graphics don't. I need to start and stop Dillo for the graphic images to be updated. Folks: How do you clear the Dillo cache? I am using dillo (0.7.3) to view an updated local html file: "file:xxx.html". I have to stop and restart dillo to see the updates. The "Reload" Button or open file menu option just keeps loading the cached pages... Thanks.. _______________________________________________ Dillo-dev mailing list Dillo-dev(a)lists.auriga.wearlab.de http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

Sept. 7, 2003

How do your clear the dillo cache

by Ronald W. Henderson

Folks: How do you clear the Dillo cache? I am using dillo (0.7.3) to view an updated local html file: "file:xxx.html". I have to stop and restart dillo to see the updates. The "Reload" Button or open file menu option just keeps loading the cached pages... Thanks..

Sept. 7, 2003

Check for unterminated quoted strings

by Andreas Kemnade

I found this tag on pages at www.reichelt.de: <A HREF="Info.html?P1mqhKwQAQsAAHVmTEY+Suche+0+50+LM%20324%20D%20SMD+lm324" onmouseover="return overlib('<TABLE><TR><TD><font face=\'Verdana, Arial, Helvetica, sans-serif\' size=1 color=\'#FFFFFF\'></font></TD></TR></TABLE>',CAPTION,'LM 324 D SMD');" onMouseout="return nd();"> It looks like correct html to me or am I wrong? But dillo does not render it correctly. It is rendered like this: <A HREF=... onmouseover="...TABLE"><TR><TD>... So the check for unterminated quoted strings confuses the table handling. With a small change to html.c, it will be rendered correctly: /* Skip over quoted string */ buf_index++; buf_index += strcspn(buf + buf_index, - (ch == '"') ? "\">" : "'>"); + (ch == '"') ? "\"" : "'"); if ( buf[buf_index] == '>' ) { /* Unterminated string value? Let's look ahead and test: * (<: unterminated, closing-quote: terminated) */ I don't know why that check is there. Does HTML allow quoted strings to be not terminated? I guess there is a better solution than mine. Greetings Andreas Kemnade

Sept. 6, 2003

Re: [Dillo-dev] Re: [Patch] Search feature and more

by Jorge Arellano Cid

Hi Johan! It took a long time to analyze the three patches, but finally here we are: [I'm not quoting the previous email bacause it got too big and can be easily found at the web archives] The patches were: 1.- Made main document window grab focus on startup and after open url. Commited! In the meanwhile, Owen taylor answered my post to GTK-list and it become clear that the "Nirvana"-widget issue is solved in GTK2. Thanks a lot for your comments on this. You may find interesting to read the answer: http://mail.gnome.org/archives/gtk-list/2003-June/msg00307.html 2.- Accelerator keys. Huh! These are to be picked very carefully! It took me a lot of work to figure simple mnemonic shortcuts that integrate well with the UI model. The chosen ones are: Shortcut Mnemonic ------------------------------------------------------------ Ctrl-U "Ctrl-URL" (to edit the URL) Ctrl-H "Ctrl-Hide" (Hide/show controls) Ctrl-S "Ctrl-Search" (search the web) Ctrl-R "Ctrl-Reload" (reload current page) ------------------------------------------------------------ (integrating with the existent) Ctrl-L "Ctrl-Location" (enters a new URL) Ctrl-F "Ctrl-Find" (find text) Ctrl-Q "ctrl-Quit" (quit window) (Note: Ctrl-S is not implemented yet) These should provide good defaults as Havoc suggests. Please give them a test drive to get the feel. Ah, while thinking of it, I thought it'd be good to add the ESC key as a way to switch from the location box into the main window, it can be easily done with the key handler you wrote. 3.- Search feature Uncommited yet, the functionality is perfect. Just some minor details in the UI: A small icon to the right of the location box (hideable as the othe icons), with Ctrl-S as shortcut, that pops up a dialog (just as find text and open url). The icon's tooltip can be "Search the Internet", "Search the Web", or something better :-) The final touches: * While working on the location bar shortcuts, I thought it'd be good to add the ESC key as a way to switch from the location box into the main window, it can be easily done with the key handler you wrote. * It'd be also good to add middle-click over the clear-url button, as a way to "paste-push" an URLs. Instead of the the current three step sequence: - Press clear-url - Paste URL - Press enter I carefully considered your previous email and this model should take good care of the several points we talked about. Half of the work is on CVS now, and the above mentioned details are pending. Please send me a new patch with the modifications to fast-track-commit-it-in! Best Jorge.-

Sept. 5, 2003

Re: [Dillo-dev] Something to think about: free vs. proprietary OSes

by Andreas Schweitzer

Hi, On Thu, Sep 04, 2003 at 01:59:51PM +0000, Phil Pennock wrote: > On 2003-09-04 at 00:11 -0700, Kelson Vibber wrote: > > Where do we draw the line... and why? Compatibility? Ideology? And to throw in even more flamebait (which I will not defend :-) ... ) The BSD's are not really free software in the meaning of FSF's definition ;-) ... To me, it doesn't matter, though. > Suggestion: the point where conditional code compilation is being > scattered throughout the code. On the other hand, it is truely beneficial for producing clean code (i.e. not lots of ifdefs) when trying to compile on largely different platforms. I speak from experience when I say that trying to compile with a different compiler (or on a different platform) usually reveals bugs. So far, dillo is mainly compiled with gcc - I'm not sure about the various solaris efforts, though. I personally once tried IBM's xlc compiler on AIX. It mostly worked and resulted in a few minor code cleanups, that went into dillo. Hmmm, I really should try Intel's IFC or tendra at some point .... Anyways, that alone would make a native Windows port at least interesting. Not that I have any experience with Micorsofts C-compiler, nor that I know about Windows Posix compliance (didn't some Windows version receive some sort of Unix specification ?). Still, I'm sure things will show up that may be real bugs. And these are just the purely technical and objective issues that came up when reading the recent mails on this list :-) > Jorge: I've been at a conference and now am on a different desktop, so > am not easily able to test the alternate fix for FreeBSD and the IO > errors -- since Andreas reports that things work fine for him now, I'll > take it on faith that the problem has been resolved -- thanks for the > prompt response! It doesn't lock up any more. Sometimes, I'm not sure if there are still issues or not. It simply may be the local network like DNS servers etc. As I said, I'll report problems once I'll find them :-) Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Sept. 5, 2003

Re: [Dillo-dev] Something to think about: free vs. proprietary OSes

by Andreas Kemnade

On Thu, 4 Sep 2003 13:59:51 +0000 Phil Pennock <phil.pennock(a)globnix.org> wrote: > (I got forced onto a new box and made a policy decision to go GTK2 only; > I had a brief look at porting to GTK2 and got more stuff compiling, but > part way through realised that I'd messed up badly so dumped that. I > won't have time to look at this again for a while -- sorry) > -- familar linux 0.7 has a gtk2 dillo. gtk1.2 is not installed by default. So there should be patches for a gtk2 dillo somewhere. Perhaps that can be used as a starting point. Greetings Andreas Kemnade

Sept. 5, 2003