August 2003 - Dillo-dev - lists.mailman3.com

Frame support in tab patch, found a bug...

by Frank de Lange

Hi'all, I just noted an interesting typo in the frame support code, which makes some framed sites look really weird. I'll fix in in the next patch, but (as it is a very simple thing to change) you might want to fix your copy asap. in html.c, in the function Html_tag_open_frameset():1971 change: gint col = *frame_number / html->stack[html->stack_top].frameset_cols; gint row = *frame_number % html->stack[html->stack_top].frameset_cols; to: gint col = *frame_number % html->stack[html->stack_top].frameset_cols; gint row = *frame_number / html->stack[html->stack_top].frameset_cols; So, in essence, switch the '/' and '%' operators. It will still make a mess of the layout as it does not obey frame sizing, but at least it is a geometrically correct mess... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Segfaults with png files

by William Trenker

I built Dillo 0.7.2 from source and it works great except when there is a png file on the web page I'm browsing. In that case, Dillo segfaults with this message on the command line: Png_error_handling: Application was compiled with png.h from libpng-1.0.12 Segmentation fault What have I done wrong? Can you give me any suggestion how to fix this? Thanks, Bill

Aug. 5, 2003

Re: [Dillo-dev] Question about frames (have them working, but...)

by Frank de Lange

On Tue, Aug 05, 2003 at 02:44:08PM +0300, madis wrote: > > On Tue, 5 Aug 2003, Frank de Lange wrote: > > > http://www.geocities.com/ikbenfrank/dillo-20030804-tabs.patch.gz > > dillo with this patch shows only noframes part on some framed sites: > > http://www.hot.ee/klubipegasus/ > http://www.lamlaw.com/ That is caused by the extra <body> tag these sites add (lamlaw has a complete body section - something a frame document should not have, http://www.hot.ee/klubipegasus/ has an extra body tag in the noframes section.) The specs say something like this: Use the <frameset> tag in lieu of a <body> tag in the frame document. You may not include any other content except valid <head> and <frameset> content in a frame document. Combining frames with a conventional document containing <body> may result in unpredictable browser behavior. So, again (this is to the list), should Dillo follow the specs - and thus produce unwanted results - or try to work around the cruft some sites serve? Fixing this would be relatively easy, and the fix can be optional (--enable-pedantic or --enable-quirks or whatever...) By the way, some sites check the browser string to decide what type of content to send, these may also send non-frames content. Same goes for sites which use Javascript to test for browser versions. So even if Dillo has full frame support one day, it can still happen that a site does not serve it (functional) frame documents... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Frank de Lange

On Tue, Aug 05, 2003 at 10:23:12AM +0200, Frank de Lange wrote: > On Tue, Aug 05, 2003 at 10:04:35AM +0200, Jens Arm wrote: > > Hi > > > > Great work the tab and frame support! > > > > If I try to open the reiserfs-Homepage (www.namesys.com) > > Just an addition to my previous reply... > > Namesys' page does show up as expected (two frames), but navigation does not > work as it should yet. The current version of the frames patch ignores the > <base target='main'> tag in the left frame, so all content ends up in the left > frame instead. This will be fixed in the next version of the patch. Yet another addition... Namesys' page uses a <base> tag without a href: (http://www.namesys.com/menu.html: ... <base target="main"> ... This is in violation of the HTML specs (href is a required parameter for <base>). What should Dillo do in this case? Currently it only checks for the target parameter after it has found a href in the tag (literal interpretation the definition of <base>), but this breaks pages like Namesys' which violate the standard. I can: a) unconditionally change the code so these pages work b) add a compile option (--pedantic-mode or --quirks-mode or whatever) to disable/enable these changes c) leave it the way it is For users a and b are the best choices, for developers c is the best. It is probably infeasible to trap all the crufty HTML out there, Namesys' site alone is good for I don't know how many problems... I personally prefer b, which gives everyone a choice. Choice is good. Any thoughts? Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Frank de Lange

On Tue, Aug 05, 2003 at 10:04:35AM +0200, Jens Arm wrote: > Hi > > Great work the tab and frame support! > > If I try to open the reiserfs-Homepage (www.namesys.com) Just an addition to my previous reply... Namesys' page does show up as expected (two frames), but navigation does not work as it should yet. The current version of the frames patch ignores the <base target='main'> tag in the left frame, so all content ends up in the left frame instead. This will be fixed in the next version of the patch. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Frank de Lange

On Tue, Aug 05, 2003 at 10:04:35AM +0200, Jens Arm wrote: > Hi > > Great work the tab and frame support! Thanks... > If I try to open the reiserfs-Homepage (www.namesys.com) > only the menu-frame is shown. > Here is the output of dillo: > > [tux@tux tux]$ dillo > Setting locale to C... > dillo_dns_init: Here we go! > Enabling cookies as from cookiesrc... > Nav_open_url: Url=>about:splash< > Nav_open_url: Url=>http://www.namesys.com< > Dns_server [0]: www.namesys.com is 0x81180b0 > Connecting to 212.16.7.65 > HTML warning: the TITLE element must be inside the HEAD section > Nav_open_url: Url=>http://www.namesys.com/menu.html< > Connecting to 212.16.7.65 > HTML warning: Invalid HTML syntax: too many <frame> tags in <frameset> > > > This I get at other sites, too. It works here... Did you use the latest CVS version of Dillo, did the patch aplpy without problems, do you use a filtering proxy which does weird things to the HTML? Namesys' page comes up in two frames. Size of frames is wrong (but that was to be expected), content is OK. This is what I get with 'View Page Source' on Namesys' page: <html> <TITLE>NAMESYS</TITLE> <frameset cols="160,*" frameborder=0 framespacing=0 border=0> <frame name="menu" src="menu.html" scrolling="auto" noresize border=0 frameborder=0 marginheight=0 marginwidth=0> <frame name="main" src="content_table.html" noresize border=0 frameborder=0 marginheight=0 marginwidth=0> </frameset> </html> So yes, that IS invalid HTML (TITLE tag outside of HEAD), but Dillo renders it OK here. It tells me about the errors in the page: Nav_open_url: Url=>http://www.namesys.com< Connecting to 212.16.7.65 HTML warning: the TITLE element must be inside the HEAD section Nav_open_url: Url=>http://www.namesys.com/menu.html< Nav_open_url: Url=>http://www.namesys.com/content_table.html< Are there any others out there who have problems like this? Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 5, 2003

Re: [Dillo-dev] [PATCH] version 7 of tab patch is ready

by Jens Arm

Hi Great work the tab and frame support! If I try to open the reiserfs-Homepage (www.namesys.com) only the menu-frame is shown. Here is the output of dillo: [tux@tux tux]$ dillo Setting locale to C... dillo_dns_init: Here we go! Enabling cookies as from cookiesrc... Nav_open_url: Url=>about:splash< Nav_open_url: Url=>http://www.namesys.com< Dns_server [0]: www.namesys.com is 0x81180b0 Connecting to 212.16.7.65 HTML warning: the TITLE element must be inside the HEAD section Nav_open_url: Url=>http://www.namesys.com/menu.html< Connecting to 212.16.7.65 HTML warning: Invalid HTML syntax: too many <frame> tags in <frameset> This I get at other sites, too. Jens

Aug. 5, 2003

Re: [Dillo-dev] Question about frames (have them working, but...)

by Andreas Schweitzer

Hi, <size problems> > <...> If anyone has any > bright ideas on how to assign widgets sizes which are relative to their > container, speak up... Or, if anyone has already created (or at least thought > about creating) a 'frameset' widget, please let me know. No need to re-invent > the wheel... About a week ago I decided to look into Frames with your tabs patch put was overwhelmed by my non-knowledge of GTK. Luckily I saw your note "Now working on frames" in one of your e-mails and I figured at the rate Frank produces code I will never have anything ready ;-) And the description sounds great ! Great work ! I'll try it out now. Anyways, getting to the point. What about tracking the sizes of the widgets ? E.g. putting the sizes in DilloDoc And also maybe putting the parent widget in DilloDoc ? That way one could "cascade" down the sizes. I haven't looked at the new patch though - just some ideas. The problem might be that all these sizes would only be calculated sizes and that GTK may calculate the sizes differently and hence may be getting different rounding errors. A lot of resizing may be getting the actual sizes and the calculated sizes heavily out of sync. One would have to see. > The patch is made against 20030804 CVS. It can be downloaded from the usual > (ad-happy, but...) Geocities site: > > http://www.geocities.com/ikbenfrank/ > > More specifically, it can be found here: > > http://www.geocities.com/ikbenfrank/dillo-20030804-tabs.patch.gz > size: 53262 bytes (gzipped, as downloaded) > 220519 bytes (uncompressed) > md5sum: 5c218077382d6c6e7300f1dd7d41e024 (gzipped, as downloaded) > f6242c4f01f0eed60645db91a8882b2c (uncompressed) And again at http://www.hs.uni-hamburg.de/~stcd102/dillo-20030804-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Aug. 5, 2003

Re: [Dillo-dev] Question about frames (have them working, but...)

by Melvin Hadasht

Hi Frank, You wrote: > If anyone has any > bright ideas on how to assign widgets sizes which are relative to their > container, speak up... I don't know Dillo internal widgets, but Gtk provides the GtkFixed widget where you can specify where the widgets are to be positioned. The API reference says that in that case the size is also fixed (but it does not say how). Check also the Gtk2 reference for this widget, as it looks more complete there. HTH -- Melvin Hadasht

Aug. 4, 2003

[PATCH] version 7 of tab patch is ready

by Frank de Lange

Oops... I seem to have messed up the subject of my last message. Anyway, as stated... the next version of my tab patch is ready, get it at http://www.geocities.com/ikbenfrank Read my last message for more info... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Aug. 4, 2003