July 2003 - Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Andreas Schweitzer

> So, next version is now on the site: > > http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz > 40887 bytes > 20dffde9c0e5f2134492e138ee707cdd (as is) > 09b454800f1b53bd83428a2b62d3e618 (uncompressed) And again on http://www.hs.uni-hamburg.de/~stcd102/dillo-20030701-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Frank de Lange

On Tue, Jul 01, 2003 at 04:07:21PM -0700, Victor Sahlstedt wrote: > I commented out the stuff in the function preceeding gboolean hide_tabs and it compiled. > > Great work by the way, I find non-tabbed browsers hardly usable for every-day-usage and as > my window manager of choice is the tabless evilwm it's been a pain uptil now. > > Tack! > > - Victor Sigh... I put the wrong version of the patch on the site... the version on the site has the definition in the old place. So, next version is now on the site: http://www.geocities.com/ikbenfrank/dillo-20030701-tabs.patch.gz 40887 bytes 20dffde9c0e5f2134492e138ee707cdd (as is) 09b454800f1b53bd83428a2b62d3e618 (uncompressed) If the previous version worked for you, there is no need to upgrade as the changes are only 'code-cosmetical'... As always, keep an eye on the site for the latest version. This patch was made against yesterday's CVS (20030701). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Frank de Lange

On Tue, Jul 01, 2003 at 02:36:25PM -0700, Victor Sahlstedt wrote: > Hi Frank, > I get the following error while compiling the patched Dillo (GCC 2.95.3); > > tab.c: In function `a_Tab_visibility_update': > tab.c:317: syntax error before `hide_tabs' > tab.c:328: `hide_tabs' undeclared (first use in this function) > tab.c:328: (Each undeclared identifier is reported only once > tab.c:328: for each function it appears in.) > gmake[3]: *** [tab.o] Error 1 > gmake[2]: *** [all-recursive] Error 1 > gmake[1]: *** [all-recursive] Error 1 > gmake: *** [all] Error 2 This is with the latest version of the patch (the one mentioned in my last message)? Check if the function begins with: (src/tab.c:301-307) /* * set visibility of tab bar */ void a_Tab_visibility_update(BrowserWindow *bw) { gboolean hide_tabs; See, that is where hide_tabs is declared. Your line numbers are off by 10. Makesme wonder if you have the right version... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

July 1, 2003

Re: [Dillo-dev] [PATCH] new version of tab patch, fixes segfault on bookmark

by Andreas Schweitzer

> I uploaded a new version of the patch to the geocities page (block those > popup/under/down/everywhere ads to your heart's content...): > > http://www.geocities.com/ikbenfrank/dillo-20030630-tabs.patch.gz Mirror on http://www.hs.uni-hamburg.de/~stcd102/dillo-20030630-tabs.patch.gz Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

July 1, 2003

[PATCH] new version of tab patch, fixes segfault on bookmark

by Frank de Lange

Hey'all, Had a minute to spare and a wireless connection in a (very smoky... a filty habit it is indeed...) coffee shop in Cambridge/UK, so I fixed the buglet which made the tabbed version of Dillo segfault on bookmark add. I also cleaned up the code a little, moved some things around to satisfy C99, removed generated files from the patch, etc. No big functional changes (unless you call 'not crashing anymore on bookmark add' a functional change...) I uploaded a new version of the patch to the geocities page (block those popup/under/down/everywhere ads to your heart's content...): http://www.geocities.com/ikbenfrank/dillo-20030630-tabs.patch.gz 41210 bytes 4e96e122819d9d61a61a07a2cb8557e4 (as is) 27b9923f410a28224957fa40474c901a (uncompressed) I removed the old patch file, and replaced it with a note telling people to download the latest version instead. In general, I keep the patch file on the geocities site up to date, so look there (http://www.geocities.com/ikbenfrank/) for the last version before submitting bug reports to me/to the list. Also, I removed the generated files (configure, makefile.in) from the patch. So, DO NOT FORGET TO RUN ./autogen.sh after patching! The patch is against the 20030630 CVS version of Dillo. As long as there are no big changes to CVS which touch the tab patch, I will try to follow CVS releases. If this should change before the tab patch is committed, I'll keep to the last CVS release which works with the patch. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

July 1, 2003

chinese spport patch for 0.7.2 and dillo's bug.

by ronnie

hi all! 1)I have make dillo-0.7.2 suport chinese .where i put the patch? 2)when you clicking mouse and then draging it to copy something will cause the dillo crash.why?

July 1, 2003

chinese patch and dillo's bug

by ronnie

hi all! 1)I have make dillo-0.7.2 suport chinese .where i put the patch? 2)when you clicking mouse and the draging it to copy something will cause the dillo crash.why? ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Sincerely Yours Xingqiang Wang Embedded Software Division. Neusoft Middleware Technologies Company Neusoft Park, Hun Nan Industrial Area, New & High-Tech Development Zone, Shenyang 110179, PRC TEL:+86-24-83665518 E-mail:wang_xq@neusoft.com Http://www.neusoft.com

July 1, 2003

selection bug

by Joe Crayne

click on the image in this page: <html> <body> <a href="http://www.google.com"> <img src="http://www.google.com/images/logo.gif"></a> </body> </html> Dillo will segfault. Apparently, this is because there is no selectable content in the page. a_Dw_ext_iterator_new() is returning NULL at selection.c:152 selection->link = a_Dw_ext_iterator_new (it); selection->link_char = Selection_correct_char_pos (selection->link, char_pos); selection->link_number = link; ret = TRUE; So I tried a naive quick fix: selection->link = a_Dw_ext_iterator_new (it); if( selection->link ) { selection->link_char = Selection_correct_char_pos (selection->link, char_pos); selection->link_number = link; ret = TRUE; } else ret = FALSE; This just moved the bug elsewhere because dillo then segfaulted when I clicked the image and held the button down and moved off of it. Selection_switch_link_to_selection() expects a non NULL iterator.

July 1, 2003