March 2003 - Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] another bug in bm_serv ?

by Jorge Arellano Cid

On Sun, 16 Mar 2003 slymer(a)slymer.org wrote: > On Sun, 16 Mar 2003 13:00:51 +0100 > Andreas Schweitzer <Andreas.Schweitzer(a)hs.uni-hamburg.de> wrote: > > > or having the single quote (') > > Hmm I have tested further a bit, it seems that it's because of > the ('). In fact it is the (')! Someone pointed me that sometime ago and I told him that it was a matter of making character stuffing for the (') in dpi commands! This is very simple to do. Please make the patch and send it to me, as I'm working other issues now. I'll forward the email I sent. Well, if I find it :) Cheers Jorge.- PS: I'm working on a segfault due to the new selection code. Sebastian: I'll report itou as soon as I get to the point of isolating/defining the problem.

March 16, 2003

Re: [Dillo-dev] ipv6 and dns threads

by Damien Couderc

Hi all, this time i take care to cc the list :) This mail include the complete reply i sent to Jorge plus some comments added since i looked recent changes. On Sun, 16 Mar 2003 02:21:52 +0100 Damien Couderc <coudercd(a)nerim.net> wrote: > Hi Jorge :) > > First i'm sorry to be a bit late to reply, i'm really busy with a > new project actually. > > For the sparc64 we use gcc 2.95.3 by default, but we also have a > port of 3.2.2 (but i don't remember if i tested with 3.2.2 so i'll > check it). Still not done. > > > You will found at the following URL patches from the openbsd > > > port: > > > http://www.openbsd.org/cgi-bin/cvsweb/ports/www/dillo/patches/ > > > > > > Some of them fix ipv6 and threaded name resolution bugs. > > There're modified versions for those patches in our CVS now! Yep dns.c seems okay for me :) > > In the specific case of the IPv6 one, I don't understand why: > > > > - dns_server[i].th1 = (pthread_t) -1; > > + dns_server[i].th1 = GPOINTER_TO_INT((pthread_t) -1); > > because 'dns_server[i].th1' is of type 'pthread_t', not int! > > This was fixing a warning of the compiler, so not really important. > It is also no longer used as we comment G_DNS_THREADED in the latest > patches. > > > In the case of the http.c patch, I modified it a bit because > > 'sa_len' is not supposed to be used from sockaddr type (at least > > that's what libc's texinfo says). > > Oh yes linux seems to not have it. > You could give a look to SA_LEN() macro which is in libc but of > course it is linux specific. > Without starting flamewar you should not take linux as (only) > reference if you want to make something portable. Okay so, i've took some time to read your changes and something took my attention : IO/http.c : socket_len = sizeof(struct sockaddr_in6); The fact is that the structure sockaddr_in6 can be really big and cause problems and i'm not sure that the use of sizeof is safe. I think the best way should be to use a define that use sa_len on bsd compliant systems and the SA_LEN() macro on linux. Damien

March 16, 2003

Re: [Dillo-dev] another bug in bm_serv ?

by slymer＠slymer.org

On Sun, 16 Mar 2003 13:00:51 +0100 Andreas Schweitzer <Andreas.Schweitzer(a)hs.uni-hamburg.de> wrote: > or having the single quote (') Hmm I have tested further a bit, it seems that it's because of the ('). -- Registered Linux user #298569 It's time to boot, do your boot ROMs know where your disk controllers are?

March 16, 2003

Re: [Dillo-dev] another bug in bm_serv ?

by Andreas Schweitzer

On Sun, Mar 16, 2003 at 01:21:11PM +0200, slymer(a)slymer.org wrote: > > I think bm_serv has a problem adding a bookmark when the title > of the page is more than 8 chars in length. or having the single quote (') ? > For example, I have visited the LAME "encoder" home page and I > wanted too bookmark it. The title of the resulting bookmark is > "LAME Ain" instead of "LAME Ain't an MP3 Encoder". Also if after I can reproduce this. > adding it I try to set the name of the bookmark right bm_serv > will act a bit funky by using 100% of my CPU and not sending the > results of the modify command to dillo. I have to close dillo I cannot reproduce this, though. Latest version of bm_srv12.c on a Linux 2.4.20, gcc3.2.2 system. Cheers Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

March 16, 2003

another bug in bm_serv ?

by slymer＠slymer.org

I think bm_serv has a problem adding a bookmark when the title of the page is more than 8 chars in length. For example, I have visited the LAME "encoder" home page and I wanted too bookmark it. The title of the resulting bookmark is "LAME Ain" instead of "LAME Ain't an MP3 Encoder". Also if after adding it I try to set the name of the bookmark right bm_serv will act a bit funky by using 100% of my CPU and not sending the results of the modify command to dillo. I have to close dillo for bm_serv to behave normaly again and also if I check the bookmarks I see that modifying the bookmark's name worked afterall. -- Registered Linux user #298569 Let me do my TRIBUTE to FISHNET STOCKINGS ...

March 16, 2003

Re: [Dillo-dev] ipv6 and dns threads

by Jorge Arellano Cid

Damien, > You will found at the following URL patches from the openbsd port : > http://www.openbsd.org/cgi-bin/cvsweb/ports/www/dillo/patches/ > > Some of them fix ipv6 and threaded name resolution bugs. There're modified versions for those patches in our CVS now! In the specific case of the IPv6 one, I don't understand why: - dns_server[i].th1 = (pthread_t) -1; + dns_server[i].th1 = GPOINTER_TO_INT((pthread_t) -1); because 'dns_server[i].th1' is of type 'pthread_t', not int! In the case of the http.c patch, I modified it a bit because 'sa_len' is not supposed to be used from sockaddr type (at least that's what libc's texinfo says). Well, the important thing is to test them, as I don't have a *BSD machine here. Thanks Jorge.-

March 15, 2003

[Patch]: SpamSafe and <base href=..> bug fix

by Melvin Hadasht

Hi, The SpamSafe (-l command line) option is meant to refrain Dillo from retrieving remote resources (images). This works unless the original HTML contains a <base href=...> entity. In which case, the remote resources are unconditionally retrieved. In a older message (Message-Id: <20030221093243.435de32f.melvin.hadasht(a)free.fr>), I posted a corresponding test case. The attached patch fixes this misbehaviour by transmitting the URL_SpamSafe flag to the new BaseURL. The patch is against current CVS. Cheers. -- Melvin Hadasht

March 15, 2003

dillo officially supported in Sylpheed-Claws

by Melvin Hadasht

Hi, Current cvs version of Sylpheed-Claws mail client (0.8.11claws14) officially supports Dillo to"safely" view html mail within the mail client window using the embedding facility of Dillo and a plugin technique in Sylpheed-Claws. The forthcoming 0.8.12claws will be the first public release to provide the Dillo plugin. (no timeline known, but it's a matter of weeks). I wrote "safely" between quotes, because IMHO there is a bug in Dillo when using the "-l" (or SpamSafe) command line option, as I pointed out in a previous mail (Message-Id: <20030221093243.435de32f.melvin.hadasht(a)free.fr>). I'll shortly post a patch for it in this ML. Thank you for your work. Cheers -- Melvin Hadasht

March 15, 2003

Re: [Dillo-dev] dillo on FreeBSD with --enable-ipv6

by Harold Gutch

On Sat, Mar 15, 2003 at 02:14:45PM -0400, Jorge Arellano Cid wrote: > Considering that, I decided to commit a modified version of the > patch, but as I don't have a BSD machine to test, you'll have to > help me. Just get the code from the CVS and send some feedback! I just tested your version - it works fine, thanks! bye, Harold

March 15, 2003

Re: [Dillo-dev] dillo on FreeBSD with --enable-ipv6

by Jorge Arellano Cid

Hi there! On Sat, 15 Mar 2003, Harold Gutch wrote: > On Sat, Mar 15, 2003 at 02:08:29PM +0100, Andreas Schweitzer wrote: > > Hi, > > > > > when enabling IPv6 on FreeBSD, dillo completely stops to work. > > > With such a binary, not even IPv4 works anymore. I'm not really > > > > I think I expereineced this, too. But since I don't > > have an IPv6 connection, I didn't know, that IPv4 is > > still supposed to work. > > > > > sure if this is a bug in dillo, or if it's in FreeBSD, but the > > > third parameter to connect() apparently needs to be sizeof(struct > > > sockaddr), which it originally is not (in src/IO/http.c:307). > > > The attached patch makes dillo work again if I compile it with > > > IPv6-support. All of this might apply to the other BSDs as well, > > > and also to other OSes. Also, I don't quite think that this > > > patch should break anything, so it should be safe to apply it. > > That's wrong, I just noticed that my patch unbreaks IPv4, but it > still doesn't fix IPv6. I guess I only tried it with IPv4 > webservers just before :(. > > > > Compare to the patches for OpenBSD : > > http://www.openbsd.org/cgi-bin/cvsweb/ports/www/dillo/patches/ > > they have already been pointed to on this mailing list. And > > I think, your patch is essentially part of theirs ;-) > > Thanks for pointing me out to that! Will the according changes > be incorporated into dillo before the next release? I finally had some time to look at it, and I hesitate to include the patch as it is, because my texinfo documents for libc say: "The one piece of information that you can get from the `struct sockaddr' data type is the "address format designator". This tells you which data type to use to understand the address fully." so "sa_len" is out. Considering that, I decided to commit a modified version of the patch, but as I don't have a BSD machine to test, you'll have to help me. Just get the code from the CVS and send some feedback! Cheers Jorge.-

March 15, 2003