November 2003 - Dillo-dev - lists.mailman3.com

patch: toggle force_my_colors

by Paul Pelzl

Hi folks, I have attached a pair of Dillo patches. They add a toggle-able menu item to the right-button context menu, which enables/disables the force_my_colors preference on the fly. I find this useful for some occasional websites that Dillo renders rather poorly, as well as sites that simply choose a horrid color scheme. The first patch applies on top of Frank's monster patch v15; the second applies against Dillo CVS of 20031119. I hope others find it useful. Paul

Nov. 22, 2003

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with keywords and more...

by Paul Pelzl

On Fri, Nov 21, 2003 at 04:46:31PM +0100, Frank de Lange wrote: > The next version (15) of my tab/frame/keyboard navigation patch is > ready (see bottom of this message for download instructions). I've got a couple of early bugs to report: 1) when using kbnav to move from a link to an entry box in a form, the most recently selected link is not properly deselected. Example: google.com. 2) the "keywords" user pref is apparently not read in a robust manner. If I separate keywords by a newline instead of a space, I can generate a segfault upon typing any URL in the location bar. Other than that, it's looking pretty solid so far. I'll keep hammering... Paul

Nov. 22, 2003

Re: [Dillo-dev] Sigh... CVS out of sync 5 minutes after I upload my patches

by Indan Zupancic

> It is as if the devil plays with it... 5 minutes after I upload my > latest patches, CVS gets updated and the patch does not apply anymore. Oh so funny. :) I saw you updated your patch today, and the first thing I thought was: Why didn't Frank say that he used the CVS version of yesterday, because CVS didn't change for two days, and _if_ CVS would be updated today, there will be problems. So, the easy sollution is to rename your patch to "dillo-20031120-tabs.patch.gz" and everything will work just fine. Although not with the current CVS of course, but that will happen anyway if you wait long enough. Are the recent changes worth it to update your patch, that's the question. Apparently you already did that, but there is no reason to include the whole source. What Thorben said is exactly what my installer script does; the -D option is nice. Offtopic: Could you reply to the CVS offer from Trent Jarvi and say what you think about a CVS branch? See: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-November/001470.html I think a seperate CVS branch would be useful, one hosted by the same server as the official Dillo CVS, or an external one, like Trent's. Where doesn't matter much I guess. At least the patches are centralized then.

Nov. 21, 2003

Re: [Dillo-dev] Sigh... CVS out of sync 5 minutes after I upload my patches

by Thorben Thuermer

On Fri, 21 Nov 2003 22:41:25 +0100 Frank de Lange <frank(a)unternet.org> wrote: > Anyone who wants to try tab/frame patch no. 15 can download the CVS > source on which it is based from the patch site: > > http://www.geocities.com/ikbenfrank/dillo-200311191409.tar.gz cvs -d :pserver:anonymous@dillo.org:/sfhome/cvs/dillo co -D 'Nov 19 14:09 2003' dillo why not use CVS's features? </offtopic>, before we get a new development model discussion > Cheers//Frank Thorben

Nov. 21, 2003

Sigh... CVS out of sync 5 minutes after I upload my patches

by Frank de Lange

It is as if the devil plays with it... 5 minutes after I upload my latest patches, CVS gets updated and the patch does not apply anymore. Well, this time I was prepared for that. Anyone who wants to try tab/frame patch no. 15 can download the CVS source on which it is based from the patch site: http://www.geocities.com/ikbenfrank/dillo-200311191409.tar.gz This is the UNPATCHED CVS code that was used to create the patch. To get a working tabbed/frames/etc browser, download this tarball and the patch, then apply the patch. From now on I will always include the CVS code on which the patch was based to get around these irritating synchronisation problems. Indan, if you want to update your HTTPS patch, may I suggest you use this source code tarball instead of current Dillo CVS? This way we are less dependent on the state of CVS... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 21, 2003

latest commit: cleanup on glib ids

by Jorge Arellano Cid

Hi Sebastian! While making the latest patch (now in CVS), I finally had the time to track gtk_timeout_add, gtk_idle_add and g_io_add_watch inside gtk/gdk/glib sources. The interesting part is that after the related wrappers, they all end using g_source_add; this function uses hook_id (ghook.h) which gets the id from seq_id. :-) In short: seq_id starts from 1 and hook_id is largely used with zero as a non-used/non-active/non-valid value! I updated dillo accordingly and eliminated the uneasy feel of initializing a guint with -1 as an invalid value. Regards Jorge.-

Nov. 21, 2003

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with key\ words an more...

by billy＠idiom.com

Frank de Lange Fri, Nov 21, 2003 at 07:33:03PM +0100: > Your mail includes a weird 'reply-to' header, which points to my domain: > > Reply-To: 3FBE3357.3040003(a)unternet.org > > Please don't do that... I'd rather not get replies to mail I did not send > myself on a non-existing address... Sorry, that should have gone in the In-Reply-To, not Reply-To header. I was cutting and pasting, and pasted wrong. -- -billy

Nov. 21, 2003

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with key words an more...

by Frank de Lange

p.s... Your mail includes a weird 'reply-to' header, which points to my domain: Reply-To: 3FBE3357.3040003(a)unternet.org Please don't do that... I'd rather not get replies to mail I did not send myself on a non-existing address... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 21, 2003

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with key words an more...

by Frank de Lange

Billy wrote: >In src/prefs.h you specify DILLO_SPLASH as file:/usr/share/dillo/dillo.html >We don't install into that prefix. > > Oh, do you not? Then use the pref splash=file:/wherever/you/want/to/install/instead The next version of the patch will contain a more elegant solution to this 'problem'... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 21, 2003

Re: [Dillo-dev] [PATCH] Version 15 of tab/frame/kbnav/etc patch, now with key words an more...

by Billy

In src/prefs.h you specify DILLO_SPLASH as file:/usr/share/dillo/dillo.html We don't install into that prefix. I made 2 changes. Added a dep for prefs.h and a rule which fixes the splash path as well as changing DILLO_SPLASH to file%%PREFIX%%/share... It's an ugle Makefile hack, but I didn't want to wade through the morass of autoconf for the correct solution. --- src/Makefile.am Fri Nov 21 09:35:45 2003 +++ src/Makefile.am.orig Tue Nov 11 07:13:59 2003 @@ -1,9 +1,3 @@ -.fixed_splash_path: - cp prefs.h x && cat x | sed 's@%%PREFIX%%@$(prefix)@' > prefs.h && rm -f x - touch .fixed_splash_path - -prefs.h: .fixed_splash_path - AM_CPPFLAGS=-DDILLORC_SYS='"$(sysconfdir)/dillorc"' SUBDIRS = IO @@ -24,8 +18,6 @@ capi.c \ capi.h \ debug.h \ - doc.c \ - doc.h \ dw.h \ dw.c \ dw_aligned_page.c \ @@ -68,18 +60,12 @@ dw_tooltip.h \ dw_widget.c \ dw_widget.h \ - gtkframeset.c \ - gtkframeset.h \ findtext.c \ findtext.h \ selection.c \ selection.h \ - focus.c \ - focus.h \ web.c \ web.h \ - pagemark.c \ - pagemark.h \ progressbar.c \ progressbar.h \ dillo.c \ @@ -100,8 +86,6 @@ image.h \ misc.c \ misc.h \ - tab.c \ - tab.h \ interface.h \ interface.c \ history.c \ --- src/prefs.h Fri Nov 21 09:35:11 2003 +++ src/prefs.h.orig Sat Nov 15 14:13:03 2003 @@ -8,8 +8,6 @@ #endif /* __cplusplus */ #define DILLO_HOME "http://www.dillo.org/" -#define DILLO_SPLASH "file:%%PREFIX%%/share/dillo/dillo.html" - #define D_GEOMETRY_DEFAULT_WIDTH 640 #define D_GEOMETRY_DEFAULT_HEIGHT 550 @@ -19,15 +17,6 @@ #define DW_COLOR_DEFAULT_PURPLE 0x800080 #define DW_COLOR_DEFAULT_BGND 0xd6d6c0 -#define COMPRESS_COMMON_PREFIXES "index of ;re: ;fwd: ;www.;welcome to ;the " - -/* target enumeration */ -enum { - TARGET_SELF, - TARGET_TAB, - TARGET_WINDOW -}; - /* define enumeration values to be returned */ enum { PARSE_OK = 0, @@ -49,8 +38,6 @@ DRC_TOKEN_TEXT_COLOR, DRC_TOKEN_USE_OBLIQUE, DRC_TOKEN_HOME, - DRC_TOKEN_SPLASH, - DRC_TOKEN_KEY_BINDINGS, DRC_TOKEN_PANEL_SIZE, DRC_TOKEN_SMALL_ICONS, DRC_TOKEN_FONT_FACTOR, @@ -69,10 +56,8 @@ DRC_TOKEN_SHOW_URL, DRC_TOKEN_SHOW_SEARCH, DRC_TOKEN_SHOW_PROGRESS_BOX, - DRC_TOKEN_SHOW_POPUP_NAVIGATION, DRC_TOKEN_FULLWINDOW_START, DRC_TOKEN_TRANSIENT_DIALOGS, - DRC_TOKEN_POPUP_DIALOGS, DRC_TOKEN_FW_FONT, DRC_TOKEN_VW_FONT, DRC_TOKEN_GENERATE_SUBMIT, @@ -81,14 +66,6 @@ DRC_TOKEN_SHOW_HTML_WARNINGS, DRC_TOKEN_SHOW_MSG, DRC_TOKEN_USE_OLD_PARSER, - DRC_TOKEN_KEYWORDS, - DRC_TOKEN_TARGET_BLANK, - DRC_TOKEN_TAB_LOAD_IN_BACKGROUND, - DRC_TOKEN_TAB_BAR_SHOW_FULLSCREEN, - DRC_TOKEN_TAB_BAR_SHOW_SINGLE_TAB, - DRC_TOKEN_TAB_BAR_SCROLLER, - DRC_TOKEN_TAB_TITLE_COMPRESS, - DRC_TOKEN_COMPRESS_COMMON_PREFIXES, DRC_TOKEN_LAST } Dillo_Rc_TokenType; @@ -102,8 +79,6 @@ gchar *no_proxy; gchar **no_proxy_vec; DilloUrl *home; - gchar *splash; - gboolean show_splash; guint32 link_color; guint32 visited_color; guint32 bg_color; @@ -130,10 +105,8 @@ gboolean show_url; gboolean show_search; gboolean show_progress_box; - gboolean show_popup_navigation; gboolean fullwindow_start; gboolean transient_dialogs; - gboolean popup_dialogs; gchar *vw_fontname; gchar *fw_fontname; gboolean generate_submit; @@ -142,16 +115,6 @@ gboolean show_html_warnings; gboolean show_msg; gboolean use_old_parser; - gchar *keywords; - gchar **keywords_vec; - gint target_blank; - gboolean tab_load_in_background; - gboolean tab_bar_show_fullscreen; - gboolean tab_bar_show_single_tab; - gboolean tab_bar_scroller; - gboolean tab_title_compress; - gchar *compress_common_prefixes; - gchar **compress_common_prefixes_vec; }; -- billy "Who get's bigger evertime you void, It's Hank the Happy Hemorroid."

Nov. 21, 2003