- Dillo-dev - lists.mailman3.com

Re: [Dillo-dev] Re: [RFC] Quo Vadis Dillo

by Frank de Lange

Eythan Weg wrote: >How about horizontal/vertical split of a tab. One >use for it is being able to compare side by side >different parts of the same document. > > No, that sounds like something which can easily be achieved using a frameset. No need for special code in Dillo for that... <frameset cols="*,*"> <frame src="doc1.html"> <frame src="doc2.html"> </frameset> Make a form which feeds two urls to a frameset page like that. Presto, two documents side by side. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [RFC] Quo Vadis Dillo

by Eythan Weg

How about horizontal/vertical split of a tab. One use for it is being able to compare side by side different parts of the same document. Eythan

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Paul Pelzl

On Wed, Nov 12, 2003 at 11:00:58AM +0100, Frank de Lange wrote: > >http://notlong.com/links/ (the links in the table appear to be > >problematic) > > > > > I see what you mean, but this is not that easy to fix. Links are sorted > on y.x order using the coordinates for the first word in the link. If > you look at the table, you'll notice that 'makeashorterlink.com' starts > half a line above all the other links in the table row, while 'ek.dk' > starts half a line after the others. This causes those links to appear > in this order: > > makeashorterlink (link DOWN)-> one of the links to the left of it (link > DOWN)-> ek.dk > > I'll see if I can find a simple solution to this problem (use a median > coordinate? use a coordinate range?), but I do not think this will be > fixed in the next patch. I think you misunderstand... I ran into a segfault as soon as I hit one of the links in the table. Are you unable to reproduce? Paul

Nov. 12, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Paul Pelzl

On Wed, Nov 12, 2003 at 08:57:05AM +0100, Frank de Lange wrote: > >>Talking about my patch, what does need improvement? > >>Some ideas: > >>- select contents of location bar/search field when they are focused > >> (DONE, in next version) > >> > > > >Heh, I made that change myself about six months ago. > > > Hm, you should have shared your patch then, ey? I use hooks to > grab-focus (->select all) and focus-out-event (->deselect all). What was > your solution? My solution was less comprehensive. I just added a line in a_Interface_open_dialog, which does everything I want since I have popup_dialogs=NO. > >>- more key bindings (replacing current key handling where applicable) > >>- remove compile options for tabs and frames, make tabs/frames standard? > >> [ PDA/embedded developers: is this OK with you? ] > >>- ??? > >> > > - i-search support within the "View Source" window would be helpful. > > > The whole 'View Source' window needs an overhaul. Best thing to do would > be to implement a (sane, no 'notepad popup spam' like Microsoft products > manage to produce) version of the 'view-source' protocol, so source is > viewed in a normal window/tab/frame/... That way you get all facilities, > for 'free'. Agreed, this is really the way to handle it. Paul

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Frank de Lange

Indan Zupancic wrote: >Anyway, the point was, Frank, you got some tips how to handle all those >patches? My current system works fine, but I need yet another directory >with Dillo source if I want to make or use another patch. > > I've made some scripts which create a temporary copy of the dillo CVS dir and the patched dir, remove all unwanted crud from the patched dir, do the diff and generate some statistics. I can send them if you want. Of course this still leaves the issues with patch makers constantly being out of sync with eachother, and each patch being broken by updates to CVS shortly after the patch was posted. More on that later... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: [PATCH] cleanup of URL_ILLEGAL_CHARS

by Frank de Lange

Jorge Arellano Cid wrote: >On Wed, 12 Nov 2003, Frank de Lange wrote: > > > >>Jorge, >> >>Skip that last patch I sent you, here is a new one which also touches >>html.c... Please apply ASAP... >> >> > > Oh!, I'll skip this one too. > > Actually, there's no BUG in the current code (but in the comments). >Fixed now. > > BTW, > >+#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) > > is a bug. > > OK, that NPTR2STR is clearly a bug, but so was the absence of URL_ILLEGAL_CHARS_(u). Or call it a style fault if you want, whatever. I see it is fixed now. Thanks... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [PATCH] cleanup of URL_ILLEGAL_CHARS

by Jorge Arellano Cid

On Wed, 12 Nov 2003, Frank de Lange wrote: > Jorge, > > Skip that last patch I sent you, here is a new one which also touches > html.c... Please apply ASAP... Oh!, I'll skip this one too. Actually, there's no BUG in the current code (but in the comments). Fixed now. BTW, +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) is a bug. Jorge.-

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Indan Zupancic

>>patch will work against the cvs from 11-11, but not from 11-10 (thats >>month-day) and the tabs patch will work against 11-10 and not 11-11. >> >>Kind of a quandary, eh.... The joy of making patches against the CVS version... If the code would be in CVS, then it would stay automatically up to date. Normally, all patches should be made against some logical cvs tag, say, a release, but if the patches are still in development it's logical the maker want them to work with the current cvs version. Personally I'm going a bit crazy because of all those Dillo versions on my hd, one original cvs version, one I work on, one clean one to test if the patches really work, then two fake Dillo directories with symlinks to all the original files, so that I can do "diff -pur" and keep unwanted noise out of the patch, keeping it small and simple. Then I moved all those directories to another pc because I wanted to upgrade my 233 Mhz pc, someone gave me a pentum 3 800 + mobo, one of them more or less broken, whole pc very unstable. Caused major filesystem corruption when I tried it out, got it stable with underclocking the cpu to 700 Mhz, but still can't compile because I suddenly miss some header files. No big deal, I backuped everything, and wanted to switch to Slackware anyway, but still means I have to do all the Dillo stuff via ssh on the other pc, until I have everything back on track again. Anyway, the point was, Frank, you got some tips how to handle all those patches? My current system works fine, but I need yet another directory with Dillo source if I want to make or use another patch. Greetings, Indan

Nov. 12, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Indan Zupancic

> So, I'm not that sure about Firebird's search box. Anyone care to > comment on this? I use Firebird too often, and I have that little extra search box. It's small, it's has annoying behaviour, I never use it. Only feature I would like to have that is search related, is that ctrl+g searches for the same string again, no matter in what way you made the first search. Greetings, Indan

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Frank de Lange

Paul Pelzl wrote: >On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote: > > >>[ LIST: please give keyboard navigation, on either version of the >>patch, a workout. This needs some testing if it is to be part of >>mainstream Dillo. Try it in frame sites, try navigatin between frames >>with Tab/Shift-Tab, try the keyboard bindings, etc. ] >> >> > >With tab/frame/keynav patch v14, I've been able to get segfaults pretty >easily just by moving between links. Here are some sample sites: > >http://memepool.com (there is a long link on the current page that causes problems) >http://notlong.com/links/ (the links in the table appear to be problematic) >http://cruel.com (a link about halfway down the current page) >http://vikings.com (one of the first links in the main frame) > >Also, here is an example of a site where the algorithm for determining >the direction of the next link breaks down: > http://linkfilter.net >At the end of each post there are a set of icons which get selected in >a non-intuitive order. > > OK, I fixed this issue as well, by ignoring the individual word size for link allocation. This page now works as you'd expect it to, I'll see if the fix does not adversely affect other sites. If it works out OK consider this issue closed. Cheers//Frank [ who has some time on his hands to fix things at the moment... Anyone looking for an accomplished free software hacker in Västra Götaland, Sweden? ] -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Cookies disabled

by Indan Zupancic

> Edit ~.dillo/cookierc into: > > DEFAULT ACCEPT Seems like a bad idea, I would use DEFAULT ACCEPT_SESSION, and use ACCEPT only for the sites you really need (and trust). Also, only the first Dillo instance has cookie support, so open a new window instead of a new Dillo if you want always cookies. Greetings, Indan

Nov. 12, 2003

Re: [Dillo-dev] Cookies disabled

by Mike Eriksen

On Wed, 12 Nov 2003, William Trenker wrote: > When dillo starts a console message indicates that cookies are disabled. Is there a way to enable cookies? > > Thanks, > Bill Edit ~.dillo/cookierc into: DEFAULT ACCEPT Mike -- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS

Nov. 12, 2003

help

by Pavankumar P

---------------------------------------------------NOTIFICATION-------------- -------------------------------------------- The subject line for this message is prohibited by Symantec AVF and the message was quarantined. The Subject Line of the message falls under restricted category. If you think that the message is valid please raise a call through helpdesk for further clarifications and release of the same." Please note this message will be retained for 3 Days for claim, after which it will be purged. ----------------------------------------------------------------------------- ----------------------------------------------- ID:MTV01EX01::SYQ69c2e949 DISCLAIMER: This message (including attachment if any) is confidential and may be privileged. Before opening attachments please check them for viruses and defects. MindTree Consulting Private Limited (MindTree) will not be responsible for any viruses or defects or any forwarded attachments emanating either from within MindTree or outside. If you have received this message by mistake please notify the sender by return e-mail and delete this message from your system. Any unauthorized use or dissemination of this message in whole or in part is strictly prohibited. Please note that e-mails are susceptible to change and MindTree shall not be liable for any improper, untimely or incomplete transmission.

Nov. 12, 2003

Re: [Dillo-dev] [PATCH] Version 14 of tab/frames/kbnav patch is ready

by Frank de Lange

Stephan Goetter wrote: >If I have a site with frames and navigate around the history isn't updated >properly. If you click back then you are on the site before. An >additional history per frame would probably do it. Then you could go back >in a frame using the popup menu. > > I'll test if this is a viable option, and add it if it works out OK. >Using tabs the copy&paste just with selection is kind of weird. You >can't select the directory in the location of a site and copy it >to the location of a new tab (cos its the same widget). >If you select some text in tab#1 you can't copy it to location#2. > > Yeah, noticed that as well. I'll see if I can find a cure... >The following patch is useful if you have a lot of tabs. You can jump >from the last to the first and vice versa (using shortcuts). > > I'll try this, and will add it to the patch if it 'feels' right... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Frank de Lange

Andreas Schweitzer wrote: >- I know this has been discussed before, but the use of > Ctrl-Shift-L versus Ctrl-L confuses me almost every > time I want to enter a URL manually. I slowly get used to it - damn > old habits :-) ... but my point is : how many other users > will be confused by this ? > Eventually, this will not matter, because all shortcuts can > be customized, IIRC. > I will probably revert back to CTRL-L for link open, CTRL-U for 'focus location bar' (which does the same when popup_dialogs=NO), and use something else for view source (thereby confusing people who are used to Mozilla et al...). >- One thing I love about dillo is/was that it did not open up > new windows when the author deemed it necesarry. Now, on > some stupid pages I get window after window, just because the > author does know nothing about good web design. > I realize that it's the strict adherence to the _blank > target. > I'll add a preference for that, so it minimizes the number of new pages it opens. Thanks for the feedback! Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Frank de Lange

Paul Pelzl wrote: >On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote: > > >>[ LIST: please give keyboard navigation, on either version of the >>patch, a workout. This needs some testing if it is to be part of >>mainstream Dillo. Try it in frame sites, try navigatin between frames >>with Tab/Shift-Tab, try the keyboard bindings, etc. ] >> >> > >With tab/frame/keynav patch v14, I've been able to get segfaults pretty >easily just by moving between links. Here are some sample sites: > >http://memepool.com (there is a long link on the current page that causes problems) > > Fixed, was caused by Dw_page_construct_iterator() always returning iterators with mask=DW_CONTENT_ALL. This caused links which contain breaks (<br>) to segfault. I changed Dw_page_construct_iterator() to allow the caller to set a mask. >http://notlong.com/links/ (the links in the table appear to be problematic) > > I see what you mean, but this is not that easy to fix. Links are sorted on y.x order using the coordinates for the first word in the link. If you look at the table, you'll notice that 'makeashorterlink.com' starts half a line above all the other links in the table row, while 'ek.dk' starts half a line after the others. This causes those links to appear in this order: makeashorterlink (link DOWN)-> one of the links to the left of it (link DOWN)-> ek.dk I'll see if I can find a simple solution to this problem (use a median coordinate? use a coordinate range?), but I do not think this will be fixed in the next patch. >http://cruel.com (a link about halfway down the current page) > > Same problem as memepool.com, fixed >http://vikings.com (one of the first links in the main frame) > > Same problem as memepool.com, fixed >Also, here is an example of a site where the algorithm for determining >the direction of the next link breaks down: > http://linkfilter.net >At the end of each post there are a set of icons which get selected in >a non-intuitive order. > > More or less the same problem as notlong.com, but a slighly different cause. The author of the page did not use width/height tags on one of the icon links (the Stats link), this makes Dillo render the links's alt-text half a line lower. This causes the link shuffle effect you noticed. I might be able to fix this one though by adding another focusable_allocate for images. Might be fixed in next patch. Thanks fo the feedback... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Andreas Schweitzer

Hi > [ LIST: please give keyboard navigation, on either version of the > patch, a workout. This needs some testing if it is to be part of > mainstream Dillo. Try it in frame sites, try navigatin between frames > with Tab/Shift-Tab, try the keyboard bindings, etc. ] Here comes a bit of feedback. I haven't found anything new (only cut-n-paste and the history) but only some user issues : - I know this has been discussed before, but the use of Ctrl-Shift-L versus Ctrl-L confuses me almost every time I want to enter a URL manually. I slowly get used to it - damn old habits :-) ... but my point is : how many other users will be confused by this ? Eventually, this will not matter, because all shortcuts can be customized, IIRC. - One thing I love about dillo is/was that it did not open up new windows when the author deemed it necesarry. Now, on some stupid pages I get window after window, just because the author does know nothing about good web design. I realize that it's the strict adherence to the _blank target. I read on the HTML Standard, and I found two points : - they are all "should" rules (6.16). The client should do this and that. - in the Target semantics (16.3.2) the standard allows for the client to override the target. so, IMHO, I would treat _blank (and probably every unknown target) just like _top, unless the user allows dillo via a preference option (in fact I already did this in my personal version of the frames version ;-) ...). This is the same argument as above : keep the current behaviour. Oh, and since I use the same argument twice : I am not saying that new behaviour is bad, just that thinking about keeping the old does not hurt either. Otherwise : so many more pages work now much more pleasantly with the frames support : thanks ! :) Cheers, Andreas -- **************************** NEW ADDRESS ****************************** Hamburger Sternwarte Universitaet Hamburg Gojenbergsweg 112 Tel. ++49 40 42891 4016 D-21029 Hamburg, Germany Fax. ++49 40 42891 4198

Nov. 12, 2003

[PATCH] cleanup of URL_ILLEGAL_CHARS

by Frank de Lange

Jorge, Skip that last patch I sent you, here is a new one which also touches html.c... Please apply ASAP... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] diff -pruN dillo/src/html.c dillo_patched/src/html.c --- dillo/src/html.c 2003-11-11 21:45:01.947370344 +0100 +++ dillo_patched/src/html.c 2003-11-12 09:01:46.119597904 +0100 @@ -152,7 +152,7 @@ static DilloUrl *Html_url_new(DilloHtml url_str, (use_base_url) ? base_url : URL_STR_(html->linkblock->base_url), flags, pos); - if ((n_ic = URL_ILLEGAL_CHARS(url)) != 0) + if ((n_ic = URL_ILLEGAL_CHARS_(url)) != 0) MSG_HTML("URL has %d illegal character%s (00-1F, 7F or space)\n", n_ic, (n_ic) > 1 ? "s" : ""); return url; diff -pruN dillo/src/url.h dillo_patched/src/url.h --- dillo/src/url.h 2003-11-11 21:45:02.153339032 +0100 +++ dillo_patched/src/url.h 2003-11-12 08:16:28.038808992 +0100 @@ -57,7 +57,7 @@ #define URL_ALT_(u) u->alt #define URL_POS_(u) u->scrolling_position #define URL_STR_(u) a_Url_str(u) -#define URL_ILLEGAL_CHARS(u) url->illegal_chars +#define URL_ILLEGAL_CHARS_(u) url->illegal_chars /* * Access methods that always return a string: @@ -77,7 +77,7 @@ #define URL_ALT(u) NPTR2STR(URL_ALT_(u)) #define URL_POS(u) URL_POS_(u) #define URL_STR(u) NPTR2STR(URL_STR_(u)) - +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) /* URL-camp compare methods */

Nov. 12, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Frank de Lange

Paul Pelzl wrote: >On Tue, Nov 11, 2003 at 03:05:17PM +0100, Frank de Lange wrote: > >>Talking about my patch, what does need improvement? >>Some ideas: >>- select contents of location bar/search field when they are focused >> (DONE, in next version) >> > >Heh, I made that change myself about six months ago. > Hm, you should have shared your patch then, ey? I use hooks to grab-focus (->select all) and focus-out-event (->deselect all). What was your solution? >Using the location bar is nice, but I think the Mozilla Firebird >approach presents a more consistent interface. It has a separate >(small) search box to the right of the location bar. Ctrl-L takes you >to the location bar, Ctrl-K takes you to the search bar. > I use Phoenixbird as well (for those few pages which Dillo does not handle good enough). I think the search bar has both advantages and disadvantages. Advantage is that is is a more consistent user interface, disadvantage is that it is small. I'm also not that keen on the combination of page and web search in one dialog: even though they are both 'search' functions, they do conceptually different things. One leads to the loading of a new page, the other does not. I prefer to have the page-loading stuff (locbar, maybe web search bar) separate from non-page-loading stuff. I also think that having a special search bar just for web search is a bit of a waste of screen real estate. The location bar is big enough for even complex search terms, it is always there (will make it popup when pressing CTRL-L in full-screen mode for next patch, just like the search/status bar does now when popup_dialogs=NO). So, I'm not that sure about Firebird's search box. Anyone care to comment on this? >>- more key bindings (replacing current key handling where applicable) >>- remove compile options for tabs and frames, make tabs/frames standard? >> [ PDA/embedded developers: is this OK with you? ] >>- ??? >> > - i-search support within the "View Source" window would be helpful. > The whole 'View Source' window needs an overhaul. Best thing to do would be to implement a (sane, no 'notepad popup spam' like Microsoft products manage to produce) version of the 'view-source' protocol, so source is viewed in a normal window/tab/frame/... That way you get all facilities, for 'free'. This can be implemented in many ways, as a plugin (but I'm not that keen on plugins as they are implemented now...), in the current code, as a dlopen() library (not there yet...), etc. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Frank de Lange

Paul Pelzl wrote: > With tab/frame/keynav patch v14, I've been able to get segfaults pretty > >easily just by moving between links. Here are some sample sites: > >http://memepool.com (there is a long link on the current page that causes problems) >http://notlong.com/links/ (the links in the table appear to be problematic) >http://cruel.com (a link about halfway down the current page) >http://vikings.com (one of the first links in the main frame) > >Also, here is an example of a site where the algorithm for determining >the direction of the next link breaks down: > http://linkfilter.net >At the end of each post there are a set of icons which get selected in >a non-intuitive order. > >Paul > > I'll look into these problems... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Frank de Lange

Patrick Shanahan wrote: > Ok, I'm knock-kneed, back-handed and generally challenged. The ssl > >patch will work against the cvs from 11-11, but not from 11-10 (thats >month-day) and the tabs patch will work against 11-10 and not 11-11. > >Kind of a quandary, eh.... > > Sigh... I'll put out a new version of my patches RSN.. I have also found a small error in Jorge's patch to url.h, so I'll try to get that committed to CVS before I produce my patch set - otherwise you'll get yet another reject once CVS is updated. Jorge, please apply the attached patch to CVS ASAP, so it does not cause rejects with my forthcoming patches... It fixes the error in the macro definition for URL_ILLEGAL_CHARS(u) and adds the missing URL_ILLEGAL_CHARS_(u). Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ] --- dillo/src/url.h 2003-11-11 21:45:02.153339032 +0100 +++ dillo_patched/src/url.h 2003-11-12 08:16:28.038808992 +0100 @@ -57,7 +57,7 @@ #define URL_ALT_(u) u->alt #define URL_POS_(u) u->scrolling_position #define URL_STR_(u) a_Url_str(u) -#define URL_ILLEGAL_CHARS(u) url->illegal_chars +#define URL_ILLEGAL_CHARS_(u) url->illegal_chars /* * Access methods that always return a string: @@ -77,7 +77,7 @@ #define URL_ALT(u) NPTR2STR(URL_ALT_(u)) #define URL_POS(u) URL_POS_(u) #define URL_STR(u) NPTR2STR(URL_STR_(u)) - +#define URL_ILLEGAL_CHARS(u) NPTR2STR(URL_ILLEGAL_CHARS_(u)) /* URL-camp compare methods */

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Frank de Lange

Kelson Vibber wrote: > At 04:20 AM 11/11/2003, Paul Pelzl wrote: > >> Perhaps some enterprising individual (not me) would be interested in >> hosting some sort of Dillo Wiki. Any patch authors could then post >> links on the wiki without having to bother website maintainers... > > > I might be able to set something up on my site. Can anyone recommend > some good Wiki software? The lists at Freshmeat.net and Wikipedia are > extremely long, and while I'm inclined to look at MediaWiki, it looks > like it would be overkill for this purpose. I have used twiki (www.twiki.org) with great success. WIsh I had broadband here in Sweden, I would be running it now... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 12, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Paul Pelzl

On Tue, Nov 11, 2003 at 03:05:17PM +0100, Frank de Lange wrote: > Talking about my patch, what does need improvement? > Some ideas: > - select contents of location bar/search field when they are focused > (DONE, in next version) Heh, I made that change myself about six months ago. > - make the 'search the web' popup disappear when popup_dialogs=NO, > replace it with a non_popup version or use the location bar for > search (like several other browsers do) Using the location bar is nice, but I think the Mozilla Firebird approach presents a more consistent interface. It has a separate (small) search box to the right of the location bar. Ctrl-L takes you to the location bar, Ctrl-K takes you to the search bar. > - more key bindings (replacing current key handling where applicable) > - remove compile options for tabs and frames, make tabs/frames standard? > [ PDA/embedded developers: is this OK with you? ] > - ??? - i-search support within the "View Source" window would be helpful. Paul

Nov. 12, 2003

Re: [Dillo-dev] Re: Keybd 3 patch

by Paul Pelzl

On Tue, Nov 11, 2003 at 02:58:43PM +0100, Frank de Lange wrote: > [ LIST: please give keyboard navigation, on either version of the > patch, a workout. This needs some testing if it is to be part of > mainstream Dillo. Try it in frame sites, try navigatin between frames > with Tab/Shift-Tab, try the keyboard bindings, etc. ] With tab/frame/keynav patch v14, I've been able to get segfaults pretty easily just by moving between links. Here are some sample sites: http://memepool.com (there is a long link on the current page that causes problems) http://notlong.com/links/ (the links in the table appear to be problematic) http://cruel.com (a link about halfway down the current page) http://vikings.com (one of the first links in the main frame) Also, here is an example of a site where the algorithm for determining the direction of the next link breaks down: http://linkfilter.net At the end of each post there are a set of icons which get selected in a non-intuitive order. Paul

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Patrick Shanahan

* Patrick Shanahan <paka(a)MyRealBox.com> [11-11-03 21:56]: > * Indan Zupancic <indan(a)nul.nu> [11-11-03 19:28]: > > > > I updated the https patch, it should work with the current cvs now. I > > didn't change anything, it's no real update, only to keep the > > impatient happy. ;) > > > > It's a quick fix, real update will come later. > > Thanks, but: > > pat@wahoo:/dillo.cvs.1110> patch -p1 <dillo-ssl.diff > patching file configure.in > Hunk #1 succeeded at 26 with fuzz 2 (offset 2 lines). > Hunk #2 succeeded at 177 (offset 8 lines). > Hunk #3 succeeded at 225 (offset 22 lines). > patching file src/IO/IO.c > patching file src/IO/IO.h > patching file src/IO/Url.c > patching file src/IO/http.c > patching file src/capi.c > Hunk #1 FAILED at 255. > 1 out of 1 hunk FAILED -- saving rejects to file src/capi.c.rej > > pat@wahoo:/dillo.cvs.1110> cat src/capi.c.rej > *************** > *** 255,266 **** > a_Capi_dpi_send_cmd(web, web->bw, cmd, "ftp", 1); > g_free(cmd); > > } else if (g_strncasecmp(url_str, "https:/", 7) == 0 && !Call && > (a_Capi_url_read(web->url, &sz) == NULL || > (URL_FLAGS(web->url) & URL_E2EReload)) ) { > cmd = g_strdup_printf("<dpi cmd='open_url' url='%s'>", url_str); > a_Capi_dpi_send_cmd(web, web->bw, cmd, "https", 1); > g_free(cmd); > > } else { > return a_Cache_open_url(web, Call, CbData); > --- 255,268 ---- > a_Capi_dpi_send_cmd(web, web->bw, cmd, "ftp", 1); > g_free(cmd); > > + #ifndef HTTPS > } else if (g_strncasecmp(url_str, "https:/", 7) == 0 && !Call && > (a_Capi_url_read(web->url, &sz) == NULL || > (URL_FLAGS(web->url) & URL_E2EReload)) ) { > cmd = g_strdup_printf("<dpi cmd='open_url' url='%s'>", url_str); > a_Capi_dpi_send_cmd(web, web->bw, cmd, "https", 1); > g_free(cmd); > + #endif > > } else { > return a_Cache_open_url(web, Call, CbData); > > it fixes three of the four failures I rec'd. ??? > Ok, I'm knock-kneed, back-handed and generally challenged. The ssl patch will work against the cvs from 11-11, but not from 11-10 (thats month-day) and the tabs patch will work against 11-10 and not 11-11. Kind of a quandary, eh.... -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Patrick Shanahan

* Indan Zupancic <indan(a)nul.nu> [11-11-03 19:28]: > > I updated the https patch, it should work with the current cvs now. I > didn't change anything, it's no real update, only to keep the > impatient happy. ;) > > It's a quick fix, real update will come later. Thanks, but: pat@wahoo:/dillo.cvs.1110> patch -p1 <dillo-ssl.diff patching file configure.in Hunk #1 succeeded at 26 with fuzz 2 (offset 2 lines). Hunk #2 succeeded at 177 (offset 8 lines). Hunk #3 succeeded at 225 (offset 22 lines). patching file src/IO/IO.c patching file src/IO/IO.h patching file src/IO/Url.c patching file src/IO/http.c patching file src/capi.c Hunk #1 FAILED at 255. 1 out of 1 hunk FAILED -- saving rejects to file src/capi.c.rej pat@wahoo:/dillo.cvs.1110> cat src/capi.c.rej *************** *** 255,266 **** a_Capi_dpi_send_cmd(web, web->bw, cmd, "ftp", 1); g_free(cmd); } else if (g_strncasecmp(url_str, "https:/", 7) == 0 && !Call && (a_Capi_url_read(web->url, &sz) == NULL || (URL_FLAGS(web->url) & URL_E2EReload)) ) { cmd = g_strdup_printf("<dpi cmd='open_url' url='%s'>", url_str); a_Capi_dpi_send_cmd(web, web->bw, cmd, "https", 1); g_free(cmd); } else { return a_Cache_open_url(web, Call, CbData); --- 255,268 ---- a_Capi_dpi_send_cmd(web, web->bw, cmd, "ftp", 1); g_free(cmd); + #ifndef HTTPS } else if (g_strncasecmp(url_str, "https:/", 7) == 0 && !Call && (a_Capi_url_read(web->url, &sz) == NULL || (URL_FLAGS(web->url) & URL_E2EReload)) ) { cmd = g_strdup_printf("<dpi cmd='open_url' url='%s'>", url_str); a_Capi_dpi_send_cmd(web, web->bw, cmd, "https", 1); g_free(cmd); + #endif } else { return a_Cache_open_url(web, Call, CbData); it fixes three of the four failures I rec'd. ??? tks, -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Nov. 12, 2003

Cookies disabled

by William Trenker

When dillo starts a console message indicates that cookies are disabled. Is there a way to enable cookies? Thanks, Bill

Nov. 12, 2003

Re: [Dillo-dev] HTTPS Patch

by Indan Zupancic

Hello, I updated the https patch, it should work with the current cvs now. I didn't change anything, it's no real update, only to keep the impatient happy. ;) It's a quick fix, real update will come later. Greetings, Indan

Nov. 11, 2003

DPI's and 0.7.3

by William Trenker

Will the download and ftp dpi's in CVS work with Dillo 0.7.3? If so, how do I build them? Or do I have to wait until version 0.8 is available? Thanks, Bill

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by robert w hall

In message <6.0.0.22.0.20031111113824.0261c2e8(a)mail.speed.net>, Kelson Vibber <kelson(a)pobox.com> writes > >I might be able to set something up on my site. Can anyone recommend some >good Wiki software? The lists at Freshmeat.net and Wikipedia are extremely >long, and while I'm inclined to look at MediaWiki, it looks like it would >be overkill for this purpose. sounds a very welcome offer and well worth a try thank you Bob -- robert w hall

Nov. 11, 2003

Re: [Dillo-dev] [PATCH] Version 14 of tab/frames/kbnav patch is ready

by Frank de Lange

Melvin Hadasht wrote: >Hi Frank, > > > >>The next version (14) of my tab/frame/keyboard navigation patch is >>ready (see bottom of this message for download instructions). >> >> > >It seems that I cannot paste selected text from a web page. Selecting >something works correctly, but pasting with middle-click to something (xterm, >gtk2, url entry), does not work. It works if I revert the patch. (tested on the >splash page and also on tabbed pages). ("Copy link" menu works) > >Cheers, > > > Yes, I noticed this as well. I did not connect it to my patch first, but it seems to be related. Il look into this for the next version. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Kelson Vibber

At 04:20 AM 11/11/2003, Paul Pelzl wrote: >Perhaps some enterprising individual (not me) would be interested in >hosting some sort of Dillo Wiki. Any patch authors could then post links >on the wiki without having to bother website maintainers... I might be able to set something up on my site. Can anyone recommend some good Wiki software? The lists at Freshmeat.net and Wikipedia are extremely long, and while I'm inclined to look at MediaWiki, it looks like it would be overkill for this purpose. Kelson Vibber www.hyperborea.org

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Jorge Arellano Cid

Hi there, > On Tue, Nov 11, 2003 at 07:20:04AM -0500, Paul Pelzl wrote: > > On Tue, Nov 11, 2003 at 10:37:41AM +0000, robert w hall wrote: > > > To reiterate > > > It would be _really nice_ if all these links to these very useful > > > patches were findable from the dillo main site :-) > > > > Perhaps some enterprising individual (not me) would be interested in > > hosting some sort of Dillo Wiki. Any patch authors could then post > > links on the wiki without having to bother website maintainers... > > A Wiki could be nice if someone were to set it up (and maintain it). > > A maintained list of patch sites on www.dillo.org could be nice, again > if someone will do the work to keep it from getting stale. I've been hearing complaints about unnoficial patches for years. It takes time an dedication to make such a compilation, to answer the incoming messages, and to keep them up to date. Nobody has volunteered to do that in a stable basis, so please allow me to remember that the current CVS is what we, the core and steady developers, have taken the time and effort to integrate (review the ChangeLog it's a quite large list). So if somebody wants to do the same with unofficial patches, _that doesn't belong to the official site_. I'd gladly provide a link to it, but beware that this new site's maintainers must take care of all of the incoming messages related to unofficial patches, and all the associated burdens. > But there already already is a user-writable area on www.dillo.org, > which supports small modifications -- the bug-track database. Please don't (for above mentioned reasons). Sincerely Jorge.-

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Francis Daly

On Tue, Nov 11, 2003 at 07:20:04AM -0500, Paul Pelzl wrote: > On Tue, Nov 11, 2003 at 10:37:41AM +0000, robert w hall wrote: > > To reiterate > > It would be _really nice_ if all these links to these very useful > > patches were findable from the dillo main site :-) > > Perhaps some enterprising individual (not me) would be interested in > hosting some sort of Dillo Wiki. Any patch authors could then post > links on the wiki without having to bother website maintainers... A Wiki could be nice if someone were to set it up (and maintain it). A maintained list of patch sites on www.dillo.org could be nice, again if someone will do the work to keep it from getting stale. But there already already is a user-writable area on www.dillo.org, which supports small modifications -- the bug-track database. That dillo does not support frames is BUG#131, not claimed by anybody. If the owner is prepared to put their address on the web, volunteer for it with "frank@wherever, patch at http://www.geocities.com/ikbenfrank/" as the comment. That dillo does not support https: URLs is BUG#223, although there's an undated indication that someone is working on that. Possibly add "patch at http://www.xs4all.nl/~dorinek/dillo/" to that entry, after checking with the current volunteer. (Or, maybe, log a new https:// bug and volunteer for that with the details. Although deliberately duplicating bugs might be considered impolite.) Keyboard navigation is BUG#230. Are there any patches floating about for features not in the bug-track database? Keep the URLs short (there's only 64 chars to play with, I believe) and people looking for fixes should be able to find them. Does that help the problem at all? All the best, f -- Francis Daly francis(a)daoine.org

Nov. 11, 2003

Re: [Dillo-dev] [PATCH] Version 14 of tab/frames/kbnav patch is ready

by Melvin Hadasht

Hi Frank, > The next version (14) of my tab/frame/keyboard navigation patch is > ready (see bottom of this message for download instructions). It seems that I cannot paste selected text from a web page. Selecting something works correctly, but pasting with middle-click to something (xterm, gtk2, url entry), does not work. It works if I revert the patch. (tested on the splash page and also on tabbed pages). ("Copy link" menu works) Cheers, -- Melvin Hadasht

Nov. 11, 2003

Re: [Dillo-dev] [PATCH] Version 14 of tab/frames/kbnav patch is ready

by Stephan Goetter

Am Mon, Nov 10, 2003 at 05:36:59PM +0100 schrieb Frank de Lange und sprach: > Hi'all, > > The next version (14) of my tab/frame/keyboard navigation patch is > ready (see bottom of this message for download instructions). > Works very well. Here are the only things I noticed: If I have a site with frames and navigate around the history isn't updated properly. If you click back then you are on the site before. An additional history per frame would probably do it. Then you could go back in a frame using the popup menu. Using tabs the copy&paste just with selection is kind of weird. You can't select the directory in the location of a site and copy it to the location of a new tab (cos its the same widget). If you select some text in tab#1 you can't copy it to location#2. The following patch is useful if you have a lot of tabs. You can jump from the last to the first and vice versa (using shortcuts). Greets, Stephan --- commands.c.old 2003-11-10 18:37:54.000000000 +0100 +++ commands.c 2003-11-11 17:44:59.000000000 +0100 @@ -429,14 +429,22 @@ void a_Commands_save_link_callback(GtkWi /* VIEW MENU */ void a_Commands_tab_prev_callback(GtkWidget *widget, gpointer client_data) { - BrowserWindow *bw = (BrowserWindow *) client_data; - gtk_notebook_prev_page(GTK_NOTEBOOK(bw->container)); + BrowserWindow *bw = (BrowserWindow *) client_data; + if (gtk_notebook_get_current_page(GTK_NOTEBOOK(bw->container)) != 0) + gtk_notebook_prev_page(GTK_NOTEBOOK(bw->container)); + else + gtk_notebook_set_page(GTK_NOTEBOOK(bw->container), g_list_length(gtk_container_children(bw->container))-1); } void a_Commands_tab_next_callback(GtkWidget *widget, gpointer client_data) { - BrowserWindow *bw = (BrowserWindow *) client_data; - gtk_notebook_next_page(GTK_NOTEBOOK(bw->container)); + BrowserWindow *bw = (BrowserWindow *) client_data; + GtkNotebook *nb = GTK_NOTEBOOK(bw->container); + if (gtk_notebook_get_current_page(GTK_NOTEBOOK(bw->container)) + != g_list_length(gtk_container_children(bw->container))-1) + gtk_notebook_next_page(nb); + else + gtk_notebook_set_page(GTK_NOTEBOOK(bw->container), 0); } #endif

Nov. 11, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Indan Zupancic

> I was unable to apply Indan's https patch to the 11-10.cvs, Known "problem", see my other mail for more info. > It would be nice if you included Indan's https patch with your's. My patch is very young and I'm not happy with it yet, but it looks like I need to update it, impatient people. :) Greetings, Indan

Nov. 11, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Patrick Shanahan

* Frank de Lange <frank(a)unternet.org> [11-11-03 09:09]: > > Now that the last release of the patches seem to work (number 13 was > less of a success...)... I successfully applied #14 to SuSE 8.1 and have found no faults. I am very pleased with the functionality, tabs & keybindings. > Where do we want to be tomorrow? > > What needs to be added/changed to improve Dillo? > > Should the tab/frame/etcetera + Indan's patch + ??? be forked into an > 'experimental' version, somewhat like the Sylpheed MUA was forked > into Sylpheed-claws? I was unable to apply Indan's https patch to the 11-10.cvs, pat@wahoo:/dillo.cvs.1110> patch -p1 <dillo-ssl.diff patching file configure.in Hunk #1 succeeded at 26 with fuzz 2 (offset 2 lines). Hunk #2 succeeded at 177 (offset 8 lines). Hunk #3 succeeded at 225 (offset 22 lines). patching file src/IO/IO.c Hunk #1 succeeded at 48 with fuzz 2. Hunk #2 succeeded at 88 (offset 18 lines). Hunk #3 succeeded at 276 (offset 18 lines). Hunk #4 succeeded at 402 (offset 18 lines). Hunk #5 succeeded at 451 (offset 21 lines). Hunk #6 succeeded at 468 (offset 21 lines). Hunk #7 succeeded at 476 (offset 21 lines). Hunk #8 succeeded at 506 (offset 21 lines). Hunk #9 succeeded at 578 (offset 22 lines). Hunk #10 FAILED at 592. Hunk #11 succeeded at 746 (offset 24 lines). 1 out of 11 hunks FAILED -- saving rejects to file src/IO/IO.c.rej patching file src/IO/IO.h Hunk #1 FAILED at 46. 1 out of 1 hunk FAILED -- saving rejects to file src/IO/IO.h.rej patching file src/IO/Url.c patching file src/IO/http.c Hunk #2 FAILED at 219. Hunk #3 succeeded at 317 with fuzz 2 (offset 3 lines). Hunk #4 succeeded at 406 (offset 5 lines). 1 out of 4 hunks FAILED -- saving rejects to file src/IO/http.c.rej patching file src/capi.c Hunk #1 FAILED at 255. 1 out of 1 hunk FAILED -- saving rejects to file src/capi.c.rej rej files available on request. It would be nice if you included Indan's https patch with your's. INFO ONLY: I have compiled an rpm of 11-10.cvs with the tabs patch which is ~240K. Also available on request. tks for your efforts, -- Patrick Shanahan Registered Linux User #207535 http://wahoo.no-ip.org @ http://counter.li.org

Nov. 11, 2003

Re: [Dillo-dev] [RFC] Quo Vadis Dillo

by Victor Sahlstedt

On Tue, 11 Nov 2003 15:05:17 +0100 Frank de Lange <frank(a)unternet.org> wrote: > Should the tab/frame/etcetera + Indan's patch + ??? be forked into an > 'experimental' version, somewhat like the Sylpheed MUA was forked into > Sylpheed-claws? Personally i'd prefer if the patches were merged with Dillo but I wouldn't mind a forkish "Dillo-Claws" or such. Jorge? > Some ideas: > - make the 'search the web' popup disappear when popup_dialogs=NO, > replace it with a non_popup version or use the location bar for > search (like several other browsers do) Being able to use the location-bar (or preferably a separate search-bar) would be really neato. It's #1 on my wish-list, anyways. Keep up the good work. - Victor

Nov. 11, 2003

Latest parser changes

by Jorge Arellano Cid

Hi there! After all the trouble with trying to convince Slashdot's webmasters to fix their HTML (because of the loftier importance of adhering to standards), and considering Andreas S. comment on that dillo was making a weird rendering only, but not helping to find the cause to fix the problem, I started a more in-depth review of it. As time passed the code I was developing turned more and more interesting and finally here you have it! This is a quote from the ChangeLog: * Adapted the generic parser to make HTML error detection, providing the line number and a hint (expected tag) in the error message! * Added 'show_html_wanings' option to dillorc (boolean). * Added information about optional, required and forbidden end tags. * Modified the parser's handling of closing tags to account for elements with an optional close tag, and for more accurate diagnosis messages. * Added 'use_old_parser' option to dillorc (boolean). * Fixed the handling of HEAD and BODY elements to account for their double optional condition (both open and close tags are optional). This basically means that now dillo will detect and print useful error messages about bad-formed HTML. After using it for a while it helped me to find bugs I have overseen for months and it proved very accurate and helpful! (it even catched one at the W3C site! :) I hope it will be a good tool for webmasters, and for people authoring simple web pages. In our side, it will help to polish our HTML parsing. For instance, it soon became clear that we're sometimes pulling tags when they should stay. For instance: <p> <ol><li> One <li> two </ol> </p> <- detects an error here. because <ol> anticipatedly cleans <p> from the stack. This may look not relevant, but when trying to build a DOM tree it certainly is! Some comments: The new parsing behaviour makes sites render different from what they used to. Sometimes they show better, some others worse. After all it is bad-formed HTML what we're dealing with. For instance: heise.de a bit worst but usable. slashdot.org renders ok. sf.net worst but usable. Please bear in mind that now dillo can diagnose these errors at render time so, as a user, now you can send a meaningful error report to a site's webmaster! (for instance slashdot is diagnosed on-the-fly). Our experience is that most webmasters welcome this reports. Finally, remember that you can turn off the HTML error messages show_html_wanings=NO and that you can fall back to the old parser: use_old_parser=YES Enjoy! (I hope ;) Jorge.-

Nov. 11, 2003

[RFC] Quo Vadis Dillo

by Frank de Lange

Hi'all, Now that the last release of the patches seem to work (number 13 was less of a success...)... Where do we want to be tomorrow? What needs to be added/changed to improve Dillo? Should the tab/frame/etcetera + Indan's patch + ??? be forked into an 'experimental' version, somewhat like the Sylpheed MUA was forked into Sylpheed-claws? Talking about my patch, what does need improvement? Some ideas: - select contents of location bar/search field when they are focused (DONE, in next version) - make the 'search the web' popup disappear when popup_dialogs=NO, replace it with a non_popup version or use the location bar for search (like several other browsers do) - more key bindings (replacing current key handling where applicable) - remove compile options for tabs and frames, make tabs/frames standard? [ PDA/embedded developers: is this OK with you? ] - ??? Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 11, 2003

Re: Keybd 3 patch

by Frank de Lange

Jorge Arellano Cid wrote: >Hi Frank, > > I just noticed the newes keyboard navigation patch in the >mailing list. Please tell me if this problems were fixed or if a >should wait the next version before aiming to a merge: > > These problems are gone. I have completely overhauled the internals so that focus always is in sync with the rest of Dillo. Which just happened to fix the problem Sebastian noticed... I'd say, wait a week or so to see if any issues crop up. If all seems OK commit the patch. [ LIST: please give keyboard navigation, on either version of the patch, a workout. This needs some testing if it is to be part of mainstream Dillo. Try it in frame sites, try navigatin between frames with Tab/Shift-Tab, try the keyboard bindings, etc. ] By the way, the patch also contains a fix to a problem with dpid/Makefile.am (which did not honour DESTDIR on installation, messing up make install for non-root users). Let me know when you apply this, because it will affect the tab/frame/kbnav patch s well. Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Paul Pelzl

On Tue, Nov 11, 2003 at 10:37:41AM +0000, robert w hall wrote: > To reiterate > It would be _really nice_ if all these links to these very useful > patches were findable from the dillo main site :-) Perhaps some enterprising individual (not me) would be interested in hosting some sort of Dillo Wiki. Any patch authors could then post links on the wiki without having to bother website maintainers... Paul

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Indan Zupancic

> Note: When Indian continues to maintain his https patch i'll probably do > not bother with mine, lazy as i am... Also the Indian's idea of cleaning > up ccc into something more easy to understand is nice (current ccc has at > least one bad property - it is _hard_ to understand what goes on in it). It is my intention to keep my https up to date, it will be in a couple of days. I'm more or less waiting till Jorge tells me that I may go ahead with writing a patch that does that IOData and GDK stuff, or that he wants to keep it as it is now. That way it's clear for me what I can do, and how the more final version of my https patch should look like. I started documenting how the CCC functions are used currently in Dillo. After having it clear what happens now it's easier to see how to improve it, and what's wrong with the existing implementation. I do not know how hard it is to manage an experimental CVS branch, it has advantages and disadvantages. One pro is that the patches always work with eachother, because they use the same code, but that also means that the patches won't work seperately, that is, there is just an extended Dillo version, and no real patches anymore. It is very good to work with a stable code base, because then it's clear that all the encountered bugs are caused by your code, and not by someone else's code. Also it's useful when the base code doesn't change that much, especially when the patch is young. It is easier to keep the code up to date when it has it's own cvs branch, but on the other hand it could also mean that if someone drops his code and stops working on it, that someone else need to keep it up to date. Altogether quite risky. Of course everything is much simpler when only a few people use the alternative branch, it shouldn't be a dump place for never updated patches (tiny ones are ok of course). I think it will be only succesful when the branch is used only for things that have a chance to come in the official Dillo, as a sort of testing and developing place. Otherwise it will be very hard to keep it in sync with the official Dillo version, and the changes will only become greater after a while. Greetings, Indan

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by robert w hall

In message <Pine.LNX.4.58.0311111201430.31566(a)kiku.itsise>, Madis Janson <madis(a)ats.cyber.ee> writes >you can use my patch for 0.7.3 until something better appears... > >http://www.zone.ee/myzz/dillo/0.7.3/dillo-0.7.3-mzz-wtab.diff.bz2 >http://www.zone.ee/myzz/dillo/0.7.3/dillo-0.7.3-mzz.html > To reiterate It would be _really nice_ if all these links to these very useful patches were findable from the dillo main site :-) -- robert w hall

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Madis Janson

On Tue, 11 Nov 2003, Mike Eriksen wrote: > Sorry to interrupt... I'm a keen user of Dillo but no hacker. I'll not > comment on all the internals of Dillo since you guys are much more clever > on this than me. > > But, see - the reason why I like Dillo is that it is light and mean - and > can be tweaked into something I need. My need is a *light* browser which > can be fitted into a thin client but still allow you to read web mail. > This requires frame and https support. Other users of Dillo, like PDA > users, couldn't care less about frames and https. > you can use my patch for 0.7.3 until something better appears... http://www.zone.ee/myzz/dillo/0.7.3/dillo-0.7.3-mzz-wtab.diff.bz2 http://www.zone.ee/myzz/dillo/0.7.3/dillo-0.7.3-mzz.html It contains both tabs patch v6 and one https implementation (mine), but you should read sslgw/README to get it work, if you want to use it. Note: When Indian continues to maintain his https patch i'll probably do not bother with mine, lazy as i am... Also the Indian's idea of cleaning up ccc into something more easy to understand is nice (current ccc has at least one bad property - it is _hard_ to understand what goes on in it). > The key point here is that neither I nor the PDA guys really have > anywhere else to go than Dillo. >

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Frank de Lange

Indan Zupancic wrote: > Having a central place for all Dillo patches is always useful, because > that way it's easier to find and use them for users. Centralised isn't the > same as semi-official, it's a united effort of the patch makers. And that > means they probably have something betters to do, say, improving their > patch and keeping it up to date with cvs. ;) Another thing we can do is go the 'sylpheed-claws' route: create an extended version of Dillo, which regularly syncs up with Dillo CVS (and, possibly, the other way around). That way it is easier to create and maintain those features which are missing from Dillo. The risk is of course that the extended version starts to divert so far from CVS that it is hard to use it as a base to patch CVS. I've thought about going that way with the tab/frame/keyboard_navigation patch, as it does not get that much exposure currently. I have not done it yet, but given the number of patches which languish because of lack of exposure it is probably a good start. An 'experimental' branch on CVS and the main Dillo site would work as well of course... Cheers//Frank -- WWWWW ________________________ ## o o\ / Frank de Lange \ }# \| / +46-734352015 \ \ `--| _/ <Hacker for Hire> \ `---' \ +31-640037120 / \ frank(a)unternet.org / `------------------------' [ "Omnis enim res, quae dando non deficit, dum habetur et non datur, nondum habetur, quomodo habenda est." ]

Nov. 11, 2003

Re: libpng detection again...

by William Trenker

Jorge Arellano Cid wrote: > <candidate line> > CPPFLAGS="$CPPFLAGS `$PNG_CONFIG --cppflags`" > </candidate line> Yes! Hooray! I've been struggling with this for months and at last I have Dillo back again. After applying this change to configure.in and re-running autoconf the ./configure worked and I was able to build Dillo without a hitch. Thank you very much. And thanks Dillo team for a great browser! Regards, Bill

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Indan Zupancic

> When I tried to add Indans https patch, it > didn't work. Too old. Two weeks ago I tried the same. At that time the > problem was the opposite! Plain bad luck, Jorge just changed those files enough, and I was bussy with making a pc stable and upgrading it, all my Dillo files are backuped on another pc now, it's a slight mess. :) Also I want to merge the read/write IOData structures, and change to the GDK API, if Jorge and others agree with that. If that's going to change then updating my https patch now is a waste of time, because relatively much is going to change (the https patch will shrink incredibly :). > But in my humble oppinion either Dillo should release official minor > version (0.7.4, 0.7.5 etc) more often so privateers can offer patches > against these, or go along with this suggestion of Indans and support a > semi-official patch model. More often is not the point, Dillo is relatively close to 0.80 and far away from 0.73, so this seems to be just an unfortunate time for patches. Normally you should just use the 0.73 patches. There is no 0.73 https patch from me because I'm not happy with the current implementation, caused by all the hassle with keeping the two IOData structures synced and GTK's io channel annoyance. If there are fewer official Dillo versions it's easier to keep all the patches up to date. Actually, all what is needed is a cvs tag for each stable release, and maybe some extra tag for sort of beta versions that can be used for patches if it turns out that the official releases are not often enough for the patches. This way it's clear for the patches what Dillo version to use, so all can be relatively easily kept synchronized (at least for what Dillo version the patches use). Having a central place for all Dillo patches is always useful, because that way it's easier to find and use them for users. Centralised isn't the same as semi-official, it's a united effort of the patch makers. And that means they probably have something betters to do, say, improving their patch and keeping it up to date with cvs. ;) Greetings, Indan P.S. Seems like I just can't write short mails. :(

Nov. 11, 2003

Re: [Dillo-dev] HTTPS Patch

by Mike Eriksen

On Mon, 10 Nov 2003, Indan Zupancic wrote: [cut - a lot!] > > Making a web site (or page for it) requires time, if you're > > willing to do that, go ahead but beware that we do not support > >unofficial patches so you'd have to answer all the incoming > >questions too. > > Hmm, a web page, mind if I use the code of the splash screen as a basis? I > only want to make an installer so that it's easy for people who, for > instance, don't know what cvs is, to get a patched Dillo version. The goal > is to have some sort of centralized patch place, with patches that work > with eachother and are up to date. It requires time, true, but I'm willing > to spend time on Dillo. The installer has no priority though, would rather > spend my time to unite the IOData structures, switch to the GDK api, and > clean up the https patch for now. > > All the things I want to have different in Dillo I'm willing to change > myself. I'm not saying you should change this or that so or so, I ask if > you mind if I change or add some things a certain way, and if you agree > that it's better that way. > > Greetings, > > Indan Sorry to interrupt... I'm a keen user of Dillo but no hacker. I'll not comment on all the internals of Dillo since you guys are much more clever on this than me. But, see - the reason why I like Dillo is that it is light and mean - and can be tweaked into something I need. My need is a *light* browser which can be fitted into a thin client but still allow you to read web mail. This requires frame and https support. Other users of Dillo, like PDA users, couldn't care less about frames and https. The key point here is that neither I nor the PDA guys really have anywhere else to go than Dillo. I need to patch up Dillo with both Franks tab/frame patch and Indans https patch. Currently Franks patch is at ver. 14. The latest patch working on the most recent official Dillo release (0.7.3) is - as far as I remember - version 6. Today, when Franks new patch came out, I patched the Dillo cvs version with it. No problem. When I tried to add Indans https patch, it didn't work. Too old. Two weeks ago I tried the same. At that time the problem was the opposite! Honestly, this isn't a good situation. After following the mailing list for a couple of months I understand that the core developers have strong oppinions on the structure of the internals of Dillo. The is probably good since this created Dillo as it is in the first place. But in my humble oppinion either Dillo should release official minor version (0.7.4, 0.7.5 etc) more often so privateers can offer patches against these, or go along with this suggestion of Indans and support a semi-official patch model. The current model will not bring Dillo forward with the necessary speed, I fear. A lot of good ideas need to be tested and eventually absorbed if proven good. > (I wonder how many people wil read this 13K monster :) I did! And this post even looks short now ;-) Mike -- Thinstation FAQ maintainer http://thinstation.sourceforge.net - a light, full featured linux based thin client OS

Nov. 10, 2003