- Dillo-dev - lists.mailman3.com

Dillo in OSX

by corvid＠lavabit.com

I just remembered the bit in png.c that goes: /* Get and set gamma information. Beware: gamma correction 2.2 will only work on PC's. todo: select screen gamma correction for other platforms. */ if (png_get_gAMA(png_ptr, info_ptr, &gamma)) png_set_gamma(png_ptr, 2.2, gamma); Does that still need fixing up for OSX nowadays?

Aug. 14, 2008

Dillo in OSX

by jcid＠dillo.org

On Wed, Aug 13, 2008 at 03:51:46AM +0000, Daniel Mota Leite wrote: > Hi again > > Found the problem... had some old fltk includes in /usr/local > and was installing the cvs to /usr ... so dillo was mixing both > includes and breaking the compile. > > its fixed now, thanks for the help, specially Johannes :) FWIW, the latest CVS should compile without warnings on 64bit. (tested under xubuntu 8.04.1) -- Cheers Jorge.-

Aug. 13, 2008

Dillo in OSX

by higuita7＠yahoo.co.uk

Hi again Found the problem... had some old fltk includes in /usr/local and was installing the cvs to /usr ... so dillo was mixing both includes and breaking the compile. its fixed now, thanks for the help, specially Johannes :) higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

Aug. 13, 2008

towards a consistent UI

by jcid＠dillo.org

Hi, Well here's my opinion on these UI points: On Mon, Aug 04, 2008 at 09:50:24PM +0200, Johannes Hofmann wrote: > Hi, > > I really like the way Ctrl-l now just selects the current > URL in normal mode avoiding a dialog window. Me too! > In fullscreen mode however, the short switch to normal mode to enter > the new URL requires a complete redraw of the page contents. > Also the contents "jumps" down for the time the location bar is > shown. This can be distracting. Find text also causes a redraw. Maybe avoiding the redraw in both cases is a good solution. Not of high priority unless really simple to implement. > Do we really want to kill all uses of dialog windows? We still have > "Search the Web" anyway. No. Some dialog windows are quite OK, and there's no need I can see to ban them. > Also the location of the "IMG ON/OFF" button seems a bit arbitrary. I like it where it is, but agree on that it may find a better place. Together with the other Panel buttons, my be. > How could a consistent user interface of dillo look like? > > Here is my proposal - just to start the discussion: > > * Everything is accessible via the menubar and via keyboard > shortcuts. The shortcuts are shown behind the menu entries. Currently the main model is context sensitive popups (right click). There're some things you can't get from them (e.g. Open File), but I see no point in duplicating the popup menus from the menu bar. About everything being accessible via keyboard shortcuts, I don't agree. I believe there are simpler ways. For instance if there's a shortcut for every popup menu entry, there's a need to remember a lot of shortcut/function pairs. Now if there's a shortcut to popup the context sensitive menu, and that menu is keyboard operable, IMHO that's easier to remember/use. If there's a frequently used operation inside a popup, it may have its own shortcut. > shortcuts are shown behind the menu entries. Agreed. > * All shortcuts are configurable. Agreed. > > * No more img on/off button. One can use a menubar entry or keyboard > shortcut instead. I prefer the button. It's more visible and gives feedback on its current status. Firefox has this functionality somewhere, and a few people know of it. > * The "Search the Web" button should be just as all the other > buttons ("Back", "Forw" ...) and be configurable of course. Agreed. With something like: search_url="<title>,<URL>" in dillorc2, with the first one being the default for instance. > Perhaps a single config option like: > panel_buttons="back, forw, home, reload, save, stop, book" I prefer the boolean way (current model). > * The "HTML bugs" button in the status bar is ok. > It shows the bug-state of the current page. Agreed! > * "Search the Web" opens the start page of the selected search > engine (e.g. google.com) and selects the search text field. > I'm not sure about that, but it avoids the dialog window and it makes > clear to which search engine the query is sent. > The additional page load for the empty search page is only > required once - then it's cached. NO! :-) I love avoiding the search page. e.g. with google. ...but, yes, I see there may be cases where the native HTML interface is preferred. Maybe a simple flag can help it: search_url="<title>,<URL>[,LoadPage]" Thus, with no flag, we get a dialog: .------------------------------, | Search with <title>: | | [_________________________] | | | | [Cancel] [OK] | '------------------------------' and with the "LoadPage" flag, the HTML page. This can be implemented quickly! ;-) > * In fullscreen mode "Ctrl-l" opens a dialog window again. Any > better solution? If the redraw can be avoided, could be, if not, the dialog may be OK. I haven't used this case too much so I don't *feel* the problem. -- Cheers Jorge.-

Aug. 11, 2008

Dillo in OSX

by Johannes.Hofmann＠gmx.de

-------- Original-Nachricht -------- > Datum: Mon, 11 Aug 2008 03:32:15 +0100 > Von: higuita <higuita(a)GMX.net> > An: "Johannes Hofmann" <Johannes.Hofmann(a)gmx.de> > Betreff: Re: [Dillo-dev] Dillo in OSX > Hi > > On Sun, 10 Aug 2008 11:36:08 +0200, "Johannes Hofmann" > <Johannes.Hofmann(a)gmx.de> wrote: > > Hm, maybe some stale fltk2 header files? > > i clean up the root dw2 folder and done a new cvs up && autogen.sh && > configure ... but still it failled > > > You could try to add -E to the failing g++ call above to check the > > preprocessed sources. > > in a command line, i added the -E and it build successful > (no error)... > if i force success on that g++ command, i can continue and > build dillo successful and dillo seems to work fine > > bad fltk install? broken compiler? > should i totally remove the dillo2 and do a totally new checkout? > > :) > > thanks in advance for the help I suspect it is somehow related to your fltk2 installation. Perhaps you have one from your distribution and a self compiled version at the same time? Johannes -- GMX Kostenlose Spiele: Einfach online spielen und Spa? haben mit Pastry Passion! http://games.entertainment.gmx.net/de/entertainment/games/free/puzzle/61691…

Aug. 11, 2008

Dillo in OSX

by higuita7＠yahoo.co.uk

Hi On Mon, 4 Aug 2008 18:50:17 -0400, Jorge Arellano Cid <jcid(a)dillo.org> wrote: > Great, committed. > I works, dillo2 runs native in Leopard > There are several glitches but it's quite a good start. 8-) humm... if g++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"dw-testbed\" -DVERSION=\"0.0.43j\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_FCNTL_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_UIO_H=1 -I. -I. -I/usr/local/include -I/usr/include/freetype2 -Wno-non-virtual-dtor -g -O2 -D_REENTRANT -D_THREAD_SAFE -Wall -MT libDw_fltk_a-fltkmisc.o -MD -MP -MF ".deps/libDw_fltk_a-fltkmisc.Tpo" -c -o libDw_fltk_a-fltkmisc.o `test -f 'fltkmisc.cc' || echo './'`fltkmisc.cc; \ then mv -f ".deps/libDw_fltk_a-fltkmisc.Tpo" ".deps/libDw_fltk_a-fltkmisc.Po"; else rm -f ".deps/libDw_fltk_a-fltkmisc.Tpo"; exit 1; fi fltkmisc.cc: In function 'void dw::fltk::misc::warpPointer(int, int)': fltkmisc.cc:45: error: 'warp_mouse' is not a member of 'fltk' make[1]: *** [libDw_fltk_a-fltkmisc.o] Error 1 make[1]: Leaving directory `/home/higuita/build/dillo2/dw2/dw' make: *** [all-recursive] Error 1 i'm using the latest svn from fltk and from dillo... i'm using slamd64 (slackware 64bits) thanks higuita -- Naturally the common people don't want war... but after all it is the leaders of a country who determine the policy, and it is always a simple matter to drag the people along, whether it is a democracy, or a fascist dictatorship, or a parliament, or a communist dictatorship. Voice or no voice, the people can always be brought to the bidding of the leaders. That is easy. All you have to do is tell them they are being attacked, and denounce the pacifists for lack of patriotism and exposing the country to danger. It works the same in every country. -- Hermann Goering, Nazi and war criminal, 1883-1946

Aug. 10, 2008

an example of page redraw problem when images load

by corvid＠lavabit.com

With automatic image loading turned off, if I go to http://genode.org/documentation/developer-resources/walk_through , page down to the [IMG] below "The launchpad application starter", and click on it, the space to the right of the image still contains remnants of the text that used to be there.

Aug. 9, 2008

Re: patch: form controls outside of forms

by jcid＠dillo.org

On Sun, Jul 20, 2008 at 07:38:56PM +0000, corvid wrote: > *remind* *remind* In absence of comment, I decided to commit it. -- Cheers Jorge.-

Aug. 6, 2008

Dillo in OSX

by jcid＠dillo.org

On Sun, Aug 03, 2008 at 07:52:56PM +0200, Johannes Hofmann wrote: > Hi Jorge, > > On Sun, Aug 03, 2008 at 01:30:01PM -0400, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > When trying to compile dillo2 in OSX, FLTK2 compiles OK, > > dw's fltkviewbase.hh needs an time.h include and I get this > > error: > > > > isc.Tpo -c -o libDw_fltk_a-fltkmisc.o `test -f 'fltkmisc.cc' || echo > > './'`fltkmisc.cc > > fltkmisc.cc: In function 'int dw::fltk::misc::screenWidth()': > > fltkmisc.cc:34: error: 'xdisplay' is not a member of 'fltk' > > fltkmisc.cc:34: error: 'xscreen' is not a member of 'fltk' > > fltkmisc.cc:34: error: 'DisplayWidth' was not declared in this scope > > fltkmisc.cc: In function 'int dw::fltk::misc::screenHeight()': > > fltkmisc.cc:39: error: 'xdisplay' is not a member of 'fltk' > > fltkmisc.cc:39: error: 'xscreen' is not a member of 'fltk' > > fltkmisc.cc:39: error: 'DisplayHeight' was not declared in this scope > > fltkmisc.cc: In function 'void dw::fltk::misc::warpPointer(int, int)': > > fltkmisc.cc:44: error: 'xdisplay' is not a member of 'fltk' > > fltkmisc.cc:44: error: 'None' was not declared in this scope > > fltkmisc.cc:45: error: 'xdisplay' is not a member of 'fltk' > > fltkmisc.cc:45: error: 'xscreen' is not a member of 'fltk' > > fltkmisc.cc:45: error: 'RootWindow' was not declared in this scope > > fltkmisc.cc:46: error: 'XWarpPointer' was not declared in this scope > > make[1]: *** [libDw_fltk_a-fltkmisc.o] Error 1 > > make: *** [all-recursive] Error 1 > > > > Do you know the proper solution for this? > > Can you please try attached patch? It replaces X11 specific calls > with platform independent ones from fltk2. > They probabely didn't exist when fltkmisc.cc was coded. > Great, committed. I works, dillo2 runs native in Leopard! There are several glitches but it's quite a good start. 8-) -- Cheers Jorge.-

Aug. 5, 2008

towards a consistent UI

by Johannes.Hofmann＠gmx.de

Hi, I really like the way Ctrl-l now just selects the current URL in normal mode avoiding a dialog window. In fullscreen mode however, the short switch to normal mode to enter the new URL requires a complete redraw of the page contents. Also the contents "jumps" down for the time the location bar is shown. This can be distracting. Do we really want to kill all uses of dialog windows? We still have "Search the Web" anyway. Also the location of the "IMG ON/OFF" button seems a bit arbitrary. How could a consistent user interface of dillo look like? Here is my proposal - just to start the discussion: * Everything is accessible via the menubar and via keyboard shortcuts. The shortcuts are shown behind the menu entries. * All shortcuts are configurable. * No more img on/off button. One can use a menubar entry or keyboard shortcut instead. * The "Search the Web" button should be just as all the other buttons ("Back", "Forw" ...) and be configurable of course. Perhaps a single config option like: panel_buttons="back, forw, home, reload, save, stop, book" * The "HTML bugs" button in the status bar is ok. It shows the bug-state of the current page. * "Search the Web" opens the start page of the selected search engine (e.g. google.com) and selects the search text field. I'm not sure about that, but it avoids the dialog window and it makes clear to which search engine the query is sent. The additional page load for the empty search page is only required once - then it's cached. * In fullscreen mode "Ctrl-l" opens a dialog window again. Any better solution? Cheers, Johannes

Aug. 4, 2008

Dillo in OSX

by Johannes.Hofmann＠gmx.de

Hi Jorge, On Sun, Aug 03, 2008 at 01:30:01PM -0400, Jorge Arellano Cid wrote: > Hi Johannes, > > When trying to compile dillo2 in OSX, FLTK2 compiles OK, > dw's fltkviewbase.hh needs an time.h include and I get this > error: > > isc.Tpo -c -o libDw_fltk_a-fltkmisc.o `test -f 'fltkmisc.cc' || echo > './'`fltkmisc.cc > fltkmisc.cc: In function 'int dw::fltk::misc::screenWidth()': > fltkmisc.cc:34: error: 'xdisplay' is not a member of 'fltk' > fltkmisc.cc:34: error: 'xscreen' is not a member of 'fltk' > fltkmisc.cc:34: error: 'DisplayWidth' was not declared in this scope > fltkmisc.cc: In function 'int dw::fltk::misc::screenHeight()': > fltkmisc.cc:39: error: 'xdisplay' is not a member of 'fltk' > fltkmisc.cc:39: error: 'xscreen' is not a member of 'fltk' > fltkmisc.cc:39: error: 'DisplayHeight' was not declared in this scope > fltkmisc.cc: In function 'void dw::fltk::misc::warpPointer(int, int)': > fltkmisc.cc:44: error: 'xdisplay' is not a member of 'fltk' > fltkmisc.cc:44: error: 'None' was not declared in this scope > fltkmisc.cc:45: error: 'xdisplay' is not a member of 'fltk' > fltkmisc.cc:45: error: 'xscreen' is not a member of 'fltk' > fltkmisc.cc:45: error: 'RootWindow' was not declared in this scope > fltkmisc.cc:46: error: 'XWarpPointer' was not declared in this scope > make[1]: *** [libDw_fltk_a-fltkmisc.o] Error 1 > make: *** [all-recursive] Error 1 > > Do you know the proper solution for this? Can you please try attached patch? It replaces X11 specific calls with platform independent ones from fltk2. They probabely didn't exist when fltkmisc.cc was coded. Cheers, Johannes

Aug. 3, 2008

Dillo in OSX

by jcid＠dillo.org

Hi Johannes, When trying to compile dillo2 in OSX, FLTK2 compiles OK, dw's fltkviewbase.hh needs an time.h include and I get this error: isc.Tpo -c -o libDw_fltk_a-fltkmisc.o `test -f 'fltkmisc.cc' || echo './'`fltkmisc.cc fltkmisc.cc: In function 'int dw::fltk::misc::screenWidth()': fltkmisc.cc:34: error: 'xdisplay' is not a member of 'fltk' fltkmisc.cc:34: error: 'xscreen' is not a member of 'fltk' fltkmisc.cc:34: error: 'DisplayWidth' was not declared in this scope fltkmisc.cc: In function 'int dw::fltk::misc::screenHeight()': fltkmisc.cc:39: error: 'xdisplay' is not a member of 'fltk' fltkmisc.cc:39: error: 'xscreen' is not a member of 'fltk' fltkmisc.cc:39: error: 'DisplayHeight' was not declared in this scope fltkmisc.cc: In function 'void dw::fltk::misc::warpPointer(int, int)': fltkmisc.cc:44: error: 'xdisplay' is not a member of 'fltk' fltkmisc.cc:44: error: 'None' was not declared in this scope fltkmisc.cc:45: error: 'xdisplay' is not a member of 'fltk' fltkmisc.cc:45: error: 'xscreen' is not a member of 'fltk' fltkmisc.cc:45: error: 'RootWindow' was not declared in this scope fltkmisc.cc:46: error: 'XWarpPointer' was not declared in this scope make[1]: *** [libDw_fltk_a-fltkmisc.o] Error 1 make: *** [all-recursive] Error 1 Do you know the proper solution for this? -- Cheers Jorge.-

Aug. 3, 2008

[patch] Another selection redraw fix

by jcid＠dillo.org

On Wed, Jul 30, 2008 at 04:43:36PM +0200, Johannes Hofmann wrote: > Hi, > > attached is another selection redraw related fix. Again, when > selecting text a too large area was redrawn. Committed. -- Cheers Jorge.-

July 30, 2008

[corvid@lavabit.com: Re: patch: form controls outside of forms]

by Johannes.Hofmann＠gmx.de

On Wed, Jul 30, 2008 at 10:47:21AM -0400, Jorge Arellano Cid wrote: > Hi, > > After the WearLab outage (web site, email, ssh, cvs, mailing > list, smoke signals...), let's try to resume from where we were. > > Jeremy: please review the "form controls outside of forms" > patch (to commit afterwards). > > Michal wrote: > > Some nice fable, had to do something regarding this :). > Which one?! *please* 8-) > > Evrerybody: > Does anybody know what happened with the WearLab? Not sure, but as I couldn't reach Andreas Kemnade, I wrote a mail to info(a)tzi.de. They then tried to find a responsible administrator. Cheers, Johannes

July 30, 2008

[patch] Another selection redraw fix

by Johannes.Hofmann＠gmx.de

Hi, attached is another selection redraw related fix. Again, when selecting text a too large area was redrawn. Cheers, Johannes PS: This is a resend. The original mail probabely got lost.

July 30, 2008

[corvid@lavabit.com: Re: patch: form controls outside of forms]

by jcid＠dillo.org

Hi, After the WearLab outage (web site, email, ssh, cvs, mailing list, smoke signals...), let's try to resume from where we were. Jeremy: please review the "form controls outside of forms" patch (to commit afterwards). Michal wrote: > Some nice fable, had to do something regarding this :). Which one?! *please* 8-) Evrerybody: Does anybody know what happened with the WearLab? -- Cheers Jorge.-

July 30, 2008

[patch] reduce redraw overhead when selecting text

by jcid＠dillo.org

On Fri, Jul 18, 2008 at 04:41:55PM +0200, Johannes Hofmann wrote: > Hi, > > here is a small bugfix that reduces the area that gets redrawn when > selecting text. The improvement is mostly noticable when running > dillo in a remote X11 session. Committed. -- Cheers Jorge.-

July 30, 2008

CVS problems

by onepoint＠starurchin.org

On Wed, Jul 30, 2008 at 01:31:08PM +0200, Michal Nowak wrote: > > Actually I saw whole dillo.org down + mailing list... Yes, it was "No route to host" for a while so I assumed everything was offline. > auriga.wearlab.de) too but, at least now, CVS repo runs. /me retries... yes it does! I hope whatever caused the outage is now fixed. > Some nice fable, had to do something regarding this :). Really? Which? None spring to my mind. Regards, Jeremy Henty

July 30, 2008

CVS problems

by newman.x＠gmail.com

On Wed, 2008-07-30 at 10:27 +0100, Jeremy Henty wrote: > I have not been able to "cvs update" for a few days now. I get "cvs > [update aborted]: connect to auriga.wearlab.de(134.102.206.165):2401 > failed: Connection timed out". Does anyone else see this? What's the > problem? Actually I saw whole dillo.org down + mailing list (both auriga.wearlab.de) too but, at least now, CVS repo runs. Some nice fable, had to do something regarding this :). -- Michal Nowak <newman.x(a)gmail.com>

July 30, 2008

CVS problems

by onepoint＠starurchin.org

I have not been able to "cvs update" for a few days now. I get "cvs [update aborted]: connect to auriga.wearlab.de(134.102.206.165):2401 failed: Connection timed out". Does anyone else see this? What's the problem? Regards, Jeremy Henty

July 30, 2008

[patch] reduce redraw overhead when selecting text

by Johannes.Hofmann＠gmx.de

Hi, here is a small bugfix that reduces the area that gets redrawn when selecting text. The improvement is mostly noticable when running dillo in a remote X11 session. Cheers, Johannes

July 18, 2008

[patch] selecting multibyte glyphs

by onepoint＠starurchin.org

On Thu, Jul 17, 2008 at 01:56:51PM -0400, Jorge Arellano Cid wrote: > On Thu, Jul 17, 2008 at 06:41:58PM +0200, Johannes Hofmann wrote: > > > > here is a patch to fix selection of multibyte glyphs as discussed > > earlier. > > Committed. Excellent! This one has annoyed me for ages. I just checked that it works with en-dashes, em-dashes and smart-quotes (which seem to be all the common cases). Cheers, Jeremy Henty

July 17, 2008

[patch] selecting multibyte glyphs

by jcid＠dillo.org

On Thu, Jul 17, 2008 at 06:41:58PM +0200, Johannes Hofmann wrote: > Hi, > > here is a patch to fix selection of multibyte glyphs as > discussed earlier. Good! Committed. -- Cheers Jorge.-

July 17, 2008

[patch] selecting multibyte glyphs

by Johannes.Hofmann＠gmx.de

Hi, here is a patch to fix selection of multibyte glyphs as discussed earlier. Cheers, Johannes

July 17, 2008

selecting multi-byte characters

by Johannes.Hofmann＠gmx.de

On Thu, Jul 10, 2008 at 11:11:01AM -0400, Jorge Arellano Cid wrote: > On Wed, Jul 09, 2008 at 05:41:35PM +0200, Johannes Hofmann wrote: > > Hi, > > > > as you may have noticed, there is a problem with selecting > > multi-byte characters. If you enlarge the selection so that e.g. '?' > > is at the edge of the selected text, the character changes in weird > > ways. > > This is due to the Textblock::sendSelectionEvent() code that simply > > uses charPos++, and charPos-- whereas it should do something like > > utf8fwd() or utf8back() from fltk. > > The problem here is that we can't simply use fltk functions in > > textblock.cc as it is independent of the GUI toolkit. > > Any ideas how to solve this? I thought about adding wrappers to > > fltkmisc.cc but that's also a bit ugly... > > AFAIS, utf8fwd() and utf8back() can be defined in platform.hh > (right after textWidth() for instance), and implemented as > wrappers in fltkplatform.hh, then used from layout in the same > inlined way as textWidth. That sounds good. I will try to come up with a patch. Cheers, Johannes

July 13, 2008

Navigation popups

by jcid＠dillo.org

Hi, Finally I found a simple way to make the navigation history popups discern the clicking mouse button. Now you can open a new window by middle clicking on history popups. A feature I missed a lot since dillo1. -- Cheers Jorge.-

July 12, 2008

selecting multi-byte characters

by jcid＠dillo.org

On Wed, Jul 09, 2008 at 05:41:35PM +0200, Johannes Hofmann wrote: > Hi, > > as you may have noticed, there is a problem with selecting > multi-byte characters. If you enlarge the selection so that e.g. '?' > is at the edge of the selected text, the character changes in weird > ways. > This is due to the Textblock::sendSelectionEvent() code that simply > uses charPos++, and charPos-- whereas it should do something like > utf8fwd() or utf8back() from fltk. > The problem here is that we can't simply use fltk functions in > textblock.cc as it is independent of the GUI toolkit. > Any ideas how to solve this? I thought about adding wrappers to > fltkmisc.cc but that's also a bit ugly... AFAIS, utf8fwd() and utf8back() can be defined in platform.hh (right after textWidth() for instance), and implemented as wrappers in fltkplatform.hh, then used from layout in the same inlined way as textWidth. -- Cheers Jorge.-

July 12, 2008

selecting multi-byte characters

by Johannes.Hofmann＠gmx.de

Hi, as you may have noticed, there is a problem with selecting multi-byte characters. If you enlarge the selection so that e.g. '?' is at the edge of the selected text, the character changes in weird ways. This is due to the Textblock::sendSelectionEvent() code that simply uses charPos++, and charPos-- whereas it should do something like utf8fwd() or utf8back() from fltk. The problem here is that we can't simply use fltk functions in textblock.cc as it is independent of the GUI toolkit. Any ideas how to solve this? I thought about adding wrappers to fltkmisc.cc but that's also a bit ugly... Cheers, Johannes

July 9, 2008

patch: (any Solarians in the audience?) rm nanosleep solaris workaround

by jcid＠dillo.org

On Sat, Jul 05, 2008 at 02:07:05AM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Johannes Hofmann wrote: > > On Fri, Jul 04, 2008 at 08:30:42PM +0200, Justus Winter wrote: > >> Jorge Arellano Cid wrote: > >>> Let's hope for somebody to have FLTK2 and dillo2 in Solaris! :) > >> I tried that, but last time I checked fltk2 failed to build on > >> Solaris10/sparc. I filed a bug [1] but got no response. > > > > Can you try this: > > > > [...] > > > > It's just a wild guess, but I could imagine, that Solaris 10 now has > > proper scandir support. > > Yes, you are right. This solved that issue. It took some more time of > hunting libraries in obscure places where the fltk build system couldn't > find them (isn't Solaris a nice platform... and the userland takes you > back in time for no extra cost :-/), but in the end it compiled fine. Good to know it works there too! If there's a general patch for configure.in with Solaris, just let us know. > Dillo2 also compiles and runs fine, only the dpid failed to start. It > turned out that there is a small error that the solaris printf kindly > exposed... patch is attached. Committed. > With that patch applied everything (well, the bookmark dpi) seems to be > working as expected. I will do some more testing next week when I get > physically closer to that box... If you can look at local files, the file dpi is also working and that's mainly it. -- Cheers Jorge.-

July 5, 2008

Attention subscribers

by newman.x＠gmail.com

On Fri, 2008-07-04 at 11:51 -0400, Jorge Arellano Cid wrote: > Hi subscribers, > > For those that subscribed long ago but couldn't get > your messages across, your accounts have been cleared > for posting. > > Sorry for the inconvinience, the dillo project is > slowly getting into full pace again... > ping test -- Michal Nowak <newman.x(a)gmail.com>

July 5, 2008

patch: (any Solarians in the audience?) rm nanosleep solaris workaround

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Johannes Hofmann wrote: > On Fri, Jul 04, 2008 at 08:30:42PM +0200, Justus Winter wrote: >> Jorge Arellano Cid wrote: >>> Let's hope for somebody to have FLTK2 and dillo2 in Solaris! :) >> I tried that, but last time I checked fltk2 failed to build on >> Solaris10/sparc. I filed a bug [1] but got no response. > > Can you try this: > > [...] > > It's just a wild guess, but I could imagine, that Solaris 10 now has > proper scandir support. Yes, you are right. This solved that issue. It took some more time of hunting libraries in obscure places where the fltk build system couldn't find them (isn't Solaris a nice platform... and the userland takes you back in time for no extra cost :-/), but in the end it compiled fine. Dillo2 also compiles and runs fine, only the dpid failed to start. It turned out that there is a small error that the solaris printf kindly exposed... patch is attached. With that patch applied everything (well, the bookmark dpi) seems to be working as expected. I will do some more testing next week when I get physically closer to that box... Justus -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIbrspoPmwNWhsaZYRAtMhAJ9svDei4lfRsWzU1jX0QXTEl/AZTACgg5xJ mw8myfHJNNiHSueY0KiLM/o= =aOrm -----END PGP SIGNATURE-----

July 5, 2008

Please help me on this...

by Johannes.Hofmann＠gmx.de

On Fri, Jul 04, 2008 at 06:32:33PM +0000, corvid wrote: > Johannes wrote: > > Also we could try to make dillo work nice as an untrusted X11 > > client. It almost works fine already btw. > > What is involved in making it an untrusted client? http://dailypackage.fedorabook.com/index.php?/archives/48-Wednesday-Why-Tru… Is a good article. Normally each X11 client can access/modify data of every other client. Untrusted clients are more restricted. Using this feature one can for example create a separate user "web" just for browsing and then do: ssh -X -l web localhost dillo-fltk Then if dillo-fltk get's compromised, the damage would be restricted to the web user. Cheers, Johannes PS: One can avoid the unnecessary encryption overhead of using ssh by doing some xauth(1) magic instead.

July 4, 2008

patch: (any Solarians in the audience?) rm nanosleep solaris workaround

by Johannes.Hofmann＠gmx.de

On Fri, Jul 04, 2008 at 08:30:42PM +0200, Justus Winter wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Jorge Arellano Cid wrote: > > On Tue, Jul 01, 2008 at 09:57:59PM +0000, corvid wrote: > >> It seems that there was a nanosleep() in src/IO/dpi.c long ago, > >> but I can't find any nanosleep()s anywhere anymore, so... > > > > Committed. > > > > Let's hope for somebody to have FLTK2 and dillo2 in Solaris! :) > > I tried that, but last time I checked fltk2 failed to build on > Solaris10/sparc. I filed a bug [1] but got no response. Can you try this: diff -r 0a9067b60fe3 configure.in --- a/configure.in Sat Jun 28 10:54:24 2008 +0200 +++ b/configure.in Fri Jul 04 20:32:07 2008 +0200 @@ -324,7 +324,7 @@ AC_CHECK_HEADER(sys/select.h,AC_DEFINE(H AC_CHECK_HEADER(sys/select.h,AC_DEFINE(HAVE_SYS_SELECT_H)) AC_CHECK_HEADER(sys/stdtypes.h,AC_DEFINE(HAVE_SYS_SELECT_H)) AC_CHECK_FUNC(scandir,[ - if test "$uname" = SunOS -o "$uname" = QNX; then + if test "$uname" = QNX; then AC_MSG_WARN(Not using $uname scandir emulation function.) else AC_DEFINE(HAVE_SCANDIR) It's just a wild guess, but I could imagine, that Solaris 10 now has proper scandir support. Cheers, Johannes

July 4, 2008

Please help me on this...

by corvid＠lavabit.com

Johannes wrote: > Also we could try to make dillo work nice as an untrusted X11 > client. It almost works fine already btw. What is involved in making it an untrusted client?

July 4, 2008

patch: (any Solarians in the audience?) rm nanosleep solaris workaround

by 4winter＠informatik.uni-hamburg.de

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jorge Arellano Cid wrote: > On Tue, Jul 01, 2008 at 09:57:59PM +0000, corvid wrote: >> It seems that there was a nanosleep() in src/IO/dpi.c long ago, >> but I can't find any nanosleep()s anywhere anymore, so... > > Committed. > > Let's hope for somebody to have FLTK2 and dillo2 in Solaris! :) I tried that, but last time I checked fltk2 failed to build on Solaris10/sparc. I filed a bug [1] but got no response. Justus 1: http://fltk.org/str.php?L1890 - -- gpg key fingerprint: C82D 382A AB38 1A54 5290 19D6 A0F9 B035 686C 6996 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIbmxSoPmwNWhsaZYRAhDgAJ9QtZaVSxw4WgVI8hxef1HRbUC0wgCglHv2 95X6xEp4bT40XIQrq9P3Yvo= =PTk3 -----END PGP SIGNATURE-----

July 4, 2008

Please help me on this...

by Johannes.Hofmann＠gmx.de

Hi, On Thu, Jul 03, 2008 at 04:19:29PM -0400, Jorge Arellano Cid wrote: > Hi there, > > Looking to a future dillo2 release for the public, I was > wondering about the main drive behind dillo2. > > I mean, in this years of Facebook, WebKit, Flash, propietary > video codecs, etc. what's the main point behind dillo2? > > From the objectives: > > 1.- The democratization of internet information access. > 2.- Personal security and privacy. For me these two are becoming more important in the face of: http://news.slashdot.org/news/08/07/04/1343214.shtml http://tech.slashdot.org/tech/08/07/03/2156204.shtml http://tech.slashdot.org/tech/08/07/03/0310203.shtml ... > 3.- High software efficiency. > > The first one is interesting to analyze along the lines that > dillo allows to search for tons of information spread through the > Internet using low HW requirements and low bandwidth as a dialup. > This is reassuring as dillo efectively enables information > access to any person under such constraints. > > The second one is partly attained by not writing to HD and by a > non-existent scripting support. Yes, non-existent scripting is a feature. However I think there is more we can do regarding security. Bug fixes and reviewing of the parser. Someone already talked about some tool to test dillo with random incorrect html - I need to check this. Also we could try to make dillo work nice as an untrusted X11 client. It almost works fine already btw. > > The third one is the one to brag about. ;-) :-) > > > Since some time, the thought that enabling dillo2 as a help > browser could also bring local information (i.e. in HD) closer to > the user came as a powerful one. Having an app. that pops-up in a > second and that's quick, responsive and easy to use is certainly > a strong drive for a person in search of information (that's why > I'd like to see it inside Debian as a help system). > > In the near future, I'd like to have CSS and proper floating > text rendering (DIV element), plus an API as a help browser. > > > There're countries where paying Universitary studies is the > state's burden. If a citizen doesn't want to study there, it's a > choice. I think the same may happen with dillo, once people know > about it, they can choose to use it or not. > > While thinking about it, these comments surprised me: > > "Slashdot | What Do You Want On Future Browsers?" > http://tech.slashdot.org/article.pl?sid=08/06/30/1845201 > > (yes, give them a read!) > > (They're talking from a full featured Firefox basis. I > don't know how may of them would like to use something like > dillo) > I'm sure there will be quite some interest in dillo. Even more, if it will support CSS one day. http://fltk.org/newsgroups.php?s4845+gfltk.development+v4846+T0 and http://wiki.openmoko.org/wiki/Web_Browser is interesting too. Also it should already be possible to compile dillo-fltk on OSX and with some work also under Cygwin. No X11 needed in both cases! Anyway, if we focus on making a browser that suits our needs, it will most probabely also suit others. > > Behind a project like ours, there're two communities: > developers and users. The main factor to push forward the project > is developers and their motivations (in a commercial environment > what pushes the development is the money invested and the profit > margins/strategy sought). > > That's why I'm asking you to help me with your views, needs > visions on the future of dillo2 these days. My vision is a secure, fast, and stable browser with a nice community :-) > > With regard to the user community, I'd love to have some > feedback from them, but I guess we need to release dillo2 first! > > :-) > Cheers, Johannes

July 4, 2008

[patch] iterator related bugs

by jcid＠dillo.org

On Fri, Jul 04, 2008 at 05:27:21PM +0200, Johannes Hofmann wrote: > On Fri, Jul 04, 2008 at 11:19:43AM -0400, Jorge Arellano Cid wrote: > > On Thu, Jul 03, 2008 at 04:09:19PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > now I have a reliable way to reproduce the problem. On DragonFly I > > > use debug malloc options, but valgrind should also work. Even > > > without any debug features I can crash dillo that way, but it takes > > > longer. > > > > > > * Choose a rather long page that does not fit on the screen with > > > lot's of links. I use my bookmarks page. > > > > > > * Start the search dialog and enter a very common string e.g. 2 > > > chars and hold the Enter key down. Dillo now scrolls through the > > > page over and over again. > > > > > > * Now click the 1. mouse button and move the mouse like crazy over > > > the scrolling page so arbitrary text gets selected and deselected. > > > > > > That crashes dillo pretty soon for me. > > > > Funny as it may look, I can't reproduce it here. Maybe it's not > > strange because we've already noticed DragonFly handles memory in > > a different way than GNU/Linux. > > > > I could crash it like this under valgrind on a linux box. I also tried with: valgrind --tool=memcheck --leak-check=yes ./dillo-fltk but I believe you! :-) > > > > BTW, it's in things like this that I really dislike C++... > > Yes, it can get tricky. On the other hand C++ in dillo is pretty > harmless compared to other projects :-) 8-P -- Cheers Jorge.-

July 4, 2008

[patch] cleanup ZoneAllocator

by Johannes.Hofmann＠gmx.de

On Fri, Jul 04, 2008 at 05:06:22PM +0200, Enrico Weigelt wrote: > * Jorge Arellano Cid <jcid(a)dillo.org> schrieb: > > On Mon, Jun 23, 2008 at 07:38:42PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > here comes me ZoneAllocator cleanup again. This time without the > > > questionable strlen() stuff. > > > > Committed. > > BTW: could this allocator live in it's own lib ? > Would be nice, to have an universal lib for that, IMHO :) It depends on SimpleVector. The lout stuff as a whole is a nice little library. Or, if that's too bloated, you can use the lout/misc.hh file standalone :-) Cheers, Johannes

July 4, 2008

Attention subscribers

by jcid＠dillo.org

Hi subscribers, For those that subscribed long ago but couldn't get your messages across, your accounts have been cleared for posting. Sorry for the inconvinience, the dillo project is slowly getting into full pace again... -- Cheers Jorge.-

July 4, 2008

9P

by weigelt＠metux.de

* Jorge Arellano Cid <jcid(a)dillo.org> schrieb: > It took some time to get back to you, but the topics raised are > non trivial. Let's start with the simpler one: What exactly does it make so complex ? BTW: on Plan9 even the whole web access runs via its own fileserver (webfs). IMHO we should keep that in mind and someday go that way. > > ACK. Maybe would should go the way Mutt does: it internally > > works with commands, and keystrokes are mapped to commands. > > Perfect for me. > > If you can patch dillo to do that, it'd be great. I'm currently too occupied, but you may trigger me in about a month ago :) > > you can add me, as long as no C++ stuff is involved. > > (don't like it's overhead). > > I also don't like C++ and its complexity! > > FLTK2 is in C++ so we had to interface with it. The idea was to > keep C++ to a minimum set of features. Does it really have to be fltk2 ? Aren't there enough other widget toolkits (in plain-C) out there ? > OTOH, windowing systems and widgets are quite well suited for > the object oriented approach, and in some places it gets simpler > than dealing directly with inheritance in C (as with GTK1). hmm, does gtk2 make it better ? > > [Translations] > > I'm already working on German translation. > > Are you working on a generic approach to translations or just German? I just added a new transled the .po file. > > [CSS] > > > * Planning for CSS, floating objects and TABS. > > > (this are important features to a nice browsing experience) > > > > Missing CSS is really bad. > > I'm planning to write an universal but small CSS parser > > (as an separate library). > > You may give a look to RCSS by Raph Levien. Okay, I'll have a look at if time allows. > > [Dillo as a help system] > > I'd like to use Dillo for an help system and control center on an > > end-user desktop appliance. Therefore I need it to execute certain > > commands. But Dillo itself should not fork/exec itself, instead > > send the commands to some special daemon via an 9P channel. > > I'd like to have Dillo as a help system in Debian! Well, that's a bit similar :) > > An simple approach could be coding an dpi which just parses the > > requested URL and sends the actual command to the exec server > > through 9P. But I have to make absolutely sure that commands > > can only be sent when coming from certain pages. > > > > How can I achieve this ? > > A simple way is to isolate those "certain pages" into a fixed URL scheme > (e.g. localhost:8081/admin file:/etc/read_only_directory/) and to check that > signature from the dpi. For this to work, you have to send the "requesting URL" > to the dpi by using dpip. hmm, we could introduce a new exec:// url scheme and filter by Referer-Header. > > I'd prefer a more generic approach: making everything available > > via 9P and let separate programs work on that filesystem. > > This also allows lot's other funny things, eg. an HTML external > > editor which directly operates on an document within an dillo > > viewer ;-) > > The 9P way of interaction is powerful. > > I like the idea of interfacing to a Javascript VM with 9P, > and reusing a proved protocol instead of having to extend/debug > dpip. :) Maybe be we even could replace the whole dpip stuff by 9P. > Now, being a 9P newbie, how much (in LOC or KB) does it add > to become a 9P server or client? This is my main concern. Quite minimal. Have a look at: svn://svn.metux.de/public/9exec svn://svn.metux.de/public/9p-mixerfs svn://svn.metux.de/public/9p-sysdb_fs The libs used: svn://svn.metux.de/public/libmixp svn://svn.metux.de/public/libmixpsrv And an vfs library that supports 9p: svn://svn.metux.de/public/libmvfs (authenticate with anonymous:anonymous to svn) > I'd like to see a sketch of a Dillo help system design using 9P. > Currently dpid would provide a Unix socket to command Dillo, and 9P > does something quite similar but more generic. The idea of being able > to remote-control Dillo from a simple application/script with a 9P > interface is more than interesting. Yep :) With libmixpsrv you can easily provide access to variables or commands through an filesystem. No more additional protocol needed - everything just sits in an hierachy with an simple and uniform access model. > For instance: Load URL, Reload, Stop, Open New window, Back, Forward, > images on/off, etc. Right, settings are just files (one file per setting). Actions are performed by writing to certain files. Let's say, some viewer is in the subdir /viewers/1/, you just write to /viewers/1/url to load a new page. > AFAIS, we'd need to make dillo work internally with commands, and > then exposing that interface for the external world. If the dillo help > system design looks interesting we can start from there. Obviously you > have given it some thought in your project so please share your ideas > with us. I'll summarize evrything as soon as I've got more time. (currently in jack-bauer-mode ;-)) > Obviously using 9P to remote-control dillo seems like an overkill, > but when it comes to Javascript, or interfacing to external apps. as > an HTML viewer, or serving as a GUI, it looks reasonable. Right, because in that case we need some command protocol nevertheless, so the additional complexity is required. When using 9P (via libmixpsrv), most of the things are already done :) cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service - http://www.metux.de/ --------------------------------------------------------------------- Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ ---------------------------------------------------------------------

July 4, 2008

[patch] iterator related bugs

by Johannes.Hofmann＠gmx.de

On Fri, Jul 04, 2008 at 11:19:43AM -0400, Jorge Arellano Cid wrote: > On Thu, Jul 03, 2008 at 04:09:19PM +0200, Johannes Hofmann wrote: > > Hi, > > > > now I have a reliable way to reproduce the problem. On DragonFly I > > use debug malloc options, but valgrind should also work. Even > > without any debug features I can crash dillo that way, but it takes > > longer. > > > > * Choose a rather long page that does not fit on the screen with > > lot's of links. I use my bookmarks page. > > > > * Start the search dialog and enter a very common string e.g. 2 > > chars and hold the Enter key down. Dillo now scrolls through the > > page over and over again. > > > > * Now click the 1. mouse button and move the mouse like crazy over > > the scrolling page so arbitrary text gets selected and deselected. > > > > That crashes dillo pretty soon for me. > > Funny as it may look, I can't reproduce it here. Maybe it's not > strange because we've already noticed DragonFly handles memory in > a different way than GNU/Linux. > I could crash it like this under valgrind on a linux box. > > > > Attached patch fixes the problem here. Please test and check for > > potential memory leaks. > > BTW, the patch fixes one leak in Iterator::scrollTo(). > > Committed both. > > I gave it a review: > > [OK] new DeepIterator > [OK] DeepIterator *DeepIterator::createVariant(Iterator *it) > [OK] object::Object *DeepIterator::clone () > OK cloneDeepIterator() > TableIterator() \ Not reviewed because thay don't inherit > TextblockIterator() / from DeepIterator > [OK][2] SelectionState::buttonPress() Thanks for reviewing. > > BTW, it's in things like this that I really dislike C++... Yes, it can get tricky. On the other hand C++ in dillo is pretty harmless compared to other projects :-) Cheers, Johannes

July 4, 2008

[patch] iterator related bugs

by jcid＠dillo.org

On Thu, Jul 03, 2008 at 04:09:19PM +0200, Johannes Hofmann wrote: > Hi, > > now I have a reliable way to reproduce the problem. On DragonFly I > use debug malloc options, but valgrind should also work. Even > without any debug features I can crash dillo that way, but it takes > longer. > > * Choose a rather long page that does not fit on the screen with > lot's of links. I use my bookmarks page. > > * Start the search dialog and enter a very common string e.g. 2 > chars and hold the Enter key down. Dillo now scrolls through the > page over and over again. > > * Now click the 1. mouse button and move the mouse like crazy over > the scrolling page so arbitrary text gets selected and deselected. > > That crashes dillo pretty soon for me. Funny as it may look, I can't reproduce it here. Maybe it's not strange because we've already noticed DragonFly handles memory in a different way than GNU/Linux. > Attached patch fixes the problem here. Please test and check for > potential memory leaks. > BTW, the patch fixes one leak in Iterator::scrollTo(). Committed both. I gave it a review: [OK] new DeepIterator [OK] DeepIterator *DeepIterator::createVariant(Iterator *it) [OK] object::Object *DeepIterator::clone () OK cloneDeepIterator() TableIterator() \ Not reviewed because thay don't inherit TextblockIterator() / from DeepIterator [OK][2] SelectionState::buttonPress() BTW, it's in things like this that I really dislike C++... -- Cheers Jorge.-

July 4, 2008

[patch] cleanup ZoneAllocator

by weigelt＠metux.de

* Jorge Arellano Cid <jcid(a)dillo.org> schrieb: > On Mon, Jun 23, 2008 at 07:38:42PM +0200, Johannes Hofmann wrote: > > Hi, > > > > here comes me ZoneAllocator cleanup again. This time without the > > questionable strlen() stuff. > > Committed. BTW: could this allocator live in it's own lib ? Would be nice, to have an universal lib for that, IMHO :) cu -- --------------------------------------------------------------------- Enrico Weigelt == metux IT service - http://www.metux.de/ --------------------------------------------------------------------- Please visit the OpenSource QM Taskforce: http://wiki.metux.de/public/OpenSource_QM_Taskforce Patches / Fixes for a lot dozens of packages in dozens of versions: http://patches.metux.de/ ---------------------------------------------------------------------

July 4, 2008

Please help me on this...

by jcid＠dillo.org

Hi there, Looking to a future dillo2 release for the public, I was wondering about the main drive behind dillo2. I mean, in this years of Facebook, WebKit, Flash, propietary video codecs, etc. what's the main point behind dillo2? From the objectives: 1.- The democratization of internet information access. 2.- Personal security and privacy. 3.- High software efficiency. The first one is interesting to analyze along the lines that dillo allows to search for tons of information spread through the Internet using low HW requirements and low bandwidth as a dialup. This is reassuring as dillo efectively enables information access to any person under such constraints. The second one is partly attained by not writing to HD and by a non-existent scripting support. The third one is the one to brag about. ;-) Since some time, the thought that enabling dillo2 as a help browser could also bring local information (i.e. in HD) closer to the user came as a powerful one. Having an app. that pops-up in a second and that's quick, responsive and easy to use is certainly a strong drive for a person in search of information (that's why I'd like to see it inside Debian as a help system). In the near future, I'd like to have CSS and proper floating text rendering (DIV element), plus an API as a help browser. There're countries where paying Universitary studies is the state's burden. If a citizen doesn't want to study there, it's a choice. I think the same may happen with dillo, once people know about it, they can choose to use it or not. While thinking about it, these comments surprised me: "Slashdot | What Do You Want On Future Browsers?" http://tech.slashdot.org/article.pl?sid=08/06/30/1845201 (yes, give them a read!) (They're talking from a full featured Firefox basis. I don't know how may of them would like to use something like dillo) Behind a project like ours, there're two communities: developers and users. The main factor to push forward the project is developers and their motivations (in a commercial environment what pushes the development is the money invested and the profit margins/strategy sought). That's why I'm asking you to help me with your views, needs visions on the future of dillo2 these days. With regard to the user community, I'd love to have some feedback from them, but I guess we need to release dillo2 first! :-) -- Cheers Jorge.-

July 3, 2008

[patch] use delete[] where necessary

by jcid＠dillo.org

On Thu, Jul 03, 2008 at 04:14:31PM +0200, Johannes Hofmann wrote: > On Wed, Jul 02, 2008 at 07:14:31PM -0400, Jorge Arellano Cid wrote: > > On Wed, Jul 02, 2008 at 10:38:51PM +0200, Johannes Hofmann wrote: > > > Hi, > > > > > > attached patch uses delete[] for deleting arrays as required by C++. > > > > Committed. > > > > Hey, a quick test showed memory usage reduction! > > Ah nice. Didn't notice that. But it's quite significative! Around 12% reduction on VSZ and 13% on RSS. And the combined effect of all the memory reduction patches has come to reduce around 50% on RSS and 28% on VSZ in dillo2. Furthermore, when comparing dillo2 with dillo1, dillo2 uses near 45% less memory than dillo1. These are interesting figures. Below is an updated table of the huge page memory usage test case: ----------- Bck/Fwd test %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 9672 4144 pts/10 S+ 09:37 0:00 ./dillo-fltk.19Jun bare 0.2 10376 4756 pts/10 S+ 09:37 0:00 ./dillo-fltk.19Jun dir list 6.9 176176 144776 pts/10 S+ 09:37 0:02 ./dillo-fltk.19Jun huge page 5.4 123556 113216 pts/10 S+ 09:37 0:02 ./dillo-fltk.19Jun back 7.0 176176 146240 pts/10 S+ 09:37 0:05 ./dillo-fltk.19Jun forward 5.6 127020 117720 pts/10 S+ 09:37 0:05 ./dillo-fltk.19Jun back 7.0 176172 146240 pts/10 S+ 09:37 0:07 ./dillo-fltk.19Jun forward 5.6 127016 117716 pts/10 S+ 09:37 0:08 ./dillo-fltk.19Jun back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 9672 4140 pts/10 S+ 09:26 0:00 ./dillo-fltk.21Jun bare 0.2 10376 4760 pts/10 S+ 09:26 0:00 ./dillo-fltk.21Jun dir list 5.9 147904 123988 pts/10 S+ 09:31 0:02 ./dillo-fltk.21Jun huge page 4.9 111668 101944 pts/10 S+ 09:31 0:02 ./dillo-fltk.21Jun back 6.0 147780 124792 pts/10 S+ 09:31 0:05 ./dillo-fltk.21Jun forward 5.0 115008 105780 pts/10 S+ 09:31 0:05 ./dillo-fltk.21Jun back 6.0 147780 124856 pts/10 S+ 09:31 0:07 ./dillo-fltk.21Jun forward 5.1 115008 105844 pts/10 S+ 09:31 0:07 ./dillo-fltk.21Jun back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 9676 4084 pts/10 S+ 11:16 0:00 ./dillo-fltk bare 0.2 10464 4768 pts/10 S+ 11:17 0:00 ./dillo-fltk dir list 5.4 136960 112920 pts/10 S+ 11:17 0:04 ./dillo-fltk huge page 4.3 100724 90864 pts/10 S+ 11:17 0:04 ./dillo-fltk back 5.4 136952 113756 pts/10 S+ 11:17 0:09 ./dillo-fltk forward 4.5 104180 94744 pts/10 S+ 11:17 0:09 ./dillo-fltk back 5.4 136888 113776 pts/10 S+ 11:17 0:13 ./dillo-fltk forward 4.5 104116 94764 pts/10 S+ 11:17 0:14 ./dillo-fltk back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.2 9676 4156 pts/13 S+ 14:57 0:00 ./dillo-fltk.03Jul bare 0.2 10300 4588 pts/13 S+ 14:57 0:00 ./dillo-fltk.03Jul dir list 5.0 114852 104808 pts/13 S+ 14:57 0:02 ./dillo-fltk.03Jul huge page 3.9 92196 82840 pts/13 S+ 14:57 0:02 ./dillo-fltk.03Jul back 5.1 117348 107284 pts/13 S+ 14:57 0:04 ./dillo-fltk.03Jul forward 3.9 92260 82972 pts/13 S+ 14:57 0:05 ./dillo-fltk.03Jul back 5.1 117364 107300 pts/13 S+ 14:57 0:07 ./dillo-fltk.03Jul forward 3.9 92260 82972 pts/13 S+ 14:57 0:07 ./dillo-fltk.03Jul back %MEM VSZ RSS TTY STAT START TIME COMMAND 0.1 8408 3524 pts/10 S+ 10:59 0:00 ./dillo1 bare 0.1 24788 3564 pts/10 S+ 11:01 0:00 ./dillo1 dir list 8.7 226996 182220 pts/10 S+ 11:01 0:07 ./dillo1 huge page 6.8 165880 141792 pts/10 S+ 11:01 0:09 ./dillo1 back 8.8 226952 184176 pts/10 S+ 11:01 0:17 ./dillo1 forward 6.9 166264 144024 pts/10 S+ 11:01 0:18 ./dillo1 back 8.8 226968 184216 pts/10 S+ 11:01 0:26 ./dillo1 forward 6.9 166264 144060 pts/10 S+ 11:01 0:27 ./dillo1 back -- Cheers Jorge.-

July 3, 2008

[patch] use delete[] where necessary

by Johannes.Hofmann＠gmx.de

On Wed, Jul 02, 2008 at 07:14:31PM -0400, Jorge Arellano Cid wrote: > On Wed, Jul 02, 2008 at 10:38:51PM +0200, Johannes Hofmann wrote: > > Hi, > > > > attached patch uses delete[] for deleting arrays as required by C++. > > Committed. > > Hey, a quick test showed memory usage reduction! Ah nice. Didn't notice that. Cheers, Johannes

July 3, 2008

[patch] iterator related bugs

by Johannes.Hofmann＠gmx.de

Hi, now I have a reliable way to reproduce the problem. On DragonFly I use debug malloc options, but valgrind should also work. Even without any debug features I can crash dillo that way, but it takes longer. * Choose a rather long page that does not fit on the screen with lot's of links. I use my bookmarks page. * Start the search dialog and enter a very common string e.g. 2 chars and hold the Enter key down. Dillo now scrolls through the page over and over again. * Now click the 1. mouse button and move the mouse like crazy over the scrolling page so arbitrary text gets selected and deselected. That crashes dillo pretty soon for me. Attached patch fixes the problem here. Please test and check for potential memory leaks. BTW, the patch fixes one leak in Iterator::scrollTo(). Cheers, Johannes

July 3, 2008

Re: patch: rm unused dw configure.in options]

by jcid＠dillo.org

On Thu, Jul 03, 2008 at 12:04:26AM +0000, corvid wrote: > Jorge accidentally applied my dw2 configure.in change (sent off-list) > to dillo2 instead, so let's put the libjpeg stuff back in case > anyone needs it: Yes, I should not commit when as tired as yesterday... Fix committed. -- Cheers Jorge.-

July 3, 2008

Re: patch: rm unused dw configure.in options]

by corvid＠lavabit.com

Jorge accidentally applied my dw2 configure.in change (sent off-list) to dillo2 instead, so let's put the libjpeg stuff back in case anyone needs it:

July 3, 2008

[patch] use delete[] where necessary

by jcid＠dillo.org

On Wed, Jul 02, 2008 at 10:38:51PM +0200, Johannes Hofmann wrote: > Hi, > > attached patch uses delete[] for deleting arrays as required by C++. Committed. Hey, a quick test showed memory usage reduction! -- Cheers Jorge.-

July 3, 2008