- Dillo-dev - lists.mailman3.com

CSS branch merged!

by akemnade＠tzi.de

Hi, On Fri, 16 Jan 2009 14:50:43 -0300 Jorge Arellano Cid <jcid(a)dillo.org> wrote: > Hi there, > > The CSS branch was merged back into main! > > It has been stabilized and we can continue working from this > basis towards our next release. I want to thank all of you > involved in helping this happen. Having basic CSS support merged > in, is quite an achievement! > nice. But.. the second page I opened causes dillo to crash. That was http://www.wetteronline.de/ (gdb) bt #0 0x080a3a85 in dw::core::Widget::queueResize (this=0x9bc1db0, ref=0, extremesChanged=true) at widget.cc:347 #1 0x080a41c3 in dw::core::Widget::setStyle (this=0x9bc1db0, style=0x9bc26f0) at widget.cc:520 #2 0x08072646 in Html_tag_open_input (html=0x9b45020, tag=0x9b90149 "<INPUT type=\"image\" src=\"/startseite/grafiken/go.gif\" wid th=\"22\" height=\"18\" alt=\"Los gehts\" style=\"font-size: 9pt; face: Arial,He lvetica\" border=\"0\"></td>\n", ' ' <repeats 19 times>, "</tr>\n", ' ' <repeats 19 times>..., tagsize=150) at form.cc:1954 #3 0x0806c403 in Html_write_raw (html=0x9b45020, buf=0x9b8e4c1 "\n<!--\nfunction GrafikPopUp(Grafik)\n{\n bild = new Image( );\n bild.src = Grafik;\n groesse(Grafik);\n}\n\nfunction groesse(Grafik)\n{ \n if ((bild.width != 0) && (bild.height != 0))\n {\n Ausgleich"..., bufsize=21961, Eof=0) at html.cc:3389 #4 0x0806cb4b in DilloHtml::write (this=0x9b45020, Buf=0x9b8dc18 "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//E N\">\n<html>\n<head>\n <meta http-equiv=\"content-type\" CONTENT=\"text/html; c harset=iso-8859-1\">\n <meta http-equiv=\"language\" content=\"de\">\n <"..., BufSize=162377984, Eof=0) at html.cc:578 #5 0x0806cbce in Html_callback (Op=0, Client=0x9b449c0) at html.cc:3569 #6 0x0805ce1a in Cache_process_queue (entry=0x9b448e0) at cache.c:1134 #7 0x0805a4dd in a_Chain_fcb (Op=162377984, Info=0x810e648, Data1=0x9b62f00, Data2=0x8106388) at chain.c:112 ---Type <return> to continue, or q <return> to quit--- #8 0x0807d82c in a_Dpi_ccc (Op=2, Branch=2, Dir=<value optimized out>, Info=0x9b4e530, Data1=0x9b63608, Data2=0x0) at dpi.c:219 #9 0x0805a4dd in a_Chain_fcb (Op=162377984, Info=0x810e648, Data1=0x9b63608, Data2=0x0) at chain.c:112 #10 0x0807dfd9 in a_IO_ccc (Op=2, Branch=2, Dir=1, Info=0x9b526b8, Data1=0x9b63a00, Data2=0x0) at IO.c:414 #11 0x0807e1f4 in IO_callback (io=0x9b63a00) at IO.c:201 #12 0x0807e2eb in IO_fd_read_cb (fd=6, data=0x2) at IO.c:287 #13 0x080d585c in fltk::wait () #14 0x080d5a34 in fltk::run () #15 0x0804fa02 in main (argc=2, argv=0xbfbbd40 widget2 seems to be invalid... Greetings Andreas Kemnade

Jan. 17, 2009

CSS branch merged!

by corvid＠lavabit.com

Johannes wrote: > On Sat, Jan 17, 2009 at 04:29:37PM +0000, corvid wrote: > > I wonder whether there's a way to specify something like > > code, tt, pre, samp, kbd {font-family: mono !important} > > * {font-family: sans !important} > > but have sans only for elements not otherwise specified. > > > > According to http://www.w3.org/TR/CSS21/cascade.html#specificity > the first rule should overrule the second one if it matches. > So this should work. > Note, that the specificity stuff is not fully implemented yet, but > it should be sufficient for the example above. Does it work for you? Also, is <element style="[whatever]"> supposed to work?

Jan. 17, 2009

[patch]: control lout's MSG from the preferences

by onepoint＠starurchin.org

This patch makes the dillorc show_msg preference control lout's MSG macros as well as dillo's. Please comment. Regards, Jeremy Henty

Jan. 17, 2009

[patch]: fix DBG build of table.cc

by onepoint＠starurchin.org

If you uncomment the #define of DBG in table.cc it won't compile. It looks as though most of the DBG code was fixed not to use the non-existent "result" variable, but one instance was left unchanged. Patch attached. Regards, Jeremy Henty

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 04:29:37PM +0000, corvid wrote: > Johannes wrote: > > On Sat, Jan 17, 2009 at 03:43:30PM +0000, corvid wrote: > > > Johannes wrote: > > > > On Sat, Jan 17, 2009 at 03:20:45PM +0000, corvid wrote: > > > > > BTW, are bold and italic supposed to work? > > > > > > > > Yes, where are you seeing problems? > > > > > > I don't see them at all. > > > > Hm, do you have a user stylesheet set? > > > > For me > > > > <body> > > Hello <b>World</b> > > <i>dillo</i> > > </body> > > > > works ok. > > It was breaking with or without a user stylesheet, > but now I have found that adding > * {font-family: sans !important} > makes them appear properly. > My system must not like Helvetica or something... Currently font handling is more or less not existing. Whatever we get from CSS as font-family is passed directly to fltk - even if it is a comma separated list. > > > I wonder whether there's a way to specify something like > code, tt, pre, samp, kbd {font-family: mono !important} > * {font-family: sans !important} > but have sans only for elements not otherwise specified. > According to http://www.w3.org/TR/CSS21/cascade.html#specificity the first rule should overrule the second one if it matches. So this should work. Note, that the specificity stuff is not fully implemented yet, but it should be sufficient for the example above. Cheers, Johannes

Jan. 17, 2009

CSS branch merged!

by corvid＠lavabit.com

Johannes wrote: > On Sat, Jan 17, 2009 at 03:43:30PM +0000, corvid wrote: > > Johannes wrote: > > > On Sat, Jan 17, 2009 at 03:20:45PM +0000, corvid wrote: > > > > BTW, are bold and italic supposed to work? > > > > > > Yes, where are you seeing problems? > > > > I don't see them at all. > > Hm, do you have a user stylesheet set? > > For me > > <body> > Hello <b>World</b> > <i>dillo</i> > </body> > > works ok. It was breaking with or without a user stylesheet, but now I have found that adding * {font-family: sans !important} makes them appear properly. My system must not like Helvetica or something... I wonder whether there's a way to specify something like code, tt, pre, samp, kbd {font-family: mono !important} * {font-family: sans !important} but have sans only for elements not otherwise specified.

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 03:43:30PM +0000, corvid wrote: > Johannes wrote: > > On Sat, Jan 17, 2009 at 03:20:45PM +0000, corvid wrote: > > > BTW, are bold and italic supposed to work? > > > > Yes, where are you seeing problems? > > I don't see them at all. Hm, do you have a user stylesheet set? For me <body> Hello <b>World</b> <i>dillo</i> </body> works ok. Cheers, Johannes

Jan. 17, 2009

CSS branch merged!

by corvid＠lavabit.com

Johannes wrote: > On Sat, Jan 17, 2009 at 03:20:45PM +0000, corvid wrote: > > BTW, are bold and italic supposed to work? > > Yes, where are you seeing problems? I don't see them at all.

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 03:20:45PM +0000, corvid wrote: > Jorge wrote: > > On Sat, Jan 17, 2009 at 10:16:31AM +0100, Hofmann Johannes wrote: > > > On Sat, Jan 17, 2009 at 05:47:19PM +0900, furaisanjin wrote: > > > > Thank you, now I can change my favorite font in much easier way. I > > > > have one more question. Is there any way to specify default font if > > > > the font specified in style sheet doesn't exist on local machine? > > > > > > > > For example, when style sheet contains > > > > > > > > body { font-family: MS Gothic, Osaka, monospace; } > > > > > > In this case dillo should try the three fonts given. At least > > > "monospace" should exist and be mapped to some default monospace > > > font. > > > This part of the font selection is just not implemented yet. > > > > > > > > > > > but I don't have none of them but I have VL Gothic. In this case I > > > > want to use VL Gothic as backup. > > > > > > It might be possible to map font names at the X11 level, i.e. in > > > .fonts.conf. But I don't know the details. > > > > BTW, is it possible to force a single font in style.css? > > this is, even when the page specified font exists in the machine. > > I'm not sure whether it's working for the right reason, > but I haven't seen any Courier since I put > code, tt, pre, samp, kbd {font-family: mono !important} > in mine. > > BTW, are bold and italic supposed to work? Yes, where are you seeing problems? Cheers, Johannes

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 11:51:37PM +0900, furaisanjin wrote: > Sorry, I mixed up 2 things. I guess default font is something I > specified in ~/.dillo/style.css if dillo can't find any fonts > specified in style. It seems that there is some timing issue when the > page is loaded. The first time somehow the page is unreadable but if I > goto to bookmark page and come back to the page, the page is readable. Argh, timing issues are bad. Can you please point me to a page where this happens? > > Another issue is that if style sheet specified none Japanese font and > the font exists on my machine, then of course the page isn't readable > at all. This isn't dillo problem but style sheet problem. Do you have an example? How does firefox handle these pages? Regards, Johannes

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 11:04:12PM +0900, furaisanjin wrote: > 2009/1/17 Hofmann Johannes <Johannes.Hofmann(a)gmx.de>: > > In this case dillo should try the three fonts given. At least > > "monospace" should exist and be mapped to some default monospace > > font. > > I don't have such font which name is "monospace" on my machine. > fc-list command doesn't show such name. What is the default mono space > font in the current CSS implementation? None. That part is not yet implemented. > > Because some pages written in Japanese contain fonts that I don't have > at all, I can't read such pages. See my answer to Jorge's mail on how to force a fixed font-family. Regards, Johannes

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 09:45:07AM -0300, Jorge Arellano Cid wrote: > On Sat, Jan 17, 2009 at 10:16:31AM +0100, Hofmann Johannes wrote: > > On Sat, Jan 17, 2009 at 05:47:19PM +0900, furaisanjin wrote: > > > Thank you, now I can change my favorite font in much easier way. I > > > have one more question. Is there any way to specify default font if > > > the font specified in style sheet doesn't exist on local machine? > > > > > > For example, when style sheet contains > > > > > > body { font-family: MS Gothic, Osaka, monospace; } > > > > In this case dillo should try the three fonts given. At least > > "monospace" should exist and be mapped to some default monospace > > font. > > This part of the font selection is just not implemented yet. > > > > > > > > but I don't have none of them but I have VL Gothic. In this case I > > > want to use VL Gothic as backup. > > > > It might be possible to map font names at the X11 level, i.e. in > > .fonts.conf. But I don't know the details. > > BTW, is it possible to force a single font in style.css? > this is, even when the page specified font exists in the machine. * {font-family: helvetica !important} should do that. Cheers, Johannes

Jan. 17, 2009

CSS branch merged!

by corvid＠lavabit.com

Jorge wrote: > On Sat, Jan 17, 2009 at 10:16:31AM +0100, Hofmann Johannes wrote: > > On Sat, Jan 17, 2009 at 05:47:19PM +0900, furaisanjin wrote: > > > Thank you, now I can change my favorite font in much easier way. I > > > have one more question. Is there any way to specify default font if > > > the font specified in style sheet doesn't exist on local machine? > > > > > > For example, when style sheet contains > > > > > > body { font-family: MS Gothic, Osaka, monospace; } > > > > In this case dillo should try the three fonts given. At least > > "monospace" should exist and be mapped to some default monospace > > font. > > This part of the font selection is just not implemented yet. > > > > > > > > but I don't have none of them but I have VL Gothic. In this case I > > > want to use VL Gothic as backup. > > > > It might be possible to map font names at the X11 level, i.e. in > > .fonts.conf. But I don't know the details. > > BTW, is it possible to force a single font in style.css? > this is, even when the page specified font exists in the machine. I'm not sure whether it's working for the right reason, but I haven't seen any Courier since I put code, tt, pre, samp, kbd {font-family: mono !important} in mine. BTW, are bold and italic supposed to work?

Jan. 17, 2009

[patch]: add copyright and license declarations to dpid sources

by jcid＠dillo.org

On Sat, Jan 17, 2009 at 11:09:01AM +0000, Jeremy Henty wrote: > > I checked all the *.{c,cc} files and found that a couple of the dpid/ > files were missing copyrights too. Patch attached. Committed. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 17, 2009

CSS branch merged!

by jcid＠dillo.org

On Sat, Jan 17, 2009 at 10:16:31AM +0100, Hofmann Johannes wrote: > On Sat, Jan 17, 2009 at 05:47:19PM +0900, furaisanjin wrote: > > Thank you, now I can change my favorite font in much easier way. I > > have one more question. Is there any way to specify default font if > > the font specified in style sheet doesn't exist on local machine? > > > > For example, when style sheet contains > > > > body { font-family: MS Gothic, Osaka, monospace; } > > In this case dillo should try the three fonts given. At least > "monospace" should exist and be mapped to some default monospace > font. > This part of the font selection is just not implemented yet. > > > > > but I don't have none of them but I have VL Gothic. In this case I > > want to use VL Gothic as backup. > > It might be possible to map font names at the X11 level, i.e. in > .fonts.conf. But I don't know the details. BTW, is it possible to force a single font in style.css? this is, even when the page specified font exists in the machine. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 17, 2009

[patch]: add copyright and license declaration to cssparser.cc

by onepoint＠starurchin.org

On Sat, Jan 17, 2009 at 12:15:54PM +0100, Hofmann Johannes wrote: > On Sat, Jan 17, 2009 at 10:38:22AM +0000, Jeremy Henty wrote: > > > > There's no copyright or license in cssparser.cc . Patch attached. > > That's because cssparser.cc is mostly taken from dillo-0.8.0-css-3 > which was written by Sebastian. We are still trying to contact him > regarding the copyright. Ah, I didn't know that. Thanks for the update. Jeremy Henty

Jan. 17, 2009

[patch]: add copyright and license declaration to cssparser.cc

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 10:38:22AM +0000, Jeremy Henty wrote: > > There's no copyright or license in cssparser.cc . Patch attached. That's because cssparser.cc is mostly taken from dillo-0.8.0-css-3 which was written by Sebastian. We are still trying to contact him regarding the copyright. Cheers, Johannes

Jan. 17, 2009

[patch]: add copyright and license declarations to dpid sources

by onepoint＠starurchin.org

I checked all the *.{c,cc} files and found that a couple of the dpid/ files were missing copyrights too. Patch attached. Regards, Jeremy Henty

Jan. 17, 2009

[patch]: add copyright and license declaration to cssparser.cc

by onepoint＠starurchin.org

There's no copyright or license in cssparser.cc . Patch attached. Regards, Jeremy Henty

Jan. 17, 2009

CSS branch merged!

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 05:47:19PM +0900, furaisanjin wrote: > Thank you, now I can change my favorite font in much easier way. I > have one more question. Is there any way to specify default font if > the font specified in style sheet doesn't exist on local machine? > > For example, when style sheet contains > > body { font-family: MS Gothic, Osaka, monospace; } In this case dillo should try the three fonts given. At least "monospace" should exist and be mapped to some default monospace font. This part of the font selection is just not implemented yet. > > but I don't have none of them but I have VL Gothic. In this case I > want to use VL Gothic as backup. It might be possible to map font names at the X11 level, i.e. in .fonts.conf. But I don't know the details. Regards, Johannes

Jan. 17, 2009

CSS branch merged!

by furaisanjin＠gmail.com

Thank you, now I can change my favorite font in much easier way. I have one more question. Is there any way to specify default font if the font specified in style sheet doesn't exist on local machine? For example, when style sheet contains body { font-family: MS Gothic, Osaka, monospace; } but I don't have none of them but I have VL Gothic. In this case I want to use VL Gothic as backup. Regards, furaisanjin 2009/1/17 corvid <corvid(a)lavabit.com>: > furaisanjin wrote: >> I just tried this and noticed that I wasn't able to change font by >> dillorc. It seems that all fonts are decided in css.c - >> buildUserAgentStyle. > > For now you could override them in .dillo/style.css > > > > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev >

Jan. 17, 2009

Re: patch: some consts

by Johannes.Hofmann＠gmx.de

On Sat, Jan 17, 2009 at 01:09:12AM +0000, corvid wrote: > (and an unrelated static) > It was time for my occasional running of nm... > committed! Thanks, Johannes

Jan. 17, 2009

CSS branch merged!

by corvid＠lavabit.com

furaisanjin wrote: > I just tried this and noticed that I wasn't able to change font by > dillorc. It seems that all fonts are decided in css.c - > buildUserAgentStyle. For now you could override them in .dillo/style.css

Jan. 17, 2009

CSS branch merged!

by furaisanjin＠gmail.com

Hi all. I just tried this and noticed that I wasn't able to change font by dillorc. It seems that all fonts are decided in css.c - buildUserAgentStyle. Regards, furaisanjin

Jan. 17, 2009

CSS branch merged!

by jcid＠dillo.org

Hi there, The CSS branch was merged back into main! It has been stabilized and we can continue working from this basis towards our next release. I want to thank all of you involved in helping this happen. Having basic CSS support merged in, is quite an achievement! :-) -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 16, 2009

focus after closing tab

by jcid＠dillo.org

On Thu, Jan 15, 2009 at 04:34:10PM +0100, Hofmann Johannes wrote: > On Thu, Jan 15, 2009 at 08:42:22AM -0300, Jorge Arellano Cid wrote: > > On Thu, Jan 15, 2009 at 06:03:28AM +0000, Jeremy Henty wrote: > > > On Tue, Jan 13, 2009 at 02:03:33PM +0100, Hofmann Johannes wrote: > > > > > > > What do you think, which page should be focused when closing a tab: > > > > > > > * the most recently opened one? > > > > > > +1 . It would certainly be better than the current behaviour. > > > > Current behaviour is a bug. Without experience on the subject I'd > > say let's follow firefox bahaviour on this. > > As far as I can tell firefox always switches to the right most tab > which should for us be equivalent to the most recently opened one > (as we do not allow to reorder tabs). > > Attached patchlet implements this behaviour for dillo. Committed. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 15, 2009

Re: A couple of patches

by Johannes.Hofmann＠gmx.de

On Thu, Jan 15, 2009 at 10:41:59AM -0300, Jorge Arellano Cid wrote: * snip* > > BTW, I have a question. How can a minimal font size be specified? > Currently I have: > > body {font-size: 18px !important} > > in style.css, but often pages come with smaller fonts. e.g. > http://www.linux.org.uk/Portaloo.cs > > For me is important because I have a problems reading tiny fonts, > and my working laptop has a high screen resolution. I've just made a change that uses the existing prefs.font_factor value to scale the base font. However this only applies to relative font sizes. If someone specifies "font-size: 10px" you will still get 10px, but I think this is correct anyway. In addition we can add some minimal_fontsize option in the future. Cheers, Johannes

Jan. 15, 2009

focus after closing tab

by Johannes.Hofmann＠gmx.de

On Thu, Jan 15, 2009 at 08:42:22AM -0300, Jorge Arellano Cid wrote: > On Thu, Jan 15, 2009 at 06:03:28AM +0000, Jeremy Henty wrote: > > On Tue, Jan 13, 2009 at 02:03:33PM +0100, Hofmann Johannes wrote: > > > > > What do you think, which page should be focused when closing a tab: > > > > > * the most recently opened one? > > > > +1 . It would certainly be better than the current behaviour. > > Current behaviour is a bug. Without experience on the subject I'd > say let's follow firefox bahaviour on this. As far as I can tell firefox always switches to the right most tab which should for us be equivalent to the most recently opened one (as we do not allow to reorder tabs). Attached patchlet implements this behaviour for dillo. Cheers, Johannes

Jan. 15, 2009

Re: A couple of patches

by Johannes.Hofmann＠gmx.de

On Thu, Jan 15, 2009 at 10:41:59AM -0300, Jorge Arellano Cid wrote: > Hi Johannes, > > On Thu, Jan 15, 2009 at 10:07:37AM +0100, Hofmann Johannes wrote: > > Hi Jorge, > > > > On Wed, Jan 14, 2009 at 07:07:00PM -0300, Jorge Arellano Cid wrote: > > > Hi Johannes, > > > > > > Here go couple of patches. Please test and apply. > > > > Thanks, applied. > > > > > > > > Note: the image background support is partial. It works well > > > when coming back to a page. AFAIS the right solution is to decode > > > transparent images to RGBA and let FLTK handle it. > > > > Yes, I think that would be the correct way to do it. > > > > > > > > BTW, the CSS prototype seems stable enough to consider a merge. > > > What do you think? > > > > Yes, it feels pretty stable and now that there is an option to > > disable remote stylesheet loading, I think we can consider making > > css-prototype the main branch of dillo. > > However I'd like to have some issues fixed: > > > > * should load_stylesheets=NO only disable remote style-sheet loading > > (as it does now), or should it disable all remote style processing > > (e.g. style given in <style type="text/css"> </style>)? > > We can add a "parse_embedded_css" option. That way there's no > ambiguity. > > My next task is to add the toolbox button mentioned in: > > http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-December/005531.html > > It may hold CSS options akin to: > > [Tb Icon] > .-------------------. .---------. > | Change charset >|--------------------------------->| UTF-8 | > | CSS >|-->.---------------. | Cp 1250 | > | Free memory >|-. |* remote CSS | | ... | > '-------------------' | |* embedded CSS | '---------' > | |* use my CSS | > | |* no CSS at all| > | '---------------' > | .------------------. > '->| Images | > | Local Files | > | Everything unused | > '-------------------' > > Note: '*' means a toggle option > Note2: "use my CSS" replaces "Force my colors" > > We can polish from there. Ok, but I think we can reduce the CSS part to * remote CSS - meaning separate stylesheets * embedded CSS - meaning CSS in <style></style> or style="" attribute I think we should always use "my CSS" if it exists. "no CSS at all" would be the same as no .dillo/style.css and "remote CSS" and "embedded CSS" switched off. > > > > * form.cc is not yet converted to the new style handling and widget > > coloring is broken. > > OK. > > > * css-prototype displays e.g. table borders in the current color not > > in shaded background-color as dillo-main does. > > This is because CSS 2.1 states: > > "If an element's border color is not specified with a border > > property, user agents must use the value of the element's 'color' > > property as the computed value for the border color. " > > (http://www.w3.org/TR/CSS21/box.html#border-color-properties) > > firefox however also uses a shaded background color. > > I'd don't know how to deal with that at the moment. > > I'd say leave it as the standard says until it becomes an issue. > In that case we can follow FF or decide better. The problem is that I'm not sure I understand the standard properly. Firefox is generally pretty standard compliant. But it's not a big issue anyway. > > > > Then there is of course tons of issues with CSS, but we can improve > > on that gradually. > > That's the idea. > > > BTW, I have a question. How can a minimal font size be specified? > Currently I have: > > body {font-size: 18px !important} The problem is that this can be overridden e.g. by later <font size=10> elements. * {font-size: 18px !important} should fix the font size to 18px. However we probabely want an non-CSS option in dillorc to set a minimum font size. > > in style.css, but often pages come with smaller fonts. e.g. > http://www.linux.org.uk/Portaloo.cs > > For me is important because I have a problems reading tiny fonts, > and my working laptop has a high screen resolution. css-prototype seems to use pretty small fonts generally. This may be a bug. Cheers, Johannes

Jan. 15, 2009

Re: A couple of patches

by jcid＠dillo.org

Hi Johannes, On Thu, Jan 15, 2009 at 10:07:37AM +0100, Hofmann Johannes wrote: > Hi Jorge, > > On Wed, Jan 14, 2009 at 07:07:00PM -0300, Jorge Arellano Cid wrote: > > Hi Johannes, > > > > Here go couple of patches. Please test and apply. > > Thanks, applied. > > > > > Note: the image background support is partial. It works well > > when coming back to a page. AFAIS the right solution is to decode > > transparent images to RGBA and let FLTK handle it. > > Yes, I think that would be the correct way to do it. > > > > > BTW, the CSS prototype seems stable enough to consider a merge. > > What do you think? > > Yes, it feels pretty stable and now that there is an option to > disable remote stylesheet loading, I think we can consider making > css-prototype the main branch of dillo. > However I'd like to have some issues fixed: > > * should load_stylesheets=NO only disable remote style-sheet loading > (as it does now), or should it disable all remote style processing > (e.g. style given in <style type="text/css"> </style>)? We can add a "parse_embedded_css" option. That way there's no ambiguity. My next task is to add the toolbox button mentioned in: http://lists.auriga.wearlab.de/pipermail/dillo-dev/2008-December/005531.html It may hold CSS options akin to: [Tb Icon] .-------------------. .---------. | Change charset >|--------------------------------->| UTF-8 | | CSS >|-->.---------------. | Cp 1250 | | Free memory >|-. |* remote CSS | | ... | '-------------------' | |* embedded CSS | '---------' | |* use my CSS | | |* no CSS at all| | '---------------' | .------------------. '->| Images | | Local Files | | Everything unused | '-------------------' Note: '*' means a toggle option Note2: "use my CSS" replaces "Force my colors" We can polish from there. > * form.cc is not yet converted to the new style handling and widget > coloring is broken. OK. > * css-prototype displays e.g. table borders in the current color not > in shaded background-color as dillo-main does. > This is because CSS 2.1 states: > "If an element's border color is not specified with a border > property, user agents must use the value of the element's 'color' > property as the computed value for the border color. " > (http://www.w3.org/TR/CSS21/box.html#border-color-properties) > firefox however also uses a shaded background color. > I'd don't know how to deal with that at the moment. I'd say leave it as the standard says until it becomes an issue. In that case we can follow FF or decide better. > Then there is of course tons of issues with CSS, but we can improve > on that gradually. That's the idea. BTW, I have a question. How can a minimal font size be specified? Currently I have: body {font-size: 18px !important} in style.css, but often pages come with smaller fonts. e.g. http://www.linux.org.uk/Portaloo.cs For me is important because I have a problems reading tiny fonts, and my working laptop has a high screen resolution. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 15, 2009

Re: focus after closing tab

by sandshrew＠gmail.com

I would vote for "the most recently opened one" too. -- Brain: an apparatus with which we think we think. - A. Bierce

Jan. 15, 2009

focus after closing tab

by jcid＠dillo.org

On Thu, Jan 15, 2009 at 06:03:28AM +0000, Jeremy Henty wrote: > On Tue, Jan 13, 2009 at 02:03:33PM +0100, Hofmann Johannes wrote: > > > What do you think, which page should be focused when closing a tab: > > > * the most recently opened one? > > +1 . It would certainly be better than the current behaviour. Current behaviour is a bug. Without experience on the subject I'd say let's follow firefox bahaviour on this. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 15, 2009

CSS speed

by Johannes.Hofmann＠gmx.de

On Wed, Jan 14, 2009 at 03:40:23PM +0000, corvid wrote: > Johannes wrote: > > On Tue, Jan 13, 2009 at 08:00:37PM +0000, corvid wrote: > > > Johannes wrote: > > > > pages with complex CSS feel a bit slow with the current css-prototype > > > > and gprof shows a huge number of CssSelector::match() calls. > > > > Attached is a patch that tries to improve that by: > > > > > > > > * putting CssSelectors into hashtables so that we only need to match > > > > against a small subset of CssSelectors. > > > > > > > > * avoiding repeated matches of CssSimpleSelectors against the same > > > > part of the doctree. > > > > > > > > Please test and report if there is a real world speedup. > > > > > > Wow! > > > > > > In the past, my best example had been pages on reddit.com that had > > > at least maybe 300 comments. They had been unusably slow--although > > > this would encourage a person not to waste time looking at reddit. > > > > > > Quite usable now. > > > > Great. reddit.com is looking strange though. There is this weird > > blue circle... > > I think it's an iframe's bullet hypertrophied by > > #ad-frame { > border: 0px; > overflow: hidden; > width: 300px; > height: 300px; > } > > <iframe id="ad-frame" frameborder="0" scrolling="no" name="ad-frame" src="/static/ad_default.html"></iframe> Ah right. We should probabely disable style processing for content that dillo generates on its own (e.g. <object> or <(i)frame> replacements). Cheers, Johannes

Jan. 15, 2009

focus after closing tab

by onepoint＠starurchin.org

On Tue, Jan 13, 2009 at 02:03:33PM +0100, Hofmann Johannes wrote: > What do you think, which page should be focused when closing a tab: > * the most recently opened one? +1 . It would certainly be better than the current behaviour. Regards, Jeremy Henty

Jan. 15, 2009

Dillo 2 in Tiny Core Linux

by corvid＠lavabit.com

Colin wrote: > Dillo 2 doesn't use any OpenGL does it? I compiled FLTK 2 without OpenGL > support, and I didn't know if that would be a problem. Nope. I normally configure fltk without gl. It's a little bit annoying that fltk2 still tries to compile its tests that use OpenGL, but not a big deal... PS I was trying to list my idea of dependencies in the FAQ recently because one of my pet peeves is when I want to try some software but it turns out that it won't compile unless I get a ton of libraries...which in turn each require a ton of libraries...and then I typically cut my losses and delete it all.

Jan. 15, 2009

Dillo 2 in Tiny Core Linux

by xentalion＠gmail.com

Hello, Just wanted to let you that I've built a package of Dillo 2 for Tiny Core Linux. http://www.tinycorelinux.com/ It is now in the repositories for Tiny Core. :D Dillo 2 doesn't use any OpenGL does it? I compiled FLTK 2 without OpenGL support, and I didn't know if that would be a problem. Thanks, Colin

Jan. 15, 2009

patch: focus URL opened from command line

by corvid＠lavabit.com

I see there's a new entry in the bug tracker reporting that after opening multiple URLs from the command line, shift-right and shift-left do not work immediately. What do you think of something like the attached patch? The downside is that it wastes cycles when you click on a link, but I was reluctant to let dillo.cc know about this UI stuff.

Jan. 14, 2009

CSS speed

by corvid＠lavabit.com

Johannes wrote: > On Tue, Jan 13, 2009 at 08:00:37PM +0000, corvid wrote: > > Johannes wrote: > > > pages with complex CSS feel a bit slow with the current css-prototype > > > and gprof shows a huge number of CssSelector::match() calls. > > > Attached is a patch that tries to improve that by: > > > > > > * putting CssSelectors into hashtables so that we only need to match > > > against a small subset of CssSelectors. > > > > > > * avoiding repeated matches of CssSimpleSelectors against the same > > > part of the doctree. > > > > > > Please test and report if there is a real world speedup. > > > > Wow! > > > > In the past, my best example had been pages on reddit.com that had > > at least maybe 300 comments. They had been unusably slow--although > > this would encourage a person not to waste time looking at reddit. > > > > Quite usable now. > > Great. reddit.com is looking strange though. There is this weird > blue circle... I think it's an iframe's bullet hypertrophied by #ad-frame { border: 0px; overflow: hidden; width: 300px; height: 300px; } <iframe id="ad-frame" frameborder="0" scrolling="no" name="ad-frame" src="/static/ad_default.html"></iframe>

Jan. 14, 2009

CSS speed

by Johannes.Hofmann＠gmx.de

On Tue, Jan 13, 2009 at 08:00:37PM +0000, corvid wrote: > Johannes wrote: > > pages with complex CSS feel a bit slow with the current css-prototype > > and gprof shows a huge number of CssSelector::match() calls. > > Attached is a patch that tries to improve that by: > > > > * putting CssSelectors into hashtables so that we only need to match > > against a small subset of CssSelectors. > > > > * avoiding repeated matches of CssSimpleSelectors against the same > > part of the doctree. > > > > Please test and report if there is a real world speedup. > > Wow! > > In the past, my best example had been pages on reddit.com that had > at least maybe 300 comments. They had been unusably slow--although > this would encourage a person not to waste time looking at reddit. > > Quite usable now. Great. reddit.com is looking strange though. There is this weird blue circle...

Jan. 14, 2009

CSS freeze

by jcid＠dillo.org

On Mon, Jan 12, 2009 at 01:25:40PM +0100, Hofmann Johannes wrote: > On Fri, Jan 09, 2009 at 04:32:33PM -0300, Jorge Arellano Cid wrote: > > Hi, > > > > Current and former CSS protos freeze on this page: > > > > http://www.instantfundas.com/2007/12/5-opera-tricks-you-did-not-know-about.… > > I've made some adjustments to the CSS parser that fix the problem > for me. Please retest. Good! Multiple return points within a function is asking for trouble. Good you removed them with the patch. It works OK here. -- Cheers Jorge.- ______________________________________________________________________ This email has been scanned by the MessageLabs Email Security System. For more information please visit http://www.messagelabs.com/email ______________________________________________________________________

Jan. 13, 2009

CSS speed

by corvid＠lavabit.com

Johannes wrote: > pages with complex CSS feel a bit slow with the current css-prototype > and gprof shows a huge number of CssSelector::match() calls. > Attached is a patch that tries to improve that by: > > * putting CssSelectors into hashtables so that we only need to match > against a small subset of CssSelectors. > > * avoiding repeated matches of CssSimpleSelectors against the same > part of the doctree. > > Please test and report if there is a real world speedup. Wow! In the past, my best example had been pages on reddit.com that had at least maybe 300 comments. They had been unusably slow--although this would encourage a person not to waste time looking at reddit. Quite usable now.

Jan. 13, 2009

focus after closing tab

by Johannes.Hofmann＠gmx.de

Hi, sometimes when closing a tab it feels that dillo focuses the "wrong" tab. Therefore I made a patch that puts the focus back to the tab from which a tab was opened. That way I always get back to the "base page" when closing a tab. Howerver I'm not sure that this is always right, e.g. when opening multiple tabs from one base page, one might want to read one after the other without going back to the base page. What do you think, which page should be focused when closing a tab: * the tab from which the closed one was opened? * the tab to the left of the closed one? * the most recently opened one? Cheers, Johannes

Jan. 13, 2009

CSS speed

by Johannes.Hofmann＠gmx.de

Hi, pages with complex CSS feel a bit slow with the current css-prototype and gprof shows a huge number of CssSelector::match() calls. Attached is a patch that tries to improve that by: * putting CssSelectors into hashtables so that we only need to match against a small subset of CssSelectors. * avoiding repeated matches of CssSimpleSelectors against the same part of the doctree. Please test and report if there is a real world speedup. Cheers, Johannes

Jan. 13, 2009

CSS freeze

by Johannes.Hofmann＠gmx.de

On Fri, Jan 09, 2009 at 04:32:33PM -0300, Jorge Arellano Cid wrote: > Hi, > > Current and former CSS protos freeze on this page: > > http://www.instantfundas.com/2007/12/5-opera-tricks-you-did-not-know-about.… I've made some adjustments to the CSS parser that fix the problem for me. Please retest. Cheers, Johannes

Jan. 12, 2009

IMG ratio

by jcid＠dillo.org

On Sun, Jan 11, 2009 at 07:40:20PM +0100, Hofmann Johannes wrote: > On Sun, Jan 11, 2009 at 03:38:04PM -0300, Jorge Arellano Cid wrote: > > On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > > > Johannes wrote: > > > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > > > I wrote: > > > > > > Johannes wrote: > > > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > > > Johannes wrote: > > > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > > > in style already. > > > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > > > Is that supposed to work now? > > > > > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > > > it works OK. This is because the second time the image dimensions > > > > > > > > are known from the dicache. > > > > > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > > > > > Done. > > > > > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > > > seeing? > > > > > > > > > > > > Same problem for me still. > > > > > > It turns out that > > > > > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > > > > > in isolation works fine, but > > > > > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > </a> > > > > > > > > > > > > doesn't. > > > > > > > > > > Ah, it works for me with css-prototype but not with main. > > > > > I didn't realize there would be any difference. > > > > > > > > There shouldn't be any difference... > > > > > > main works for you, then? Hmm. > > > > It works for me. > > Try going to: > > <a href="http://auriga.wearlab.de/"> > <img src="http://www.dillo.org/wearlab.png" height=20> > </a> > > then hit the bookmark button and then go back to the above page. > First time scaling works, but when going back it's not scaled > anymore. Got it! Thxs. -- Cheers Jorge.-

Jan. 11, 2009

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 03:38:04PM -0300, Jorge Arellano Cid wrote: > On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > > Johannes wrote: > > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > > I wrote: > > > > > Johannes wrote: > > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > > Johannes wrote: > > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > > in style already. > > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > > Is that supposed to work now? > > > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > > it works OK. This is because the second time the image dimensions > > > > > > > are known from the dicache. > > > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > > > Done. > > > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > > seeing? > > > > > > > > > > Same problem for me still. > > > > > It turns out that > > > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > > > in isolation works fine, but > > > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > </a> > > > > > > > > > > doesn't. > > > > > > > > Ah, it works for me with css-prototype but not with main. > > > > I didn't realize there would be any difference. > > > > > > There shouldn't be any difference... > > > > main works for you, then? Hmm. > > It works for me. Try going to: <a href="http://auriga.wearlab.de/"> <img src="http://www.dillo.org/wearlab.png" height=20> </a> then hit the bookmark button and then go back to the above page. First time scaling works, but when going back it's not scaled anymore. Cheers, Johannes

Jan. 11, 2009

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > Johannes wrote: > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > I wrote: > > > > Johannes wrote: > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > Johannes wrote: > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > in style already. > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > Is that supposed to work now? > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > it works OK. This is because the second time the image dimensions > > > > > > are known from the dicache. > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > Done. > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > seeing? > > > > > > > > Same problem for me still. > > > > It turns out that > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > in isolation works fine, but > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > </a> > > > > > > > > doesn't. > > > > > > Ah, it works for me with css-prototype but not with main. > > > I didn't realize there would be any difference. > > > > There shouldn't be any difference... > > main works for you, then? Hmm. > > It gets the size of the box right, but > then the rgb data inside it isn't scaled. Ok, I'm seeing the problem now with main and the example you have provided. css-prototype indeed seems to work fine. Not sure why :-) Cheers, Johannes

Jan. 11, 2009

IMG ratio

by jcid＠dillo.org

On Sun, Jan 11, 2009 at 06:31:35PM +0000, corvid wrote: > Johannes wrote: > > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > > I wrote: > > > > Johannes wrote: > > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > > Johannes wrote: > > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > > in style already. > > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > > lack of scaling when I leave a page and come back. > > > > > > > Is that supposed to work now? > > > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > > it works OK. This is because the second time the image dimensions > > > > > > are known from the dicache. > > > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > > > Johannes: please test and merge. > > > > > > > > > > Done. > > > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > > seeing? > > > > > > > > Same problem for me still. > > > > It turns out that > > > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > > > in isolation works fine, but > > > > > > > > <a href="http://auriga.wearlab.de/"> > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > </a> > > > > > > > > doesn't. > > > > > > Ah, it works for me with css-prototype but not with main. > > > I didn't realize there would be any difference. > > > > There shouldn't be any difference... > > main works for you, then? Hmm. It works for me. > It gets the size of the box right, but > then the rgb data inside it isn't scaled. > > (...which is the behaviour I've always seen > with fltk-era dillo when returning to pages. > On the original load, I would get stretched > images, but that's been fixed now.) If main doesn't work for you, please share the sample HTML/img code that faults? -- Cheers Jorge.-

Jan. 11, 2009

IMG ratio

by corvid＠lavabit.com

Johannes wrote: > On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > > I wrote: > > > Johannes wrote: > > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > > Johannes wrote: > > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > > in style already. > > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > > 0) for inclusion into main. > > > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > > lack of scaling when I leave a page and come back. > > > > > > Is that supposed to work now? > > > > > > > > > > Yes, it is supposed to work. > > > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > > it works OK. This is because the second time the image dimensions > > > > > are known from the dicache. > > > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > > > Johannes: please test and merge. > > > > > > > > Done. > > > > > > > > corvid, can you please verify that this fixes the issue you were > > > > seeing? > > > > > > Same problem for me still. > > > It turns out that > > > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > > > in isolation works fine, but > > > > > > <a href="http://auriga.wearlab.de/"> > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > </a> > > > > > > doesn't. > > > > Ah, it works for me with css-prototype but not with main. > > I didn't realize there would be any difference. > > There shouldn't be any difference... main works for you, then? Hmm. It gets the size of the box right, but then the rgb data inside it isn't scaled. (...which is the behaviour I've always seen with fltk-era dillo when returning to pages. On the original load, I would get stretched images, but that's been fixed now.)

Jan. 11, 2009

IMG ratio

by Johannes.Hofmann＠gmx.de

On Sun, Jan 11, 2009 at 05:09:24PM +0000, corvid wrote: > I wrote: > > Johannes wrote: > > > On Sun, Jan 11, 2009 at 09:00:51AM -0300, Jorge Arellano Cid wrote: > > > > On Sun, Jan 11, 2009 at 01:00:14AM +0000, corvid wrote: > > > > > Johannes wrote: > > > > > > On Fri, Jan 09, 2009 at 11:58:54PM +0100, Hofmann Johannes wrote: > > > > > > > I think the html part needs not be changed. Everything is available > > > > > > > in style already. > > > > > > > I've attached a quick patch that seems to work for fixed sizes. > > > > > > > It does not handle something like width="50%" however. > > > > > > > > > > > > As the patch works rather well for me and improves the current > > > > > > behaviour, I've cleaned it up a bit (avoiding a possible division by > > > > > > 0) for inclusion into main. > > > > > > > > > > Loading an image scales properly for me, but I still see > > > > > lack of scaling when I leave a page and come back. > > > > > Is that supposed to work now? > > > > > > > > Yes, it is supposed to work. > > > > > > > > Altough now that you mention it, I have problems the *first* > > > > time a only-one-dimension-specified image tag is loaded. Once coming back > > > > it works OK. This is because the second time the image dimensions > > > > are known from the dicache. > > > > > > > > Patch 8f7293125059 from main fixes this. > > > > > > > > Johannes: please test and merge. > > > > > > Done. > > > > > > corvid, can you please verify that this fixes the issue you were > > > seeing? > > > > Same problem for me still. > > It turns out that > > > > <img src="http://www.dillo.org/wearlab.png" height=20> > > > > in isolation works fine, but > > > > <a href="http://auriga.wearlab.de/"> > > <img src="http://www.dillo.org/wearlab.png" height=20> > > </a> > > > > doesn't. > > Ah, it works for me with css-prototype but not with main. > I didn't realize there would be any difference. There shouldn't be any difference... > Sorry for any confusion... I'm confused now. Cheers, Johannes

Jan. 11, 2009