- Dillo-dev - lists.mailman3.com

experimental patch: Re: dillo2 wrapping Chinese

by corvid＠lavabit.com

furaisanjin wrote: > I just wonder why this condiction exists in the patch. > > if (*s&0xe2 == 0xe2) { > > There are characters which start from 0xe5 in Japanese. Ah yes, that is an error. Thank you. Any problems with "if (*s&0xe0 == 0xe0) {" instead? I believe that would force everything above U+0800 through the decoding, but oh well. (unicode blocks for the curious: http://unicode.org/Public/UNIDATA/Blocks.txt) Oh, by the way, I noticed in the line breaking document that they also listed 20000..2A6D6CJK UNIFIED IDEOGRAPHS EXTENSION B 2F800..2FA1DCJK COMPATIBILITY IDEOGRAPHS SUPPLEMENT but I wasn't sure whether anyone makes any real use of characters above U+FFFF.

June 6, 2009

experimental patch: Re: dillo2 wrapping Chinese

by furaisanjin＠gmail.com

Hi. I just wonder why this condiction exists in the patch. if (*s&0xe2 == 0xe2) { There are characters which start from 0xe5 in Japanese. Regards, furaisanjin

June 6, 2009

patch: NOP keybinding

by Johannes.Hofmann＠gmx.de

On Fri, Jun 05, 2009 at 01:50:58AM +0000, corvid wrote: > I think it would be nice to have a NOP binding to > get rid of a default binding. > > complicated patch: +1 maybe lowercase the "NOP"? Cheers, Johannes > diff -r fb041759363c src/keys.cc > --- a/src/keys.cc Fri Jun 05 01:22:16 2009 +0000 > +++ b/src/keys.cc Fri Jun 05 01:43:47 2009 +0000 > @@ -78,6 +78,7 @@ static const Mapping_t modifierNames[] = > }; > > static const KeyBinding_t default_keys[] = { > + { "NOP" , KEYS_NOP , 0 , 0 }, > { "open" , KEYS_OPEN , fltk::CTRL , 'o' }, > { "new-window" , KEYS_NEW_WINDOW , fltk::CTRL , 'n' }, > { "new-tab" , KEYS_NEW_TAB , fltk::CTRL , 't' }, > _______________________________________________ > Dillo-dev mailing list > Dillo-dev(a)dillo.org > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

June 5, 2009

patch: NOP keybinding

by corvid＠lavabit.com

I think it would be nice to have a NOP binding to get rid of a default binding. complicated patch:

June 5, 2009

[PATCH] fix dillorc path

by corvid＠lavabit.com

Paul wrote: > When opening dillo from the CLI I noticed the following message: > > paths: Cannot open file '/home/user/.dillo/dillorc' > paths: Cannot open file '/etc/dillo/dillorc' > paths: Using internal defaults... > > Checked my system and saw that dillorc had been installed > in /usr/etc/dillorc > > Checking config.log showed sysconfdir='${prefix}/etc', so no > surprises there. But Paths::getPrefsFP() in src/paths.cc uses > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS, > as specified in src/Makefile.am, instead. Now all is fine! In addition, perhaps we should make sysconfdir have '/dillo' at the end. If I look in an etc dir and see dillorc, I'd know what it's for, but I wouldn't know what uses keysrc.

June 4, 2009

form widgets, ascent/descent

by corvid＠lavabit.com

I was playing around in dw, and noticed that, whereas form widgets normally like to put much of their height into descent, when style sets the height, Textblock::calcWidgetSize() puts it all into ascent. I checked firefox and saw that their form widgets ascend. If we made everything ascend and just put font->descent into the descent, it would make life simpler. Or, nearly. I guess there is RELIEF_Y_THICKNESS, but I could almost ignore that...

June 4, 2009

[PATCH] fix dillorc path

by paul＠claws-mail.org

Hi, When opening dillo from the CLI I noticed the following message: paths: Cannot open file '/home/user/.dillo/dillorc' paths: Cannot open file '/etc/dillo/dillorc' paths: Using internal defaults... Checked my system and saw that dillorc had been installed in /usr/etc/dillorc Checking config.log showed sysconfdir='${prefix}/etc', so no surprises there. But Paths::getPrefsFP() in src/paths.cc uses PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS, as specified in src/Makefile.am, instead. Now all is fine! Seems the right thing to do. with regards Paul -- "Thanks to his green candle, the 'Pataphysician can lighten our darkness."

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by corvid＠lavabit.com

Rogut?s wrote: > Also, it is most probably unrelated and I'm only a casual dillo user, > but after basically every 15+ minute session, keyboard shortcuts start > misbehaving: i.e. they work as if the <Alt> modifier was pressed (for > example, typing 'a' in the location bar moves the cursor to the far > left, as with <Alt>a or Home). Only solution I've found was restarting > dillo (and this is where I missed something like session saving). > I haven't reported yet, because I have no idea how to reproduce it. I saw the same thing for a little while, and it was completely bewildering. I don't think it's happened for the last week or two, though.

June 4, 2009

patch: smaller findbar buttons for narrow screen

by corvid＠lavabit.com

Johannes wrote: > On Wed, Jun 03, 2009 at 01:37:34AM +0000, corvid wrote: > > I resized my window to make it narrower and discovered that > > the findbar buttons eat all of the space and make the > > input widget disappear. > > > > With button width reduced to 40 with a narrow window, > > if I resize down to match that ipaq screenshot that Andreas made, > > I can still see a reasonable amount of input field. > > Nice. It doesn't work however when manually resizing the window. Yeah. > What about using cramped mode unconditionally? I would like that. PS I am constructing this mail manually from dillo-dev archive data because I didn't receive any dillo-dev mail after my Chinese patch and before the message Rogutes just sent. Maybe they'll show up eventually...

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by paul＠claws-mail.org

Hi, On Thu, 4 Jun 2009 20:29:43 +0300 Rogut?s Sparnuotos <rogutes(a)googlemail.com> wrote: > Does anything change when you save the keysrc file attached to this > e-mail to ~/.dillo/keysrc ? Unfortunately not. best regards Paul -- "Thanks to his green candle, the 'Pataphysician can lighten our darkness."

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by rogutes＠googlemail.com

Johannes Hofmann (2009-06-04 16:58): > On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote: > > Hi, > > > > I've got recent code from mercurial, June 1st. > > No keyboard shortcuts are working for me using KDE 3.5.10. > > > > I was speaking to Johannes Hofmann about this problem, he asked me > > what my locale was (it's en-GB.UTF-8) and also asked me to report > > the problem here. > > Thanks for reporting. > > > > > Do you need more information from me? > > Is anyone else seeing this? dillo shortcuts don't seem to work at > all for Paul. Shortcuts in test/editor from fltk2 seem to work > though. > I can't reproduce the problem so far. Paul, Does anything change when you save the keysrc file attached to this e-mail to ~/.dillo/keysrc ? I think I had something similar, but I didn't have time to report...and now I forgot what it was :/ P.S. Actually, dillo doesn't even start for me anymore, saying "Can't do 24-bit 0xff0000 0xff00 0xff visual" Indeed, I am temporarily running a 24bpp desktop with an old graphics card and I've put Option "Pixmap" "24" in the ServerFlags section of xorg.conf. Also, it is most probably unrelated and I'm only a casual dillo user, but after basically every 15+ minute session, keyboard shortcuts start misbehaving: i.e. they work as if the <Alt> modifier was pressed (for example, typing 'a' in the location bar moves the cursor to the far left, as with <Alt>a or Home). Only solution I've found was restarting dillo (and this is where I missed something like session saving). I haven't reported yet, because I have no idea how to reproduce it. -- -- Rogut?s Sparnuotos

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by paul＠claws-mail.org

Hi Jorge, On Thu, 4 Jun 2009 12:23:57 -0400 Jorge Arellano Cid <jcid(a)dillo.org> wrote: > Paul, please let us know what binding are you trying to make, > what is failing and your keysrc. I'm not actually trying to make any. I got on to this problem when talking to Johannes on #claws - dillo1 had 'show controls' and 'reload' in the context menu, which was always very useful in Claws Mail with the plugin, because it runs `dillo -f`, but anyway... Even the default keybindings don't work for me. I don't have a keysrc file, but I did create one, at Johannes suggestion, but this didn't have any effect either. Pressing key-combos has no effect. best regards Paul -- "Thanks to his green candle, the 'Pataphysician can lighten our darkness."

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by jcid＠dillo.org

On Thu, Jun 04, 2009 at 04:58:14PM +0200, Johannes Hofmann wrote: > On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote: > > Hi, > > > > I've got recent code from mercurial, June 1st. > > No keyboard shortcuts are working for me using KDE 3.5.10. > > > > I was speaking to Johannes Hofmann about this problem, he asked me > > what my locale was (it's en-GB.UTF-8) and also asked me to report > > the problem here. > > Thanks for reporting. > > > > > Do you need more information from me? > > Is anyone else seeing this? dillo shortcuts don't seem to work at > all for Paul. Shortcuts in test/editor from fltk2 seem to work > though. > I can't reproduce the problem so far. Paul, please let us know what binding are you trying to make, what is failing and your keysrc. -- Cheers Jorge.-

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by Johannes.Hofmann＠gmx.de

On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote: > Hi, > > I've got recent code from mercurial, June 1st. > No keyboard shortcuts are working for me using KDE 3.5.10. > > I was speaking to Johannes Hofmann about this problem, he asked me > what my locale was (it's en-GB.UTF-8) and also asked me to report > the problem here. Thanks for reporting. > > Do you need more information from me? Is anyone else seeing this? dillo shortcuts don't seem to work at all for Paul. Shortcuts in test/editor from fltk2 seem to work though. I can't reproduce the problem so far. Cheers, Johannes

June 4, 2009

patch: smaller findbar buttons for narrow screen

by Johannes.Hofmann＠gmx.de

On Wed, Jun 03, 2009 at 01:37:34AM +0000, corvid wrote: > I resized my window to make it narrower and discovered that > the findbar buttons eat all of the space and make the > input widget disappear. > > With button width reduced to 40 with a narrow window, > if I resize down to match that ipaq screenshot that Andreas made, > I can still see a reasonable amount of input field. Nice. It doesn't work however when manually resizing the window. What about using cramped mode unconditionally? Cheers, Johannes

June 4, 2009

keyboard shortcuts non-functioning under KDE 3.5.10

by paul＠claws-mail.org

Hi, I've got recent code from mercurial, June 1st. No keyboard shortcuts are working for me using KDE 3.5.10. I was speaking to Johannes Hofmann about this problem, he asked me what my locale was (it's en-GB.UTF-8) and also asked me to report the problem here. Do you need more information from me? Whilst I'm here I would like to say thanks to Johannes for sorting out the --xid option, Claws Mail now has a dillo plugin again! with regards Paul -- "Thanks to his green candle, the 'Pataphysician can lighten our darkness."

June 4, 2009

experimental patch: Re: dillo2 wrapping Chinese

by corvid＠lavabit.com

Back in November, furaisanjin wrote: > 2008/11/12 corvid <corvid(a)lavabit.com>: > > dillo people: It turns out that dillo handles Chinese quite badly because the > > text doesn't contain whitespace (BUG 827). It looks like Japanese is that > > way as well. > > Yes, dillo doesn't handle Japanese either when a line is long and > doesn't have break on it. > > I modified html_process_word so that each Japanese word is added by > addText. In this way appearance is better but sometimes table looks > bad. I made a new version that goes in html_process_word (handles numeric character references).

June 3, 2009

patch: smaller findbar buttons for narrow screen

by corvid＠lavabit.com

I resized my window to make it narrower and discovered that the findbar buttons eat all of the space and make the input widget disappear. With button width reduced to 40 with a narrow window, if I resize down to match that ipaq screenshot that Andreas made, I can still see a reasonable amount of input field.

June 3, 2009

view source dpi question

by jcid＠dillo.org

On Tue, Jun 02, 2009 at 09:43:57PM +0200, Johannes Hofmann wrote: > On Sun, May 31, 2009 at 09:26:57PM -0400, Jorge Arellano Cid wrote: > > On Mon, Jun 01, 2009 at 12:17:23AM +0200, Johannes Hofmann wrote: > > > On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote: > > > > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote: > > > > > > annoyed by the slow source view widget I'd like to play with > > > > > > a source viewer dpi (Jorge, I think you suggested to use a > > > > > > dpi instead of coding it in dillo directly). > > > > > > However I want to avoid to reload the page from the dpi, as I want > > > > > > to be able to view the source exactly as it is currently displayed. > > > > > > > > > > > > How should I pass the html document from dillo to the dpi? Any > > > > > > ideas? > > > > > > > > > > Can you borrow the start_send_page stuff used to send local files to dillo? > > > > > > > > That's the idea. > > > > > > > > You have to pass the source to the dpi to create a table with > > > > the line number. That way you have the handy line number and find > > > > text functionality. > > > > > > > > Something like: > > > > > > > > <table> > > > > <tr><td>1 > > > > <td> LINE_CONTENT_HERE > > > > <tr><td>2 > > > > <td> LINE_CONTENT_HERE > > > > ... > > > > </table> > > > > > > Yes, that will be the fun part :) I also think about an option to > > > pass the html to tidy to make it more readable. > > > However first I need to get the html from dillo to the dpi. Is > > > the start_send_page already working in that direction or is a new > > > equivalent method needed? > > > > From the top of my head (because I haven't worked there in a > > long time): start_send_page is the canonical way to send a page > > to dillo from a dpi. The missing part may be how to send the page > > to the dpi first. I remember making a short and funny dialog for > > adding bookmarks to illustrate how bidirectional data exchange > > could be done; it's still in the code! > > (take a look in a_Bookmarks_chat_add()) > > > > If it gets unclear, please let me know to allocate some time to > > help on it. > > Here are two questions already :) > > * the DPIs seem to send > <cmd='start_send_page' url='dpi:/hello/' '> > before sending the actual html page. > Note the quote in front of '>'. > Is this intended? At least it doesn't seem to work when I remove > it. Absolutely! You can find a detailed explanation in dpip/dpip.c > * What is the reason for the SockHandler stuff. Why are DPIs not > just using plain printf and friends? There were some problems. e.g. The stream functions block when reading. Dpis also can be filters (stdin/stdout) or servers using a single socket (stdin/stdin) for read and write, and the sock handler unifies this with common code and a single interface. Dpis handle different tasks and transfer sizes so buffering becomes important, and all that is unified in a single layer (as now) instead of a myriad of approaches that break sometimes for no clear reason (as before. e.g. different default buffering across OS). -- Cheers Jorge.-

June 2, 2009

view source dpi question

by Johannes.Hofmann＠gmx.de

On Sun, May 31, 2009 at 09:26:57PM -0400, Jorge Arellano Cid wrote: > On Mon, Jun 01, 2009 at 12:17:23AM +0200, Johannes Hofmann wrote: > > On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote: > > > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote: > > > > > annoyed by the slow source view widget I'd like to play with > > > > > a source viewer dpi (Jorge, I think you suggested to use a > > > > > dpi instead of coding it in dillo directly). > > > > > However I want to avoid to reload the page from the dpi, as I want > > > > > to be able to view the source exactly as it is currently displayed. > > > > > > > > > > How should I pass the html document from dillo to the dpi? Any > > > > > ideas? > > > > > > > > Can you borrow the start_send_page stuff used to send local files to dillo? > > > > > > That's the idea. > > > > > > You have to pass the source to the dpi to create a table with > > > the line number. That way you have the handy line number and find > > > text functionality. > > > > > > Something like: > > > > > > <table> > > > <tr><td>1 > > > <td> LINE_CONTENT_HERE > > > <tr><td>2 > > > <td> LINE_CONTENT_HERE > > > ... > > > </table> > > > > Yes, that will be the fun part :) I also think about an option to > > pass the html to tidy to make it more readable. > > However first I need to get the html from dillo to the dpi. Is > > the start_send_page already working in that direction or is a new > > equivalent method needed? > > From the top of my head (because I haven't worked there in a > long time): start_send_page is the canonical way to send a page > to dillo from a dpi. The missing part may be how to send the page > to the dpi first. I remember making a short and funny dialog for > adding bookmarks to illustrate how bidirectional data exchange > could be done; it's still in the code! > (take a look in a_Bookmarks_chat_add()) > > If it gets unclear, please let me know to allocate some time to > help on it. Here are two questions already :) * the DPIs seem to send <cmd='start_send_page' url='dpi:/hello/' '> before sending the actual html page. Note the quote in front of '>'. Is this intended? At least it doesn't seem to work when I remove it. * What is the reason for the SockHandler stuff. Why are DPIs not just using plain printf and friends? Cheers, Johannes

June 2, 2009

patch: Re: [Dillo-dev] https through a proxy

by corvid＠lavabit.com

Jorge wrote: > Please commit the necessary parts. Done. All: To borrow Jorge's usual line, "Please test."

June 1, 2009

view source dpi question

by jcid＠dillo.org

On Mon, Jun 01, 2009 at 12:17:23AM +0200, Johannes Hofmann wrote: > On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote: > > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote: > > > > annoyed by the slow source view widget I'd like to play with > > > > a source viewer dpi (Jorge, I think you suggested to use a > > > > dpi instead of coding it in dillo directly). > > > > However I want to avoid to reload the page from the dpi, as I want > > > > to be able to view the source exactly as it is currently displayed. > > > > > > > > How should I pass the html document from dillo to the dpi? Any > > > > ideas? > > > > > > Can you borrow the start_send_page stuff used to send local files to dillo? > > > > That's the idea. > > > > You have to pass the source to the dpi to create a table with > > the line number. That way you have the handy line number and find > > text functionality. > > > > Something like: > > > > <table> > > <tr><td>1 > > <td> LINE_CONTENT_HERE > > <tr><td>2 > > <td> LINE_CONTENT_HERE > > ... > > </table> > > Yes, that will be the fun part :) I also think about an option to > pass the html to tidy to make it more readable. > However first I need to get the html from dillo to the dpi. Is > the start_send_page already working in that direction or is a new > equivalent method needed? From the top of my head (because I haven't worked there in a long time): start_send_page is the canonical way to send a page to dillo from a dpi. The missing part may be how to send the page to the dpi first. I remember making a short and funny dialog for adding bookmarks to illustrate how bidirectional data exchange could be done; it's still in the code! (take a look in a_Bookmarks_chat_add()) If it gets unclear, please let me know to allocate some time to help on it. -- Cheers Jorge.-

June 1, 2009

view source dpi question

by Johannes.Hofmann＠gmx.de

On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote: > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote: > > > annoyed by the slow source view widget I'd like to play with > > > a source viewer dpi (Jorge, I think you suggested to use a > > > dpi instead of coding it in dillo directly). > > > However I want to avoid to reload the page from the dpi, as I want > > > to be able to view the source exactly as it is currently displayed. > > > > > > How should I pass the html document from dillo to the dpi? Any > > > ideas? > > > > Can you borrow the start_send_page stuff used to send local files to dillo? > > That's the idea. > > You have to pass the source to the dpi to create a table with > the line number. That way you have the handy line number and find > text functionality. > > Something like: > > <table> > <tr><td>1 > <td> LINE_CONTENT_HERE > <tr><td>2 > <td> LINE_CONTENT_HERE > ... > </table> Yes, that will be the fun part :) I also think about an option to pass the html to tidy to make it more readable. However first I need to get the html from dillo to the dpi. Is the start_send_page already working in that direction or is a new equivalent method needed? Cheers, Johannes

June 1, 2009

view source dpi question

by jcid＠dillo.org

On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote: > > annoyed by the slow source view widget I'd like to play with > > a source viewer dpi (Jorge, I think you suggested to use a > > dpi instead of coding it in dillo directly). > > However I want to avoid to reload the page from the dpi, as I want > > to be able to view the source exactly as it is currently displayed. > > > > How should I pass the html document from dillo to the dpi? Any > > ideas? > > Can you borrow the start_send_page stuff used to send local files to dillo? That's the idea. You have to pass the source to the dpi to create a table with the line number. That way you have the handy line number and find text functionality. Something like: <table> <tr><td>1 <td> LINE_CONTENT_HERE <tr><td>2 <td> LINE_CONTENT_HERE ... </table> -- Cheers Jorge.-

June 1, 2009

[patch]: more doxygen fixes

by jcid＠dillo.org

On Sun, May 31, 2009 at 06:50:28AM +0100, Jeremy Henty wrote: > > Doxygen is missing some methods because it's not smart enough about > namespaces and sometimes thinks that the signatures of the declaration > and the definition are different when they are not. You can see the > warnings in its output (hint: redirect stdout to /dev/null to extract > the warnings from the noise). Patch attached that adds some explicit > namespace qualifiers. This removes doxygen's confusion, fixes the > docs and silences the warnings. Committed! -- Cheers Jorge.-

May 31, 2009

Re: the *_freeall() patch

by jcid＠dillo.org

On Sat, May 30, 2009 at 01:21:12AM +0000, corvid wrote: > In http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-March/006234.html > about key bindings, the matter of the *freeall()s came up. > My copy of the patch that I sent you has that same date on it, Mar 25, > and I think I sent it within maybe...two days. > > I've been running on it without incident since that time, other > than that since-fixed klist bug that it found. Committed. BTW, I also added a a_Prefs_freeall() function. Please test. -- Cheers Jorge.-

May 31, 2009

view source dpi question

by corvid＠lavabit.com

> annoyed by the slow source view widget I'd like to play with > a source viewer dpi (Jorge, I think you suggested to use a > dpi instead of coding it in dillo directly). > However I want to avoid to reload the page from the dpi, as I want > to be able to view the source exactly as it is currently displayed. > > How should I pass the html document from dillo to the dpi? Any > ideas? Can you borrow the start_send_page stuff used to send local files to dillo?

May 31, 2009

view source dpi question

by Johannes.Hofmann＠gmx.de

Hi, annoyed by the slow source view widget I'd like to play with a source viewer dpi (Jorge, I think you suggested to use a dpi instead of coding it in dillo directly). However I want to avoid to reload the page from the dpi, as I want to be able to view the source exactly as it is currently displayed. How should I pass the html document from dillo to the dpi? Any ideas? Cheers, Johannes

May 31, 2009

[patch]: more doxygen fixes

by corvid＠lavabit.com

Johannes wrote: > On Sun, May 31, 2009 at 02:58:40PM -0400, Jorge Arellano Cid wrote: > > On Sun, May 31, 2009 at 06:50:28AM +0100, Jeremy Henty wrote: > > > > > > Doxygen is missing some methods because it's not smart enough about > > > namespaces and sometimes thinks that the signatures of the declaration > > > and the definition are different when they are not. You can see the > > > warnings in its output (hint: redirect stdout to /dev/null to extract > > > the warnings from the noise). Patch attached that adds some explicit > > > namespace qualifiers. This removes doxygen's confusion, fixes the > > > docs and silences the warnings. > > > > It looks OK to me. > > Does anybody have any objection/comment? > > +1 No objections.

May 31, 2009

patch: Re: [Dillo-dev] https through a proxy

by Johannes.Hofmann＠gmx.de

On Wed, May 27, 2009 at 12:17:26AM +0000, corvid wrote: > Here you go. As I said, I have not had the opportunity to > test this under a wide range of conditions. I'd like to see this in the release, because ignoring the proxy for https is not only unexpected, but can be a security / privacy problem e.g. when using tor. Cheers, Johannes

May 31, 2009

[patch]: more doxygen fixes

by Johannes.Hofmann＠gmx.de

On Sun, May 31, 2009 at 02:58:40PM -0400, Jorge Arellano Cid wrote: > On Sun, May 31, 2009 at 06:50:28AM +0100, Jeremy Henty wrote: > > > > Doxygen is missing some methods because it's not smart enough about > > namespaces and sometimes thinks that the signatures of the declaration > > and the definition are different when they are not. You can see the > > warnings in its output (hint: redirect stdout to /dev/null to extract > > the warnings from the noise). Patch attached that adds some explicit > > namespace qualifiers. This removes doxygen's confusion, fixes the > > docs and silences the warnings. > > It looks OK to me. > Does anybody have any objection/comment? +1 Cheers, Johannes

May 31, 2009

[patch]: spelling: instanciate

by jcid＠dillo.org

On Sat, May 30, 2009 at 01:54:32PM +0100, Jeremy Henty wrote: > > Replying to myself, > > > You have been reading "Great stupidities of English spelling", > > number 361 of a *very* long series. > > Hasty clarification: I meant that English spelling itself is stupid > (since "instanciate" is more logical than "instantiate"). I wasn't > insulting the authors of the code (and didn't intend to write anything > that could be construed as though I was). :-) Although the meaning looked quite unambiguous to me from the beginning... -- Cheers Jorge.-

May 31, 2009

[patch]: more doxygen fixes

by jcid＠dillo.org

On Sun, May 31, 2009 at 06:50:28AM +0100, Jeremy Henty wrote: > > Doxygen is missing some methods because it's not smart enough about > namespaces and sometimes thinks that the signatures of the declaration > and the definition are different when they are not. You can see the > warnings in its output (hint: redirect stdout to /dev/null to extract > the warnings from the noise). Patch attached that adds some explicit > namespace qualifiers. This removes doxygen's confusion, fixes the > docs and silences the warnings. It looks OK to me. Does anybody have any objection/comment? -- Cheers Jorge.-

May 31, 2009

[patch]: more doxygen fixes

by onepoint＠starurchin.org

Doxygen is missing some methods because it's not smart enough about namespaces and sometimes thinks that the signatures of the declaration and the definition are different when they are not. You can see the warnings in its output (hint: redirect stdout to /dev/null to extract the warnings from the noise). Patch attached that adds some explicit namespace qualifiers. This removes doxygen's confusion, fixes the docs and silences the warnings. Regards, Jeremy Henty

May 31, 2009

[patch]: spelling: instanciate

by corvid＠lavabit.com

Jeremy wrote: > The act of creating an instance is not "instanciation" but > "instantiation". Patch attached. Committed.

May 30, 2009

patch: segfault in win_cb in uicmd.cc

by corvid＠lavabit.com

I was closing dillo. So far as I can recall, I just hit ^Q a couple times (my usual method), but I don't think that would explain the win_cb(). (gdb) bt #0 0x08055a00 in UI::tabs (this=0x0) at ui.hh:105 #1 0x080555ef in win_cb (w=0x813fe48, cb_data=0x8190618) at uicmd.cc:351 #2 0x080df426 in fltk::handle () at ../fltk/Widget.h:127 #3 0x080e0995 in do_queued_events () at x11/run.cxx:399 #4 0x080e0c16 in fltk::wait (time_to_wait=1.00000002e+20) at x11/run.cxx:459 #5 0x080e0db0 in fltk::run () at run.cxx:399 #6 0x0804f737 in main (argc=1, argv=0xbffffb34) at dillo.cc:353 (gdb) p num_bws $13 = 2 (gdb) p bws[0] $14 = (BrowserWindow *) 0x81da720 (gdb) p bws[1] $15 = (BrowserWindow *) 0x81e4a10 (gdb) p bws[2] $16 = (BrowserWindow *) 0x81da720 Perhaps I had just closed the old bw[0], with a_List_remove moving the old bw[2] there. Here's a patch, since it's a good idea in any case to check what we've been given in a callback, but there is a bit of symptom-vs-disease in that I'm not positive how I got here in this situation.

May 30, 2009

[patch]: spelling: instanciate

by onepoint＠starurchin.org

Replying to myself, > You have been reading "Great stupidities of English spelling", > number 361 of a *very* long series. Hasty clarification: I meant that English spelling itself is stupid (since "instanciate" is more logical than "instantiate"). I wasn't insulting the authors of the code (and didn't intend to write anything that could be construed as though I was). Regards, Jeremy Henty

May 30, 2009

[patch]: spelling: instanciate

by onepoint＠starurchin.org

The act of creating an instance is not "instanciation" but "instantiation". Patch attached. You have been reading "Great stupidities of English spelling", number 361 of a *very* long series. Regards, Jeremy Henty

May 30, 2009

--xid option

by corvid＠lavabit.com

Johannes wrote: > On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote: > > On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > > > Jorge wrote: > > > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > > > I hope my UTF-8 file.c code counts as polishing..." > > > > > > > > Send them to me when they're ready. > > > > > > It looks like I sent the UTF-8 one on the 17th, and > > > the MSG macros on the 16th, with another mail on the > > > 18th discovering that, whatever the gnu info text might say, > > > "" is safer than an empty argument. > > > > Both committed (thanks for the bump). > > > > @all: please compile test. > > Is this non_ascci instead of non_ascii in misc.c a typo? I've always left it alone when working in that bit of the code (either in misc or in file) under the assumption that it dated back to prehistory and therefore had become 'venerable' somehow, but the cvs log shows it only being introduced in 2006.

May 29, 2009

--xid option

by Johannes.Hofmann＠gmx.de

On Fri, May 29, 2009 at 04:25:18PM -0400, Jorge Arellano Cid wrote: > On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > > Jorge wrote: > > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > > I hope my UTF-8 file.c code counts as polishing..." > > > > > > Send them to me when they're ready. > > > > It looks like I sent the UTF-8 one on the 17th, and > > the MSG macros on the 16th, with another mail on the > > 18th discovering that, whatever the gnu info text might say, > > "" is safer than an empty argument. > > Both committed (thanks for the bump). > > @all: please compile test. Is this non_ascci instead of non_ascii in misc.c a typo? Cheers, Johannes PS: Compiles fine here.

May 29, 2009

--xid option

by jcid＠dillo.org

On Fri, May 29, 2009 at 07:28:39PM +0000, corvid wrote: > Jorge wrote: > > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > > Of course naturally I think, "I hope my MSG macros count as polishing... > > > I hope my UTF-8 file.c code counts as polishing..." > > > > Send them to me when they're ready. > > It looks like I sent the UTF-8 one on the 17th, and > the MSG macros on the 16th, with another mail on the > 18th discovering that, whatever the gnu info text might say, > "" is safer than an empty argument. Both committed (thanks for the bump). @all: please compile test. -- Cheers Jorge.-

May 29, 2009

patch: a binding for stop

by corvid＠lavabit.com

Jorge wrote: > On Fri, May 29, 2009 at 02:39:04AM +0000, corvid wrote: > > > I don't like much Esc for stop, but if that's FFs default, > > > it may be better than another (as the Ctrl-x clash you spot). > > > Afterall this is what configurable keybindings is suppossed to > > > solve so Esc is OK for me as default. > > > > I'll have to rip out the mysterious HIDE_PANELS in order to > > take back Escape which it is using. > > AFAIS, in the sense of: > > > What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN? > > The idea is to handle the case of a "search text" request on > hidden panels. In which case the search panel is temporarily > shown, until Esc is pressed. > > If it can be done with less variables, no problem. So it was added on purpose. All right. > Now, Esc is used to: > > - Close dialog windows > - Hide the search panel > > Please don't rip that functionality. The idea is Esc to stop > when there's no search bar. I don't want to use escape for stop if the search bar conflicts with it.

May 29, 2009

--xid option

by corvid＠lavabit.com

Jorge wrote: > On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > > Of course naturally I think, "I hope my MSG macros count as polishing... > > I hope my UTF-8 file.c code counts as polishing..." > > Send them to me when they're ready. It looks like I sent the UTF-8 one on the 17th, and the MSG macros on the 16th, with another mail on the 18th discovering that, whatever the gnu info text might say, "" is safer than an empty argument.

May 29, 2009

repo

by Johannes.Hofmann＠gmx.de

On Fri, May 29, 2009 at 12:05:48PM -0400, Jorge Arellano Cid wrote: > Johannes, > > In patch fd2b0634abe9 there's a long-word splitter, please add > a comment on why it's there. IIRC it was discussed in dillo-dev > recently but memory is fragile. Oh that slipped in accidentally. I removed it. We may need something like that in the future but that needs more thought. > > BTW, there's a warning too: > > xembed.cc: In member function 'void Xembed::createInternal(uint32_t)': > xembed.cc:126: warning: unused variable 'x' Fixed. Cheers, Johannes

May 29, 2009

repo

by jcid＠dillo.org

Johannes, In patch fd2b0634abe9 there's a long-word splitter, please add a comment on why it's there. IIRC it was discussed in dillo-dev recently but memory is fragile. BTW, there's a warning too: xembed.cc: In member function 'void Xembed::createInternal(uint32_t)': xembed.cc:126: warning: unused variable 'x' TIA. -- Cheers Jorge.-

May 29, 2009

--xid option

by jcid＠dillo.org

On Thu, May 28, 2009 at 12:48:22PM +0000, corvid wrote: > Johannes wrote: > > On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote: > > > AFAIS the current repo is almost dillo-2.1. I'd freeze here > > > and only accept bug fixes and polish from now. Opinions? > > > > Ok for me. > > A release sounds good. > Of course naturally I think, "I hope my MSG macros count as polishing... > I hope my UTF-8 file.c code counts as polishing..." Send them to me when they're ready. > The auth crash that Tim reported is the one thing clearly in the way. It'd be good to solve this one. > Bits of polish that I see in skimming through my mail is the matter > of the sysconf dir, and of the keybindings changing and the mystery of > KEYS_HIDE_PANELS. And putting together sample style.css and keysrc. Yes. I have other items here, but more on this later. -- Cheers Jorge.-

May 29, 2009

patch: a binding for stop

by jcid＠dillo.org

On Fri, May 29, 2009 at 02:39:04AM +0000, corvid wrote: > > I don't like much Esc for stop, but if that's FFs default, > > it may be better than another (as the Ctrl-x clash you spot). > > Afterall this is what configurable keybindings is suppossed to > > solve so Esc is OK for me as default. > > I'll have to rip out the mysterious HIDE_PANELS in order to > take back Escape which it is using. AFAIS, in the sense of: > What is the purpose of KEYS_HIDE_PANELS when we have KEYS_FULLSCREEN? The idea is to handle the case of a "search text" request on hidden panels. In which case the search panel is temporarily shown, until Esc is pressed. If it can be done with less variables, no problem. Now, Esc is used to: - Close dialog windows - Hide the search panel Please don't rip that functionality. The idea is Esc to stop when there's no search bar. -- Cheers Jorge.-

May 29, 2009

x offset > 64k

by Johannes.Hofmann＠gmx.de

On Thu, May 28, 2009 at 12:36:05PM +0000, corvid wrote: > Johannes wrote: > > On Thu, May 28, 2009 at 03:55:57AM +0000, corvid wrote: > > > I tried looking at a stylesheet, but nothing displayed. > > > It was a one-line document about 7k chars long. > > > > > > It turned out that fltk::getwidth() calls XftTextExtents32() > > > and the width comes back in a short, so it wrapped at 32k. > > > > > > I chopped the line into 1k-long "words", and now I saw > > > text, but once I made a line somewhere over 8k chars long, drawing > > > would wrap and start at the beginning again. Everything looked > > > all right in fltk::drawtext_transformed() as it called > > > XftDrawString32()... > > > > > > I have no idea whether this is something easy to deal with > > > in some way, or a limitation in X... > > > > > > > Oh. This is extremely nasty. Yes, it is a limitation of X. And > > someone (fltk or dillo) needs to workaround it. Fltk2 has 32bit > > coordinate space, but single drawing operations seem still to be > > limited in size, as they are directly mapped to their X > > counterparts. > > The individual drawing requests weren't too big after splitting > them up, so far as I could tell. I was trying > > data = a_Misc_expand_tabs(Start + i - len, len); > while (data->len > 1000) { > char *s = dStrndup(data->str, 1000); > DW2TB(dw)->addText(s, widgetStyle); > dStr_erase(data, 0, 1000); > dFree(s); > } > DW2TB(dw)->addText(data->str, widgetStyle); > > where data had become a Dstr*. That's fltk not checking the coordinates for 16bit overflow before passing it to XftDrawString32(). Of course one could argue that Xft should do that check. We probabely need to do it ourselfes in fltkviewbase.cc by adding checks for coordinates >= USHRT_MAX. But what is our general plan to fix these issues? I'd say in the long run we could try to make all the draw* methods in fltkviewbase.cc work properly with arbitrary int coordinates by breaking them down to equivalent (as far as the visible area is concerned) drawrequests with smaller coordinates. Cheers, Johannes

May 28, 2009

--xid option

by onepoint＠starurchin.org

On Thu, May 28, 2009 at 09:02:41AM +0200, Johannes Hofmann wrote: > On Wed, May 27, 2009 at 05:25:15PM -0400, Jorge Arellano Cid wrote: > > AFAIS the current repo is almost dillo-2.1. I'd freeze here and > > only accept bug fixes and polish from now. Opinions? > > Ok for me. +1. We really want to ship the CSS support (and all the other goodies we have) in a stable release and there are no show-stopping problems. Regards, Jeremy Henty

May 28, 2009

patch: a binding for stop

by jcid＠dillo.org

On Wed, May 27, 2009 at 02:22:57PM +0000, corvid wrote: > > Wondering whether we can come to a decision on this one.. > I don't like much Esc for stop, but if that's FFs default, it may be better than another (as the Ctrl-x clash you spot). Afterall this is what configurable keybindings is suppossed to solve so Esc is OK for me as default. > -------------------------------------- > > > Jeremy wrote: > > On Wed, May 06, 2009 at 11:32:31AM -0400, Jorge Arellano Cid wrote: > > > > > > The other one I can think of as mnemonic is <ctrl>x. What do > > > people think? > > > > That clashes with "Cut". Select some text in the URL window and > > <ctrl>+x will delete it. I think it's not a good idea to grab > > something that (a) already has a conventional action, and (b) already > > performs that conventional action in the GUI. > > > > And while we're talking about conventional use: Dillo is highly > > unconventional when it uses <ctrl>+q to close a tab. Everyone else[1] > > uses <ctrl>+w to close a tab (<ctrl>+<shift>+q to close a window) and > > <ctrl>+q to quit. Which can be annoying when switching between the > > two. > > > > Firefox uses Escape to stop, and arora[2] uses <ctrl>+. . > > > > Regards, > > > > Jeremy Henty > > > > [1] ie. Firefox :-) > > [2] http://code.google.com/p/arora/ - WebKit+Qt-based browser. It > > looks very nice and may supplant Firefox as "the browser to fall back > > to when Dillo can't handle the page". > > -- Cheers Jorge.-

May 28, 2009