Hi, <a1ex@dismail.de> wrote:
Hi,
The attached patch adds a Sec-GPC header to Dillo. It defaults to ON, and is controllable through a dillorc setting of 'http_sec_gpc'.
Also, I changed DNT to be user-controllable with a dillorc setting of 'http_dnt', also defaults to ON.
I know that this is too late to get in for the 3.3.0 release, but I'm sending it for review now, and if there are any issues it should allow plenty of time to fix.
Regards, Alex
Friendly post-release ping! I've been running with this patch for a while now and it seems to be working fine. Here are some tests demonstrating how it works (showing HTTP headers using the new 'trace_http' feature): Default settings (http_dnt=YES, http_sec_gpc=YES): GET / HTTP/1.1\x0D Host: dillo-browser.org\x0D User-Agent: Dillo/3.3.0\x0D Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8\x0D Accept-Encoding: gzip, deflate, br\x0D Referer: https://dillo-browser.org/\x0D Connection: keep-alive\x0D DNT: 1\x0D Sec-GPC: 1\x0D \x0D Only DNT on (http_dnt=YES, http_sec_gpc=NO): GET / HTTP/1.1\x0D Host: dillo-browser.org\x0D User-Agent: Dillo/3.3.0\x0D Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8\x0D Accept-Encoding: gzip, deflate, br\x0D Referer: https://dillo-browser.org/\x0D Connection: keep-alive\x0D DNT: 1\x0D \x0D Only Sec-GPC on (http_dnt=NO, http_sec_gpc=YES): GET / HTTP/1.1\x0D Host: dillo-browser.org\x0D User-Agent: Dillo/3.3.0\x0D Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8\x0D Accept-Encoding: gzip, deflate, br\x0D Referer: https://dillo-browser.org/\x0D Connection: keep-alive\x0D Sec-GPC: 1\x0D \x0D Both off (http_dnt=NO, http_sec_gpc=NO): GET / HTTP/1.1\x0D Host: dillo-browser.org\x0D User-Agent: Dillo/3.3.0\x0D Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8\x0D Accept-Encoding: gzip, deflate, br\x0D Referer: https://dillo-browser.org/\x0D Connection: keep-alive\x0D \x0D If my implementation is less than ideal and you'd rather do it differently, or if this feature simply isn't worth bothering with, that's fine too. Regards, Alex