This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. --- Notes: This change addresses two issues: 1. This restores the ability to close a tab by middle-clicking on it. This matches long-supported behaviour of other browsers. 2. Right-clicking a tab is now no longer a destructive action. It is common user expectation that right-clicking may produce a contextual menu. This expectation should not result in a lost tab. dillorc | 2 +- src/prefs.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dillorc b/dillorc index dbe36f53..a3d22adc 100644 --- a/dillorc +++ b/dillorc @@ -424,7 +424,7 @@ ui_tab_bg_color=#b7beb7 # A mouse's middle click over a tab closes the Tab. # With mousewheel mouses, right click feels way better (set to YES). -#right_click_closes_tab=YES +#right_click_closes_tab=NO # Scroll over tabs (using the mouse wheel) to switch among tabs. # If set to NO, the page will be scrolled instead. diff --git a/src/prefs.c b/src/prefs.c index a57c792c..09b693a2 100644 --- a/src/prefs.c +++ b/src/prefs.c @@ -81,7 +81,7 @@ void a_Prefs_init(void) prefs.load_stylesheets=TRUE; prefs.middle_click_drags_page = TRUE; prefs.middle_click_opens_new_tab = TRUE; - prefs.right_click_closes_tab = TRUE; + prefs.right_click_closes_tab = FALSE; prefs.scroll_switches_tabs = TRUE; prefs.scroll_switches_tabs_reverse = FALSE; prefs.no_proxy = dStrdup(PREFS_NO_PROXY); -- Plasma
Hi, On Wed, Apr 30, 2025 at 03:31:21PM -0500, Plasma (David Paul) wrote:
This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. ---
Notes: This change addresses two issues:
1. This restores the ability to close a tab by middle-clicking on it. This matches long-supported behaviour of other browsers.
Since when do we follow what other browsers do?
2. Right-clicking a tab is now no longer a destructive action. It is common user expectation that right-clicking may produce a contextual menu. This expectation should not result in a lost tab.
Not interested in this patch, not all systems have 3 mouse button, specially old netbooks. If you prefer to use the middle button change the option in dillorc. Rodrigo.
On Wed, 30 Apr 2025 22:52:57 +0200 Rodrigo Arias <rodarima@gmail.com> wrote:
On Wed, Apr 30, 2025 at 03:31:21PM -0500, Plasma (David Paul) wrote:
This reverts commit 6392699316bbdfd027862fa28050cd54253f25d4. ---
Notes: This change addresses two issues:
1. This restores the ability to close a tab by middle-clicking on it. This matches long-supported behaviour of other browsers.
Since when do we follow what other browsers do?
Ok, maybe that wasn't the best way to phrase that. It's not just browsers that support closing a tab by middle-clicking; it is also the standard behaviour in both my IRC client and my graphical text editor (in addition to my other browsers). Dillo having a different default is disorienting in a similar manner (though, admittedly, not to the same severity) as driving a vehicle and discovering that the functions of the pedals are flipped.
2. Right-clicking a tab is now no longer a destructive action. It is common user expectation that right-clicking may produce a contextual menu. This expectation should not result in a lost tab.
Not interested in this patch, not all systems have 3 mouse button, specially old netbooks. If you prefer to use the middle button change the option in dillorc.
Alas. -- Plasma
participants (2)
-
Plasma (David Paul) -
Rodrigo Arias