Hi, the load_images button toggles the global prefs.load_images variable but the buttons of other browser windows are not updated accordingly. Should load_images be a per window variable, or should we update the buttons in all other windows? Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded. Cheers, Johannes
Johannes wrote:
the load_images button toggles the global prefs.load_images variable but the buttons of other browser windows are not updated accordingly. Should load_images be a per window variable, or should we update the buttons in all other windows?
Doesn't matter to me; I don't use it.
Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded.
I'd been ignoring it since I very rarely use that either, but all right, here's a patch (will apply at an offset since my tree has forms code in it that isn't worth putting into CVS until after release).
On Sat, Sep 06, 2008 at 08:28:28PM +0000, corvid wrote:
Johannes wrote:
the load_images button toggles the global prefs.load_images variable but the buttons of other browser windows are not updated accordingly. Should load_images be a per window variable, or should we update the buttons in all other windows?
Doesn't matter to me; I don't use it.
Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded.
I'd been ignoring it since I very rarely use that either, but all right, here's a patch (will apply at an offset since my tree has forms code in it that isn't worth putting into CVS until after release).
Very nice. Now it also deactivates the "Load images" menu entry properly when all images have been loaded manually. Thanks, Johannes
On Sat, Sep 06, 2008 at 08:28:28PM +0000, corvid wrote:
Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded.
I'd been ignoring it since I very rarely use that either, but all right, here's a patch (will apply at an offset since my tree has forms code in it that isn't worth putting into CVS until after release).
Committed. -- Cheers Jorge.-
On Sat, Sep 06, 2008 at 09:00:33PM +0200, Johannes Hofmann wrote:
Hi,
the load_images button toggles the global prefs.load_images variable but the buttons of other browser windows are not updated accordingly. Should load_images be a per window variable, or should we update the buttons in all other windows?
A per window setting looks OK to me. That way people that use it only on certain pages (like me) are happy, and those that prefer text mode most of the time can have load_images=NO in dillo2rc.
Also, when switching to load_images=true, the "Load images" entry in the popup menu get's deactivated, even though the images of the current page are not yet loaded.
This is a bug. -- Cheers Jorge.-
Jorge wrote:
On Sat, Sep 06, 2008 at 09:00:33PM +0200, Johannes Hofmann wrote:
Should load_images be a per window variable, or should we update the buttons in all other windows?
A per window setting looks OK to me. That way people that use it only on certain pages (like me) are happy, and those that prefer text mode most of the time can have load_images=NO in dillo2rc.
I just put this together. I won't make much use of it, so please test.
On Tue, Sep 16, 2008 at 12:10:15AM +0000, corvid wrote:
Jorge wrote:
On Sat, Sep 06, 2008 at 09:00:33PM +0200, Johannes Hofmann wrote:
Should load_images be a per window variable, or should we update the buttons in all other windows?
A per window setting looks OK to me. That way people that use it only on certain pages (like me) are happy, and those that prefer text mode most of the time can have load_images=NO in dillo2rc.
I just put this together. I won't make much use of it, so please test.
Nice! It even simplifies things a bit. Thanks, Johannes
participants (3)
-
corvid＠lavabit.com -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de