Latest whitespace handling patches
Hi, The latest cleanups and whitespace handling patches have come like a fresh breeze removing unnecessary code. They're good for better code clarity. One of the few regressions I've noticed is extra underlining of links (the space before the first word's letter). As in: http://www.dwheeler.com/blog/2009/10/27/#dod-oss-2009 BTW, I'm close to commiting the DPIP changes. Hopefully near this month's end. -- Cheers Jorge.-
Jorge wrote:
One of the few regressions I've noticed is extra underlining of links (the space before the first word's letter). As in:
More like a...shifting of the unpleasantness. We had lots of cases of "<a ...> word </a> word" that underlined the space following the link. Now we have some "word <a ....> word</a>" that underline the space preceding the link. I could look at the possible spaces and select the one with the least-decorated style, perhaps.
On Wed, Oct 28, 2009 at 06:31:56PM +0000, corvid wrote:
Jorge wrote:
One of the few regressions I've noticed is extra underlining of links (the space before the first word's letter). As in:
More like a...shifting of the unpleasantness.
We had lots of cases of "<a ...> word </a> word" that underlined the space following the link. Now we have some "word <a ....> word</a>" that underline the space preceding the link.
I remember thinkering on this bug several times. That's why I'm happy this is getting a cleanup!
I could look at the possible spaces and select the one with the least-decorated style, perhaps.
Now that you have this part of the code in your short-term memory cells ;), please try to make a good link-underline test page. If you can come up with a 100% solution it'd be great. -- Cheers Jorge.-
Jorge wrote:
On Wed, Oct 28, 2009 at 06:31:56PM +0000, corvid wrote:
I could look at the possible spaces and select the one with the least-decorated style, perhaps.
Now that you have this part of the code in your short-term memory cells ;), please try to make a good link-underline test page. If you can come up with a 100% solution it'd be great.
I think it'll be a matter of what we want to define the solution as, for instance, whether there is a clear enough choice for <a ...>word </a><s> word</s>. If I put a space inside the A, I might want it, and I might not. I'm probably more likely to want it if it's a matter of U, S, or overline, and less likely to want it if it's from an A, but maybe that's too detailed and picky.
On Wed, Oct 28, 2009 at 10:18:25PM +0000, corvid wrote:
Jorge wrote:
On Wed, Oct 28, 2009 at 06:31:56PM +0000, corvid wrote:
I could look at the possible spaces and select the one with the least-decorated style, perhaps.
Now that you have this part of the code in your short-term memory cells ;), please try to make a good link-underline test page. If you can come up with a 100% solution it'd be great.
I think it'll be a matter of what we want to define the solution as, for instance, whether there is a clear enough choice for <a ...>word </a><s> word</s>. If I put a space inside the A, I might want it, and I might not. I'm probably more likely to want it if it's a matter of U, S, or overline, and less likely to want it if it's from an A, but maybe that's too detailed and picky.
In this case, the easy solution is to look what Firefox does. For instance try the attached test page. -- Cheers Jorge.-
Jorge wrote:
On Wed, Oct 28, 2009 at 10:18:25PM +0000, corvid wrote:
Jorge wrote:
On Wed, Oct 28, 2009 at 06:31:56PM +0000, corvid wrote:
I could look at the possible spaces and select the one with the least-decorated style, perhaps.
Now that you have this part of the code in your short-term memory cells ;), please try to make a good link-underline test page. If you can come up with a 100% solution it'd be great.
I think it'll be a matter of what we want to define the solution as, for instance, whether there is a clear enough choice for <a ...>word </a><s> word</s>. If I put a space inside the A, I might want it, and I might not. I'm probably more likely to want it if it's a matter of U, S, or overline, and less likely to want it if it's from an A, but maybe that's too detailed and picky.
In this case, the easy solution is to look what Firefox does. For instance try the attached test page.
Firefox seems to follow the original behaviour consistently :( I'm shocked by this because ff surely does whatever ms does, and so people must actually see all of those underlined spaces. It seems to me that if they saw them, they'd take them out. So I'll undo it.
participants (2)
-
corvid＠lavabit.com -
jcid＠dillo.org