CPU hog with large selections
Hi there, Yesterday I came accross this bug while reading: http://freshmeat.net/articles/view/889/ (272KB) If you go to a comment in the middle of the page, start selecting text with the mouse, and move it to the leftmost border (so it selects all the text up to the start), the CPU will hog and dillo will become unresponsive as it was in a dead loop. For instance, from the bottom line it takes 10 minutes to recover on a pentium II 233Mhz. I almost sure this can be improved. Please someone give a hand to fixing it. Cheers Jorge.-
Hi, On Tue, Sep 02, Jorge Arellano Cid wrote:
Yesterday I came accross this bug while reading:
http://freshmeat.net/articles/view/889/ (272KB)
If you go to a comment in the middle of the page, start selecting text with the mouse, and move it to the leftmost border (so it selects all the text up to the start), the CPU will hog and dillo will become unresponsive as it was in a dead loop.
For instance, from the bottom line it takes 10 minutes to recover on a pentium II 233Mhz. I almost sure this can be improved.
Please someone give a hand to fixing it.
Fixed and comitted. BTW, there is (still) a memory leak in the selection (reproduce this simply by selecting text several times), but this leak exists also in the old code, so it is not likely to be caused by the recent changes. Sebastian
Sebastian,
Hi,
On Tue, Sep 02, Jorge Arellano Cid wrote:
Yesterday I came accross this bug while reading:
http://freshmeat.net/articles/view/889/ (272KB)
If you go to a comment in the middle of the page, start selecting text with the mouse, and move it to the leftmost border (so it selects all the text up to the start), the CPU will hog and dillo will become unresponsive as it was in a dead loop.
For instance, from the bottom line it takes 10 minutes to recover on a pentium II 233Mhz. I almost sure this can be improved.
Please someone give a hand to fixing it.
Fixed and comitted.
Great! One less problem on the list.
BTW, there is (still) a memory leak in the selection (reproduce this simply by selecting text several times), but this leak exists also in the old code, so it is not likely to be caused by the recent changes.
I understand. It'd be good if we can coordinate to review the tab + frames patch this week (and next). Do you have some time? Regards Jorge.- PS: I added the missing include for <string.h>
participants (2)
-
Jorge Arellano Cid -
Sebastian Geerken