[patch] optimize redraw after resize for textblocks
Hello, here comes my attempt to avoid unnecessary redraws caused by images that are not visible. The first patch makes some minor optimizations to the drawing code and disables the use of the asap parameter for better testing. The second patch replaces the general queueDrawTotal() in Layout::resizeIdle () with more specific redraw calls in widgets that can be topLevel. Currently only Textblock is optimized. The idea is that resizing child widgets in a textblock don't affect the layout of the textblock above the resizing widget. So only the area below needs to be redrawn. I think that does not hold for tables, but perhaps other optimizations are possible here? Ideas anyone? The effect is visible e.g. on http://chlamydia.fs.ei.tum.de/pub/DragonFly/packages/stable/DragonFly-1.10.1... but not on table based pages. Cheers, Johannes
Hi, On Mon, Feb 18, 2008 at 05:50:43PM +0100, Johannes Hofmann wrote:
Hello,
here comes my attempt to avoid unnecessary redraws caused by images that are not visible. The first patch makes some minor optimizations to the drawing code and disables the use of the asap parameter for better testing. The second patch replaces the general queueDrawTotal() in Layout::resizeIdle () with more specific redraw calls in widgets that can be topLevel. Currently only Textblock is optimized. The idea is that resizing child widgets in a textblock don't affect the layout of the textblock above the resizing widget. So only the area below needs to be redrawn.
Excellent! Committed. (Of course this is a work that is in state of flux, but I preferred to have this basis in CVS). BTW, this explanation: "The idea is that resizing child widgets in a textblock don't affect the layout of the textblock above the resizing widget." should make its way, as a comment, into the code.
I think that does not hold for tables, but perhaps other optimizations are possible here? Ideas anyone?
Yes, after my work on tables, I think if the column sizes don't change, the rule could be the same used for the textblock. Please excuse me for my lack of time the past week and these days, I'll answer and work as time permits... -- Cheers Jorge.-
participants (2)
-
jcid@dillo.org
-
Johannes.Hofmann@gmx.de