Hi! Here's my patch that adds a search feature and makes a few minor modifications to dillo's interface. - Added search dialog. - Added search button to location bar. - Hidable using show_search preference. - Added cache for search, findtext and open url dialogs. - Added selection of contents upon opening of search, findtext and open url dialogs. - Added selection of text upon shortcut focusing of location bar. - Added deactivation of Ctrl-L in full screen mode. - Added focusing of document window at full screen mode activation. - Added shortcut (ESC) to focus document window. - Accelerators - Ctrl-L, focus location bar. - Ctrl-Shift-L, open url dialog. - Ctrl-S, open search dialog - Z, back - X, forward - ESC, focus document window Most of this has been discussed already in (http://lists.auriga.wearlab.de/pipermail/dillo-dev/2003-June/000781.html) but some additional motivations goes below. Jorge, if you don't agree with me on the shortcut issue, please change them as you prefer. If you don't like the text selection parts, it's easily disabled in the corresponding open dialog callback. Cheers, Johan Some motivations: ================= - Selection of text upon opening of Open Url dialog. - Dialog most likely to be used to enter _new_ urls, hence the previous url should be cleared or should be easy to clear. - By selecting the previous url, it is easily cleared but also easily modifed, if desired. - Selection of text upon shortcut focusing of location bar, and upon opening of find text and search dialog. - As above, by selecting the text, it is easily cleared and also easily modified. - Common behaviour in other applications. - Added cache for search, findtext and open url dialogs. - Previously the text was cleared if you hit cancel (but not otherwise). Accelerators - Ctrl-L/Ctrl-Shift-L, focus locationbar/open url dialog - Partially overlapping functionality (hence shortcuts should be similar). - Use of location bar makes dialog (almost) redundant (hence ctrl-shift for open dialog). - Shortcuts also found in Mozilla. - Ctrl-U interferes with GTK's Delete line shortcut. - F11, fullscreen - De facto standard shortcut for full screen browsing. - Probably not one of the most used shortcuts, why the more awkward F11 key may be used instead of a quicker Ctrl-<key> shortcut. - Ctrl-H interferes with GTK Delete Backward Character shortcut. - Z/X, back/forward - These shortcuts will enable quick back/forw without having to move the left hand (from the left hand side of the keyboard) or to move the right hand from the mouse (assuming the majority of dillos users are right handed). - ESC, focus document window - Added as requested. - Temporary workaround for GTK focus issue?
On Friday October 17 at 08:41pm Johan Hovold <johan@myspys.org> wrote:
- Z/X, back/forward - These shortcuts will enable quick back/forw without having to move the left hand (from the left hand side of the keyboard) or to move the right hand from the mouse (assuming the majority of dillos users are right handed).
Actually, with a dvorak keymap, "," and "." (the current back/forward keys) are very well positioned, in the space usually occupied by 'w' and 'w,' respectively, on a qwerty keyboard. -- -johann koenig Now Playing: Today is Sweetmorn, the 67th day of Bureaucracy in the YOLD 3169 My public pgp key: http://mental-graffiti.com/pgp/johannkoenig.pgp
participants (2)
-
Johan Hovold
-
Johann Koenig