fullwindow_start=YES config doesn't work with 2.2
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
Dennis wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
I think it was an oversight because there are lots of preferences and we don't all use them (I'm thinking of the Havoc Pennington articles on preferences and UI that Jorge has brought up on occasion). So I guess we should - continue to focus_location when open url was selected by key combination or menu. - check the pref first for the other cases. Johannes, does that sound right?
On Wed, Feb 24, 2010 at 05:14:30PM +0000, corvid wrote:
Dennis wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
I think it was an oversight because there are lots of preferences and we don't all use them (I'm thinking of the Havoc Pennington articles on preferences and UI that Jorge has brought up on occasion).
So I guess we should - continue to focus_location when open url was selected by key combination or menu. - check the pref first for the other cases.
Johannes, does that sound right?
Hm, in case we have a URL from the command line, there is no need to focus_location obviously. What do we do if fullwindow_start=YES is set and no url is given on the command line?
On Wed, 24 Feb 2010 23:57:12 +0100, Johannes Hofmann wrote:
On Wed, Feb 24, 2010 at 05:14:30PM +0000, corvid wrote:
Dennis wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
I think it was an oversight because there are lots of preferences and we don't all use them (I'm thinking of the Havoc Pennington articles on preferences and UI that Jorge has brought up on occasion).
So I guess we should - continue to focus_location when open url was selected by key combination or menu. - check the pref first for the other cases.
Johannes, does that sound right?
Hm, in case we have a URL from the command line, there is no need to focus_location obviously. What do we do if fullwindow_start=YES is set and no url is given on the command line?
No panel, as per the preferences description :b. Which is somewhat related to another problem I'm still having ... when fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) only for the first tab -- but not in any other tabs I open (Ctrl-T). Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas?
Dennis wrote:
Which is somewhat related to another problem I'm still having ... when fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) only for the first tab -- but not in any other tabs I open (Ctrl-T).
Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas?
Would you expect this for new windows that you ^N into existence as well?
On Thu, 25 Feb 2010 17:13:17 +0000, corvid wrote:
Dennis wrote:
Which is somewhat related to another problem I'm still having ... when fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) only for the first tab -- but not in any other tabs I open (Ctrl-T).
Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas?
Would you expect this for new windows that you ^N into existence as well?
Hrm. Actually, yes. Although there might be others who enjoy middle-clicking clipboarded urls (for whom this might be annoying), or those who might just want to open a local file (Ctrl-O).
On Wed, Feb 24, 2010 at 06:07:48PM -0500, Dennis Nezic wrote:
On Wed, 24 Feb 2010 23:57:12 +0100, Johannes Hofmann wrote:
On Wed, Feb 24, 2010 at 05:14:30PM +0000, corvid wrote:
Dennis wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
I think it was an oversight because there are lots of preferences and we don't all use them (I'm thinking of the Havoc Pennington articles on preferences and UI that Jorge has brought up on occasion).
So I guess we should - continue to focus_location when open url was selected by key combination or menu. - check the pref first for the other cases.
Johannes, does that sound right?
Hm, in case we have a URL from the command line, there is no need to focus_location obviously. What do we do if fullwindow_start=YES is set and no url is given on the command line?
No panel, as per the preferences description :b.
Which is somewhat related to another problem I'm still having ... when fullwindow_start=YES and I Ctrl-L to go to the location bar, but don't Ctrl-space to toggle fullscreen-mode, it works (shows the location bar) only for the first tab -- but not in any other tabs I open (Ctrl-T).
Ctrl-L should automatically de-fullscreen the tab, n'est-ce pas?
That's just another bug. I have just committed a fix. Please give it a try. Cheers, Johannes
On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
It's a bug! Please check how the patch in current repository works for you. -- Cheers Jorge.-
On Wed, 24 Feb 2010 14:22:01 -0300, Jorge Arellano Cid wrote:
On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
It's a bug!
Please check how the patch in current repository works for you.
Works great! Thanks!
On Wed, Feb 24, 2010 at 02:47:26PM -0500, Dennis Nezic wrote:
On Wed, 24 Feb 2010 14:22:01 -0300, Jorge Arellano Cid wrote:
On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
It's a bug!
Please check how the patch in current repository works for you.
Works great! Thanks!
I see an issue with the current fix. It never focusses location in fullscreen mode for new windows. So when opening a new empty window (e.g. Ctrl-N) in fullscreen mode, the location bar is not focussed. Jorge, what do you think about the alternative fix below. It sticks to the principle stated in the comment in UIcmd_open_url_nbw(). diff -r 5d2db34381f9 src/uicmd.cc --- a/src/uicmd.cc Thu Feb 25 18:17:48 2010 +0100 +++ b/src/uicmd.cc Thu Feb 25 18:22:21 2010 +0100 @@ -471,8 +471,7 @@ win->callback(win_cb, DilloTabs); - if (new_ui->get_panelmode() != UI_HIDDEN) - new_ui->focus_location(); + new_ui->focus_location(); return new_bw; } @@ -617,6 +616,8 @@ void a_UIcmd_open_url(BrowserWindow *bw, const DilloUrl *url) { a_Nav_push(bw, url); + if (BW2UI(bw)->get_panelmode() == UI_TEMPORARILY_SHOW_PANELS) + BW2UI(bw)->set_panelmode(UI_HIDDEN); a_UIcmd_focus_main_area(bw); } Cheers, Johannes
On Thu, Feb 25, 2010 at 06:25:59PM +0100, Johannes Hofmann wrote:
On Wed, Feb 24, 2010 at 02:47:26PM -0500, Dennis Nezic wrote:
On Wed, 24 Feb 2010 14:22:01 -0300, Jorge Arellano Cid wrote:
On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
It's a bug!
Please check how the patch in current repository works for you.
Works great! Thanks!
I see an issue with the current fix. It never focusses location in fullscreen mode for new windows. So when opening a new empty window (e.g. Ctrl-N) in fullscreen mode, the location bar is not focussed.
Jorge, what do you think about the alternative fix below. It sticks to the principle stated in the comment in UIcmd_open_url_nbw().
It looks & feels OK to me. I made some changes so Bookmarks, Home and Open File follow the same behaviour. Note: when dillo starts fullscreen and the bw is toggled to normal with Ctrl-Space, a new bw (tab or window) follows the panel status of the issuing bw, which is correct IMO. Please check the attached patch. -- Cheers Jorge.-
On Fri, Feb 26, 2010 at 07:47:55PM -0300, Jorge Arellano Cid wrote:
On Thu, Feb 25, 2010 at 06:25:59PM +0100, Johannes Hofmann wrote:
On Wed, Feb 24, 2010 at 02:47:26PM -0500, Dennis Nezic wrote:
On Wed, 24 Feb 2010 14:22:01 -0300, Jorge Arellano Cid wrote:
On Wed, Feb 24, 2010 at 10:24:02AM -0500, Dennis Nezic wrote:
When dillorc's fullwindow_start=YES (which is supposed to hide the widget panels on startup), it doesn't actually do this. (It does hide it after you click on a link or type in a url.) My guess is it was assumed that the first thing you want to do when opening a browser is to type in a url (or click a bookmark link, etc) -- but this is not true. (Many times I want to simply load a single page and then close it.)
It's a bug!
Please check how the patch in current repository works for you.
Works great! Thanks!
I see an issue with the current fix. It never focusses location in fullscreen mode for new windows. So when opening a new empty window (e.g. Ctrl-N) in fullscreen mode, the location bar is not focussed.
Jorge, what do you think about the alternative fix below. It sticks to the principle stated in the comment in UIcmd_open_url_nbw().
It looks & feels OK to me.
I made some changes so Bookmarks, Home and Open File follow the same behaviour. Note: when dillo starts fullscreen and the bw is toggled to normal with Ctrl-Space, a new bw (tab or window) follows the panel status of the issuing bw, which is correct IMO.
Please check the attached patch.
Committed! Thanks, Johannes
participants (4)
-
corvid＠lavabit.com -
dennisn＠dennisn.dyndns.org -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de