Missing include directive for OpenBSD?
Dear List, I have not updated dillo2 for a long time. Now that I have done so I see that I have missed a lot! I needed the following tiny patch to allow compilation on my OpenBSD 4.3 System: Index: dw/style.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.cc,v retrieving revision 1.10 diff -b -u -p -r1.10 style.cc --- dw/style.cc 5 Sep 2008 12:58:52 -0000 1.10 +++ dw/style.cc 7 Sep 2008 11:50:08 -0000 @@ -24,6 +24,7 @@ #include <string.h> #include <unistd.h> #include <ctype.h> +#include <sys/stdint.h> #include "core.hh" I am not sure whether this should have been caught by an autoconfig check. Can someone point me into the right direction so this can be changed to a proper patch? Thanks for your efforts and please keep up the good work! Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
On Sun, Sep 07, 2008 at 01:51:19PM +0200, Christian Kellermann wrote:
Dear List,
I have not updated dillo2 for a long time. Now that I have done so I see that I have missed a lot! I needed the following tiny patch to allow compilation on my OpenBSD 4.3 System:
Index: dw/style.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.cc,v retrieving revision 1.10 diff -b -u -p -r1.10 style.cc --- dw/style.cc 5 Sep 2008 12:58:52 -0000 1.10 +++ dw/style.cc 7 Sep 2008 11:50:08 -0000 @@ -24,6 +24,7 @@ #include <string.h> #include <unistd.h> #include <ctype.h> +#include <sys/stdint.h>
#include "core.hh"
I am not sure whether this should have been caught by an autoconfig check. Can someone point me into the right direction so this can be changed to a proper patch?
It's needed for the definition of intptr_t, right? Does #include <stdint.h> (without sys/) also help? Alternatively we could include <inttypes.h>. Cheers, Johannes
* Johannes Hofmann <Johannes.Hofmann@gmx.de> [080907 14:09]:
On Sun, Sep 07, 2008 at 01:51:19PM +0200, Christian Kellermann wrote: It's needed for the definition of intptr_t, right? Does #include <stdint.h> (without sys/) also help? Alternatively we could include <inttypes.h>.
Aye, stdint.h also does it. Cheers, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
On Sun, Sep 07, 2008 at 02:16:38PM +0200, Christian Kellermann wrote:
* Johannes Hofmann <Johannes.Hofmann@gmx.de> [080907 14:09]:
On Sun, Sep 07, 2008 at 01:51:19PM +0200, Christian Kellermann wrote: It's needed for the definition of intptr_t, right? Does #include <stdint.h> (without sys/) also help? Alternatively we could include <inttypes.h>.
Aye, stdint.h also does it.
Ok, thanks for the report. Johannes
On Sun, Sep 07, 2008 at 01:51:19PM +0200, Christian Kellermann wrote:
Dear List,
I have not updated dillo2 for a long time. Now that I have done so I see that I have missed a lot! I needed the following tiny patch to allow compilation on my OpenBSD 4.3 System:
Index: dw/style.cc =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.cc,v retrieving revision 1.10 diff -b -u -p -r1.10 style.cc --- dw/style.cc 5 Sep 2008 12:58:52 -0000 1.10 +++ dw/style.cc 7 Sep 2008 11:50:08 -0000 @@ -24,6 +24,7 @@ #include <string.h> #include <unistd.h> #include <ctype.h> +#include <sys/stdint.h>
#include "core.hh"
I am not sure whether this should have been caught by an autoconfig check. Can someone point me into the right direction so this can be changed to a proper patch?
Yes, in dillo2's tree src/colors.h has a check that OpenBSD 4.3 is happy with. Please test it.
Thanks for your efforts and please keep up the good work!
:-) Help is welcomed! -- Cheers Jorge.-
* Jorge Arellano Cid <jcid@dillo.org> [080908 17:18]:
Yes, in dillo2's tree src/colors.h has a check that OpenBSD 4.3 is happy with. Please test it.
Ok, so I duplicated this check to the dw2 tree and rebuild. I can confirm that this works for OpenBSD 4.3. The file now looks like this (older patches removed): $ cvs diff -bup dw/style.hh Index: dw/style.hh =================================================================== RCS file: /sfhome/cvs/dillo/dw2/dw/style.hh,v retrieving revision 1.5 diff -b -u -p -r1.5 style.hh --- dw/style.hh 18 Jun 2008 13:19:24 -0000 1.5 +++ dw/style.hh 12 Sep 2008 06:39:38 -0000 @@ -1,6 +1,14 @@ #ifndef __DW_STYLE_HH__ #define __DW_STYLE_HH__ +#ifdef HAVE_INTTYPES_H +#include <inttypes.h> +#else +#ifdef HAVE_STDINT_H +#include <stdint.h> +#endif +#endif + #ifndef __INCLUDED_FROM_DW_CORE_HH__ # error Do not include this file directly, use "core.hh" instead. #endif Kind regards, Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
On Fri, Sep 12, 2008 at 08:39:10AM +0200, Christian Kellermann wrote:
* Jorge Arellano Cid <jcid@dillo.org> [080908 17:18]:
Yes, in dillo2's tree src/colors.h has a check that OpenBSD 4.3 is happy with. Please test it.
Ok, so I duplicated this check to the dw2 tree and rebuild. I can confirm that this works for OpenBSD 4.3.
Committed. -- Cheers Jorge.-
participants (3)
-
Christian.Kellermann＠nefkom.net -
jcid＠dillo.org -
Johannes.Hofmann＠gmx.de