Downloading a file twice
Dear Dillo developers, I just noticed a strange behaviour when trying to download a file twice with Dillo: When you click on a link, which points to a pdf file, the "Save Link as File" dialog pops up. When you then press "Cancel" and afterwards click on the link again, nothing happens, i.e. the save dialog does not show up again. One has to reload the page in order to get the save dialog again. Is this behaviour desired? I find it a bit confusing. Kind regards, Alexander
Alexander wrote:
I just noticed a strange behaviour when trying to download a file twice with Dillo:
When you click on a link, which points to a pdf file, the "Save Link as File" dialog pops up. When you then press "Cancel" and afterwards click on the link again, nothing happens, i.e. the save dialog does not show up again. One has to reload the page in order to get the save dialog again.
Is this behaviour desired? I find it a bit confusing.
I think this is because of the part in a_Nav_push() that goes: if (bw->nav_expecting && !a_Url_cmp(bw->nav_expect_url, url) && !strcmp(URL_FRAGMENT(bw->nav_expect_url),URL_FRAGMENT(url))) { /* we're already expecting that url (most probably a double-click) */ return; }
On Tue, Jul 19, 2011 at 03:09:43PM +0000, corvid wrote:
Alexander wrote:
I just noticed a strange behaviour when trying to download a file twice with Dillo:
When you click on a link, which points to a pdf file, the "Save Link as File" dialog pops up. When you then press "Cancel" and afterwards click on the link again, nothing happens, i.e. the save dialog does not show up again. One has to reload the page in order to get the save dialog again.
Is this behaviour desired?
Not at all.
I find it a bit confusing.
It's a bug. Would you mind filling an entry in the bugtrack? (just for my pleasure of marking it "done" soon ;)
I think this is because of the part in a_Nav_push() that goes:
if (bw->nav_expecting && !a_Url_cmp(bw->nav_expect_url, url) && !strcmp(URL_FRAGMENT(bw->nav_expect_url),URL_FRAGMENT(url))) { /* we're already expecting that url (most probably a double-click) */ return; }
Yes, but the problem is elsewhere. I'm testing a two liner that fixes it. -- Cheers Jorge.-
On Tue, Jul 19, 2011 at 07:07:07PM +0200, Alexander Voigt wrote:
Hi Jorge.
Would you mind filling an entry in the bugtrack? (just for my pleasure of marking it "done" soon ;)
I just created a bug report, BugID = 982.
Thanks. Please test the fix in current repo. -- Cheers Jorge.-
Hi Dillo developers. On Tue, Jul 19, 2011 at 09:49:10PM +0200, Alexander Voigt wrote:
Thanks, the current repo fixes the bug for me!
I just noticed that this bug is also present in the current release candidate dillo-2.2.1-rc1. I would recommend to fix this bug also in the upcomming release, if possible. Kind regards, Alexander
On Sat, Jul 23, 2011 at 10:20:54AM +0200, Alexander Voigt wrote:
Hi Dillo developers.
On Tue, Jul 19, 2011 at 09:49:10PM +0200, Alexander Voigt wrote:
Thanks, the current repo fixes the bug for me!
I just noticed that this bug is also present in the current release candidate dillo-2.2.1-rc1. I would recommend to fix this bug also in the upcomming release, if possible.
There were several other bugfixes and improvements that were not backported to the dillo-2.x branch. We could think we lack a maintainer for the 2.x branch, but that's not the case as the branch is officially deprecated, and we want to focus all the manpower in dillo3. Thanks for the catch anyway. -- Cheers Jorge.-
participants (3)
-
corvid@lavabit.com
-
Hole.destructor@gmx.de
-
jcid@dillo.org